Re: [ovs-dev] [PATCH 2/2] datapath-windows: Add Win10Analyze to a make target

Acked-by: Alin Balutoiu <abalut...@cloudbasesolutions.com> > -Original Message- > From: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> On Behalf Of Shashank Ram > Sent: Monday, March 5, 2018 6:45 AM > To: Alin Gabriel Serdean <aserd...@ovn.org>

Re: [ovs-dev] [PATCH 1/2] datapath-windows: Add Win10Analyze target

Acked-by: Alin Balutoiu <abalut...@cloudbasesolutions.com> > -Original Message- > From: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> On Behalf Of Alin Gabriel Serdean > Sent: Saturday, March 3, 2018 1:42 AM > To: d...@openvswitch.org > Cc: Ali

Re: [ovs-dev] [PATCH] windows: Fix return value in case of named pipe send failure

Acked-by: Alin Balutoiu <abalut...@cloudbasesolutions.com> > -Original Message- > From: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> On Behalf Of Alin Gabriel Serdean > Sent: Monday, April 30, 2018 11:44 PM > To: d...@openvswitch.org > Cc: Ali

Re: [ovs-dev] [PATCH] datapath-windows: Support to selectively compile targets

I agree with having the target specified during make and not during configure. There is no reason to re-do the whole configure process (as Alin mentioned that it is particularly slow on Windows) only to change the target version. Thanks, Alin Balutoiu > -Original Message- > Fro

Re: [ovs-dev] [PATCH 6/6] installer-windows: Add x64 installer build via command line

Acked-by: Alin Balutoiu <abalut...@cloudbasesolutions.com> > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Alin Gabriel Serdean > Sent: Tuesday, October 31, 2017 6:26 PM > To: d...@openvswitch.o

Re: [ovs-dev] [PATCH 5/6] installer-windows: Modify installer so it can be compiled on x64

Minor comment inline. Acked-by: Alin Balutoiu <abalut...@cloudbasesolutions.com> > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Alin Gabriel Serdean > Sent: Tuesday, October 31, 2017 6:26 PM > To:

Re: [ovs-dev] [PATCH 4/6] installer-windows: Call WIX binaries outside of MSBuild on x64

Acked-by: Alin Balutoiu <abalut...@cloudbasesolutions.com> > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Alin Gabriel Serdean > Sent: Tuesday, October 31, 2017 6:26 PM > To: d...@openvswitch.o

Re: [ovs-dev] [PATCH 3/6] installer-windows: Resolve WIX solution build type

Acked-by: Alin Balutoiu <abalut...@cloudbasesolutions.com> > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Alin Gabriel Serdean > Sent: Tuesday, October 31, 2017 6:26 PM > To: d...@openvswitch.o

Re: [ovs-dev] [PATCH 1/6] build-windows: Suppress output from MSBuild

Acked-by: Alin Balutoiu <abalut...@cloudbasesolutions.com> > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Alin Gabriel Serdean > Sent: Tuesday, October 31, 2017 6:26 PM > To: d...@openvswitch.o

[ovs-dev] [PATCH] windows,python: remove dead code in send_wait

Found while looking over the code. Signed-off-by: Alin Balutoiu <abalut...@cloudbasesolutions.com> Suggested-by: Alin Gabriel Serdean <aserd...@ovn.org> --- python/ovs/stream.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/python/ovs/stream.py b/python/ovs/stream.py i

[ovs-dev] [PATCH 1/2] windows, python: create a different event for sockets

not signaled. Signed-off-by: Alin Balutoiu <abalut...@cloudbasesolutions.com> Co-authored-by: Alin Gabriel Serdean <aserd...@ovn.org> Signed-off-by: Alin Gabriel Serdean <aserd...@ovn.org> --- python/ovs/stream.py | 19 +++ 1 file changed, 11 insertions(+), 8

[ovs-dev] [PATCH] windows,python: Add restrictions to named pipes

Bump the security around named pipes to be more restrictive: disable network access and allow only administrators and above to access the named pipes. Signed-off-by: Alin Balutoiu <abalut...@cloudbasesolutions.com> --- python/ovs/winutils.p

Re: [ovs-dev] [PATCH] windows, python: Fix event type returned from poller

/pywin32/pypiwin32/blob/master/win32/src/win32file.i#L896-L987 > -Original Message- > From: aserd...@ovn.org [mailto:aserd...@ovn.org] > Sent: Wednesday, August 23, 2017 12:05 PM > To: 'Russell Bryant' <russ...@ovn.org>; Alin Balutoiu > <abalut...@cloudba

Re: [ovs-dev] [PATCH] windows, python: set the reset event to automatic

Comments answered inline. Thanks, Alin Balutoiu. > -Original Message- > From: Russell Bryant [mailto:russ...@ovn.org] > Sent: Tuesday, August 22, 2017 2:35 PM > To: Alin Balutoiu <abalut...@cloudbasesolutions.com> > Cc: d...@openvswitch.org > Subject: Re: [

Re: [ovs-dev] [PATCH] windows, python: Fix event type returned from poller

Looking at the implementation of WaitForMultipleObjects in Python it looks that the call will raise an exception if WAIT_FAILED is returned. This case is treated by the try/except block around the WaitForMultipleObjects function. Thanks, Alin Balutoiu. > -Original Message- >

[ovs-dev] [PATCH] windows, python: set the reset event to automatic

structures. Signed-off-by: Alin Balutoiu <abalut...@cloudbasesolutions.com> --- python/ovs/stream.py | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/python/ovs/stream.py b/python/ovs/stream.py index f82a449..b30c4aa 100644 --- a/python/ovs/stream.py +++ b/pyth

[ovs-dev] [PATCH] windows, python: Remove code duplication in send/recv functions

Move the return value at the end of the function regardless of the pending/non-pending operation. Signed-off-by: Alin Balutoiu <abalut...@cloudbasesolutions.com> --- python/ovs/stream.py | 78 1 file changed, 36 insertions(+), 42 del

[ovs-dev] [PATCH] windows, python: Fix event type returned from poller

only for debugging purposes inside the function "__log_wakeup" later on. Signed-off-by: Alin Balutoiu <abalut...@cloudbasesolutions.com> --- python/ovs/poller.py | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/python/ovs/poller.py b/python/ovs/poller.

[ovs-dev] [PATCH v2 2/2] python: Force file system encoding on cmdline args

On Windows, the default file system encoding is 'mbcs' resulting in a bad conversion. To make it cross-platform tolerant use 'sys.getfilesystemencoding()' instead of 'utf-8'. Co-authored-by: Alin Serdean <aserd...@cloudbasesolutions.com> Signed-off-by: Alin Balutoiu &

[ovs-dev] [PATCH v2 1/2] python: fix python3 encode/decode on Windows

. The necessary encoding has been moved before any sending function (this also includes named pipes send on Windows). Co-authored-by: Alin Serdean <aserd...@cloudbasesolutions.com> Signed-off-by: Alin Balutoiu <abalut...@cloudbasesolutions.com> Signed-off-by: Alin Serdean <aserd...@cloudbasesolut

[ovs-dev] [PATCH 2/2] python: Force file system encoding on cmdline args

On Windows, the default file system encoding is 'mbcs' resulting in a bad conversion. To make it cross-platform tolerant use 'sys.getfilesystemencoding()' instead of 'utf-8'. Co-authored-by: Alin Serdean <aserd...@cloudbasesolutions.com> Signed-off-by: Alin Balutoiu &

[ovs-dev] [PATCH 1/2] python: fix python3 encode/decode on Windows

. The necessary encoding has been moved before any sending function (this also includes named pipes send on Windows). Co-authored-by: Alin Serdean <aserd...@cloudbasesolutions.com> Signed-off-by: Alin Balutoiu <abalut...@cloudbasesolutions.com> Signed-off-by: Alin Serdean <aserd...@cloudba

[ovs-dev] [PATCH V4 5/5] Python tests: Enable python tests on Windows

From: Alin Balutoiu <abalut...@cloudbasesolutions.com> Updated the Readme with additional library required for the python tests. Remove the code which disable python tests to be run on Windows. Signed-off-by: Alin-Gheorghe Balutoiu <abalut...@cloudbasesolutions.com> --- V2: Change

[ovs-dev] [PATCH V4 3/5] Python tests: Daemon ported to Windows

From: Alin Balutoiu <abalut...@cloudbasesolutions.com> Instead of using os.fork (not supported on Windows), subprocess.Popen is used and os.pipe was replaced with Windows pipes. To be able to identify the child process, an extra parameter was added to daemon process '--pipe-

Re: [ovs-dev] [PATCH V3 5/5] Python tests: Enable python tests on Windows

Yes, "pip" is included in the MSI installer from http://python.org > From: Guru Shetty [mailto:g...@ovn.org] > Sent: Tuesday, January 3, 2017 9:33 PM > To: Alin Balutoiu <abalut...@cloudbasesolutions.com> > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PAT

Re: [ovs-dev] [PATCH V3 2/5] Python tests: Ported UNIX sockets to Windows

Ok, I'll include that in the next version. Mind if I respin the series after you take a look over the rest of the patches? > From: Guru Shetty [mailto:g...@ovn.org] > Sent: Tuesday, January 3, 2017 9:09 PM > To: Alin Balutoiu <abalut...@cloudbasesolutions.com> > Cc: d.

Re: [ovs-dev] [PATCH V3 2/5] Python tests: Ported UNIX sockets to Windows

ary 3, 2017 8:17 PM > To: Alin Balutoiu <abalut...@cloudbasesolutions.com> > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH V3 2/5] Python tests: Ported UNIX sockets to > Windows > > > > On 3 January 2017 at 08:46, Alin Balutoiu > <mailto:abalut...@

[ovs-dev] [PATCH V3 5/5] Python tests: Enable python tests on Windows

From: Alin Balutoiu <abalut...@cloudbasesolutions.com> Updated the Readme with additional library required for the python tests. Remove the code which disable python tests to be run on Windows. Signed-off-by: Alin Balutoiu <abalut...@cloudbasesolutions.com> --- V2: Changed code-blo

[ovs-dev] [PATCH V3 4/5] Python tests: Set CREATE_NO_WINDOW flag for Popen

From: Alin Balutoiu <abalut...@cloudbasesolutions.com> On Windows if the flag CREATE_NO_WINDOW is not specified when using subprocess.Popen, a new window will appear with the new process. The window is not necessary for the tests. This patch addresses this issue by adding th

[ovs-dev] [PATCH V3 3/5] Python tests: Daemon ported to Windows

From: Alin Balutoiu <abalut...@cloudbasesolutions.com> Instead of using os.fork (not supported on Windows), subprocess.Popen is used and os.pipe was replaced with Windows pipes. To be able to identify the child process, an extra parameter was added to daemon process '--pipe-

[ovs-dev] [PATCH V3 1/5] Python tests: Add winutils.py module

From: Alin Balutoiu <abalut...@cloudbasesolutions.com> This patch adds a new python module which contains helper functions. These will be neccessary for the Windows implementation. They cover the following aspects: sockets and namedpipes. Signed-off-by: Alin Balutoiu &

Re: [ovs-dev] [PATCH V2 5/5] Python tests: Enable python tests on Windows

Please ignore this patch, I will send another one soon. Thanks, Alin Balutoiu. > -Original Message- > From: Alin Balutoiu > Sent: Tuesday, January 3, 2017 5:17 PM > To: d...@openvswitch.org > Cc: Alin Balutoiu <abalut...@cloudbasesolutions.com> > Subject: [PA

Re: [ovs-dev] [PATCH V2 4/5] Python tests: Set CREATE_NO_WINDOW flag for Popen

Please ignore this patch, I will send another one soon. Thanks, Alin Balutoiu. > -Original Message- > From: Alin Balutoiu > Sent: Tuesday, January 3, 2017 5:17 PM > To: d...@openvswitch.org > Cc: Alin Balutoiu <abalut...@cloudbasesolutions.com> > Subject: [PATCH V

Re: [ovs-dev] [PATCH V2 3/5] Python tests: Daemon ported to Windows

Please ignore this patch, I will send another one soon. Thanks, Alin Balutoiu. > -Original Message- > From: Alin Balutoiu > Sent: Tuesday, January 3, 2017 5:17 PM > To: d...@openvswitch.org > Cc: Alin Balutoiu <abalut...@cloudbasesolutions.com>; Paul Boca > <p

Re: [ovs-dev] [PATCH V2 1/5] Python tests: Add winutils.py module

Please ignore this patch, I will send another one soon. Thanks, Alin Balutoiu. > -Original Message- > From: Alin Balutoiu > Sent: Tuesday, January 3, 2017 5:17 PM > To: d...@openvswitch.org > Cc: Alin Balutoiu <abalut...@cloudbasesolutions.com> > Subject: [PATCH V

Re: [ovs-dev] [PATCH V2 0/5] Adds python tests support for Windows

Please ignore this patch, I will send another one soon. Thanks, Alin Balutoiu. > -Original Message- > From: Alin Balutoiu > Sent: Tuesday, January 3, 2017 5:17 PM > To: d...@openvswitch.org > Cc: Alin Balutoiu <abalut...@cloudbasesolutions.com> > Subject: [PATCH V

[ovs-dev] [PATCH V2 5/5] Python tests: Enable python tests on Windows

From: Alin Balutoiu <abalut...@cloudbasesolutions.com> Updated the Readme with additional library required for the python tests. Remove the code which disable python tests to be run on Windows. Signed-off-by: Alin-Gheorghe Balutoiu <abalut...@cloudbasesolutions.com> --- V2: Change

[ovs-dev] [PATCH V2 4/5] Python tests: Set CREATE_NO_WINDOW flag for Popen

From: Alin Balutoiu <abalut...@cloudbasesolutions.com> On Windows if the flag CREATE_NO_WINDOW is not specified when using subprocess.Popen, a new window will appear with the new process. The window is not necessary for the tests. This patch addresses this issue by adding th

[ovs-dev] [PATCH V2 2/5] Python tests: Ported UNIX sockets to Windows

From: Alin Balutoiu <abalut...@cloudbasesolutions.com> Unix sockets (AF_UNIX) are not supported on Windows. The replacement of Unix sockets on Windows is implemented using named pipes, we are trying to mimic the behaviour of unix sockets. Instead of using Unix sockets to communicate b

[ovs-dev] [PATCH V2 1/5] Python tests: Add winutils.py module

From: Alin Balutoiu <abalut...@cloudbasesolutions.com> This patch adds a new python module which contains helper functions. These will be neccessary for the Windows implementation. They cover the following aspects: sockets and namedpipes. Signed-off-by: Alin-Gheorghe Balutoiu &

[ovs-dev] [PATCH V2 0/5] Adds python tests support for Windows

. An additional flag (CREATE_NO_WINDOW) is also added to subprocess.Popen for Windows. The console window is not used in any way, therefore we can disable the console window for processes created on Windows. Alin Balutoiu (5): Python tests: Add winutils.py module Python tests: Ported UNIX sockets to Windows

Re: [ovs-dev] [PATCH 4/5] Python tests: Set CREATE_NO_WINDOW flag for Popen

Actually they are not needed, only the changes from ovs-vtep are needed. Thanks, Alin Balutoiu. > -Original Message- > From: Alin Serdean > Sent: Friday, December 30, 2016 12:29 AM > To: Alin Balutoiu <abalut...@cloudbasesolutions.com>; > d...@openvswitch.org > C

Re: [ovs-dev] [PATCH 5/5] Python tests: Enable python tests on Windows

Replied to the comment inlined. Thanks, Alin Balutoiu. > -Original Message- > From: Alin Serdean > Sent: Friday, December 30, 2016 12:00 AM > To: Alin Balutoiu <abalut...@cloudbasesolutions.com>; > d...@openvswitch.org > Cc: Alin Balutoiu <abalut...@cloudbases

[ovs-dev] [PATCH 4/5] Python tests: Set CREATE_NO_WINDOW flag for Popen

On Windows if the flag CREATE_NO_WINDOW is not specified when using subprocess.Popen, a new window will appear with the new process. The window is not necessary for the tests. This patch addresses this issue by adding the flag CREATE_NO_WINDOW for all subprocess.Popen calls if the machine is

[ovs-dev] [PATCH 2/5] Python tests: Ported UNIX sockets to Windows

Unix sockets (AF_UNIX) are not supported on Windows. The replacement of Unix sockets on Windows is implemented using named pipes, we are trying to mimic the behaviour of unix sockets. Instead of using Unix sockets to communicate between components Named Pipes are used. This makes the python

[ovs-dev] [PATCH 3/5] Python tests: Daemon ported to Windows

Instead of using os.fork (not supported on Windows), subprocess.Popen is used and os.pipe was replaced with Windows pipes. To be able to identify the child process, an extra parameter was added to daemon process '--pipe-handle'. This parameter contains the parent Windows pipe handle which is used

[ovs-dev] [PATCH 1/5] Python tests: Add winutils.py module

This patch adds a new python module which contains helper functions. These will be neccessary for the Windows implementation. They cover the following aspects: sockets and namedpipes. Signed-off-by: Alin-Gheorghe Balutoiu --- python/automake.mk | 3 +-

[ovs-dev] [PATCH 5/5] Python tests: Enable python tests on Windows

Updated the Readme with additional library required for the python tests. Remove the code which disable python tests to be run on Windows. Signed-off-by: Alin-Gheorghe Balutoiu --- Documentation/intro/install/windows.rst | 7 +++ tests/atlocal.in

[ovs-dev] [PATCH 0/5] Adds python tests support for Windows

. An additional flag (CREATE_NO_WINDOW) is also added to subprocess.Popen for Windows. The console window is not used in any way, therefore we can disable the console window for processes created on Windows. Alin Balutoiu (5): Python tests: Add winutils.py module Python tests: Ported UNIX sockets to Windows