Re: [ovs-dev] [PATCH] ovn-controller: Inject GARPs to logical switch pipeline to update neighbors

It makes sense to update the test to check for 2 packets. Kindly update it with this patch. Thanks Anil On Tue, Dec 4, 2018 at 8:26 AM Han Zhou wrote: > On Mon, Dec 3, 2018 at 9:54 AM Daniel Alvarez wrote: > > > > Prior to this patch, GARPs announcing NAT addresses or new VIFs > > were sent

Re: [ovs-dev] [PATCH] ovn: Support configuring the BFD params for the tunnel interfaces

On Mon, Sep 24, 2018 at 3:12 PM wrote: > From: Numan Siddique > > With this commit the users can override the default BFD params - > min_rx, min_tx and decay_min_rx if desired. This can be useful > to debug any issues related to BFD, like BFD state changes are > seen frequently. > >

Re: [ovs-dev] [PATCH v7 4/4] Replace router internal MAC with gateway MAC for reply packets

Thanks Ben On Wed, Aug 15, 2018 at 6:40 AM, Ben Pfaff wrote: > I've asked Justin to take a look at this series. > > On Tue, Aug 14, 2018 at 08:48:25PM +0530, Anil Venkata wrote: > > Gentle reminder requesting more reviews.. > > > > Mark has reviewed the patch se

Re: [ovs-dev] [PATCH v7 4/4] Replace router internal MAC with gateway MAC for reply packets

m a proper code review, but you can add the > Tested-By: Miguel Angel Ajo > > The issue I described previously seems to be fixed on the v7 of the series. > > > On Mon, Aug 6, 2018 at 9:19 PM Mark Michelson wrote: > >> On 08/06/2018 01:58 PM, Anil Venkata wrote: >>

Re: [ovs-dev] [PATCH v7 4/4] Replace router internal MAC with gateway MAC for reply packets

Thanks Mark. Kindly look at my comment inline. On Fri, Aug 3, 2018 at 2:17 AM, Mark Michelson wrote: > On 08/01/2018 08:16 AM, vkomm...@redhat.com wrote: > >> From: venkata anil >> >> Previous patches in the series doesn't address issue 1 explained in [1] >> i.e >> 1) removal of router gateway

Re: [ovs-dev] [PATCH v6 2/3] Send gateway port ARP through router internal ports

Thanks Mark for the review. Please see my reply inline. On Thu, Jul 19, 2018 at 7:04 PM, Mark Michelson wrote: > This patch had some compilation errors. It may be due to changes in master > since this patchset was posted: > > ovn/controller/pinctrl.c: In function ‘send_garp_run’: >

Re: [ovs-dev] [PATCH v6 1/3] Avoid tunneling for VLAN packets redirected to a gateway chassis

Thanks Mark for the review. I will address the review comments. On Thu, Jul 19, 2018 at 6:54 PM, Mark Michelson wrote: > I've had a look through and have some notes in-line. I know some of them > will be a bit nit-picky, but...sometimes that's just how I am :) > > > On 06/25/2018 03:53 PM,

Re: [ovs-dev] [PATCH v5 0/3] Use VLANs for VLAN packets redirected to a gateway chassis

ress when the packet is leaving the host) > I plan to start working (with some help from Anil) on a follow up > patch to make sure "1" does not happen, and then "2" if we confirm that's > problematic. > > Best, > Miguel Ángel. > > > > On Tue, Jul 10, 2018

Re: [ovs-dev] [PATCH v5 0/3] Use VLANs for VLAN packets redirected to a gateway chassis

On Sat, Jun 16, 2018 at 12:05 AM, Ben Pfaff wrote: > On Thu, Jun 07, 2018 at 02:59:46PM +0530, vkomm...@redhat.com wrote: > > From: Venkata Anil > > > > This patch avoids tunneling and instead uses source tenant vlan network > > across hypervisors for traffic from vlan network on local

Re: [ovs-dev] [PATCH v4 2/2] Send gateway port ARP through router internal ports

On Wed, Jun 6, 2018 at 12:09 AM, Numan Siddique wrote: > > > On Tue, Jun 5, 2018 at 6:24 PM, wrote: > >> From: Venkata Anil >> >> External switches should learn the distributed gateway port MAC address >> as they have to forward the packet tagged with tenant vlan network but >> with this MAC

Re: [ovs-dev] [PATCH v3] Avoid tunneling for VLAN packets redirected to a gateway chassis

On Fri, Jun 1, 2018 at 12:13 AM, Anil Venkata wrote: > Thanks Russell. > > On Thu, May 31, 2018 at 1:41 AM, Russell Bryant wrote: > >> One more general question: >> >> a major difference when doing the redirect to the gateway via a VLAN >> vs a geneve tun

Re: [ovs-dev] [PATCH v3] Avoid tunneling for VLAN packets redirected to a gateway chassis

Thanks Russell. On Thu, May 31, 2018 at 1:41 AM, Russell Bryant wrote: > One more general question: > > a major difference when doing the redirect to the gateway via a VLAN > vs a geneve tunnel is the lack of metadata. You've demonstrated how > it's easy enough to identify the network (the

Re: [ovs-dev] [PATCH v2] ovn: Avoid nb_cfg update notification flooding

Acked-By: Venkata Anil <vkomm...@redhat.com> I have reviewed and tested the patch. It looks good to me. Thanks Anil On Mon, Mar 26, 2018 at 11:09 AM, Anil Venkata <anilvenk...@redhat.com> wrote: > > On Sat, Mar 24, 2018 at 7:06 AM, Han Zhou <zhou...@gmail.com>

Re: [ovs-dev] [PATCH v2] ovn: Avoid nb_cfg update notification flooding

On Sat, Mar 24, 2018 at 7:06 AM, Han Zhou <zhou...@gmail.com> wrote: > Anil, thanks for the review! > > On Thu, Mar 22, 2018 at 11:12 PM, Anil Venkata <anilvenk...@redhat.com> > wrote: > > > > Is it possible to add a test for this patch i.e testing

Re: [ovs-dev] [PATCH v2] ovn: Avoid nb_cfg update notification flooding

Is it possible to add a test for this patch i.e testing if hypervisors correctly updating Chassis_NB_Cfg's nb_cfg when a new value is assigned to NB_Global's nb_cfg? Please see other comments inline Thanks Anil On Thu, Mar 22, 2018 at 4:57 AM, Han Zhou wrote: > nb_cfg as a

Re: [ovs-dev] [PATCH] Add unixctl option for ovn-northd

This is required for spawning ovn-northd for networking-ovn functional tests i.e https://review.openstack.org/#/c/532440/ https://review.openstack.org/#/c/532440/11/networking_ovn/tests/functional/resources/process.py@60

Re: [ovs-dev] [PATCH v2] ovn: Fix BFD error config on gateway

Reviewed change and it looks fine. Also tested the test case. On Sun, Aug 20, 2017 at 8:07 PM, Zhenyu Gao wrote: > The bfd_calculate_chassis function calculates gateway's peer datapaths > to figure out which tunnel's BFD should be enabled to from the current > chassis.

Re: [ovs-dev] [PATCH v1] ovn: Fix BFD error config on gateway

Hi Zhenyu Gao Is it possible for you to add a test case for this scenario. This test on the master code( without your patch) should fail, and your patch should make the test pass. Thanks Anil On Wed, Aug 16, 2017 at 12:17 PM, Zhenyu Gao wrote: > The

Re: [ovs-dev] [PATCH v7 1/1] ovn: l3ha, CLI for logical router port gateway chassis

Thanks Miguel. lrp-set-gateway-chassis is also used for updating the priority. User can initially set priority to some value and later can update with another value. For example, user can add chassis with priority 5, later can update it to 10 ovn-nbctl lrp-set-gateway-chassis lrp0 chassis1 5

Re: [ovs-dev] [PATCH v6 1/1] ovn: l3ha, CLI for logical router port gateway chassis

Thanks Russell. I will update man page. Thanks Anil On Tue, Jul 18, 2017 at 12:07 AM, Russell Bryant wrote: > On Mon, Jul 17, 2017 at 8:01 AM, Venkata Anil Kommaddi > wrote: > > From: Venkata Anil > > > > This change adds commands to

Re: [ovs-dev] [PATCH v5 1/1] ovn: l3ha, CLI for logical router port gateway chassis

Thanks Miguel. I will update it. On Fri, Jul 14, 2017 at 6:24 PM, Miguel Angel Ajo Pelayo < majop...@redhat.com> wrote: > Hey Anil!, thanks for the cli commands :D that's great > > Comments inline > > Other than those comments it looks fine to my unexperienced eyes. I'm > going to grab & try