[ovs-dev] [v4] odp-execute: Fix AVX checksum calculation.

2024-05-24 Thread Emma Finn
issue with actions autovalidator enabled. Signed-off-by: Emma Finn Reported-by: Eelco Chaudron --- lib/odp-execute-avx512.c | 5 tests/dpif-netdev.at | 64 2 files changed, 69 insertions(+) diff --git a/lib/odp-execute-avx512.c b/lib/odp-execute

[ovs-dev] [v3] odp-execute: Fix AVX checksum calculation.

2024-05-21 Thread Emma Finn
autovalidator. Signed-off-by: Emma Finn Reported-by: Eelco Chaudron --- lib/odp-execute-avx512.c | 5 + tests/dpif-netdev.at | 26 ++ 2 files changed, 31 insertions(+) diff --git a/lib/odp-execute-avx512.c b/lib/odp-execute-avx512.c index 50c48bfd4..a74a85dc1 100644

[ovs-dev] [v2] odp-execute: Fix AVX checksum calculation.

2024-05-14 Thread Emma Finn
autovalidator. Signed-off-by: Emma Finn Reported-by: Eelco Chaudron --- lib/odp-execute-avx512.c | 5 + tests/dpif-netdev.at | 26 ++ 2 files changed, 31 insertions(+) diff --git a/lib/odp-execute-avx512.c b/lib/odp-execute-avx512.c index 50c48bfd4..a74a85dc1 100644

[ovs-dev] [PATCH] odp-execute: Fix AVX checksum calculation.

2024-05-07 Thread Emma Finn
ation of set_masked IPv4 action") Signed-off-by: Emma Finn Reported-by: Eelco Chaudron --- lib/odp-execute-avx512.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/odp-execute-avx512.c b/lib/odp-execute-avx512.c index 50c48bfd4..911fdd3ea 100644 --- a/lib/odp-execute-avx512.c +++ b/lib/o

[ovs-dev] [v8] odp-execute: Add ISA implementation of set_masked IPv6 action

2022-12-08 Thread Emma Finn
| +-++ | mod_ipv6 4 x field | 1.43x | +-++ Signed-off-by: Emma Finn --- v8: - Added check for L4 header length. v7: - Added clearing of connection tracking fields. v6: - Added check

[ovs-dev] [PATCH] odp-execute: Add check for L4 header size.

2022-12-08 Thread Emma Finn
This patch adds check for L4 header size for avx512 implementation of the ipv4 action. Fixes: 92eb03f7b03a ("odp-execute: Add ISA implementation of set_masked IPv4 action") Signed-off-by: Emma Finn --- lib/odp-execute-avx512.c | 6 -- 1 file changed, 4 insertions(+), 2 deletion

[ovs-dev] [v7] odp-execute: Add ISA implementation of set_masked IPv6 action

2022-12-06 Thread Emma Finn
| +-++ | mod_ipv6 4 x field | 1.43x | +-++ Signed-off-by: Emma Finn --- v7: - Added clearing of connection tracking fields. v6: - Added check for ipv6 extension headers. v5: - Fixed

[ovs-dev] [PATCH] odp-execute: Fix ipv4 missing clearing of connection tracking fields.

2022-12-06 Thread Emma Finn
This patch add clearing of connection tracking fields to the avx512 implementation of the ipv4 action. This patch also extends the actions autovalidator to include a compare for packet metadata. Signed-off-by: Emma Finn --- lib/odp-execute-avx512.c | 2 ++ lib/odp-execute-private.c | 12

[ovs-dev] [v6] odp-execute: Add ISA implementation of set_masked IPv6 action

2022-11-30 Thread Emma Finn
This commit adds support for the AVX512 implementation of the ipv6_set_addrs action as well as an AVX512 implementation of updating the L4 checksums. Signed-off-by: Emma Finn --- v6: - Added check for ipv6 extension headers. v5: - Fixed load for ip6 src and dst mask for checksum check. v4

[ovs-dev] [v5] odp-execute: Add ISA implementation of set_masked IPv6 action

2022-11-25 Thread Emma Finn
This commit adds support for the AVX512 implementation of the ipv6_set_addrs action as well as an AVX512 implementation of updating the L4 checksums. Signed-off-by: Emma Finn --- v5: - Fixed load for ip6 src and dst mask for checksum check. v4: - Reworked and moved check for checksum

[ovs-dev] [v4] odp-execute: Add ISA implementation of set_masked IPv6 action

2022-11-24 Thread Emma Finn
This commit adds support for the AVX512 implementation of the ipv6_set_addrs action as well as an AVX512 implementation of updating the L4 checksums. Signed-off-by: Emma Finn --- v4: - Reworked and moved check for checksum outside loop. - Code cleanup based on review from Eelco. v3

[ovs-dev] [v3] odp-execute: Add ISA implementation of set_masked IPv6 action

2022-09-26 Thread Emma Finn
This commit adds support for the AVX512 implementation of the ipv6_set_addrs action as well as an AVX512 implementation of updating the L4 checksums. Signed-off-by: Emma Finn --- v3: - Added a runtime check for AVX512 vbmi. v2: - Added check for availbility of s6_addr32 field of struct

[ovs-dev] [v2] odp-execute: Add ISA implementation of set_masked IPv6 action

2022-09-20 Thread Emma Finn
This commit adds support for the AVX512 implementation of the ipv6_set_addrs action as well as an AVX512 implementation of updating the L4 checksums. Signed-off-by: Emma Finn --- v2: - Added check for availbility of s6_addr32 field of struct in6_addr. - Fixed network headers for freebsd

[ovs-dev] [PATCH] odp-execute: Add ISA implementation of set_masked IPv6 action

2022-09-13 Thread Emma Finn
This commit adds support for the AVX512 implementation of the ipv6_set_addrs action as well as an AVX512 implementation of updating the L4 checksums. Signed-off-by: Emma Finn --- lib/odp-execute-avx512.c | 163 +++ 1 file changed, 163 insertions(+) diff

[ovs-dev] [v12 10/10] odp-execute: Add ISA implementation of set_masked IPv4 action

2022-07-15 Thread Emma Finn
This commit adds support for the AVX512 implementation of the ipv4_set_addrs action as well as an AVX512 implementation of updating the checksums. Signed-off-by: Emma Finn Acked-by: Sunil Pai G --- lib/odp-execute-avx512.c | 206 +++ 1 file changed, 206

[ovs-dev] [v12 09/10] odp-execute: Add ISA implementation of set_masked ETH

2022-07-15 Thread Emma Finn
This commit includes infrastructure changes for enabling set_masked_X actions and also adds support for the AVX512 implementation of the eth_set_addrs action. Signed-off-by: Emma Finn Acked-by: Sunil Pai G Acked-by: Eelco Chaudron --- lib/odp-execute-avx512.c | 90

[ovs-dev] [v12 07/10] odp-execute: Add ISA implementation of pop_vlan action.

2022-07-15 Thread Emma Finn
This commit adds the AVX512 implementation of the pop_vlan action. Signed-off-by: Emma Finn Signed-off-by: Harry van Haaren Co-authored-by: Harry van Haaren Acked-by: Sunil Pai G Acked-by: Eelco Chaudron --- lib/automake.mk | 4 + lib/odp-execute-avx512.c | 187

[ovs-dev] [v12 08/10] odp-execute: Add ISA implementation of push_vlan action.

2022-07-15 Thread Emma Finn
This commit adds the AVX512 implementation of the push_vlan action. Signed-off-by: Emma Finn Acked-by: Sunil Pai G Acked-by: Eelco Chaudron --- lib/odp-execute-avx512.c | 54 lib/odp-execute.c| 22 +--- 2 files changed, 67

[ovs-dev] [v12 06/10] odp-execute: Add ISA implementation of actions.

2022-07-15 Thread Emma Finn
This commit adds the AVX512 implementation of the action functionality. Usage: $ ovs-appctl odp-execute/action-impl-set avx512 Signed-off-by: Emma Finn Signed-off-by: Harry van Haaren Co-authored-by: Harry van Haaren Acked-by: Sunil Pai G Acked-by: Eelco Chaudron --- Documentation/topics

[ovs-dev] [v12 05/10] acinclude: Add configure option to enable actions autovalidator at build time.

2022-07-15 Thread Emma Finn
From: Kumar Amber This commit adds a new command to allow the user to enable the actions autovalidator by default at build time thus allowing for running unit test by default. $ ./configure --enable-actions-default-autovalidator Signed-off-by: Kumar Amber Acked-by: Harry van Haaren

[ovs-dev] [v12 04/10] odp-execute: Add command to switch action implementation.

2022-07-15 Thread Emma Finn
implementations of actions are available and what implementation is active during runtime. Usage: $ ovs-appctl odp-execute/action-impl-show Added separate test-case for ovs-actions show/set commands: odp-execute - actions implementation Signed-off-by: Emma Finn Signed-off-by: Kumar Amber Signed-off

[ovs-dev] [v12 02/10] odp-execute: Add function pointer for pop_vlan action.

2022-07-15 Thread Emma Finn
This commit removes the pop_vlan action from the large switch and creates a separate function for batched processing. A function pointer is also added to call the new batched function for the pop_vlan action. Signed-off-by: Emma Finn Acked-by: Harry van Haaren Acked-by: Sunil Pai G Acked

[ovs-dev] [v12 03/10] odp-execute: Add auto validation function for actions.

2022-07-15 Thread Emma Finn
-execute/action-impl-set autovalidator Signed-off-by: Emma Finn Acked-by: Harry van Haaren Acked-by: Sunil Pai G Acked-by: Eelco Chaudron --- NEWS | 2 + lib/dp-packet.c | 24 ++ lib/dp-packet.h | 4 ++ lib/odp-execute-private.c | 98

[ovs-dev] [v12 00/10] Actions Infrastructure + Optimizations

2022-07-15 Thread Emma Finn
ase to master - Minor change to variable names - Added Tags from Harry. --- v4: - Rebase to master - Add ISA implementation of push_vlan action --- v3: - Refactored to fix unit test failures - Removed some sign-off on commits --- v2: - Fix the CI build issues --- Emma Finn (9): odp-execute:

[ovs-dev] [v12 01/10] odp-execute: Add function pointers to odp-execute for different action implementations.

2022-07-15 Thread Emma Finn
the user can choose the action implementation to best suite their use case. Signed-off-by: Emma Finn Acked-by: Harry van Haaren Acked-by: Sunil Pai G --- v10: - switch from < __OVS_ATTR_MAX back to <= OVS_ATTR_MAX (Eelco) v9: - rebase conflicts on NEWS - As Actions is initialized in vs

[ovs-dev] [v11 10/10] odp-execute: Add ISA implementation of set_masked IPv4 action

2022-07-14 Thread Emma Finn
This commit adds support for the AVX512 implementation of the ipv4_set_addrs action as well as an AVX512 implementation of updating the checksums. Signed-off-by: Emma Finn --- lib/odp-execute-avx512.c | 216 +++ 1 file changed, 216 insertions(+) diff --git

[ovs-dev] [v11 07/10] odp-execute: Add ISA implementation of pop_vlan action.

2022-07-14 Thread Emma Finn
From: Harry van Haaren This commit adds the AVX512 implementation of the pop_vlan action. Signed-off-by: Emma Finn --- lib/automake.mk | 4 + lib/odp-execute-avx512.c | 186 ++ lib/odp-execute-private.c | 32 ++- lib/odp-execute-private.h

[ovs-dev] [v11 09/10] odp-execute: Add ISA implementation of set_masked ETH

2022-07-14 Thread Emma Finn
This commit includes infrastructure changes for enabling set_masked_X actions and also adds support for the AVX512 implementation of the eth_set_addrs action. Signed-off-by: Emma Finn --- lib/odp-execute-avx512.c | 90 +++ lib/odp-execute-private.c | 14

[ovs-dev] [v11 08/10] odp-execute: Add ISA implementation of push_vlan action.

2022-07-14 Thread Emma Finn
This commit adds the AVX512 implementation of the push_vlan action. Signed-off-by: Emma Finn Acked-by: Eelco Chaudron --- lib/odp-execute-avx512.c | 54 lib/odp-execute.c| 22 +--- 2 files changed, 67 insertions(+), 9 deletions

[ovs-dev] [v11 02/10] odp-execute: Add function pointer for pop_vlan action.

2022-07-14 Thread Emma Finn
This commit removes the pop_vlan action from the large switch and creates a separate function for batched processing. A function pointer is also added to call the new batched function for the pop_vlan action. Signed-off-by: Emma Finn Acked-by: Harry van Haaren Acked-by: Eelco Chaudron --- lib

[ovs-dev] [v11 06/10] odp-execute: Add ISA implementation of actions.

2022-07-14 Thread Emma Finn
This commit adds the AVX512 implementation of the action functionality. Usage: $ ovs-appctl odp-execute/action-impl-set avx512 Signed-off-by: Emma Finn Signed-off-by: Harry van Haaren --- Documentation/topics/dpdk/bridge.rst | 30 Documentation/topics

[ovs-dev] [v11 05/10] acinclude: Add configure option to enable actions autovalidator at build time.

2022-07-14 Thread Emma Finn
From: Kumar Amber This commit adds a new command to allow the user to enable the actions autovalidator by default at build time thus allowing for running unit test by default. $ ./configure --enable-actions-default-autovalidator Signed-off-by: Kumar Amber Acked-by: Harry van Haaren

[ovs-dev] [v11 04/10] odp-execute: Add command to switch action implementation.

2022-07-14 Thread Emma Finn
implementations of actions are available and what implementation is active during runtime. Usage: $ ovs-appctl odp-execute/action-impl-show Added separate test-case for ovs-actions show/set commands: odp-execute - actions implementation Signed-off-by: Emma Finn Signed-off-by: Kumar Amber Signed-off

[ovs-dev] [v11 03/10] odp-execute: Add auto validation function for actions.

2022-07-14 Thread Emma Finn
-execute/action-impl-set autovalidator Signed-off-by: Emma Finn Acked-by: Harry van Haaren Acked-by: Eelco Chaudron --- NEWS | 2 + lib/dp-packet.c | 24 ++ lib/dp-packet.h | 4 ++ lib/odp-execute-private.c | 98

[ovs-dev] [v11 00/10] Actions Infrastructure + Optimizations

2022-07-14 Thread Emma Finn
lan action --- v3: - Refactored to fix unit test failures - Removed some sign-off on commits --- v2: - Fix the CI build issues --- Emma Finn (8): odp-execute: Add function pointers to odp-execute for different action implementations. odp-execute: Add function pointer for pop_vlan action.

[ovs-dev] [v11 01/10] odp-execute: Add function pointers to odp-execute for different action implementations.

2022-07-14 Thread Emma Finn
the user can choose the action implementation to best suite their use case. Signed-off-by: Emma Finn Acked-by: Harry van Haaren --- v10: - switch from < __OVS_ATTR_MAX back to <= OVS_ATTR_MAX (Eelco) v9: - rebase conflicts on NEWS - As Actions is initialized in vswitchd/bridge.c now

[ovs-dev] [v8 10/10] odp-execute: Add ISA implementation of set_masked IPv4 action

2022-07-07 Thread Emma Finn
This commit adds support for the AVX512 implementation of the ipv4_set_addrs action as well as an AVX512 implementation of updating the checksums. Signed-off-by: Emma Finn --- lib/odp-execute-avx512.c | 208 +++ 1 file changed, 208 insertions(+) diff --git

[ovs-dev] [v8 09/10] odp-execute: Add ISA implementation of set_masked ETH

2022-07-07 Thread Emma Finn
This commit includes infrastructure changes for enabling set_masked_X actions and also adds support for the AVX512 implementation of the eth_set_addrs action. Signed-off-by: Emma Finn --- lib/odp-execute-avx512.c | 90 +++ lib/odp-execute-private.c | 14

[ovs-dev] [v8 08/10] odp-execute: Add ISA implementation of push_vlan action.

2022-07-07 Thread Emma Finn
This commit adds the AVX512 implementation of the push_vlan action. Signed-off-by: Emma Finn --- lib/odp-execute-avx512.c | 55 lib/odp-execute.c| 22 +--- 2 files changed, 68 insertions(+), 9 deletions(-) diff --git a/lib/odp

[ovs-dev] [v8 07/10] odp-execute: Add ISA implementation of pop_vlan action.

2022-07-07 Thread Emma Finn
This commit adds the AVX512 implementation of the pop_vlan action. Signed-off-by: Emma Finn --- lib/odp-execute-avx512.c | 153 +- lib/odp-execute-private.h | 2 +- 2 files changed, 153 insertions(+), 2 deletions(-) diff --git a/lib/odp-execute-avx512.c b

[ovs-dev] [v8 06/10] odp-execute: Add ISA implementation of actions.

2022-07-07 Thread Emma Finn
This commit adds the AVX512 implementation of the action functionality. Usage: $ ovs-appctl odp-execute/action-impl-set avx512 Signed-off-by: Emma Finn Acked-by: Harry van Haaren --- Documentation/ref/ovs-actions.7.rst | 26 + Documentation/topics/testing.rst| 24

[ovs-dev] [v8 04/10] odp-execute: Add command to switch action implementation.

2022-07-07 Thread Emma Finn
implementations of actions are available and what implementation is active during runtime. Usage: $ ovs-appctl odp-execute/action-impl-show Added separate test-case for ovs-actions show/set commands: PMD - ovs-actions configuration Signed-off-by: Emma Finn Signed-off-by: Kumar Amber Signed-off

[ovs-dev] [v8 00/10] Actions Infrastructure + Optimizations

2022-07-07 Thread Emma Finn
: - Refactored to fix unit test failures - Removed some sign-off on commits --- v2: - Fix the CI build issues --- Emma Finn (9): odp-execute: Add function pointers to odp-execute for different action implementations. odp-execute: Add function pointer for pop_vlan action. odp-execute: Add

[ovs-dev] [v8 05/10] dpif-netdev: Add configure option to enable actions autovalidator at build time.

2022-07-07 Thread Emma Finn
From: Kumar Amber This commit adds a new command to allow the user to enable the actions autovalidator by default at build time thus allowing for running unit test by default. $ ./configure --enable-actions-default-autovalidator Signed-off-by: Kumar Amber Acked-by: Harry van Haaren ---

[ovs-dev] [v8 03/10] odp-execute: Add auto validation function for actions.

2022-07-07 Thread Emma Finn
-execute/action-impl-set autovalidator Signed-off-by: Emma Finn Acked-by: Harry van Haaren --- NEWS | 2 + lib/dp-packet.c | 24 ++ lib/dp-packet.h | 4 ++ lib/odp-execute-private.c | 99 +++ lib/odp-execute

[ovs-dev] [v8 02/10] odp-execute: Add function pointer for pop_vlan action.

2022-07-07 Thread Emma Finn
This commit removes the pop_vlan action from the large switch and creates a separate function for batched processing. A function pointer is also added to call the new batched function for the pop_vlan action. Signed-off-by: Emma Finn Acked-by: Harry van Haaren --- lib/odp-execute-private.c

[ovs-dev] [v8 01/10] odp-execute: Add function pointers to odp-execute for different action implementations.

2022-07-07 Thread Emma Finn
the user can choose the action implementation to best suite their use case. Signed-off-by: Emma Finn Acked-by: Harry van Haaren --- lib/automake.mk | 2 + lib/dpif-netdev.c | 4 ++ lib/odp-execute-private.c | 92 +++ lib/odp-execute-private.h

[ovs-dev] [PATCH v7 11/11] odp-execute: Add ISA implementation of set_masked IPv4 action

2022-06-14 Thread Emma Finn
This commit adds support for the AVX512 implementation of the ipv4_set_addrs action as well as an AVX512 implementation of updating the checksums. Signed-off-by: Emma Finn --- lib/odp-execute-avx512.c | 210 ++ lib/odp-execute-private.c | 1 + lib/odp

[ovs-dev] [PATCH v7 10/11] odp-execute: Add ISA implementation of set_masked ETH

2022-06-14 Thread Emma Finn
This commit includes infrastructure changes for enabling set_masked_X actions and also adds support for the AVX512 implementation of the eth_set_addrs action. Signed-off-by: Emma Finn --- lib/odp-execute-avx512.c | 69 +++ lib/odp-execute-private.c | 56

[ovs-dev] [PATCH v7 09/11] odp-execute: Add ISA implementation of push_vlan action.

2022-06-14 Thread Emma Finn
This commit adds the AVX512 implementation of the push_vlan action. Signed-off-by: Emma Finn --- lib/odp-execute-avx512.c | 37 + lib/odp-execute-private.c | 1 + lib/odp-execute.c | 22 +- 3 files changed, 51 insertions(+), 9

[ovs-dev] [PATCH v7 08/11] odp-execute: Add ISA implementation of pop_vlan action.

2022-06-14 Thread Emma Finn
This commit adds the AVX512 implementation of the pop_vlan action. Signed-off-by: Emma Finn --- lib/odp-execute-avx512.c | 91 1 file changed, 91 insertions(+) diff --git a/lib/odp-execute-avx512.c b/lib/odp-execute-avx512.c index 1fb334689..f9e2b1727

[ovs-dev] [PATCH v7 07/11] odp-execute: Add ISA implementation of actions.

2022-06-14 Thread Emma Finn
This commit adds the AVX512 implementation of the action functionality. Usage: $ ovs-appctl dpif-netdev/action-impl-set avx512 Signed-off-by: Emma Finn Acked-by: Harry van Haaren --- Documentation/ref/ovs-actions.7.rst | 26 ++ Documentation/topics/testing.rst| 24

[ovs-dev] [PATCH v7 05/11] odp-execute: Add command to switch action implementation.

2022-06-14 Thread Emma Finn
-actions show/set commands: 1023: PMD - ovs-actions configuration Signed-off-by: Emma Finn Co-authored-by: Kumar Amber Signed-off-by: Kumar Amber Acked-by: Harry van Haaren --- NEWS| 3 +++ lib/dpif-netdev-unixctl.man | 8 lib/dpif-netdev.c | 38

[ovs-dev] [PATCH v7 06/11] dpif-netdev: Add configure option to enable actions autovalidator at build time.

2022-06-14 Thread Emma Finn
From: Kumar Amber This commit adds a new command to allow the user to enable the actions autovalidator by default at build time thus allowing for running unit test by default. $ ./configure --enable-actions-default-autovalidator Signed-off-by: Kumar Amber Acked-by: Harry van Haaren ---

[ovs-dev] [PATCH v7 04/11] odp-execute: Add auto validation function for actions.

2022-06-14 Thread Emma Finn
-netdev/action-impl-set autovalidator Signed-off-by: Emma Finn Acked-by: Harry van Haaren --- NEWS | 3 ++ lib/dp-packet.c | 23 + lib/dp-packet.h | 4 ++ lib/odp-execute-private.c | 98 +++ lib/odp-execute

[ovs-dev] [PATCH v7 03/11] odp-execute: Add function pointer for pop_vlan action.

2022-06-14 Thread Emma Finn
This commit removes the pop_vlan action from the large switch and creates a separate function for batched processing. A function pointer is also added to call the new batched function for the pop_vlan action. Signed-off-by: Emma Finn Acked-by: Harry van Haaren --- lib/odp-execute-private.c

[ovs-dev] [PATCH v7 02/11] odp-execute: Add function pointers to odp-execute for different action implementations.

2022-06-14 Thread Emma Finn
the user can choose the action implementation to best suite their use case. Signed-off-by: Emma Finn Acked-by: Harry van Haaren --- lib/automake.mk | 2 + lib/dpif-netdev.c | 4 ++ lib/odp-execute-private.c | 80 +++ lib/odp-execute-private.h

[ovs-dev] [PATCH v7 01/11] ofproto-dpif: Fix incorrect checksums in input packets

2022-06-14 Thread Emma Finn
The IP checksum field was invalid in the input packets for some unit tests. The unit tests will still pass without a valid checksum, however we should still fix these. Signed-off-by: Emma Finn Acked-by: Eelco Chaudron --- This was found using the autovalidator introduced later in this series

[ovs-dev] [PATCH v7 00/11] Actions Infrastructure + Optimizations

2022-06-14 Thread Emma Finn
to variable names - Added Tags from Harry. --- v4: - Rebase to master - Add ISA implementation of push_vlan action --- v3: - Refactored to fix unit test failures - Removed some sign-off on commits --- v2: - Fix the CI build issues --- Emma Finn (10): ofproto-dpif: Fix incorrect checksums in input packets

[ovs-dev] [PATCH v7 11/11] odp-execute: Add ISA implementation of set_masked IPv4 action

2022-06-14 Thread Emma Finn
This commit adds support for the AVX512 implementation of the ipv4_set_addrs action as well as an AVX512 implementation of updating the checksums. Signed-off-by: Emma Finn --- lib/odp-execute-avx512.c | 210 ++ lib/odp-execute-private.c | 1 + lib/odp

[ovs-dev] [PATCH v7 10/11] odp-execute: Add ISA implementation of set_masked ETH

2022-06-14 Thread Emma Finn
This commit includes infrastructure changes for enabling set_masked_X actions and also adds support for the AVX512 implementation of the eth_set_addrs action. Signed-off-by: Emma Finn --- lib/odp-execute-avx512.c | 69 +++ lib/odp-execute-private.c | 56

[ovs-dev] [PATCH v7 09/11] odp-execute: Add ISA implementation of push_vlan action.

2022-06-14 Thread Emma Finn
This commit adds the AVX512 implementation of the push_vlan action. Signed-off-by: Emma Finn --- lib/odp-execute-avx512.c | 37 + lib/odp-execute-private.c | 1 + lib/odp-execute.c | 22 +- 3 files changed, 51 insertions(+), 9

[ovs-dev] [PATCH v7 08/11] odp-execute: Add ISA implementation of pop_vlan action.

2022-06-14 Thread Emma Finn
This commit adds the AVX512 implementation of the pop_vlan action. Signed-off-by: Emma Finn --- lib/odp-execute-avx512.c | 91 1 file changed, 91 insertions(+) diff --git a/lib/odp-execute-avx512.c b/lib/odp-execute-avx512.c index 1fb334689..f9e2b1727

[ovs-dev] [PATCH v7 07/11] odp-execute: Add ISA implementation of actions.

2022-06-14 Thread Emma Finn
This commit adds the AVX512 implementation of the action functionality. Usage: $ ovs-appctl dpif-netdev/action-impl-set avx512 Signed-off-by: Emma Finn Acked-by: Harry van Haaren --- Documentation/ref/ovs-actions.7.rst | 26 ++ Documentation/topics/testing.rst| 24

[ovs-dev] [PATCH v7 06/11] dpif-netdev: Add configure option to enable actions autovalidator at build time.

2022-06-14 Thread Emma Finn
From: Kumar Amber This commit adds a new command to allow the user to enable the actions autovalidator by default at build time thus allowing for running unit test by default. $ ./configure --enable-actions-default-autovalidator Signed-off-by: Kumar Amber Acked-by: Harry van Haaren ---

[ovs-dev] [PATCH v7 05/11] odp-execute: Add command to switch action implementation.

2022-06-14 Thread Emma Finn
-actions show/set commands: 1023: PMD - ovs-actions configuration Signed-off-by: Emma Finn Co-authored-by: Kumar Amber Signed-off-by: Kumar Amber Acked-by: Harry van Haaren --- NEWS| 3 +++ lib/dpif-netdev-unixctl.man | 8 lib/dpif-netdev.c | 38

[ovs-dev] [PATCH v7 04/11] odp-execute: Add auto validation function for actions.

2022-06-14 Thread Emma Finn
-netdev/action-impl-set autovalidator Signed-off-by: Emma Finn Acked-by: Harry van Haaren --- NEWS | 3 ++ lib/dp-packet.c | 23 + lib/dp-packet.h | 4 ++ lib/odp-execute-private.c | 98 +++ lib/odp-execute

[ovs-dev] [PATCH v7 03/11] odp-execute: Add function pointer for pop_vlan action.

2022-06-14 Thread Emma Finn
This commit removes the pop_vlan action from the large switch and creates a separate function for batched processing. A function pointer is also added to call the new batched function for the pop_vlan action. Signed-off-by: Emma Finn Acked-by: Harry van Haaren --- lib/odp-execute-private.c

[ovs-dev] [PATCH v7 02/11] odp-execute: Add function pointers to odp-execute for different action implementations.

2022-06-14 Thread Emma Finn
the user can choose the action implementation to best suite their use case. Signed-off-by: Emma Finn Acked-by: Harry van Haaren --- lib/automake.mk | 2 + lib/dpif-netdev.c | 4 ++ lib/odp-execute-private.c | 80 +++ lib/odp-execute-private.h

[ovs-dev] [PATCH v7 01/11] ofproto-dpif: Fix incorrect checksums in input packets

2022-06-14 Thread Emma Finn
The IP checksum field was invalid in the input packets for some unit tests. The unit tests will still pass without a valid checksum, however we should still fix these. Signed-off-by: Emma Finn Acked-by: Eelco Chaudron --- This was found using the autovalidator introduced later in this series

[ovs-dev] [PATCH v7 00/11] Actions Infrastructure + Optimizations

2022-06-14 Thread Emma Finn
to variable names - Added Tags from Harry. --- v4: - Rebase to master - Add ISA implementation of push_vlan action --- v3: - Refactored to fix unit test failures - Removed some sign-off on commits --- v2: - Fix the CI build issues --- Emma Finn (10): ofproto-dpif: Fix incorrect checksums in input packets

[ovs-dev] [v6 10/11] odp-execute: Add ISA implementation of set_masked ETH action

2022-05-10 Thread Emma Finn
This commit includes infrastructure changes for enabling set_masked_X actions and also adds support for the AVX512 implementation of the eth_set_addrs action. Signed-off-by: Emma Finn --- .../linux/compat/include/linux/openvswitch.h | 2 +- lib/odp-execute-avx512.c | 56

[ovs-dev] [v6 11/11] odp-execute: Add ISA implementation of set_masked IPv4 action

2022-05-10 Thread Emma Finn
This commit adds support for the AVX512 implementation of the ipv4_set_addrs action as well as an AVX512 implementation of updating the checksums. Signed-off-by: Emma Finn --- lib/odp-execute-avx512.c | 194 ++ lib/odp-execute-private.c | 1 + lib/odp

[ovs-dev] [v6 09/11] odp-execute: Add ISA implementation of push_vlan action.

2022-05-10 Thread Emma Finn
This commit adds the AVX512 implementation of the push_vlan action. Signed-off-by: Emma Finn --- lib/odp-execute-avx512.c | 56 --- lib/odp-execute-private.c | 1 + lib/odp-execute.c | 24 ++--- 3 files changed, 69 insertions(+), 12

[ovs-dev] [v6 08/11] odp-execute: Add ISA implementation of pop_vlan action.

2022-05-10 Thread Emma Finn
This commit adds the AVX512 implementation of the pop_vlan action. Signed-off-by: Emma Finn --- lib/odp-execute-avx512.c | 73 ++- lib/odp-execute-private.c | 2 +- lib/odp-execute-private.h | 2 +- 3 files changed, 74 insertions(+), 3 deletions(-) diff

[ovs-dev] [v6 07/11] odp-execute: Add ISA implementation of actions.

2022-05-10 Thread Emma Finn
This commit adds the AVX512 implementation of the action functionality. Usage: $ ovs-appctl dpif-netdev/action-impl-set avx512 Signed-off-by: Emma Finn Acked-by: Harry van Haaren --- Documentation/topics/dpdk/bridge.rst | 25 +++ Documentation/topics/testing.rst | 20

[ovs-dev] [v6 06/11] dpif-netdev: Add configure option to enable actions autovalidator at build time.

2022-05-10 Thread Emma Finn
From: Kumar Amber This commit adds a new command to allow the user to enable the actions autovalidator by default at build time thus allowing for running unit test by default. $ ./configure --enable-actions-default-autovalidator Signed-off-by: Kumar Amber Acked-by: Harry van Haaren ---

[ovs-dev] [v6 05/11] odp-execute: Add command to switch action implementation.

2022-05-10 Thread Emma Finn
-actions get/set commands: 1023: PMD - ovs-actions configuration Signed-off-by: Emma Finn Co-authored-by: Kumar Amber Signed-off-by: Kumar Amber Acked-by: Harry van Haaren --- NEWS| 2 ++ lib/dpif-netdev-unixctl.man | 6 ++ lib/dpif-netdev.c | 39

[ovs-dev] [v6 04/11] odp-execute: Add auto validation function for actions.

2022-05-10 Thread Emma Finn
-netdev/action-impl-set autovalidator Signed-off-by: Emma Finn Acked-by: Harry van Haaren --- NEWS | 2 + lib/dp-packet.c | 23 + lib/dp-packet.h | 4 ++ lib/odp-execute-private.c | 99 +++ lib/odp-execute

[ovs-dev] [v6 03/11] odp-execute: Add function pointer for pop_vlan action.

2022-05-10 Thread Emma Finn
This commit removes the pop_vlan action from the large switch and creates a separate function for batched processing. A function pointer is also added to call the new batched function for the pop_vlan action. Signed-off-by: Emma Finn Acked-by: Harry van Haaren --- lib/odp-execute-private.c

[ovs-dev] [v6 02/11] odp-execute: Add function pointers to odp-execute for different action implementations.

2022-05-10 Thread Emma Finn
the user can choose the action implementation to best suite their use case. Signed-off-by: Emma Finn Acked-by: Harry van Haaren --- lib/automake.mk | 2 + lib/dpif-netdev.c | 4 ++ lib/odp-execute-private.c | 94 ++ lib/odp-execute-private.h

[ovs-dev] [v6 01/11] ofproto-dpif: Fix incorrect checksums in input packets

2022-05-10 Thread Emma Finn
The IP checksum field was invalid in the input packets for some unit tests. The unit tests will still pass without a valid checksum, however we should still fix these. Signed-off-by: Emma Finn --- This was found using the autovalidator introduced later in this series. --- --- tests/ofproto

[ovs-dev] [v6 00/11] Actions Infrastructure + Optimizations

2022-05-10 Thread Emma Finn
. --- v4: - Rebase to master - Add ISA implementation of push_vlan action --- v3: - Refactored to fix unit test failures - Removed some sign-off on commits --- v2: - Fix the CI build issues --- Emma Finn (10): ofproto-dpif: Fix incorrect checksums in input packets odp-execute: Add function

[ovs-dev] [PATCH v5 8/8] odp-execute: Add ISA implementation of push_vlan action.

2022-01-12 Thread Emma Finn
This commit adds the AVX512 implementation of the push_vlan action. The implementation here is auto-validated by the miniflow extract autovalidator, hence its correctness can be easily tested and verified. Signed-off-by: Emma Finn --- lib/odp-execute-avx512.c | 62

[ovs-dev] [PATCH v5 7/8] odp-execute: Add ISA implementation of pop_vlan action.

2022-01-12 Thread Emma Finn
This commit adds the AVX512 implementation of the pop_vlan action. The implementation here is auto-validated by the miniflow extract autovalidator, hence its correctness can be easily tested and verified. Signed-off-by: Emma Finn --- lib/odp-execute-avx512.c | 77

[ovs-dev] [PATCH v5 6/8] odp-execute: Add ISA implementation of actions.

2022-01-12 Thread Emma Finn
This commit adds the AVX512 implementation of the action functionality. Usage: $ ovs-appctl dpif-netdev/action-impl-set avx512 Signed-off-by: Emma Finn Acked-by: Harry van Haaren --- Documentation/topics/dpdk/bridge.rst | 25 ++ Documentation/topics/testing.rst | 20

[ovs-dev] [PATCH v5 5/8] dpif-netdev: Add configure option to enable actions autovalidator at build time.

2022-01-12 Thread Emma Finn
From: Kumar Amber This commit adds a new command to allow the user to enable the actions autovalidator by default at build time thus allowing for running unit test by default. $ ./configure --enable-actions-default-autovalidator Signed-off-by: Kumar Amber Acked-by: Harry van Haaren ---

[ovs-dev] [PATCH v5 4/8] odp-execute: Add command to switch action implementation.

2022-01-12 Thread Emma Finn
-actions get/set commands: 1023: PMD - ovs-actions configuration Signed-off-by: Emma Finn Co-authored-by: Kumar Amber Signed-off-by: Kumar Amber Acked-by: Harry van Haaren --- NEWS| 2 ++ lib/dpif-netdev-unixctl.man | 6 ++ lib/dpif-netdev.c | 39

[ovs-dev] [PATCH v5 3/8] odp-execute: Add auto validation function for actions.

2022-01-12 Thread Emma Finn
-netdev/action-impl-set autovalidator Signed-off-by: Emma Finn Acked-by: Harry van Haaren --- NEWS | 2 + lib/dp-packet.c | 23 + lib/dp-packet.h | 5 ++ lib/odp-execute-private.c | 99 +++ lib/odp-execute

[ovs-dev] [PATCH v5 1/8] odp-execute: Add function pointers to odp-execute for different action implementations.

2022-01-12 Thread Emma Finn
the user can choose the action implementation to best suite their use case. Signed-off-by: Emma Finn Acked-by: Harry van Haaren --- lib/automake.mk | 2 + lib/dpif-netdev.c | 2 + lib/odp-execute-private.c | 84 + lib/odp-execute-private.h | 98

[ovs-dev] [PATCH v5 2/8] odp-execute: Add function pointer for pop_vlan action.

2022-01-12 Thread Emma Finn
This commit removes the pop_vlan action from the large switch and creates a separate function for batched processing. A function pointer is also added to call the new batched function for the pop_vlan action. Signed-off-by: Emma Finn Acked-by: Harry van Haaren --- lib/odp-execute-private.c

[ovs-dev] [PATCH v5 0/8] Actions Infrastructure + Optimizations

2022-01-12 Thread Emma Finn
also introduces an optimized version of the push and pop vlan actions. Emma Finn (7): odp-execute: Add function pointers to odp-execute for different action implementations. odp-execute: Add function pointer for pop_vlan action. odp-execute: Add auto validation function for actions. odp

[ovs-dev] [PATCH v4 9/9] odp-execute: Add ISA implementation of push_vlan action.

2022-01-05 Thread Emma Finn
This commit adds the AVX512 implementation of the push_vlan action. The implementation here is auto-validated by the miniflow extract autovalidator, hence its correctness can be easily tested and verified. Signed-off-by: Emma Finn --- NEWS | 1 + lib/odp-execute-avx512.c

[ovs-dev] [PATCH v4 8/9] odp-execute: Add ISA implementation of pop_vlan action.

2022-01-05 Thread Emma Finn
This commit adds the AVX512 implementation of the pop_vlan action. The implementation here is auto-validated by the miniflow extract autovalidator, hence its correctness can be easily tested and verified. Signed-off-by: Emma Finn --- NEWS | 1 + lib/odp-execute-avx512.c

[ovs-dev] [PATCH v4 7/9] odp-execute: Add ISA implementation of actions.

2022-01-05 Thread Emma Finn
This commit adds the AVX512 implementation of the action functionality. Usage: $ ovs-appctl dpif-netdev/action-impl-set avx512 Signed-off-by: Emma Finn --- Documentation/topics/dpdk/bridge.rst | 25 ++ Documentation/topics/testing.rst | 20 +--- NEWS

[ovs-dev] [PATCH v4 6/9] dpif-netdev: Add configure option to enable actions autovalidator at build time.

2022-01-05 Thread Emma Finn
From: Kumar Amber This commit adds a new command to allow the user to enable the actions autovalidator by default at build time thus allowing for running unit test by default. $ ./configure --enable-actions-default-autovalidator Signed-off-by: Kumar Amber --- NEWS | 2 ++

[ovs-dev] [PATCH v4 5/9] pmd.at: Add test-cases for ovs-actions commands.

2022-01-05 Thread Emma Finn
From: Kumar Amber Added separate test-case for ovs-actions get/set commands: 1023: PMD - ovs-actions configuration The above added tests are to test the commands which are used to either get or set the ovs-actions function pointers to various different implementations like AVX512 or

[ovs-dev] [PATCH v4 4/9] odp-execute: Add command to switch action implementation.

2022-01-05 Thread Emma Finn
also adds a new command to retrieve the list of available action implementations. This can be used by to check what implementations of actions are available and what implementation is active during runtime. Usage: $ ovs-appctl dpif-netdev/action-impl-get Signed-off-by: Emma Finn --- NEWS

[ovs-dev] [PATCH v4 3/9] odp-execute: Add auto validation function for actions.

2022-01-05 Thread Emma Finn
-netdev/action-impl-set autovalidator Signed-off-by: Emma Finn --- NEWS | 2 + lib/dp-packet.c | 23 + lib/dp-packet.h | 5 ++ lib/odp-execute-private.c | 99 +++ lib/odp-execute-private.h | 3 ++ 5 files changed

[ovs-dev] [PATCH v4 2/9] odp-execute: Add function pointer for pop_vlan action.

2022-01-05 Thread Emma Finn
This commit removes the pop_vlan action from the large switch and creates a separate function for batched processing. A function pointer is also added to call the new batched function for the pop_vlan action. Signed-off-by: Emma Finn --- lib/odp-execute-private.c | 19 +- lib

  1   2   >