ng
/var/run/openvswitch/ovs-vswitchd.pid →
/run/openvswitch/ovs-vswitchd.pid; please update the unit file
accordingly.
Acked-by: Flavio Leitner
Thanks Timothy,
fbl
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Hi Kumar,
There is an issue with the signed-offs reported by 0-day Robot.
For additional info, please check the link below and look for the
tag Co-authored-by:
https://github.com/openvswitch/ovs/blob/master/Documentation/internals/contributing/submitting-patches.rst#tags
Otherwise the patch
Hi Joe,
Maybe you can take a look...
Thanks,
fbl
On Thu, Jul 08, 2021 at 11:40:12AM -0300, Flavio Leitner wrote:
>
> Hi Pravin,
>
> Any thoughts on this patch? We are closing OVS 2.16, so it would
> be nice to know if it looks okay or needs changes, specially
&g
On Mon, Jul 12, 2021 at 02:22:46PM +0200, Eelco Chaudron wrote:
> See some comments below…
>
> For this patch series, I’m only looking at the diff from v6..v9, not a full
> review.
> I will do basic compilation and some tests at the end.
>
> Cheers,
>
> Eelco
>
>
> On 12 Jul 2021, at 7:51,
On Fri, Jul 09, 2021 at 05:36:02PM +0530, kumar Amber wrote:
> This commits add the mfex optimized options to be
> executed as part of scalar DPIF.
>
> Signed-off-by: kumar Amber
> ---
Acked-by: Flavio Leitner
___
dev
rrectness of each implementation is
> achieved through autovalidation, unit tests with known packets, and
> fuzz tested packets.
>
> Signed-off-by: Harry van Haaren
> Acked-by: Eelco Chaudron
> ---
Acked-by: Flavio Leitner
___
de
Hi,
On Fri, Jul 09, 2021 at 05:36:00PM +0530, kumar Amber wrote:
> From: Harry van Haaren
>
> This commit adds AVX512 implementations of miniflow extract.
> By using the 64 bytes available in an AVX512 register, it is
> possible to convert a packet to a miniflow data-structure in
> a small
the
> optimized miniflow extract parsers.
>
> The ovs-appctl command "dpif-netdev/pmd-perf-show" now has an
> extra entry indicating if the optimized MFEX was hit:
>
> - MFEX Opt hits:6786432 (100.0 %)
>
> Signed-off-by: Har
uzzy traffic
> type pcap to be used in fuzzy unit test.
>
> Signed-off-by: Kumar Amber
>
> ---
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Hi,
On Fri, Jul 09, 2021 at 05:35:56PM +0530, kumar Amber wrote:
> From: Kumar Amber
>
> This commit introduces additional command line paramter
Parameter.
> for mfex study function. If user provides additional packet out
> it is used in study to compare minimum packets which must be
On Fri, Jul 09, 2021 at 05:35:55PM +0530, kumar Amber wrote:
> From: Kumar Amber
>
> This commit adds a new command to allow the user to enable
> autovalidatior by default at build time thus allowing for
> runnig unit test by default.
>
> $ ./configure --enable-mfex-default-autovalidator
>
>
Hi,
On Fri, Jul 09, 2021 at 05:35:53PM +0530, kumar Amber wrote:
> From: Kumar Amber
>
> The study function runs all the available implementations
> of miniflow_extract and makes a choice whose hitmask has
> maximum hits and sets the mfex to that function.
>
> Study can be run at runtime
d.
>
> The use of auto-validator and special study function is also described
> in detail as well as running fuzzy tests.
>
> Signed-off-by: Kumar Amber
> Co-authored-by: Cian Ferriter
> Signed-off-by: Cian Ferriter
> Co-authored-by: Harry van Haaren
> Signed-off-by: Ha
On Fri, Jul 09, 2021 at 05:35:52PM +0530, kumar Amber wrote:
> From: Kumar Amber
>
> This patch introduced the auto-validation function which
> allows users to compare the batch of packets obtained from
> different miniflow implementations against the linear
> miniflow extract and return a
Hi
On Fri, Jul 09, 2021 at 05:35:51PM +0530, kumar Amber wrote:
> From: Kumar Amber
>
> This patch introduces the mfex function pointers which allows
Let's use capital MFEX.
> the user to switch between different miniflow extract implementations
> which are provided by the OVS based on
On Fri, Jul 09, 2021 at 10:08:39PM +0200, Ilya Maximets wrote:
> On 7/8/21 2:16 PM, Flavio Leitner wrote:
> > On Mon, Jul 05, 2021 at 07:57:41AM -0400, Eelco Chaudron wrote:
> >> When TSO is disabled from a userspace forwarding datapath perspective,
> >> but T
hitting on EMC by using a mark ID provided by a NIC. Add a
> PMD statistic for this hit.
>
> Signed-off-by: Cian Ferriter
> Acked-by: Flavio Leitner
>
> ---
>
> Cc: Gaetan Rivet
> Cc: Sriharsha Basavapatna
>
> v14:
> - Added Flavio's Acked-by tag.
&g
binary. It also returns which
> implementations are in use by the OVS PMD threads.
>
> Usage:
> $ ovs-appctl dpif-netdev/dpif-impl-get
>
> Signed-off-by: Harry van Haaren
> Co-authored-by: Cian Ferriter
> Signed-off-by: Cian Ferri
tions in
> parallel and comparing output is not a valid testing method, as there
> are changes in DPIF statistic counters (side effects). As a result, the
> DPIF is tested directly against the unit-tests.
>
> Signed-off-by: Harry van Haaren
> Co-author
On Fri, Jul 09, 2021 at 01:43:08PM +, Van Haaren, Harry wrote:
> > -Original Message-
>
>
> > > +Optimizing Specific Subtable Search
> > > +~~~
> > > +
> > > +The DPCLS wildcarding engine can be "specialized" to handle specific
> > > subtable
> > >
Hi,
Thanks for following up with this patch.
See my comments below.
On Thu, Jul 08, 2021 at 09:41:54PM +0530, kumar Amber wrote:
> From: Harry van Haaren
>
> This commit avoids many instances of "using subtable X for miniflow (x,y)"
> in the ovs-vswitchd log when using the DPCLS
On Fri, Jul 09, 2021 at 01:55:25PM +0200, Eelco Chaudron wrote:
>
>
> On 9 Jul 2021, at 13:16, Amber, Kumar wrote:
>
> > Hi Eelco,
> >
> >> -Original Message-
> >> From: Eelco Chaudron
> >> Sent: Friday, July 9, 2021 4:42 PM
> &
Hi Pravin,
Any thoughts on this patch? We are closing OVS 2.16, so it would
be nice to know if it looks okay or needs changes, specially
changes related to the userspace interface.
Thanks,
fbl
On Wed, Jun 30, 2021 at 05:53:49AM -0400, Mark Gray wrote:
> The Open vSwitch kernel module uses the
Hi,
Eelco did an extensive review on this one already, so I will
try to not repeat the same.
See below.
On Tue, Jul 06, 2021 at 02:11:40PM +0100, Cian Ferriter wrote:
> From: Kumar Amber
>
> This patch introduces the mfex function pointers which allows
> the user to switch between different
Hi Ian,
This one affects TSO which I think you have interest.
If you're okay with the patch, could you please merge it?
Thanks,
fbl
On Mon, Jul 05, 2021 at 07:57:41AM -0400, Eelco Chaudron wrote:
> When TSO is disabled from a userspace forwarding datapath perspective,
> but TSO has been
On Wed, Jul 07, 2021 at 12:58:28PM -0700, Ben Pfaff wrote:
> On Wed, Jul 07, 2021 at 04:37:11PM -0300, Flavio Leitner wrote:
> >
> > Hi,
> >
> > On Tue, Jul 06, 2021 at 03:37:09PM -0700, Ben Pfaff wrote:
> > > The vswitchd database schema requires role
Hi,
On Wed, Jul 07, 2021 at 04:53:14PM +0200, Ilya Maximets wrote:
> On 7/6/21 3:34 PM, Van Haaren, Harry wrote:
> >> -Original Message-
> >> From: Ilya Maximets
> >> Sent: Thursday, July 1, 2021 11:32 AM
> >> To: Van Haaren, Harry ; Ilya Maximets
> >>
> >> Cc: Eli Britstein ; ovs dev
Hi,
On Tue, Jul 06, 2021 at 03:37:09PM -0700, Ben Pfaff wrote:
> The vswitchd database schema requires role names to be "master" or
> "slave", but this code tried to use "primary" and "secondary".
We have defined the constraints in the schema and we can't change
the schema because it would
Hello,
Please find my comments below.
On Thu, Jul 01, 2021 at 04:06:14PM +0100, Cian Ferriter wrote:
> From: Harry van Haaren
>
> This commit adds a new command to retrieve the list of available
> DPIF implementations. This can be used by to check what implementations
> of the DPIF are
t; rather than the number of vports.
> b) Ordering per-flow is maintained as packets are distributed to
> CPUs based on mechanisms such as RSS and flows are distributed
> to a single user space thread.
> c) Packets from a flow can only wake up one user space thread.
>
> Reported-at: ht
Hi,
Please see my comments below.
On Thu, Jul 01, 2021 at 04:06:13PM +0100, Cian Ferriter wrote:
> From: Harry van Haaren
>
> This commit adds a new command to allow the user to switch
> the active DPIF implementation at runtime. A probe function
> is executed before switching the DPIF
ed-off-by: Cian Ferriter
> Co-authored-by: Kumar Amber
> Signed-off-by: Kumar Amber
>
> ---
Thanks for addressing all the previous comments.
It seems that if we had used a emc_hit along with existing
smc_hit the code would be easier read, instead adding/removing
bitmasks
on based on ISA capabilities
> of the runtime CPU, leading to optimizations and higher performance.
>
> Signed-off-by: Harry van Haaren
> Co-authored-by: Cian Ferriter
> Signed-off-by: Cian Ferriter
>
> ---
Acked-by: Flavio Leitner
__
Hi,
After the refactoring and rebasing, this patch doesn't seem
necessary anymore. I don't see value in keeping it.
Can we drop it? What do you think?
fbl
On Thu, Jul 01, 2021 at 04:06:10PM +0100, Cian Ferriter wrote:
> From: Harry van Haaren
>
> This commit moves the datapath lookup
> One valid checkpatch issue with the use of the
> EMC_FOR_EACH_POS_WITH_HASH() macro was fixed.
>
> Signed-off-by: Harry van Haaren
> Co-authored-by: Cian Ferriter
> Signed-off-by: Cian Ferriter
>
> ---
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, Jul 06, 2021 at 04:20:59PM -0300, Flavio Leitner wrote:
>
> Hi,
>
> I was reviewing the patch while testing and I can consistently
> loss 1Mpps (or more) on a P2P scenario with this flow table:
> ovs-ofctl add-flow br0 in_port=dpdk0,actions=output:dpdk1
>
>
Hi,
I was reviewing the patch while testing and I can consistently
loss 1Mpps (or more) on a P2P scenario with this flow table:
ovs-ofctl add-flow br0 in_port=dpdk0,actions=output:dpdk1
TX: 14Mpps
RX without patch: +12.6Mpps
RX with patch: 11.67Mpps
CPU: Intel(R) Xeon(R) Silver 4114 CPU @
On Tue, Jul 06, 2021 at 03:27:41PM +0200, Adrian Moreno wrote:
>
>
> On 7/6/21 2:50 PM, Flavio Leitner wrote:
> > On Tue, Jul 06, 2021 at 08:25:59AM +0200, Adrian Moreno wrote:
> >>
> >>
> >> On 7/5/21 4:15 PM, Flavio Leitner wrote:
> >>>
&g
On Tue, Jul 06, 2021 at 08:25:59AM +0200, Adrian Moreno wrote:
>
>
> On 7/5/21 4:15 PM, Flavio Leitner wrote:
> >
> > Hi,
> >
> > On Wed, Jun 30, 2021 at 05:43:54PM +0200, Adrian Moreno wrote:
> >> The match keyword "igmp" is not supported i
Hi Mark,
David had some comments about the NEWS file, and I found an issue
on Windows below.
On Tue, Jul 06, 2021 at 05:31:11AM -0400, Mark Gray wrote:
> The Open vSwitch kernel module uses the upcall mechanism to send
> packets from kernel space to user space when it misses in the kernel
>
Hi Mark,
On Mon, Jul 05, 2021 at 09:38:37AM -0400, Mark Gray wrote:
> The Open vSwitch kernel module uses the upcall mechanism to send
> packets from kernel space to user space when it misses in the kernel
> space flow table. The upcall sends packets via a Netlink socket.
> Currently, a Netlink
ng user space code can be found at:
> https://mail.openvswitch.org/pipermail/ovs-dev/2021-April/382618.html
>
> Bugzilla: https://bugzilla.redhat.com/1844576
> Signed-off-by: Mark Gray
> ---
It looks good and works for me.
Acked-by: Flavio Leitner
Thanks Mark!
fbl
__
S will crash.
>
> Fixes: 73858f9db ("netdev-linux: Prepend the std packet in the TSO packet")
> Signed-off-by: Eelco Chaudron
> ---
Nice, thanks Eelco.
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
ised concerns about changing the output and break scripts in
the past. However, it seems not removing the keyword also cause
issues, so I am not opposing to remove the igmp keyword anymore.
Acked-by: Flavio Leitner
Thanks,
fbl
___
dev mailing list
d...@op
Hi,
Thanks for fixing this bug!
On Fri, Jul 02, 2021 at 10:22:36AM -0400, Eelco Chaudron wrote:
> When TSO is disabled from a userspace forwarding datapath perspective,
> but TSO has been wrongly enabled on the kernel side, log a warning
> message, and drop the packet. With the current
Hi Mark,
One more thing, this seems a relevant change to mention in the
NEWS file.
Thanks,
fbl
On Wed, Jun 30, 2021 at 05:56:11AM -0400, Mark Gray wrote:
> The Open vSwitch kernel module uses the upcall mechanism to send
> packets from kernel space to user space when it misses in the kernel
>
Hi Mark,
Thanks for addressing the comments. The patch looks good to me
and I plan to test it tomorrow.
fbl
On Wed, Jun 30, 2021 at 05:53:49AM -0400, Mark Gray wrote:
> The Open vSwitch kernel module uses the upcall mechanism to send
> packets from kernel space to user space when it misses in
Hi Mark,
I've not tested this yet.
See some comments below.
On Wed, Jun 30, 2021 at 05:56:11AM -0400, Mark Gray wrote:
> The Open vSwitch kernel module uses the upcall mechanism to send
> packets from kernel space to user space when it misses in the kernel
> space flow table. The upcall sends
On Wed, Jun 30, 2021 at 05:56:10AM -0400, Mark Gray wrote:
> Fixes: 1579cf677fcb ("dpif-linux: Implement the API functions to allow
> multiple handler threads read upcall.")
> Signed-off-by: Mark Gray
> ---
Acked-by: Flavio Lei
y
> ---
Acked-by: Flavio Leitner
Thanks Mark!
fbl
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Thu, Jul 01, 2021 at 12:12:18PM +, Van Haaren, Harry wrote:
> > -Original Message-
> > From: Flavio Leitner
> > Sent: Thursday, July 1, 2021 12:15 PM
> > To: Van Haaren, Harry
> > Cc: Amber, Kumar ; d...@openvswitch.org;
> > i.maxim...@ovn.o
On Wed, Jun 30, 2021 at 04:54:22PM +, Van Haaren, Harry wrote:
> > -Original Message-
> > From: Eelco Chaudron
> > Sent: Wednesday, June 30, 2021 3:35 PM
> > To: Van Haaren, Harry
> > Cc: Amber, Kumar ; d...@openvswitch.org;
> > i.maxim...@o
On Thu, Jul 01, 2021 at 10:55:55AM +, Van Haaren, Harry wrote:
> > -Original Message-
> > From: Amber, Kumar
> > Sent: Thursday, July 1, 2021 10:50 AM
> > To: Van Haaren, Harry
> > Cc: d...@openvswitch.org; i.maxim...@ovn.org; Flavio Leitner
> >
Hi,
On Thu, Jun 17, 2021 at 09:57:53PM +0530, Kumar Amber wrote:
> From: Harry van Haaren
>
> This commit adds 3 new traffic profile implementations to the
> existing avx512 miniflow extract infrastructure. The profiles added are:
> - Ether()/IP()/TCP()
> - Ether()/Dot1Q()/IP()/UDP()
> -
On Tue, Jun 29, 2021 at 10:19:41PM +0530, Kumar Amber wrote:
> From: Harry van Haaren
>
> This commit avoids many instances of "using subtable X for miniflow (x,y)"
> in the ovs-vswitchd log when using the DPCLS Autovalidator. This occurs
> when no specialized subtable is found, and the generic
On Tue, Jun 29, 2021 at 05:11:00PM +, Amber, Kumar wrote:
> Hi Eelco, Flavio,
>
> Pls find my replies Inline
>
> > -Original Message-
> > From: Flavio Leitner
> > Sent: Tuesday, June 29, 2021 7:51 PM
> > To: Eelco Chaudron
> > Cc
On Tue, Jun 29, 2021 at 04:32:05PM +, Van Haaren, Harry wrote:
> > -Original Message-
> > From: dev On Behalf Of Eelco Chaudron
> > Sent: Tuesday, June 29, 2021 1:38 PM
> > To: Amber, Kumar
> > Cc: d...@openvswitch.org; i.maxim...@ovn.org
> > Subject: Re: [ovs-dev] [v4 03/12]
Hi,
On Tue, Jun 29, 2021 at 03:20:36PM +, Amber, Kumar wrote:
> Hi Flavio,
>
> Replies inline.
>
> > >
> > > Guess the above needs to be atomic.
> > >
> > > Removed based on Flavio comments.
> >
> > I asked to initialize that using an API and Eelco is asking to set it
> > atomically.
> >
On Tue, Jun 29, 2021 at 03:50:22PM +0200, Eelco Chaudron wrote:
>
>
> On 28 Jun 2021, at 4:57, Flavio Leitner wrote:
>
> > Hi,
> >
> >
> > On Thu, Jun 17, 2021 at 09:57:49PM +0530, Kumar Amber wrote:
> >> Tests:
> >> 6: OVS-DPDK - MFEX
tch.org; i.maxim...@ovn.org; Stokes, Ian
> ; Flavio Leitner
> Subject: Re: [ovs-dev] [v4 02/12] dpif-netdev: Add auto validation function
> for miniflow extract
>
>
> On 17 Jun 2021, at 18:27, Kumar Amber wrote:
>
> This patch introduced the auto-validation function w
Hi,
On Thu, Jun 17, 2021 at 09:57:52PM +0530, Kumar Amber wrote:
> From: Harry van Haaren
>
> This commit adds AVX512 implementations of miniflow extract.
> By using the 64 bytes available in an AVX512 register, it is
> possible to convert a packet to a miniflow data-structure in
> a small
t; These instructions will be used in the CPU ISA optimized
> implementations of traffic profile aware miniflow extract.
>
> Signed-off-by: Harry van Haaren
> ---
Acked-by: Flavio Leitner
fbl
___
dev mailing list
d...@openvswitch.org
htt
On Thu, Jun 17, 2021 at 09:57:50PM +0530, Kumar Amber wrote:
> From: Harry van Haaren
>
> This commit adds a new counter to be displayed to the user when
> requesting datapath packet statistics. It counts the number of
> packets that are parsed and a miniflow built up from it by the
> optimized
Hi,
On Thu, Jun 17, 2021 at 09:57:49PM +0530, Kumar Amber wrote:
> Tests:
> 6: OVS-DPDK - MFEX Autovalidator
> 7: OVS-DPDK - MFEX Autovalidator Fuzzy
>
> Added a new directory to store the PCAP file used
> in the tests and a script to generate the fuzzy traffic
> type pcap to be used in
Hi,
On Thu, Jun 17, 2021 at 09:57:48PM +0530, Kumar Amber wrote:
> This commit introduces additonal command line paramter
Typos.
> for mfex study function. If user provides additional packet out
> it is used in study to compare minimum
Hi,
I think Ian covered all issues and I suspect this patch might
change a bit due to comments on previous patches.
fbl
On Thu, Jun 17, 2021 at 09:57:47PM +0530, Kumar Amber wrote:
> This commit adds a new command to allow the user to enable
> autovalidatior by default at build time thus
On Thu, Jun 17, 2021 at 09:57:46PM +0530, Kumar Amber wrote:
> This commit adds a section to the dpdk/bridge.rst netdev documentation,
> detailing the added miniflow functionality. The newly added commands are
> documented, and sample output is provided.
>
> The use of auto-validator and special
Hi,
On Thu, Jun 17, 2021 at 09:57:45PM +0530, Kumar Amber wrote:
> The study function runs all the available implementations
> of miniflow_extract and makes a choice whose hitmask has
> maximum hits and sets the mfex to that function.
>
> Study can be run at runtime using the following
Hi,
I haven't tested the patch set yet.
I left some comments in line.
On Thu, Jun 17, 2021 at 09:57:44PM +0530, Kumar Amber wrote:
> This patch introduced the auto-validation function which
> allows users to compare the batch of packets obtained from
> different miniflow implementations
Hi,
I am reviewing this patch ignoring the things that were
already pointed out in other reviews in the ML.
On Thu, Jun 17, 2021 at 09:57:43PM +0530, Kumar Amber wrote:
> This patch introduces the mfex function pointers which allows
> the user to switch between different miniflow extract
On Thu, Jun 24, 2021 at 12:52:49PM +, Van Haaren, Harry wrote:
> > On Thu, Jun 24, 2021 at 11:07:59AM +, Van Haaren, Harry wrote:
> > > > On Thu, Jun 17, 2021 at 05:18:25PM +0100, Cian Ferriter wrote:
> > > > > From: Harry van Haaren
>
> > > I do like the idea of toolchain supporting ISA
On Thu, Jun 24, 2021 at 11:53:34AM +, Ferriter, Cian wrote:
[...]
> > On Thu, Jun 17, 2021 at 05:18:18PM +0100, Cian Ferriter wrote:
> > > +
> > > +VLOG_DEFINE_THIS_MODULE(dpif_netdev_impl);
> > > +
> > > +/* Actual list of implementations goes here. */
> > > +static struct
Hi Harry,
On Thu, Jun 24, 2021 at 11:07:59AM +, Van Haaren, Harry wrote:
> > -Original Message-
> > From: dev On Behalf Of Flavio Leitner
> > Sent: Thursday, June 24, 2021 4:57 AM
> > To: Ferriter, Cian
> > Cc: ovs-dev@openvswitch.org; i.maxim...@ovn
On Thu, Jun 17, 2021 at 05:18:17PM +0100, Cian Ferriter wrote:
> From: Harry van Haaren
>
> This commit adds the AVX512 implementation of DPIF functionality,
> specifically the dp_netdev_input_outer_avx512 function. This function
> only handles outer (no re-circulations), and is optimized to use
opcount to calculate the miniflow block indexes.
>
> Signed-off-by: Harry van Haaren
>
> ---
Acked-by: Flavio Leitner
This patch series implements low level optimizations by manually
coding instructions. I wonder if gcc couldn't get some relevant
level of vectorized optimization
ic variables.
Anyways, 2 or 3 CPU flags make no relevant difference now.
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
e has been checked to
> ensure the 16 block code paths are executing.
>
> Signed-off-by: Harry van Haaren
>
> ---
The changes look good to me. I also introduced errors on the
first 8 blocks and on the second 8 blocks and both caused the
autovalidation to fail.
Acked-by: Flavio Leitner
_
On Thu, Jun 17, 2021 at 05:18:21PM +0100, Cian Ferriter wrote:
> Signed-off-by: Cian Ferriter
>
> ---
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
> ---
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
> Signed-off-by: Harry van Haaren
>
> ---
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Thu, Jun 17, 2021 at 05:18:19PM +0100, Cian Ferriter wrote:
> From: Harry van Haaren
>
> This commit adds a new command to retrieve the list of available
> DPIF implementations. This can be used by to check what implementations
> of the DPIF are available in any given OVS binary.
>
> Usage:
On Thu, Jun 17, 2021 at 05:18:18PM +0100, Cian Ferriter wrote:
> From: Harry van Haaren
>
> This commit adds a new command to allow the user to switch
> the active DPIF implementation at runtime. A probe function
> is executed before switching the DPIF implementation, to ensure
> the CPU is
On Tue, Jun 22, 2021 at 03:42:46PM +, Stokes, Ian wrote:
> > Hi Flavio,
> >
> > Thanks for the review. My responses are inline.
> >
> > Cian
> >
> > > -Original Message-
> > > From: Flavio Leitner
> > > Sent: Monday
,
fbl
On Tue, Jun 22, 2021 at 11:10:32AM +, Van Haaren, Harry wrote:
> > -Original Message-
> > From: dev On Behalf Of Flavio Leitner
> > Sent: Monday, June 21, 2021 5:39 PM
> > To: Ferriter, Cian
> > Cc: ovs-dev@openvswitch.org; Amber, Kumar ;
> >
Hi,
This commit could be submitted outside of this patch-set as fix
for commit 9ff7cabfd7 ("dpif-netdev: add subtable-lookup-prio-get
command") and commit 3d018c3ea79d ("dpif-netdev: add subtable lookup
prio set command.").
This helps to get it merged sooner and reduce this patch-set size.
On Mon, Jun 21, 2021 at 04:13:12PM +, Ferriter, Cian wrote:
> Hi Flavio,
>
> Thanks for the review. My responses are inline.
>
> Cian
>
> > -Original Message-
> > From: Flavio Leitner
> > Sent: Sunday 20 June 2021 21:09
> > To: Ferriter, Ci
Hi,
I am still reviewing the patch, but I thought worth to discuss
few items below.
On Thu, Jun 17, 2021 at 05:18:17PM +0100, Cian Ferriter wrote:
> From: Harry van Haaren
>
> This commit adds the AVX512 implementation of DPIF functionality,
> specifically the dp_netdev_input_outer_avx512
Hello,
On Thu, Jun 17, 2021 at 05:18:16PM +0100, Cian Ferriter wrote:
> From: Harry van Haaren
>
> This commit adds a function pointer to the pmd thread data structure,
> giving the pmd thread flexibility in its dpif-input function choice.
> This allows choosing of the implementation based on
Hello,
I have some comments inline.
On Thu, Jun 17, 2021 at 05:18:15PM +0100, Cian Ferriter wrote:
> From: Harry van Haaren
>
> This commit moves the datapath lookup functions required for
> hardware offload to a seperate file. This allows other DPIF
Hello,
Some comments below.
On Thu, Jun 17, 2021 at 05:18:14PM +0100, Cian Ferriter wrote:
> From: Harry van Haaren
>
> Split the very large file dpif-netdev.c and the datastructures
> it contains into multiple header files. Each header file is
> responsible for the datastructures of that
Hi Mark,
This looks good to me.
Since the new scheme doesn't allow users to change the number
of handlers, we must update ovs-vswitchd.conf.db(5) as well.
Some comments below.
On Fri, Apr 30, 2021 at 11:31:29AM -0400, Mark Gray wrote:
> The Open vSwitch kernel module uses the upcall
On Fri, Apr 30, 2021 at 11:31:27AM -0400, Mark Gray wrote:
> 'n_handlers' and 'n_revalidators' are declared as type 'size_t'.
> However, dpif_handlers_set() requires parameter 'n_handlers' as
> type 'uint32_t'. This patch fixes this type mismatch.
The change looks good, but I didn't understand
On Fri, Apr 30, 2021 at 11:31:28AM -0400, Mark Gray wrote:
> Signed-off-by: Mark Gray
This looks like a bug fix for this commit:
1579cf677fcb dpif-linux: Implement the API functions to allow multiple ...
If you agree, please add the Fixes: tag.
fbl
> ---
> lib/dpif-netlink.c | 4 ++--
> 1
Hi Mark,
I think this patch is going in the right direction but there
are some points that I think we should address. See below.
On Fri, Apr 30, 2021 at 11:33:25AM -0400, Mark Gray wrote:
> The Open vSwitch kernel module uses the upcall mechanism to send
> packets from kernel space to user
On Wed, May 19, 2021 at 01:22:58PM -0700, Ben Pfaff wrote:
> On Wed, May 19, 2021 at 10:03:57PM +0200, Ilya Maximets wrote:
> > Hi.
> >
> > Taking into account some very unhealthy things that happened recently
> > with FreeNode network and resigning of lots of its stuff [1], we
> > probably need
Hi,
On Fri, Apr 30, 2021 at 11:31:26AM -0400, Mark Gray wrote:
> This series proposes a new method of distributing upcalls
> to user space threads attempting to resolve a number of
> issues with the current method.
>
I ran some tests with old V10, current master and this RFC
including the
r 0.0/sec 0.000/sec 0.0011/sec total:
4
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Thu, Apr 15, 2021 at 01:32:06PM +0200, Eelco Chaudron wrote:
>
>
> On 15 Apr 2021, at 13:12, Flavio Leitner wrote:
>
> > Hi Eelco,
> >
> > On Thu, Apr 15, 2021 at 10:07:24AM +0200, Eelco Chaudron wrote:
> > >
> > >
>
Hi Eelco,
On Thu, Apr 15, 2021 at 10:07:24AM +0200, Eelco Chaudron wrote:
>
>
> On 14 Apr 2021, at 17:50, David Marchand wrote:
>
> > Skipping further processing of invalid IP packets helps avoid crashes
> > but it does not help to figure out if the malformed packets are still
> > present on
ded) but will
> cause the "right" side to succeed to establish a connection as all
> connections will have been loaded on the "left" side.
>
> Reported-at:
> https://mail.openvswitch.org/pipermail/ovs-dev/2021-April/381857.html
> Fixes: 8fc62df8b
101 - 200 of 1013 matches
Mail list logo
