Re: [ovs-dev] [PATCH] ipsec: Fix race in system tests

2021-04-13 Thread Flavio Leitner
ded) but will > cause the "right" side to succeed to establish a connection as all > connections will have been loaded on the "left" side. > > Reported-at: > https://mail.openvswitch.org/pipermail/ovs-dev/2021-April/381857.html > Fixes: 8fc62df8b

Re: [ovs-dev] [PATCH v3 0/5] ipsec: Fix IPv6 support

2021-04-06 Thread Flavio Leitner
On Tue, Apr 06, 2021 at 02:53:34PM +0100, Mark Gray wrote: > On 06/04/2021 13:59, Flavio Leitner wrote: > > On Tue, Apr 06, 2021 at 12:30:42PM +0100, Mark Gray wrote: > >> On 05/04/2021 20:56, Flavio Leitner wrote: > >>> On Thu, Apr 01, 2021 at 07:48:19PM +0100, Ma

Re: [ovs-dev] [PATCH v3 0/5] ipsec: Fix IPv6 support

2021-04-06 Thread Flavio Leitner
On Tue, Apr 06, 2021 at 12:30:42PM +0100, Mark Gray wrote: > On 05/04/2021 20:56, Flavio Leitner wrote: > > On Thu, Apr 01, 2021 at 07:48:19PM +0100, Mark Gray wrote: > >> On 01/04/2021 19:29, Ilya Maximets wrote: > >>> On 4/1/21 3:58 PM, Mark Gray wrote: > >&g

Re: [ovs-dev] [PATCH v3 0/5] ipsec: Fix IPv6 support

2021-04-05 Thread Flavio Leitner
On Thu, Apr 01, 2021 at 07:48:19PM +0100, Mark Gray wrote: > On 01/04/2021 19:29, Ilya Maximets wrote: > > On 4/1/21 3:58 PM, Mark Gray wrote: > >> This series fixes IPv6 support for Libreswan and introduces > >> IPsec system tests for Libreswan. > >> > >> Mark Gray (5): > >> ipsec: IPv6 default

Re: [ovs-dev] [PATCH v2 3/5] ipsec: IPv6 default route support for Libreswan

2021-03-31 Thread Flavio Leitner
t; still interprets '%defaultroute' as the IPv4 address on the > default gateway interface (see: > https://github.com/libreswan/libreswan/issues/416) giving > an "address family inconsistency" error. > > This patch resolves this issue by speci

Re: [ovs-dev] [PATCH v2 4/5] ipsec: Introduce IPsec system tests for Libreswan

2021-03-31 Thread Flavio Leitner
On Wed, Mar 31, 2021 at 04:05:08AM -0400, Mark Gray wrote: > This patch adds system tests for OVS IPsec using Libreswan. > If Libreswan is not present on the system, the tests will > be skipped. > > These tests set up an underlay switch with bridge 'br0' > to carry encrypted traffic between two em

Re: [ovs-dev] [PATCH v2 5/5] ipsec: Update ordering of imports

2021-03-31 Thread Flavio Leitner
On Wed, Mar 31, 2021 at 04:05:09AM -0400, Mark Gray wrote: > Signed-off-by: Mark Gray > --- Acked-by: Flavio Leitner ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2 2/5] ipsec: Allow custom file locations

2021-03-31 Thread Flavio Leitner
nables system testing for > OVS IPsec. > > Signed-off-by: Mark Gray > --- Acked-by: Flavio Leitner ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2 1/5] system-common-macros: clean up veth device on test failure

2021-03-31 Thread Flavio Leitner
On Wed, Mar 31, 2021 at 04:05:05AM -0400, Mark Gray wrote: > 'on_exit' should be run directly after creation > of veth device. > > Fixes: 119db2cb18a7 ("kmod-macros: Move some code to traffic-common-macros.") > Signed-off-by: Mark Gray > Acked-by: Eelco Cha

Re: [ovs-dev] [PATCH] openvswitch: perform refragmentation for packets which pass through conntrack

2021-03-23 Thread Flavio Leitner
Hi, On Fri, Mar 19, 2021 at 04:43:07PM -0400, Aaron Conole wrote: > When a user instructs a flow pipeline to perform connection tracking, > there is an implicit L3 operation that occurs - namely the IP fragments > are reassembled and then processed as a single unit. After this, new > fragments

Re: [ovs-dev] [PATCH v2] dpif-netdev: Allow PMD auto load balance with cross-numa.

2021-03-17 Thread Flavio Leitner
e there is only one numa with pmds available, the > same numa will always poll before and after reassignment, so estimates > are valid. Allow PMD auto load balance to trigger a reassignment in > this case. > > Signed-off-by: Kevin Traynor > Acked-by: Eelco Chaudron >

Re: [ovs-dev] [PATCH v3 1/2] dpctl: dpif: add kernel datapath cache hit output

2021-03-03 Thread Flavio Leitner
on. */ > + __u64 n_cache_hit; /* Number of cache matches for flow lookups. */ another nit: the datapath uses tab + spaces. Otherwise: Acked-by: Flavio Leitner Thanks fbl > __u64 pad1; /* Pad for future expension. */ > - __u64 pad2; /* Pa

Re: [ovs-dev] [PATCH v3 2/2] dpctl: dpif: allow viewing and configuring dp cache sizes

2021-03-03 Thread Flavio Leitner
precision as before. The API doesn't say anything about cache 'name' pointer ownership most probably because it is hardcoded to a single name. I think it's fine for now but in the future we might need to change that using xstrdup() and let the caller calls free(). Thanks for in

Re: [ovs-dev] [PATCH 2/2] dpctl: dpif: allow viewing and configuring dp cache sizes

2021-03-01 Thread Flavio Leitner
On Wed, Sep 02, 2020 at 12:12:44PM +0200, Eelco Chaudron wrote: > This patch adds a general way of viewing/configuring datapath > cache sizes. With an implementation for the netlink interface. I see you added support to multiple cache levels. Does that mean we can use to set sizes of EMC and SMC?

Re: [ovs-dev] [PATCH 1/2] dpctl: dpif: add kernel datapath cache hit output

2021-03-01 Thread Flavio Leitner
Hi Eelco, Thanks for the patch. I added few comments in line below. On Wed, Sep 02, 2020 at 12:12:36PM +0200, Eelco Chaudron wrote: > This patch adds cache usage statistics to the output: > > $ ovs-dpctl show >

Re: [ovs-dev] [PATCH] conntrack: Add a test for IPv4 UDP zero checksum

2021-02-10 Thread Flavio Leitner
On Wed, Feb 10, 2021 at 02:45:06PM -0500, Aaron Conole wrote: > Flavio Leitner writes: > > > On Wed, Feb 10, 2021 at 11:49:33AM -0500, Aaron Conole wrote: > >> Recently, during some conntrack testing a bug was uncovered in a DPDK > >> PMD, which doesn't

Re: [ovs-dev] [PATCH] conntrack: Add a test for IPv4 UDP zero checksum

2021-02-10 Thread Flavio Leitner
On Wed, Feb 10, 2021 at 11:49:33AM -0500, Aaron Conole wrote: > Recently, during some conntrack testing a bug was uncovered in a DPDK > PMD, which doesn't support an IPv4 packet with a zero checksum value. > In order to show that the connection tracking code in userspace > supports IPv4 UDP with a

Re: [ovs-dev] [PATCH] cirrus: Use FreeBSD 12.2.

2021-02-10 Thread Flavio Leitner
On Wed, Feb 10, 2021 at 01:09:27PM -0300, Flavio Leitner wrote: > On Wed, Feb 10, 2021 at 05:02:44PM +0100, Ilya Maximets wrote: > > FreeBSD 12.1 reached EOL and our builds are failing on Cirrus CI. > > Updating to 12.2 - current production release. > > > > S

Re: [ovs-dev] [PATCH] cirrus: Use FreeBSD 12.2.

2021-02-10 Thread Flavio Leitner
h looks perfect. Acked-by: Flavio Leitner ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-2.14 0/2] Release patches for v2.14.2.

2021-02-10 Thread Flavio Leitner
insertions(+), 3 deletions(-) > > -- > 2.26.2 > > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev To the set: Acked-by: Flavio Leitner fbl

Re: [ovs-dev] [PATCH branch-2.13 0/2] Release patches for v2.13.3.

2021-02-10 Thread Flavio Leitner
insertions(+), 3 deletions(-) > > -- > 2.26.2 > > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev To the set: Acked-by: Flavio Leitner

Re: [ovs-dev] [PATCH branch-2.12 0/2] Release patches for v2.12.3.

2021-02-10 Thread Flavio Leitner
insertions(+), 3 deletions(-) > > -- > 2.26.2 > > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev To the set: Acked-by: Flavio Leitner

Re: [ovs-dev] [PATCH branch-2.11 0/2] Release patches for v2.11.6.

2021-02-10 Thread Flavio Leitner
insertions(+), 3 deletions(-) > > -- > 2.26.2 > > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev To the set: Acked-by: Flavio Leitner

Re: [ovs-dev] [PATCH branch-2.10 0/2] Release patches for v2.10.7.

2021-02-10 Thread Flavio Leitner
insertions(+), 3 deletions(-) > > -- > 2.26.2 > > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev To the set: Acked-by: Flavio Leitner

Re: [ovs-dev] [PATCH branch-2.9 0/2] Release patches for v2.9.9.

2021-02-10 Thread Flavio Leitner
insertions(+), 3 deletions(-) > > -- > 2.26.2 > > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev To the set: Acked-by: Flavio Leitner

Re: [ovs-dev] [PATCH branch-2.8 0/2] Release patches for v2.8.11.

2021-02-10 Thread Flavio Leitner
insertions(+), 3 deletions(-) > > -- > 2.26.2 > > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev To the set: Acked-by: Flavio Leitner

Re: [ovs-dev] [PATCH branch-2.7 0/2] Release patches for v2.7.13.

2021-02-10 Thread Flavio Leitner
insertions(+), 3 deletions(-) > > -- > 2.26.2 > > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev To the set: Acked-by: Flavio Leitner

Re: [ovs-dev] [PATCH branch-2.6 0/2] Release patches for v2.6.10.

2021-02-10 Thread Flavio Leitner
insertions(+), 3 deletions(-) > > -- > 2.26.2 > > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev To set Acked-by: Flavio Leitner

Re: [ovs-dev] [PATCH branch-2.5 0/2] Release patches for v2.5.12.

2021-02-10 Thread Flavio Leitner
insertions(+), 3 deletions(-) > > -- > 2.26.2 > > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev To the set Acked-by: Flavio Leitner

Re: [ovs-dev] [PATCH v4] Enable VXLAN TSO for DPDK datapath

2021-02-04 Thread Flavio Leitner
Hi Yi, Again, sorry the delay to review the patch. The patch is using the outer length fields from DPDK which seems to be a problem in OVS because most of the packet transformation functions are not aware of that. Therefore, after the packet gets encapsulated most of existing functions will s

Re: [ovs-dev] [PATCH v6 0/4] Add PMD auto load balance parameters.

2021-02-02 Thread Flavio Leitner
Hi, On Mon, Feb 01, 2021 at 03:46:16PM +, Kevin Traynor wrote: > On 01/02/2021 15:41, Kevin Traynor wrote: > > On 21/12/2020 13:10, Kevin Traynor wrote: > >> v6: > >> - Split patches to add log to existing interval param as a seperate fix > >> first > >> - Fix reference in vswitchd.xml > >>

Re: [ovs-dev] [PATCH 0/2] Patches to branch for 2.15.

2021-01-15 Thread Flavio Leitner
On Fri, Jan 15, 2021 at 09:34:18PM +0100, Ilya Maximets wrote: > On 1/15/21 8:25 PM, Ilya Maximets wrote: > > Ilya Maximets (2): > > Prepare for 2.15.0. > > Prepare for post-2.15.0 (2.15.90). > > > > NEWS | 6 +- > > configure.ac | 2 +- > > debian/changelog | 10 +++

Re: [ovs-dev] [PATCH 0/2] Patches to branch for 2.15.

2021-01-15 Thread Flavio Leitner
sertions(+), 4 deletions(-) > > -- > 2.25.4 > To the set Acked-by: Flavio Leitner ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Refactor the DPDK transmit path.

2021-01-13 Thread Flavio Leitner
Hi Marko, On Wed, Jan 13, 2021 at 10:51:03AM +, Kovacevic, Marko wrote: > Hi Flavio, > > > So, I see a small performance gain. Can you provide a more detailed > > test description? I wonder if we are testing the same thing. > > VSPERF phy2phy_tput uses 2 dpdk pmds and performs zero packet

Re: [ovs-dev] [PATCH branch-2.12 0/2] Release patches for v2.12.2.

2021-01-13 Thread Flavio Leitner
insertions(+), 3 deletions(-) > > -- > 2.27.0 > To the set: Acked-by: Flavio Leitner ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-2.13 0/2] Release patches for v2.13.2.

2021-01-13 Thread Flavio Leitner
insertions(+), 3 deletions(-) > > -- > 2.27.0 > Looks like to be applied, still... To the set: Acked-by: Flavio Leitner ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-2.11 0/2] Release patches for v2.11.5.

2021-01-13 Thread Flavio Leitner
insertions(+), 3 deletions(-) > > -- > 2.27.0 > To the set: Acked-by: Flavio Leitner ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-2.10 0/2] Release patches for v2.10.6.

2021-01-13 Thread Flavio Leitner
insertions(+), 3 deletions(-) > > -- > 2.27.0 > To the set: Acked-by: Flavio Leitner ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-2.9 0/2] Release patches for v2.9.8.

2021-01-13 Thread Flavio Leitner
insertions(+), 3 deletions(-) > > -- > 2.27.0 > To the set: Acked-by: Flavio Leitner ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-2.8 0/2] Release patches for v2.8.10.

2021-01-13 Thread Flavio Leitner
insertions(+), 3 deletions(-) > > -- > 2.27.0 > To the set: Acked-by: Flavio Leitner ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-2.6 0/2] Release patches for v2.6.9.

2021-01-13 Thread Flavio Leitner
insertions(+), 3 deletions(-) > > -- > 2.27.0 > To the set Acked-by: Flavio Leitner ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-2.5 0/2] Release patches for v2.5.11.

2021-01-13 Thread Flavio Leitner
insertions(+), 3 deletions(-) > > -- > 2.27.0 > To the set Acked-by: Flavio Leitner ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-2.7 0/2] Release patches for v2.7.12.

2021-01-13 Thread Flavio Leitner
insertions(+), 3 deletions(-) > > -- > 2.27.0 > To the set Acked-by: Flavio Leitner ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-2.14 0/2] Release patches for v2.14.1.

2021-01-13 Thread Flavio Leitner
insertions(+), 3 deletions(-) > > -- > 2.27.0 > Looks like it is applied already, but anyways: Acked-by: Flavio Leitner ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH net-next] net: openvswitch: add log message for error case

2021-01-13 Thread Flavio Leitner
dler() function. > > Reported-by: Flavio Leitner > Signed-off-by: Eelco Chaudron > --- Acked-by: Flavio Leitner ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH V5 2/2] acinclude: Warn when --with-linux parameter is supplied

2021-01-12 Thread Flavio Leitner
On Tue, Jan 12, 2021 at 11:15:30AM -0800, Greg Rose wrote: > Building the Linux kernel driver from the Open vSwitch source tree > is deprecated. Emit a warning when the '--with-linux' configure > parameter is supplied to remind the user. > > Signed-off-by: Greg Rose &

Re: [ovs-dev] [PATCH V5 1/2] doc: Deprecate building Linux kernel module from OVS source tree

2021-01-12 Thread Flavio Leitner
cember/378831.html > > Signed-off-by: Greg Rose > --- Acked-by: Flavio Leitner ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH V4 2/2] acinclude: Warn when --with-linux parameter is supplied

2021-01-11 Thread Flavio Leitner
On Mon, Jan 11, 2021 at 12:26:50PM -0800, Greg Rose wrote: > The Linux Out of Tree kernel driver is deprecated. Emit a warning > when the '--with-linux' configure parameter is supplied to remind > the user. Same here, I suggest to rephrase the out of tree above as well. fbl > > Signed-off-by:

Re: [ovs-dev] [PATCH V4 1/2] doc: Deprecate the Linux Out of Tree module

2021-01-11 Thread Flavio Leitner
On Mon, Jan 11, 2021 at 12:26:49PM -0800, Greg Rose wrote: > It is decided (1) to deprecate the Linux Out of Tree (OOT) module. > Update the NEWS and FAQ to provide notice. I suggest to rephrase the out of tree above as well. fbl > > 1. https://mail.openvswitch.org/pipermail/ovs-dev/2020-Decemb

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Refactor the DPDK transmit path.

2021-01-11 Thread Flavio Leitner
Hi Sunil, On Mon, Jan 11, 2021 at 03:49:56PM +, Pai G, Sunil wrote: > Hi Flavio, > > > > -Original Message- > > From: dev On Behalf Of Flavio Leitner > > Sent: Sunday, January 10, 2021 8:35 AM > > To: d...@openvswitch.org > > Cc: David Mar

Re: [ovs-dev] [PATCH] Documentation: Simplify the website main page.

2021-01-09 Thread Flavio Leitner
On Thu, Jan 07, 2021 at 12:15:10PM -0800, Ben Pfaff wrote: > On Mon, Dec 28, 2020 at 07:02:55PM -0300, Flavio Leitner wrote: > > The initial website page is difficult to read because of > > the large amount of links from different parts of the whole > > documentation. Most of

[ovs-dev] [PATCH v2] netdev-dpdk: Refactor the DPDK transmit path.

2021-01-09 Thread Flavio Leitner
leaving only the dpdk transmit code under the txq lock. Signed-off-by: Flavio Leitner --- V2: - mentioned the tx lock change in the commit message. - fixed packet leak when copy fails. - moved pkt_cnt = cnt two lines up. I tested the following scenarios with iperf and iperf -R and noticed

Re: [ovs-dev] [PATCH] netdev-dpdk: Refactor the DPDK transmit path.

2021-01-09 Thread Flavio Leitner
On Wed, Jan 06, 2021 at 04:13:14PM +0100, David Marchand wrote: > On Thu, Dec 3, 2020 at 6:50 PM Flavio Leitner wrote: > > > > This patch split out the common code between vhost and dpdk transmit > > paths to shared functions to simplify the code and fix an issue. >

Re: [ovs-dev] [PATCH v3 2/4] ovs-ctl: Use 'stop_daemon' to stop ovs-monitor-ipsec

2021-01-04 Thread Flavio Leitner
On Mon, Jan 04, 2021 at 03:45:19AM -0500, Mark Gray wrote: > Signed-off-by: Mark Gray > Acked-by: Eelco Chaudron > --- Acked-by: Flavio Leitner Thanks, fbl ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/lis

[ovs-dev] [PATCH] Documentation: Simplify the website main page.

2020-12-28 Thread Flavio Leitner
new links might not get included. This patch simplifies the main page by highlighting the project level documentation. The static part is reduced to the main level index pages. All the links are available by clicking on 'Full Table of Contents' at the end of Documentation section. Signed-of

Re: [ovs-dev] [PATCH] security.rst: Add more information about the Downstream mailing list.

2020-12-24 Thread Flavio Leitner
On Thu, Dec 24, 2020 at 10:58:08AM -0800, Justin Pettit wrote: > Signed-off-by: Justin Pettit > --- LGTM Acked-by: Flavio Leitner fbl ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2] ovs-monitor-ipsec: set correct 'leftcert' and 'rightcert' name

2020-12-24 Thread Flavio Leitner
dhat.com/show_bug.cgi?id=1906280 > Signed-off-by: Mark Gray > Acked-by: Eelco Chaudron > --- Acked-by: Flavio Leitner ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2] ovs-monitor-ipsec: Add support for tunnel 'local_ip'

2020-12-24 Thread Flavio Leitner
ip' option is not present, it > will default to the previous behaviour of using '%defaultroute' > > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1906280 > Signed-off-by: Mark Gray > Acked-by: Eelco Chaudron > --- Acked-by: Flavio Leitner __

Re: [ovs-dev] [PATCH v2 4/4] ovs-monitor-ipsec: Add option to not restart IKE daemon

2020-12-24 Thread Flavio Leitner
On Thu, Dec 24, 2020 at 04:38:58AM -0500, Mark Gray wrote: > Signed-off-by: Mark Gray > Acked-by: Eelco Chaudron > --- Acked-by: Flavio Leitner ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2 3/4] ovs-monitor-ipsec: Allow exit of ipsec daemon maintaining state

2020-12-24 Thread Flavio Leitner
ity is maintained. One example of this is during an > upgrade. This will require the caller to clear this persistent > state when appropriate (e.g. before 'ovs-monitor-ipsec') is restarted. > > Signed-off-by: Mark Gray > Acked-by: Eelco Chaudron >

Re: [ovs-dev] [PATCH v2 2/4] ovs-ctl: Check for ovs-monitor-ipsec pidfile before exit

2020-12-24 Thread Flavio Leitner
On Thu, Dec 24, 2020 at 04:38:56AM -0500, Mark Gray wrote: > Check for pidfile before attempting 'exit'. If pidfile does > not exist, we cannot cleanly exit so kill process. Hi Mark, It looks like the commit message needs update, otherwise the patch looks okay to me. fbl > > Signed-off-by: Ma

Re: [ovs-dev] [PATCH v2] ovs-monitor-ipsec: Fix _nss_clear_database() parse error

2020-12-23 Thread Flavio Leitner
be bytes or a tuple of bytes, not str" > > Modify subprocess.Popen() to write in 'text' mode so that > 'startwith' can correctly parse output. > > Signed-off-by: Mark Gray > --- Acked-by: Flavio Leitner

Re: [ovs-dev] [PATCH] ovs-monitor-ipsec: Suppress "unknown %d argument" warning

2020-12-23 Thread Flavio Leitner
On Mon, Dec 21, 2020 at 08:12:33AM -0500, Mark Gray wrote: > As 'ovs-vswitchd' does not understand IPsec tunnel options, it > gives a warning message. This can be safely suppressed. > > Signed-off-by: Mark Gray > --- Acked-by: Flavio Leitner __

Re: [ovs-dev] [PATCH 3/4] ovs-monitor-ipsec: Allow exit of ipsec daemon maintaining state

2020-12-23 Thread Flavio Leitner
On Wed, Dec 16, 2020 at 07:04:34AM -0500, Mark Gray wrote: > When 'ovs-monitor-ipsec' exits, it clears all persistent state (i.e. > active ipsec connections, /etc/ipsec.conf, certs/keys). In some > use-cases, we may want to exit and maintain state so that ipsec > connectivity is maintained. One exa

Re: [ovs-dev] [PATCH 2/4] ovs-ctl: Check for ovs-monitor-ipsec pidfile before exit

2020-12-23 Thread Flavio Leitner
On Wed, Dec 16, 2020 at 07:04:33AM -0500, Mark Gray wrote: > Check for pidfile before attempting 'exit'. If pidfile does > not exist, we cannot cleanly exit so kill process. > > Signed-off-by: Mark Gray > --- > utilities/ovs-ctl.in | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) >

Re: [ovs-dev] [PATCH 1/4] ovs-monitor-ipsec: Fix active connection regex

2020-12-23 Thread Flavio Leitner
ways this could be resolved including > a cleverer regular expression, or re.findall(). However, this > approach was taken as it simplifies the code easing maintainability. > > Signed-off-by: Mark Gray > --- Acked-by: Flavio Leitner ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2] odp-util: Fix netlink message overflow with userdata.

2020-12-21 Thread Flavio Leitner
Credit to OSS-Fuzz. > > Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=27640 > Fixes: e995e3df57ea ("Allow OVS_USERSPACE_ATTR_USERDATA to be variable > length.") > Signed-off-by: Ilya Maximets > --- Acked-by: Flavio Leitner Thanks! fbl _

Re: [ovs-dev] [PATCH v6 0/4] Add PMD auto load balance parameters.

2020-12-21 Thread Flavio Leitner
-- > 4 files changed, 85 insertions(+), 15 deletions(-) > > -- > 2.26.2 > To the set: Acked-by: Flavio Leitner Thanks Kevin, fbl ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] odp-util: Fix netlink message overflow with userdata.

2020-12-18 Thread Flavio Leitner
On Fri, Dec 18, 2020 at 11:33:53PM +0100, Ilya Maximets wrote: > On 12/18/20 9:46 PM, Flavio Leitner wrote: > > On Fri, Dec 18, 2020 at 06:49:30PM +0100, Ilya Maximets wrote: > >> On 12/17/20 6:53 PM, Flavio Leitner wrote: > >>> On Thu, Dec 17, 2020 at 01:00:5

Re: [ovs-dev] [PATCH v5 2/3] dpif-netdev: Add more logs to PMD auto load balance parameters.

2020-12-18 Thread Flavio Leitner
On Fri, Dec 18, 2020 at 11:18:27PM +, Kevin Traynor wrote: > On 18/12/2020 21:54, Flavio Leitner wrote: > > On Fri, Dec 18, 2020 at 05:51:51PM +, Kevin Traynor wrote: > >> Previously if PMD auto load balance was disabled, updates to > >> parameters did not get lo

Re: [ovs-dev] [PATCH v5 1/3] dpif-netdev: Add parameters to configure PMD auto load balance.

2020-12-18 Thread Flavio Leitner
On Fri, Dec 18, 2020 at 06:48:12PM -0300, Flavio Leitner wrote: > On Fri, Dec 18, 2020 at 05:51:50PM +, Kevin Traynor wrote: > > From: Christophe Fontaine > > > > Two important parts of how PMD auto load balance operates is how > > loaded a core needs to be

Re: [ovs-dev] [PATCH v5 2/3] dpif-netdev: Add more logs to PMD auto load balance parameters.

2020-12-18 Thread Flavio Leitner
On Fri, Dec 18, 2020 at 05:51:51PM +, Kevin Traynor wrote: > Previously if PMD auto load balance was disabled, updates to > parameters did not get logged. > > Add logs so that if there are any changes to the parameters, > the change is shown as well as the current enabled/disabled > state of P

Re: [ovs-dev] [PATCH v5 1/3] dpif-netdev: Add parameters to configure PMD auto load balance.

2020-12-18 Thread Flavio Leitner
On Fri, Dec 18, 2020 at 05:51:50PM +, Kevin Traynor wrote: > From: Christophe Fontaine > > Two important parts of how PMD auto load balance operates is how > loaded a core needs to be and how much improvement is estimated > before a PMD auto load balance can trigger. > > Previously they were

Re: [ovs-dev] [PATCH v2] NEWS: Move '--offload-stats' entry to correct release.

2020-12-18 Thread Flavio Leitner
On Fri, Dec 18, 2020 at 06:16:14PM +0100, Ilya Maximets wrote: > Patch landed to 2.13, not 2.12. > > Fixes: 164413156cf9 ("Add offload packets statistics") > Signed-off-by: Ilya Maximets > --- Thanks! Acked-by: Flavio Leitner _

Re: [ovs-dev] [PATCH] odp-util: Fix netlink message overflow with userdata.

2020-12-18 Thread Flavio Leitner
On Fri, Dec 18, 2020 at 06:49:30PM +0100, Ilya Maximets wrote: > On 12/17/20 6:53 PM, Flavio Leitner wrote: > > On Thu, Dec 17, 2020 at 01:00:56PM +0100, Ilya Maximets wrote: > >> On 11/23/20 3:12 PM, Ilya Maximets wrote: > >>> Too big userdata could overflow net

Re: [ovs-dev] [PATCH] test-stream: Silence memory leak report.

2020-12-17 Thread Flavio Leitner
. > > Signed-off-by: Ilya Maximets > --- Acked-by: Flavio Leitner ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] odp-util: Fix netlink message overflow with userdata.

2020-12-17 Thread Flavio Leitner
On Thu, Dec 17, 2020 at 01:00:56PM +0100, Ilya Maximets wrote: > On 11/23/20 3:12 PM, Ilya Maximets wrote: > > Too big userdata could overflow netlink message leading to out-of-bound > > memory accesses or assertion while formatting nested actions. > > > > Fix that by checking the saize and return

Re: [ovs-dev] [PATCH] ofp-parse: Support "igmp" keyword in flows.

2020-12-16 Thread Flavio Leitner
On Wed, Nov 04, 2020 at 05:33:27PM +0100, Ilya Maximets wrote: > On 11/3/20 5:46 PM, Ben Pfaff wrote: > > On Tue, Nov 03, 2020 at 03:53:51AM +0100, Ilya Maximets wrote: > >> On 11/3/20 12:28 AM, Ben Pfaff wrote: > >>> match_format() prints out "igmp" for IGMP flows, but > >>> ofp_parse_protocol() d

Re: [ovs-dev] Question about supporting the OVS out-of-tree kernel drivers

2020-12-16 Thread Flavio Leitner
On Sun, Nov 29, 2020 at 02:30:29AM +0100, Ilya Maximets wrote: > On 11/12/20 6:04 PM, Gregory Rose wrote: > > > > > > On 11/12/2020 5:10 AM, Mark Gray wrote: > >> On 30/10/2020 18:32, Gregory Rose wrote: > >>> > >>> The question is whether there is any interest in continuing to support > >>> the

Re: [ovs-dev] [PATCH] conntrack: fix zone sync issue

2020-12-16 Thread Flavio Leitner
This email has 'To' field pointing to ovs-dev, but the patch seems to fix another code other than OVS. You might have realized by now, but in case you're still waiting... :) Thanks, fbl On Mon, Oct 19, 2020 at 10:53:13AM +0800, yang_y...@163.com wrote: > From: Yi Yang > > In some use cases,

Re: [ovs-dev] [PATCH] NEWS: Move '--offload-stats' entry to correct release.

2020-12-16 Thread Flavio Leitner
Hi Ilya, This patch broke after a87d827ecb ("NEWS: Move GTP-U entry to correct release."), otherwise it looks good to me. fbl On Wed, Oct 14, 2020 at 11:50:30PM +0200, Ilya Maximets wrote: > Patch landed to 2.13, not 2.12. > > Fixes: 164413156cf9 ("Add offload packets statistics") > Signed-of

Re: [ovs-dev] [PATCH v3] conntrack: add generic IP protocol support

2020-12-16 Thread Flavio Leitner
can > be extracted it's treated as generic L3. The change below mimics the > behavior of the kernel. > > Signed-off-by: Eelco Chaudron > --- This patch conflicts with NEWS file, otherwise: Acked-by: Flavio Leitner ___ dev mailing li

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Stop forwarding MLD reports to group ports.

2020-12-16 Thread Flavio Leitner
. > The same issue doesn't exist with IPv4. > > Fixes: 06994f879c ("mcast-snooping: Add Multicast Listener Discovery support") > Signed-off-by: XiaoXiong Ding > --- Acked-by: Flavio Leitner ___ dev mailing list d...@op

[ovs-dev] [PATCH] netdev-dpdk: Refactor the DPDK transmit path.

2020-12-03 Thread Flavio Leitner
This patch split out the common code between vhost and dpdk transmit paths to shared functions to simplify the code and fix an issue. The issue is that the packet coming from non-DPDK device and egressing on a DPDK device currently skips the hwol preparation. Signed-off-by: Flavio Leitner

Re: [ovs-dev] [PATCH V3 1/4] Enable VXLAN TSO for DPDK datapath

2020-11-23 Thread Flavio Leitner
Hi Yi, On Mon, Nov 02, 2020 at 11:16:49AM +0800, yang_y_yi wrote: > > > Thanks a lot, Flavio, please check inline comments for more discussion. > > > > At 2020-10-31 01:55:57, "Flavio Leitner" wrote: > > > >Hi Yi, > > > >Thanks fo

Re: [ovs-dev] [PATCH] odp-util: Fix overflow of nested netlink attributes.

2020-11-13 Thread Flavio Leitner
count the included header to check only the payload and there are many more places in netlink with asserts, so it looks okay to me. The new test triggers the assert if the check nl_attr_oversized() is removed, so the test reproduces the issue and the assert catches that. The -E2BIG retu

Re: [ovs-dev] [PATCH V3 1/4] Enable VXLAN TSO for DPDK datapath

2020-10-30 Thread Flavio Leitner
Hi Yi, Thanks for the patch and sorry the delay to review it. See my comments in line. Thanks, fbl On Fri, Aug 07, 2020 at 06:56:45PM +0800, yang_y...@163.com wrote: > From: Yi Yang > > Many NICs can support VXLAN TSO which can help > improve across-compute-node VM-to-VM performance > in ca

Re: [ovs-dev] [PATCH v10] dpif-netlink: distribute polling to discreet handlers

2020-10-29 Thread Flavio Leitner
tirq_entry -ag > > # in a separate terminal > ip netns exec left arping -I left0 -c 1 172.31.110.11 > > # in the perf terminal after exiting > perf script > > Look for the number of 'handler' threads which were made active. > > Suggest

[ovs-dev] [PATCH] ovs-ctl: Prepend OVS binary directories to PATH.

2020-10-28 Thread Flavio Leitner
f the PATH wrong order. The same issue happens if one changes $OVS_BINDIR or $OVS_SBINDIR variables. The solution is to prepend those directories if they are not already in PATH. Reported-by: Mark Gray Signed-off-by: Flavio Leitner --- utilities/ovs-ctl.in | 6 +- 1 file changed, 5 insert

Re: [ovs-dev] [PATCH v9] dpif-netlink: distribute polling to discreet handlers

2020-10-27 Thread Flavio Leitner
tirq_entry -ag > > # in a separate terminal > ip netns exec left arping -I left0 -c 1 172.31.110.11 > > # in the perf terminal after exiting > perf script > > Look for the number of 'handler' threads which were made active. > > Suggest

Re: [ovs-dev] [PATCH] netdev-dpdk: fix incorrect shinfo initialization

2020-10-27 Thread Flavio Leitner
On Tue, Oct 27, 2020 at 01:47:22PM +0100, Ilya Maximets wrote: > On 10/27/20 12:34 PM, Flavio Leitner wrote: > > On Wed, Oct 14, 2020 at 03:22:48PM +0800, yang_y...@163.com wrote: > >> From: Yi Yang > >> > >> shinfo is used to store reference counter and free

Re: [ovs-dev] [PATCH] netdev-dpdk: fix incorrect shinfo initialization

2020-10-27 Thread Flavio Leitner
is by always storing shinfo at the tail of external buffer. > > Fixes: 29cf9c1b3b9c ("userspace: Add TCP Segmentation Offload support") > Co-authored-by: Olivier Matz > Signed-off-by: Olivier Matz > Signed-off-by: Yi Yang > --- Acked-by: Flavio Leitner Tha

Re: [ovs-dev] [PATCH v1 1/1] dpif-netdev: Fix typo in copyright header.

2020-10-06 Thread Flavio Leitner
ren > Signed-off-by: Ian Stokes > --- Acked-by: Flavio Leitner ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2 4/4] release-process: Policy for unmaintained branches.

2020-10-06 Thread Flavio Leitner
t OVS releases > with the last available DPDK LTS, e.g. OVS 2.11 last stable release > will likely be released with the 18.11 EOL release validated. > > Signed-off-by: Ilya Maximets > --- Thanks for adding the possibility for developers to provide a backport fix. Acked-by: Flavio

Re: [ovs-dev] [PATCH v2 3/4] release-process: Standardize designation of new LTS releases.

2020-10-06 Thread Flavio Leitner
d avoid marking some > particular release as LTS in case of significant issues with it. > > Signed-off-by: Ilya Maximets > --- Acked-by: Flavio Leitner ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2 2/4] release-process: Add transition period for LTS releases.

2020-10-06 Thread Flavio Leitner
15 release, i.e. we will provide the last release, if any, on > branch-2.5 somewhere around Feb 2021. (I don't actually expect many > fixes there) I think you jinxed it with that last phrase. :-) > > Signed-off-by: Ilya Maximets > --- Acked-by: Flavio Leitner __

Re: [ovs-dev] [PATCH v2] ofproto-dpif-upcall: Log the emergency flow flush.

2020-09-30 Thread Flavio Leitner
On Wed, Sep 30, 2020 at 02:23:11PM +0200, Ilya Maximets wrote: > On 9/30/20 2:16 PM, Ilya Maximets wrote: > > On 9/30/20 1:24 PM, Eelco Chaudron wrote: > >> > >> > >> On 30 Sep 2020, at 13:19, Flavio Leitner wrote: > >> > >>> On We

[ovs-dev] [PATCH v3] ofproto-dpif-upcall: Log the emergency flow flush.

2020-09-30 Thread Flavio Leitner
When the number of flows in the datapath reaches twice the maximum, revalidators will delete all flows as an emergency action to recover. In that case, log a message with values and increase a coverage counter. Signed-off-by: Flavio Leitner --- ofproto/ofproto-dpif-upcall.c | 21

Re: [ovs-dev] [PATCH v2] ofproto-dpif-upcall: Log the emergency flow flush.

2020-09-30 Thread Flavio Leitner
On Wed, Sep 30, 2020 at 08:45:07AM +0200, Eelco Chaudron wrote: > > > On 29 Sep 2020, at 22:07, Flavio Leitner wrote: > > > When the number of flows in the datapath reaches twice the > > maximum, revalidators will delete all flows as an emergency > > action t

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Log the emergency flow flush.

2020-09-29 Thread Flavio Leitner
On Tue, Sep 29, 2020 at 05:27:31PM +0200, Ilya Maximets wrote: > On 9/15/20 9:21 PM, Flavio Leitner wrote: > > When the number of flows in the datapath reaches twice the > > maximum, revalidators will delete all flows as an emergency > > action to recover. In that case, log

<    1   2   3   4   5   6   7   8   9   10   >