On Mon, Apr 01, 2019 at 12:07:43AM +0200, Pablo Neira Ayuso wrote:
> On Tue, Mar 26, 2019 at 05:57:08PM -0300, Flavio Leitner wrote:
> > Each NAT helper creates a module alias which follows a pattern.
> > Use macros for consistency.
> >
> > Signed-off-by: Flavio Leitne
On Wed, Apr 03, 2019 at 09:49:13AM -0700, Yifeng Sun wrote:
> From: Flavio Leitner
>
> Upstream commit:
> commit 7f6d6558ae44bc193eb28df3617c364d3bb6df39
> Author: Flavio Leitner
> Date: Fri Sep 28 14:55:34 2018 -0300
>
> Revert "openvswitch: Fix
his change fixes those problems. It will try to load the module
only if it's not present. It grabs a reference to the NAT module
and holds it while the flow is active. Finally, an error message
shows up if either actions above fails.
Fixes: 17c357efe5ec ("openvswitch: load NAT helper")
S
Signed-off-by: Flavio Leitner
---
net/netfilter/nf_nat_sip.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/net/netfilter/nf_nat_sip.c b/net/netfilter/nf_nat_sip.c
index f31c2a1b95b8..42b3d2e7ecbd 100644
--- a/net/netfilter/nf_nat_sip.c
+++ b/net/netfilter/nf_nat_sip.c
Signed-off-by: Flavio Leitner
---
net/netfilter/nf_nat_tftp.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/net/netfilter/nf_nat_tftp.c b/net/netfilter/nf_nat_tftp.c
index 51673aa6e1dc..5a7af30e3e02 100644
--- a/net/netfilter/nf_nat_tftp.c
+++ b/net/netfilter/nf_nat_tftp.c
@@ -18,6
Signed-off-by: Flavio Leitner
---
net/netfilter/nf_nat_irc.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/net/netfilter/nf_nat_irc.c b/net/netfilter/nf_nat_irc.c
index c18e3ce6589b..853e91c1cea5 100644
--- a/net/netfilter/nf_nat_irc.c
+++ b/net/netfilter/nf_nat_irc.c
@@ -28,6 +28,8
Signed-off-by: Flavio Leitner
---
net/netfilter/nf_nat_ftp.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/net/netfilter/nf_nat_ftp.c b/net/netfilter/nf_nat_ftp.c
index 19f5739fd5e2..70fddcddad54 100644
--- a/net/netfilter/nf_nat_ftp.c
+++ b/net/netfilter/nf_nat_ftp.c
@@ -28,6 +28,8
Signed-off-by: Flavio Leitner
---
net/netfilter/nf_nat_amanda.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/net/netfilter/nf_nat_amanda.c b/net/netfilter/nf_nat_amanda.c
index e87075763f73..344096418224 100644
--- a/net/netfilter/nf_nat_amanda.c
+++ b/net/netfilter/nf_nat_amanda.c
The API allows a conntrack helper to indicate its corresponding
NAT helper which then can be loaded and reference counted.
Signed-off-by: Flavio Leitner
---
include/net/netfilter/nf_conntrack_helper.h | 19 +++-
net/netfilter/nf_conntrack_amanda.c | 2 +
net/netfilter
an API to point to the NAT helper.
The following patches will register each NAT helper using
the new API.
The last patch fixes openvswitch to use the new API to
load and reference the NAT helper and also report an error
if the operation fails.
Flavio Leitner (8):
netfilter: use macros
Each NAT helper creates a module alias which follows a pattern.
Use macros for consistency.
Signed-off-by: Flavio Leitner
---
include/net/netfilter/nf_conntrack_helper.h | 4
net/ipv4/netfilter/nf_nat_h323.c| 2 +-
net/ipv4/netfilter/nf_nat_pptp.c| 2 +-
net
The buffer needs to be reallocated and data copied when
the netnsid netlink attribute is included, so avoid that
by accounting the attribute when the buffer is initially
allocated.
Fixes: 756819ddd788 ("netdev-linux: use netlink to update netdev.")
Signed-off-by: Flavio Leitner
---
linux: use netlink to update netdev.")
Signed-off-by: Flavio Leitner
---
lib/netdev-linux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
index 965e7eee8..5fcd2188a 100644
--- a/lib/netdev-linux.c
+++ b/lib/netdev-linux.c
@@ -6054
submission.
Flavio Leitner (2):
netlink linux: account for the netnsid netlink attr.
netlink linux: fix to append the netnsid netlink attr.
lib/netdev-linux.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--
2.20.1
___
dev mailing list
as well.
Fixes: 16ec3d4fbb96 ("openvswitch: Fix cached ct with helper.")
Signed-off-by: Flavio Leitner
---
net/openvswitch/conntrack.c | 6 ++
1 file changed, 6 insertions(+)
Changelog:
v2 - removed nfct_help(ct) check as it is not necessary.
diff --git a/net/openvswitch/conntra
On Sat, Mar 23, 2019 at 12:32:37PM -0700, Pravin Shelar wrote:
> On Thu, Mar 21, 2019 at 9:52 AM Flavio Leitner wrote:
> >
> > When the conntrack is initialized, there is no helper attached
> > yet so the nat info initialization (nf_nat_setup_info) skips
>
as well.
Fixes: 16ec3d4fbb96 ("openvswitch: Fix cached ct with helper.")
Signed-off-by: Flavio Leitner
---
net/openvswitch/conntrack.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/net/openvswitch/conntrack.c b/net/openvswitch/conntrack.c
index 1b6896896fff..a7664515c
sense and it most
probably will make the services management more reliable.
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
gt; "make check".
>
> Signed-off-by: Timothy Redaelli
> ---
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
to the following analysis:
* https://mail.openvswitch.org/pipermail/ovs-dev/2016-January/308592.html
*
* We use 512 kB to give us some margin of error. */
Signed-off-by: Flavio Leitner
---
rhel/usr_lib_systemd_system_ovs-vswitchd.service.in | 1 +
1 file changed, 1 insertion(+)
diff --git
On Wed, Feb 27, 2019 at 09:31:27AM -0800, Ben Pfaff wrote:
> On Fri, Feb 22, 2019 at 05:26:30PM -0300, Flavio Leitner wrote:
> > On Wed, Feb 20, 2019 at 04:47:14PM -0800, Justin Pettit wrote:
> > > Signed-off-by: Justin Pettit
> > > ---
> >
> > Your pa
On Wed, Feb 20, 2019 at 04:47:14PM -0800, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
> ---
Your patches are okay, but unfortunately while testing I found an
issue which is resolved by the commit below in branch-2.11 and master:
commit 024d93f62ca7a7fef9c8fc5f69a38b60ebf7e0ab
Author:
On Thu, Feb 21, 2019 at 04:54:39PM +0300, Ilya Maximets wrote:
> On 21.02.2019 16:48, Flavio Leitner wrote:
> > On Tue, Feb 19, 2019 at 10:12:28AM +0300, Ilya Maximets wrote:
> >> DPDK uses dlopen to load plugins and we need to search for
> >> library containing this fun
On Wed, Feb 20, 2019 at 04:49:24PM -0800, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
> ---
I reviewed and applied, but did not build.
To the set
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswit
On Wed, Feb 20, 2019 at 04:49:40PM -0800, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
> ---
I reviewed and applied, but did not build.
To the set
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswit
On Wed, Feb 20, 2019 at 04:49:15PM -0800, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
> ---
I reviewed and applied, but did not build.
To the set
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswit
On Wed, Feb 20, 2019 at 04:49:06PM -0800, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
> ---
I reviewed and applied, but did not build.
To the set
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswit
On Wed, Feb 20, 2019 at 04:47:42PM -0800, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
> ---
I reviewed and applied, but did not build.
To the set
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswit
On Tue, Feb 19, 2019 at 10:12:28AM +0300, Ilya Maximets wrote:
> DPDK uses dlopen to load plugins and we need to search for
> library containing this function. But we should not do this
> in a loop because 'AC_SEARCH_LIBS' could do this for us.
> Also, 'AC_SEARCH_LIBS' prints user-visible messages
e we're defining VHOST_NUMA only if RTE_LIBRTE_VHOST_NUMA
> defined. This costs nothing as all the checks with 'AC_CHECK_DECL'
> are cached.
>
> Signed-off-by: Ilya Maximets
> ---
Awesome!
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Wed, Feb 20, 2019 at 10:25:45PM +, Ophir Munk wrote:
> If we wanted to switch to a multi-threaded offload model today- we could have
> done it in two steps:
> 1. Implement a multi-threaded model on current master branch.
> 2. Do the split.
>
> The two steps seem independent. The split
On Tue, Feb 19, 2019 at 09:47:10PM -0800, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
> ---
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, Feb 19, 2019 at 09:47:09PM -0800, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
> ---
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, Feb 19, 2019 at 10:51:40AM +0900, Chris Mi wrote:
> If vxlan dst_port is not default 4789, "ovs-dpctl dump-flows"
> will fail. The error message is:
>
> netdev_linux|INFO|ioctl(SIOCGIFINDEX) on vxlan_sys_4789 device failed: No
> such device
>
> That's because when calling
On Mon, Feb 18, 2019 at 04:16:02PM +, Ophir Munk wrote:
> From: Roni Bar Yanai
>
> Hardware offloading-code is moved to a new file called
> netdev-rte-offloads.c. The original offloading-code is copied as is
> from the netdev-dpdk.c file into the new file where future
> offloading-code
On Wed, Feb 20, 2019 at 03:47:37PM +0300, Ilya Maximets wrote:
> Simple test for basic partial HWOL functionality.
Works for me, thanks!
Acked-by: Flavio Leitner
> Signed-off-by: Ilya Maximets
> ---
> tests/dpif-netdev.at | 74
>
On Mon, Feb 18, 2019 at 07:00:25PM +0300, Ilya Maximets wrote:
> Simple test for basic partial HWOL functionality.
>
> Signed-off-by: Ilya Maximets
> ---
> tests/dpif-netdev.at | 74
> 1 file changed, 74 insertions(+)
>
> diff --git
On Mon, Feb 18, 2019 at 07:00:24PM +0300, Ilya Maximets wrote:
> Add debug logging for partial HWOL for dummy interfaces for
> the future using in tests.
>
> Signed-off-by: Ilya Maximets
> ---
Acked-by: Flavio Leitner
___
dev
On Mon, Feb 18, 2019 at 07:00:23PM +0300, Ilya Maximets wrote:
> Match packets received on dummy interfaces with offloaded flows and
> set up corresponding marks in dp-packet.
>
> Signed-off-by: Ilya Maximets
> ---
Acked-by: Flavio Leitner
ply updates the flow in
the hash table, which looks correct to me.
Acked-by: Flavio Leitner
> Signed-off-by: Ilya Maximets
> ---
> lib/netdev-dummy.c | 106 +++--
> 1 file changed, 103 insertions(+), 3 deletions(-)
>
> diff --git a/lib
On Mon, Feb 18, 2019 at 07:00:20PM +0300, Ilya Maximets wrote:
> Additionally, new API call 'dp_packet_set_flow_mark' is needed
> for packet clone. Mostly for dummy HWOL implementation.
>
> Signed-off-by: Ilya Maximets
> ---
Acked-by:
t;
> Signed-off-by: Ilya Maximets
> ---
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Mon, Feb 18, 2019 at 06:05:54PM +, Ian Stokes wrote:
> On 2/17/2019 5:37 PM, Ophir Munk wrote:
> > This details how to configure representors ports.
> >
> > Signed-off-by: Ophir Munk
> > ---
> > v1:
> > First version
> > v2:
> > Following patch reviews.
> >
af Shuler
> Reviewed-by: Asaf Penso
> ---
This adds dependencies when a PMD is enabled and is not using dlopen,
which makes sense. I see no problems with the patchset.
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
h
On Fri, Feb 15, 2019 at 04:07:03PM +0300, Ilya Maximets wrote:
> Additionally, new API call 'dp_packet_set_flow_mark' is needed
> for packet clone. Mostly for dummy HWOL implementation.
>
> Signed-off-by: Ilya Maximets
> ---
> lib/dp-packet.h | 23 +--
> 1 file changed, 21
On Fri, Feb 15, 2019 at 04:07:04PM +0300, Ilya Maximets wrote:
> Dummy interfaces clones dp-packet while 'receive' appctl processing.
> In general, we should do this anyway to avoid any possible issues in
> the future with real interfaces.
>
> Signed-off-by: Ilya Maximets
> ---
On Fri, Feb 15, 2019 at 04:07:02PM +0300, Ilya Maximets wrote:
> 1. No reason to have mbuf related APIs in a generic code.
> 2. Not only RSS/checksums should be invalidated in case of tunnel
>decapsulation or sending to 'ring' ports.
>
> In order to fix two above issues, new function
>
umber of new flows.
>
> Fixes: 241bad15d99a ("dpif-netdev: associate flow with a mark id")
> Signed-off-by: Ilya Maximets
> ---
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Fri, Feb 15, 2019 at 04:07:01PM +0300, Ilya Maximets wrote:
> Getters should have const arguments.
>
> Signed-off-by: Ilya Maximets
> ---
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch
On Thu, Feb 14, 2019 at 03:06:33PM +0100, Matthias May via dev wrote:
> On 14/02/2019 14:34, Flavio Leitner wrote:
> > Matthias, could you describe to where exactly you sent out the
> > patch? ovs-dev@openvswitch.org or d...@openvswitch.org or something
> > else?
> So
Hi Ben,
This is another patch with From: field altered to be
ovs-dev@openvswitch.org.
[...]
From: Matthias May via dev
Reply-To: Matthias May
If the patch gets applied as is, the commit's Author will have the
wrong email.
Just FYI because before Sriharsha and Neal had the same issue
On Thu, Feb 14, 2019 at 01:47:27PM +0300, Ilya Maximets wrote:
> On 13.02.2019 19:39, Ian Stokes wrote:
> > On 2/13/2019 8:14 AM, Ophir Munk wrote:
> >>
> >>
> >>> -Original Message-
> -Original Message-
> From: Ian Stokes
> Sent: Tuesday, February 12, 2019 7:17 PM
is no order.)
> Note: linux/if.h depends on sys/socket.h .
> * 'ovs_u128_is_zero' used instead of manual checking of fields.
> * Code simplified by using direct pointer to 'match->wc.masks'.
> * 'sizeof's rewritten to be coding-style complient.
>
> Signed-off-by: Ilya Maximets
>
On Wed, Feb 06, 2019 at 11:33:04AM +0300, Ilya Maximets wrote:
> On 05.02.2019 23:19, Flavio Leitner wrote:
> > On Tue, Feb 05, 2019 at 06:43:08PM +0300, Ilya Maximets wrote:
> >> Hi Flavio.
> >> Thanks for taking a look.
> >>
> >> On 05.02.2019 15:
On Tue, Feb 05, 2019 at 06:43:08PM +0300, Ilya Maximets wrote:
> Hi Flavio.
> Thanks for taking a look.
>
> On 05.02.2019 15:38, Flavio Leitner wrote:
> >
> > Hi Ilya,
> >
> > Thanks for the patch and I think we knew about that pain when we
> > exposed
Hi Ilya,
Thanks for the patch and I think we knew about that pain when we
exposed the very first parameter. I still remember Aaron struggling
to find the best path forward. Time flies and here we are.
The problem is that this change is not friendly from the community
perspective to its users.
up in userspace is on my
ToDo list, but I haven't had a chance to get to it yet.
Thanks,
fbl
>
> On Wed, Jan 23, 2019 at 07:55:36AM -0200, Flavio Leitner wrote:
> >
> > Hi,
> >
> > Just a reminder about this revert.
> >
> > On Thu, Dec 13, 2018 at 12:30:4
Hi,
Just a reminder about this revert.
On Thu, Dec 13, 2018 at 12:30:47PM -0200, Flavio Leitner wrote:
>
> This should be applied to branch-2.10 as well.
And now branch-2.11
Thanks,
fbl
>
> (BTW, I had CC few folks in the patchset, but I am only seeing Guru, so
> I
; VMware-BZ: #2249788
>
> Signed-off-by: Martin Xu
> Signed-off-by: Greg Rose
> CC: Flavio Leitner
> CC: Yi-Hung Wei
> CC: Yifeng Sun
> CC: Zak Whittington
> CC: Ben Pfaff
> ---
LGTM
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
names will be ovn, ovn-common, ovn-central, ovn-host,
> ovn-vtep and ovn-docker.
>
> Signed-off-by: Numan Siddique
> Acked-by: Timothy Redaelli
> Tested-By: Timothy Redaelli
> ---
The patch looks good and I can build ovs and ovn packages
on fedora 29.
Acked-by: Flavio Leitner
or upgrade with
> > the same version as already installed, the conflict kicks in. Otherwise,
> > such is allowed with --replacepkgs.
> >
> > Obsoletes is needed for the upgrade path from kmod-openvswitch to
> > openvswitch-kmod.
> >
> > Fixes: 22c33c3039 (rhel: s
t is moved to another network namespace.
Signed-off-by: Flavio Leitner
---
lib/dpif-netlink.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c
index 03470603f..dfa9d9199 100644
--- a/lib/dpif-netlink.c
+++ b/lib/dpif-netlink.c
@@ -90
fails only if the port with that name exists in the current netns.
If the port is in another netns, it will get a new dp_port and because
of that userspace will delete the old port. At this point the original
port is gone from the other netns and there a fresh port in the current
netns.
Signed-off-
This should be applied to branch-2.10 as well.
(BTW, I had CC few folks in the patchset, but I am only seeing Guru, so
I am adding them to this email just in case)
Thanks,
fbl
On Thu, Dec 13, 2018 at 12:24:45PM -0200, Flavio Leitner wrote:
> The optimization introduced a regression in
rent netns.
If the port is in another netns, it will get a new dp_port and because
of that userspace will delete the old port. At this point the original
port is gone from the other netns and there a fresh port in the current
netns.
This patchset reverts the original commit and the two other follow up
On Wed, Dec 12, 2018 at 08:36:09AM -0800, Ben Pfaff wrote:
> On Wed, Dec 05, 2018 at 03:12:08PM -0200, Flavio Leitner wrote:
> >
> > Hi Ben,
> >
> > This patch introduced a regression in OSP environments using internal
> > ports in other netns. Their netw
On Thu, Dec 13, 2018 at 11:03:40AM -0200, Flavio Leitner wrote:
> On Wed, Dec 12, 2018 at 08:36:09AM -0800, Ben Pfaff wrote:
> > Would you mind coming up with a series that reverts the OVS 2.10 patch
> > and separately adds the improved fix?
>
> Sure, I will submit the revert
t is moved to another network namespace.
Signed-off-by: Flavio Leitner
---
ofproto/ofproto-dpif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index 2dc5778e1..f40f157ca 100644
--- a/ofproto/ofproto-dpif.c
+++ b/ofproto/ofproto-dpif.c
Hi Ben,
On Fri, Mar 09, 2018 at 05:00:27PM -0800, Ben Pfaff wrote:
> The route table is implemented in terms of a classifier structure, which
> supports versioning with atomic transactional updates, but OVS didn't
> actually use it for the route table. This commit starts using that feature
> for
On Wed, Dec 05, 2018 at 10:55:51AM -0800, Greg Rose wrote:
> From: Flavio Leitner
>
> Upstream commit:
> commit 17c357efe5eceebdc3971a48b3d4d61a03c1178b
> Author: Flavio Leitner
> Date: Fri Sep 28 14:51:28 2018 -0300
>
> openvswitch: load
Hi Ben,
This patch introduced a regression in OSP environments using internal
ports in other netns. Their networking configuration is lost when
the service is restarted because the ports are recreated now.
Before the patch it checked using netlink if the port with a specific
"name" was already
switch directory as a
> %post operation.
>
> Signed-off-by: David Marchand
> ---
LGTM, thanks David!
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> This commit prevent the static libraries and libtool archives to be shipped.
>
> [1]
> https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries
> Signed-off-by: Timothy Redaelli
> ---
Acked-by: Flavio Leitner
_
On Sun, Nov 11, 2018 at 11:04:01AM -0800, Ben Pfaff wrote:
> On Sun, Nov 11, 2018 at 04:32:40PM +0100, Timothy Redaelli wrote:
> > Hi,
> > from commit bc4fd439586f ("rhel: Ship ovs shared libraries, fedora")
> > the openvswitch-devel subpackage (in openvswitch-fedora.spec)
> > stated to include
-dpdk/set-admin-state {up|down} and
> ovs-ofctl mod-port {up|down} commands on a XL710
> and 82599ES.
>
> Fixes: 3b1fb0779b87 ("netdev-dpdk: Don't call rte_dev_stop() in
> update_flags().")
> Signed-off-by: Eelco Chaudron
>
> ---
LGTM
Acked-by: Fl
previous file mode (0644) on rtnetlink.h.
>
> CC: John Hurley
> Fixes: 135ee7ef362f ("rtnetlink: extend parser to include kind of master and
> slave")
> Signed-off-by: Timothy Redaelli
> ---
Acked-by: Flavio Leitner
___
dev mailing l
mode (0644) on bond.c.
>
> CC: Ben Pfaff
> Fixes: 90061ea7d1dd ("bond: Fix LACP fallback to active-backup when recirc is
> enabled.")
> Signed-off-by: Timothy Redaelli
> ---
Acked-by: Flavio Leitner
___
dev mailing list
d...@op
On Fri, Nov 09, 2018 at 07:24:55AM -0500, Eelco Chaudron wrote:
> When the netdev link flags are changed, !NETDEV_UP, the DPDK ports are not
> actually going down. This is causing problems for people trying to bring
> down a bond member. The bond link is no longer being used to receive or
>
Hi,
On Fri, Nov 02, 2018 at 03:13:35PM -0400, Mark Michelson wrote:
[...]
> With this in mind, we'd like to propose an amended plan.
>
> The short version: rather than completing all four phases by the 2.11
> release, instead we will implement phases 3 and 4 for 2.11, and then
> complete phases
ULL
> >
> > Adapted from an idea by Michael Qiu :
> > https://patchwork.ozlabs.org/patch/777570/
> >
> > Co-authored-by: Tiago Lam
> >
> > Signed-off-by: Mark Kavanagh
> > Signed-off-by: Tiago Lam
> > Acked-by: Eelco Chaudron
> > Acked-by:
On Thu, Nov 01, 2018 at 09:32:50AM +0530, Sriharsha Basavapatna via dev wrote:
> On Thu, Nov 1, 2018 at 5:32 AM Flavio Leitner wrote:
> > Hi Sriharsha,
> >
> > Do you mind to send this again but directly to
> > d...@openvswitch.org
> > instead of
> > ovs-d
have been an interesting journey to find the root cause if not by
code inspection.
Acked-by: Flavio Leitner
fbl
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Hi Sriharsha,
Do you mind to send this again but directly to
d...@openvswitch.org
instead of
ovs-dev@openvswitch.org ?
I received spam with the same issue but only when sent to
ovs-dev@
Thanks,
fbl
On Thu, Nov 01, 2018 at 12:51:41AM +0530, Sriharsha Basavapatna via dev wrote:
> A few lines
On Wed, Oct 31, 2018 at 11:06:50AM -0700, Ben Pfaff wrote:
> It makes parsing them more difficult.
It does, indeed.
Acked-by: Flavio Leitner
>
> Signed-off-by: Ben Pfaff
> ---
> Documentation/internals/contributing/submitting-patches.rst | 3 +++
> 1 file changed, 3 inser
On Wed, Oct 31, 2018 at 11:02:08AM -0700, Ben Pfaff wrote:
> Suggested-by: Gregory Rose
> Signed-off-by: Ben Pfaff
> ---
> Documentation/internals/contributing/submitting-patches.rst | 6 ++
> 1 file changed, 6 insertions(+)
LGTM
Acked-by: Flavio Leitner
> diff --g
F is documented as experimental in the docs, so
Acked-by: Flavio Leitner
> ---
> Documentation/intro/install/dpdk.rst | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Documentation/intro/install/dpdk.rst
> b/Documentation/intro/install/dpdk.rst
> index 312b1a873..13546bb7
On Tue, Oct 30, 2018 at 01:10:51PM +, Stokes, Ian wrote:
> > > Report the link speed of the device in netdev_dpdk_get_status()
> > > function.
> > >
> > > Link speed is already reported as part of the netdev_get_features()
> > > function. However only link speeds defined in the OpenFlow specs
io, this patch is based on suggestions from you
>
> https://mail.openvswitch.org/pipermail/ovs-dev/2018-September/351809.html
>
> I'd like to add
>
> Co-authored-by: Flavio Leitner
> Signed-off-by: Flavio Leitner
>
> if you agree to sign of
On Fri, Oct 19, 2018 at 01:01:00PM +0300, Ilya Maximets wrote:
> > On Thu, Jun 28, 2018 at 02:39:32PM -0300, Flavio Leitner wrote:
> >> Ian, I am afraid that the issue might be local and we most probably can
> >> fix with a follow up patch later, so if others are
On Fri, Oct 05, 2018 at 03:50:46PM +0100, Lam, Tiago wrote:
> On 03/10/2018 19:26, Flavio Leitner wrote:
> > On Fri, Sep 28, 2018 at 05:15:06PM +0100, Tiago Lam wrote:
> >> When a dp_packet is from a DPDK source, and it contains multi-segment
> >> mbufs, the data_len
ti-segment mbufs, need to be set prior to start OvS.
>
> To support other options, OVS_DPDK_START() has been modified to accept
> extra configs in the form "$config_name=$config_value". It then uses
> ovs-vsctl to set the configs.
>
> Signed-off-by: Tiago Lam
> A
; these tests.
>
> Signed-off-by: Tiago Lam
> Acked-by: Eelco Chaudron
> ---
nice!
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Fri, Sep 28, 2018 at 05:15:12PM +0100, Tiago Lam wrote:
> From: Mark Kavanagh
>
> Currently, jumbo frame support for OvS-DPDK is implemented by
> increasing the size of mbufs within a mempool, such that each mbuf
> within the pool is large enough to contain an entire jumbo frame of
> a
On Fri, Sep 28, 2018 at 05:15:11PM +0100, Tiago Lam wrote:
> From: Mark Kavanagh
>
> Currently, packets are only copied to a single segment in the function
> dpdk_do_tx_copy(). This could be an issue in the case of jumbo frames,
> particularly when multi-segment mbufs are involved.
>
> This
Hi Tiago,
There is a lot to digest in this patch, so I only have a general
comment about it for now.
See below.
On Fri, Sep 28, 2018 at 05:15:10PM +0100, Tiago Lam wrote:
> Previous commits have added support to the dp_packet API to handle
> multi-segmented packets, where data is not stored
On Fri, Sep 28, 2018 at 05:15:08PM +0100, Tiago Lam wrote:
> In its current implementation dp_packet_shift() is also unaware of
> multi-seg mbufs (that holds data in memory non-contiguously) and assumes
> that data exists contiguously in memory, memmove'ing data to perform the
> shift.
>
> To add
On Fri, Sep 28, 2018 at 05:15:09PM +0100, Tiago Lam wrote:
> From: Michael Qiu
>
> When doing packet clone, if packet source is from DPDK driver,
> multi-segment must be considered, and copy the segment's data one by
> one.
>
> Also, lots of DPDK mbuf's info is missed during a copy, like packet
now depends on the type of
> packet.
>
> Co-authored-by: Mark Kavanagh
>
> Signed-off-by: Mark Kavanagh
> Signed-off-by: Tiago Lam
> Acked-by: Eelco Chaudron
> ---
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Fri, Sep 28, 2018 at 05:15:06PM +0100, Tiago Lam wrote:
> When a dp_packet is from a DPDK source, and it contains multi-segment
> mbufs, the data_len is not equal to the packet size, pkt_len. Instead,
> the data_len of each mbuf in the chain should be considered while
> distributing the new
;
> Signed-off-by: Tiago Lam
> Acked-by: Eelco Chaudron
> ---
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
601 - 700 of 1013 matches
Mail list logo
