Python3 complains if a dict key is changed during the
iteration.
Use list() to create a copy of it.
Traceback (most recent call last):
File "./ovsdb/ovsdb-idlc.in", line 1581, in
func(*args[1:])
File "./ovsdb/ovsdb-idlc.in", line 185, in printCIDLHeader
On Tue, Sep 03, 2019 at 03:17:03PM -0700, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
> ---
Also to the set.
Acked-by: Flavio Leitner
thanks Justin
fbl
___
dev mailing list
d...@openvswitch.org
On Tue, Sep 03, 2019 at 03:13:54PM -0700, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
> ---
To the set
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, Sep 03, 2019 at 03:10:17PM -0700, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
> ---
To the set
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, Sep 03, 2019 at 03:02:59PM -0700, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
> ---
To the set
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Wed, Aug 28, 2019 at 11:29:54AM -0700, Ben Pfaff wrote:
> On Tue, Aug 13, 2019 at 01:34:04PM -0300, Flavio Leitner via dev wrote:
> > When a packet needs to be encapsulated in userspace, the endpoint
> > address needs to be resolved to fill in the headers. If it is not,
> &g
The commit b1356b50aa6a ("tnl-neigh: Use outgoing ofproto version.")
uses the output indentation from newer OvS versions which include the
commit 7be29a47576d ("ofproto-dpif: Remove tabs from output.").
Fixes: b1356b50aa6a ("tnl-neigh: Use outgoing ofproto version.")
Signed-off-by: Flavio Leitner
On Wed, Aug 28, 2019 at 11:29:54AM -0700, Ben Pfaff wrote:
> On Tue, Aug 13, 2019 at 01:34:04PM -0300, Flavio Leitner via dev wrote:
> > When a packet needs to be encapsulated in userspace, the endpoint
> > address needs to be resolved to fill in the headers. If it is not,
> &g
Hi Ben and Ilya,
This patch has two reviews, so any chance for you to take a look
soon as well?
Thanks in advance!
fbl
On Tue, Aug 13, 2019 at 01:34:04PM -0300, Flavio Leitner via dev wrote:
> When a packet needs to be encapsulated in userspace, the endpoint
> address needs to be re
On Tue, Aug 13, 2019 at 01:34:04PM -0300, Flavio Leitner via dev wrote:
> When a packet needs to be encapsulated in userspace, the endpoint
> address needs to be resolved to fill in the headers. If it is not,
> then currently OvS sends either a Neighbor Solicitation (IPv6)
> or an ARP
When a packet needs to be encapsulated in userspace, the endpoint
address needs to be resolved to fill in the headers. If it is not,
then currently OvS sends either a Neighbor Solicitation (IPv6)
or an ARP Query (IPv4) to resolve it.
The problem is that the NS/ARP packet will go through the flow
On Tue, Jul 02, 2019 at 08:50:16PM -0400, Vasu Dasari wrote:
> Hi Flavio,
>
> I am trying to emulate the test case scenario you mentioned earlier, where
> in we need to clean you neighbor cache when an external interface goes
> down. To study that, I wrote a small script based off of test case
>
Hi Michal,
On Tue, Jul 02, 2019 at 10:06:47PM +0100, Michal Orsák wrote:
> Hello,
>
> On 02/07/2019 19:47, Flavio Leitner wrote:
> > On Tue, Jul 02, 2019 at 10:00:44AM -0700, Ben Pfaff wrote:
> > > Hi Ilya and Ian. Please allow me to introduce Michal Orsak, a grad
> > > student currently
On Tue, Jul 02, 2019 at 10:00:44AM -0700, Ben Pfaff wrote:
> Hi Ilya and Ian. Please allow me to introduce Michal Orsak, a grad
> student currently looking at packet classifiers. He's implemented a
> novel classifier that is faster than the one already in OVS in the
> benchmarks that he's run.
On Fri, Jun 28, 2019 at 04:29:36PM +0300, Ilya Maximets wrote:
> On 28.06.2019 16:17, Flavio Leitner wrote:
> > On Fri, Jun 28, 2019 at 03:21:07PM +0300, Ilya Maximets wrote:
> >> On 27.06.2019 14:12, Kevin Traynor wrote:
> >>> vhost tx retries may occur, and it can be a sign that
> >>> the guest
On Thu, Jun 27, 2019 at 12:12:32PM +0100, Kevin Traynor wrote:
> vhost tx retries can provide some mitigation against
> dropped packets due to a temporarily slow guest/limited queue
> size for an interface, but on the other hand when a system
> is fully loaded those extra cycles retrying could
On Tue, Jun 25, 2019 at 03:57:24PM +0100, Kevin Traynor wrote:
> vhost tx retries can provide some mitigation against
> dropped packets due to a temporarily slow guest/limited queue
> size for an interface, but on the other hand when a system
> is fully loaded those extra cycles retrying could
On Wed, Jun 26, 2019 at 11:05:42AM -0300, Flavio Leitner via dev wrote:
> On Tue, Jun 25, 2019 at 03:57:22PM +0100, Kevin Traynor wrote:
> > Add documentation about vhost tx retries and external
> > configuration that can help reduce/avoid them.
> >
> > Signed-off-b
On Tue, Jun 25, 2019 at 03:57:23PM +0100, Kevin Traynor wrote:
> vhost tx retries may occur, and it can be a sign that
> the guest is not optimally configured.
>
> Add some stats so a user will know if vhost tx retries are
> occurring and hence give a hint that guest config should be
> examined.
On Tue, Jun 25, 2019 at 03:57:22PM +0100, Kevin Traynor wrote:
> Add documentation about vhost tx retries and external
> configuration that can help reduce/avoid them.
>
> Signed-off-by: Kevin Traynor
> Acked-by: Eelco Chaudron
> ---
This also has a magic number without a define, but since the
On Tue, Jun 25, 2019 at 03:57:21PM +0100, Kevin Traynor wrote:
> Fix minor issue of one possible additional retry.
>
> Fixes: c6ec9d176dbf ("netdev-dpdk: Fix vHost stats.")
> Signed-off-by: Kevin Traynor
> Acked-by: Eelco Chaudron
> ---
Acked-by: Flavio Leitner
On Tue, Jun 25, 2019 at 03:59:57PM +0300, Ilya Maximets wrote:
> On 25.06.2019 15:41, Flavio Leitner wrote:
> > On Tue, Jun 25, 2019 at 03:37:09PM +0300, Ilya Maximets wrote:
> >> On 25.06.2019 15:20, Flavio Leitner wrote:
> >>> On Tue, Jun 25, 2019 at 01:07:53PM +0300, Ilya Maximets wrote:
>
Hi William,
On Thu, Jun 20, 2019 at 11:00:56AM -0700, William Tu wrote:
> The patch adds the basic spin lock functions:
> ovs_spin_{lock, try_lock, unlock, init, destroy}.
> I have some use cases using af_xdp, patches will
> come later.
Usually the new API is merged along with an user
On Tue, Jun 25, 2019 at 01:12:11PM +0300, Ilya Maximets wrote:
> 'netdev' datapath is implemented within ovs-vswitchd process and can
> not exist without it, so it should be gracefully terminated with a
> full cleanup of resources upon ovs-vswitchd exit.
>
> This change forces dpif cleanup for
On Tue, Jun 25, 2019 at 03:37:09PM +0300, Ilya Maximets wrote:
> On 25.06.2019 15:20, Flavio Leitner wrote:
> > On Tue, Jun 25, 2019 at 01:07:53PM +0300, Ilya Maximets wrote:
> >> On 25.06.2019 0:15, Flavio Leitner wrote:
> >>> On Mon, Jun 24, 2019 at 06:28:37PM +0300, Ilya Maximets wrote:
> >>
On Tue, Jun 25, 2019 at 01:07:53PM +0300, Ilya Maximets wrote:
> On 25.06.2019 0:15, Flavio Leitner wrote:
> > On Mon, Jun 24, 2019 at 06:28:37PM +0300, Ilya Maximets wrote:
> >> 'netdev' datapath is implemented within ovs-vswitchd process and can
> >> not exist without it, so it should be
On Mon, Jun 24, 2019 at 05:43:26PM -0400, Vasu Dasari wrote:
> On Mon, Jun 24, 2019 at 3:58 PM Flavio Leitner wrote:
> > On Wed, Jun 19, 2019 at 11:02:07PM -0400, Vasu Dasari wrote:
> > > +{
> > > +struct tnl_neigh_entry *neigh;
> > > +bool changed = false;
> > > +
> > > +
On Fri, Jun 21, 2019 at 02:41:57PM +0100, Kevin Traynor wrote:
> vhost tx retries may occur, and it can be a sign that
> the guest is not optimally configured.
>
> Add some stats so a user will know if vhost tx retries are
> occurring and hence give a hint that guest config should be
> examined.
On Fri, Jun 21, 2019 at 02:41:56PM +0100, Kevin Traynor wrote:
> Fix minor issue of one additional retry and add
> documentation about vhost tx retries and ways to
> reduce/remove them.
>
> Signed-off-by: Kevin Traynor
>
> ---
> There is a checkpatch warning that one of the libvirt
> lines in
On Mon, Jun 24, 2019 at 06:28:37PM +0300, Ilya Maximets wrote:
> 'netdev' datapath is implemented within ovs-vswitchd process and can
> not exist without it, so it should be gracefully terminated with a
> full cleanup of resources upon ovs-vswitchd exit.
>
> This change forces dpif cleanup for
On Wed, Jun 19, 2019 at 11:02:07PM -0400, Vasu Dasari wrote:
> Say an ARP entry is learnt on a OVS port and when such a port is deleted,
> learnt entry should be removed from the port. It would have be aged out after
> ARP ageout time. This code will clean up immediately.
>
> Added test
On Fri, May 10, 2019 at 02:31:26PM -0400, Aaron Conole wrote:
> Aaron Conole writes:
>
> > Flavio Leitner writes:
> >
> >> On Thu, Apr 18, 2019 at 01:46:22PM -0600, Alex Williamson wrote:
> >>> On Thu, 18 Apr 2019 15:50:43 -0300
> >>> Flavio Leitner wrote:
> >>>
> >>> > On Thu, Apr 18, 2019
On Thu, May 02, 2019 at 04:12:38PM -0400, Eelco Chaudron wrote:
> For all other error cases in queue_userspace_packet() the error is
> returned, so it makes sense to do the same for these two error cases.
>
> Reported-by: Davide Caratti
> Signed-off-by: Eelco Chaudron
> ---
LGTM
Acked-by:
On Thu, Apr 18, 2019 at 01:46:22PM -0600, Alex Williamson wrote:
> On Thu, 18 Apr 2019 15:50:43 -0300
> Flavio Leitner wrote:
>
> > On Thu, Apr 18, 2019 at 12:06:57PM -0600, Alex Williamson wrote:
> > > On Thu, 18 Apr 2019 13:56:23 -0300
> > > Flavio Leitner wrote:
> > >
> > > > On Thu, Apr
On Thu, Apr 18, 2019 at 12:06:57PM -0600, Alex Williamson wrote:
> On Thu, 18 Apr 2019 13:56:23 -0300
> Flavio Leitner wrote:
>
> > On Thu, Apr 18, 2019 at 10:43:11AM -0600, Alex Williamson wrote:
> > > On Thu, 18 Apr 2019 13:23:54 -0300
> > > Flavio Leitner wrote:
> > >
> > > > On Thu, Apr
On Thu, Apr 18, 2019 at 10:43:11AM -0600, Alex Williamson wrote:
> On Thu, 18 Apr 2019 13:23:54 -0300
> Flavio Leitner wrote:
>
> > On Thu, Apr 18, 2019 at 11:05:28AM -0400, Aaron Conole wrote:
> > > On some systems, it's possible that the initialization of the misc chardev
> > > associated with
On Thu, Apr 18, 2019 at 11:05:28AM -0400, Aaron Conole wrote:
> On some systems, it's possible that the initialization of the misc chardev
> associated with /dev/vfio/vfio is delayed. This happens on machines with
> large numbers of cores (at least 88+). If this delay exceeds the time
> required
On Wed, Apr 17, 2019 at 04:35:05PM -0700, Ben Pfaff wrote:
> On Wed, Apr 17, 2019 at 05:07:34PM -0300, Flavio Leitner via dev wrote:
> > On Tue, Mar 26, 2019 at 04:15:07PM -0400, Mark Michelson wrote:
> > > I've once again rolled another OVN/OVS split version. It can be fo
On Tue, Mar 26, 2019 at 04:15:07PM -0400, Mark Michelson wrote:
> I've once again rolled another OVN/OVS split version. It can be found at
> https://github.com/putnopvut/ovn_mk2.git
>
> The main changes between this and the old split POC are as follows:
>
> * This is based on a much newer build
On Mon, Apr 01, 2019 at 12:10:32AM +0200, Pablo Neira Ayuso wrote:
> On Tue, Mar 26, 2019 at 05:57:09PM -0300, Flavio Leitner wrote:
> > The API allows a conntrack helper to indicate its corresponding
> > NAT helper which then can be loaded and reference counted.
> >
> > Signed-off-by: Flavio
On Mon, Apr 01, 2019 at 12:07:43AM +0200, Pablo Neira Ayuso wrote:
> On Tue, Mar 26, 2019 at 05:57:08PM -0300, Flavio Leitner wrote:
> > Each NAT helper creates a module alias which follows a pattern.
> > Use macros for consistency.
> >
> > Signed-off-by: Flavio Leitner
> > ---
> >
On Wed, Apr 03, 2019 at 09:49:13AM -0700, Yifeng Sun wrote:
> From: Flavio Leitner
>
> Upstream commit:
> commit 7f6d6558ae44bc193eb28df3617c364d3bb6df39
> Author: Flavio Leitner
> Date: Fri Sep 28 14:55:34 2018 -0300
>
> Revert "openvswitch: Fix template leak in error
42 matches
Mail list logo
