[ovs-dev] [PATCH V4 02/24] datapath: drop unneeded likely() call around IS_ERR()

2020-10-12 Thread Greg Rose
around the !IS_ERR() is not needed. Signed-off-by: Enrico Weigelt Signed-off-by: David S. Miller Cc: Enrico Weigelt Signed-off-by: Greg Rose --- datapath/datapath.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath/datapath.c b/datapath/datapath.c index

[ovs-dev] [PATCH V4 04/24] datapath: Print error when ovs_execute_actions() fails

2020-10-12 Thread Greg Rose
ovs_execute_actions() are silently discarded. This patch prints out an debug message when error happens so as to provide helpful hints for debugging. Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Cc: Yifeng Sun Reviewed-by: Yifeng Sun Signed-off-by: Greg Rose --- datapath

[ovs-dev] [PATCH] compat: Replace the HAVE_L4_RXHASH define with HAVE_L4_HASH

2020-09-17 Thread Greg Rose
The skb now uses l4_hash and it is easier to check for it. Also fixes a compile error for RHEL 7.7. Signed-off-by: Greg Rose --- acinclude.m4 | 4 ++-- datapath/datapath.c | 6 +++--- datapath/linux/compat/include/linux/skbuff.h | 4

[ovs-dev] [PATCH 3/3] vxlan: Make vxlan tunnel work in IP_TUNNEL_INFO_BRIDGE mode

2020-09-17 Thread Greg Rose
vxlan_sys_4789 dst 172.168.0.2 \ src_vni 1000 vni 1000 self Signed-off-by: wenxu Signed-off-by: Greg Rose --- include/openvswitch/packets.h | 3 ++- lib/netdev-vport.c| 18 ++ lib/netdev.h | 2 ++ lib/odp-util.c| 21

[ovs-dev] [PATCH 1/3] ip_tunnels: new IP_TUNNEL_INFO_BRIDGE flag for ip_tunnel_info mode

2020-09-17 Thread Greg Rose
. Used by bridge driver later in the series to pass per vlan dst metadata to bridge ports. Signed-off-by: Roopa Prabhu Signed-off-by: David S. Miller Cc: Roopa Prabhu Signed-off-by: Greg Rose --- datapath/linux/compat/include/net/ip_tunnels.h | 1 + 1 file changed, 1 insertion

[ovs-dev] [PATCH 2/3] datapath: Make metadata_dst tunnel work in IP_TUNNEL_INFO_BRIDGE mode

2020-09-17 Thread Greg Rose
172.168.0.1 \ src_vni 1000 vni 1000 self bridge fdb append ff:ff:ff:ff:ff:ff dev vxlan_sys_4789 dst 172.168.0.2 \ src_vni 1000 vni 1000 self Signed-off-by: wenxu Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Cc: wenxu Signed-off-by: Greg Rose

[ovs-dev] [PATCH 0/3] Add IP_TUNNEL_INFO_BRIDGE mode feature

2020-09-17 Thread Greg Rose
Let's pick these patches up. Submitted some time ago but then dropped. Enables the IP_TUNNEL_INFO_BRIDGE feature from upstream Linux and then pulls in to patches from wenxu to complete the feature enablement for openvswitch. Passes Travis here: https://travis-ci.org/github/gvrose8192/ovs-experim

[ovs-dev] [PATCH V3 24/24] Documentation: Update faq and NEWS for kernel 5.8

2020-09-16 Thread Greg Rose
Update the NEWS and faq now that we will support up to Linux kernel 5.8. Signed-off-by: Greg Rose --- Documentation/faq/releases.rst | 1 + NEWS | 2 ++ 2 files changed, 3 insertions(+) diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst index

[ovs-dev] [PATCH V3 16/24] datapath: drop unneeded BUG_ON() in ovs_flow_cmd_build_info()

2020-09-16 Thread Greg Rose
vSwitch kernel components.") Signed-off-by: Paolo Abeni Signed-off-by: David S. Miller Cc: Paolo Abeni Signed-off-by: Greg Rose --- datapath/datapath.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/datapath/datapath.c b/datapath/datapath.c index 047b3312e..877

[ovs-dev] [PATCH V3 07/24] datapath: don't unlock mutex when changing the user_features fails

2020-09-16 Thread Greg Rose
lowed. Other kernel thread may be in critical section while we unlock it because of setting user_feature fail. Fixes: 95a7233c4 ("net: openvswitch: Set OvS recirc_id from tc chain index") Cc: Paul Blakey Signed-off-by: Tonghao Zhang Tested-by: Greg Rose Acked

[ovs-dev] [PATCH V3 14/24] datapath: don't call pad_packet if not necessary

2020-09-16 Thread Greg Rose
ngth of attribute including padding. Cc: Joe Stringer Cc: William Tu Signed-off-by: Tonghao Zhang Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Cc: Tonghao Zhang Reviewed-by: Tonghao Zhang Signed-off-by: Greg Rose --- datapath/datapath.c | 22 -

[ovs-dev] [PATCH V3 20/24] datapath: Distribute switch variables for initialization

2020-09-16 Thread Greg Rose
id S. Miller Cc: Kees Cook Signed-off-by: Greg Rose --- datapath/flow_netlink.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/datapath/flow_netlink.c b/datapath/flow_netlink.c index d3fd77106..996041602 100644 --- a/datapath/flow_netlink.c +++ b/dat

[ovs-dev] [PATCH V3 19/24] datapath: use skb_list_walk_safe helper for gso segments

2020-09-16 Thread Greg Rose
se for the new function, keeping the flow of the existing code as intact as possible. Signed-off-by: Jason A. Donenfeld Signed-off-by: David S. Miller Cc: Jason A. Donenfeld Signed-off-by: Greg Rose --- datapath/datapath.c | 11 --- datapath/li

[ovs-dev] [PATCH V3 18/24] datapath: support asymmetric conntrack

2020-09-16 Thread Greg Rose
t;) Cc: aaron conole Acked-by: Aaron Conole Signed-off-by: Greg Rose --- datapath/conntrack.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/datapath/conntrack.c b/datapath/conntrack.c index 5b4d6cce0..c7a318baf 100644 --- a/datapath/conntrack.c +++ b/datapath/conntrack.c @

[ovs-dev] [PATCH V3 15/24] datapath: fix flow command message size

2020-09-16 Thread Greg Rose
by: Qi Jun Ding Signed-off-by: Paolo Abeni Signed-off-by: David S. Miller Cc: Paolo Abeni Signed-off-by: Greg Rose --- datapath/datapath.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/datapath/datapath.c b/datapath/datapath.c index b9ac67635..047b3312e 10

[ovs-dev] [PATCH V3 22/24] acinclude: Enable builds up to Linux 5.8

2020-09-16 Thread Greg Rose
Allow building openvswitch against Linux kernels up to and including version 5.8. Signed-off-by: Greg Rose --- acinclude.m4 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/acinclude.m4 b/acinclude.m4 index 3d56510a0..1460289ca 100644 --- a/acinclude.m4 +++ b/acinclude.m4

[ovs-dev] [PATCH V3 23/24] travis: Update kernel list as of 5.8

2020-09-16 Thread Greg Rose
Update the list to more closely track the LTS releases on kernel.org. Signed-off-by: Greg Rose --- .travis.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 43e6a75cc..9fd8bbe01 100644 --- a/.travis.yml +++ b/.travis.yml @@ -38,8 +38,8

[ovs-dev] [PATCH V3 13/24] datapath: select vport upcall portid directly

2020-09-16 Thread Greg Rose
if so select it directly in fast-path. Signed-off-by: Tonghao Zhang Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Cc: Tonghao Zhang Reviewed-by: Tonghao Zhang Signed-off-by: Greg Rose --- datapath/vport.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff -

[ovs-dev] [PATCH V3 11/24] datapath: fix possible memleak on destroy flow-table

2020-09-16 Thread Greg Rose
, so release the flow mask struct. Signed-off-by: Tonghao Zhang Tested-by: Greg Rose Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Added additional compat layer fixup for WRITE_ONCE() Cc: Tonghao Zhang Reviewed-by: Tonghao Zhang Signed-off-by: Greg Rose

[ovs-dev] [PATCH V3 21/24] datapath: use hlist_for_each_entry_rcu instead of hlist_for_each_entry

2020-09-16 Thread Greg Rose
traversing them, use hlist_for_each_entry_rcu. Signed-off-by: Tonghao Zhang Tested-by: Greg Rose Reviewed-by: Greg Rose Signed-off-by: David S. Miller Compat fixup - OVS doesn't support lockdep_ovsl_is_held() yet Cc: Tonghao Zhang Reviewed-by: Tonghao Zhang Signed-o

[ovs-dev] [PATCH V3 03/24] datapath: do not update max_headroom if new headroom is equal to old headroom

2020-09-16 Thread Greg Rose
size would be changed. If the vport which has the largest headroom is deleted, the new max_headroom would be set. But, if the new headroom size is equal to the old headroom size, updating routine is unnecessary. Signed-off-by: Taehee Yoo Tested-by: Greg Rose Reviewed-by

[ovs-dev] [PATCH V3 10/24] datapath: add likely in flow_lookup

2020-09-16 Thread Greg Rose
ly for performance. Signed-off-by: Tonghao Zhang Tested-by: Greg Rose Acked-by: William Tu Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Cc: Tonghao Zhang Reviewed-by: Tonghao Zhang Signed-off-by: Greg Rose --- datapath/flow_table.c | 4 ++-- 1 file chan

[ovs-dev] [PATCH V3 09/24] datapath: simplify the flow_hash

2020-09-16 Thread Greg Rose
Zhang Tested-by: Greg Rose Acked-by: William Tu Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Cc: Tonghao Zhang Reviewed-by: Tonghao Zhang Signed-off-by: Greg Rose --- datapath/flow_table.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git

[ovs-dev] [PATCH V3 12/24] datapath: simplify the ovs_dp_cmd_new

2020-09-16 Thread Greg Rose
Tested-by: Greg Rose Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Cc: Tonghao Zhang Reviewed-by: Tonghao Zhang Signed-off-by: Greg Rose --- datapath/datapath.c | 60 - 1 file changed, 38 insertions(+), 22 deletions(-) diff

[ovs-dev] [PATCH V3 06/24] datapath: fix GFP flags in rtnl_net_notifyid()

2020-09-16 Thread Greg Rose
l Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Backport the datapath.c portion of this fix. Cc: Guillaume Nault Signed-off-by: Greg Rose --- datapath/datapath.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/datapath/datapat

[ovs-dev] [PATCH V3 08/24] datapath: optimize flow-mask looking up

2020-09-16 Thread Greg Rose
| M | NULL |... | NULL | NULL| +---+ This patch don't optimize slow or control path, still using ma->max to traverse. Slow path: * tbl_mask_array_realloc * ovs_flow_tbl_lookup_exact * flow_mask_find Signed-off-by: Tonghao Zhang Tested-by: Greg Ros

[ovs-dev] [PATCH V3 17/24] datapath: remove another BUG_ON()

2020-09-16 Thread Greg Rose
_flow_cmd_del critical section.") Signed-off-by: Paolo Abeni Signed-off-by: David S. Miller Cc: Paolo Abeni Signed-off-by: Greg Rose --- datapath/datapath.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/datapath/datapath.c b/datapath/datapath.c index 87

[ovs-dev] [PATCH V3 04/24] datapath: Print error when ovs_execute_actions() fails

2020-09-16 Thread Greg Rose
ovs_execute_actions() are silently discarded. This patch prints out an debug message when error happens so as to provide helpful hints for debugging. Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Cc: Yifeng Sun Reviewed-by: Yifeng Sun Signed-off-by: Greg Rose --- datapath

[ovs-dev] [PATCH V3 05/24] datapath: Set OvS recirc_id from tc chain index

2020-09-16 Thread Greg Rose
t the local datapath changes from this patch and add compat layer fixup for the DECLARE_STATIC_KEY_FALSE macro. Cc: Paul Blakey Signed-off-by: Greg Rose --- acinclude.m4 | 3 ++ datapath/datapath.c | 34 --- datapath/datap

[ovs-dev] [PATCH V3 00/24] Add support for Linux kernels up to 5.8.x

2020-09-16 Thread Greg Rose
er to add link to passing Travis build in cover letter Eelco Chaudron (1): datapath: return an error instead of doing BUG_ON() Enrico Weigelt (1): datapath: drop unneeded likely() call around IS_ERR() Greg Rose (3): acinclude: Enable builds up to Linux 5.8 travis: Update kernel list as o

[ovs-dev] [PATCH V3 02/24] datapath: drop unneeded likely() call around IS_ERR()

2020-09-16 Thread Greg Rose
around the !IS_ERR() is not needed. Signed-off-by: Enrico Weigelt Signed-off-by: David S. Miller Cc: Enrico Weigelt Signed-off-by: Greg Rose --- datapath/datapath.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath/datapath.c b/datapath/datapath.c index

[ovs-dev] [PATCH V3 01/24] datapath: return an error instead of doing BUG_ON()

2020-09-16 Thread Greg Rose
returned, so it makes sense to do the same for these two error cases. Reported-by: Davide Caratti Signed-off-by: Eelco Chaudron Acked-by: Flavio Leitner Signed-off-by: David S. Miller Cc: Eelco Chaudron Acked-by: Eelco Chaudron Signed-off-by: Greg Rose --- datapath

[ovs-dev] [PATCH v2 11/24] datapath: fix possible memleak on destroy flow-table

2020-09-09 Thread Greg Rose
, so release the flow mask struct. Signed-off-by: Tonghao Zhang Tested-by: Greg Rose Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Added additional compat layer fixup for WRITE_ONCE() Cc: Tonghao Zhang Reviewed-by: Tonghao Zhang Signed-off-by: Greg Rose

[ovs-dev] [PATCH v2 07/24] datapath: don't unlock mutex when changing the user_features fails

2020-09-09 Thread Greg Rose
lowed. Other kernel thread may be in critical section while we unlock it because of setting user_feature fail. Fixes: 95a7233c4 ("net: openvswitch: Set OvS recirc_id from tc chain index") Cc: Paul Blakey Signed-off-by: Tonghao Zhang Tested-by: Greg Rose Acked

[ovs-dev] [PATCH v2 22/24] acinclude: Enable builds up to Linux 5.8

2020-09-09 Thread Greg Rose
Allow building openvswitch against Linux kernels up to and including version 5.8. Signed-off-by: Greg Rose --- acinclude.m4 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/acinclude.m4 b/acinclude.m4 index 3d56510a0..c04e4e429 100644 --- a/acinclude.m4 +++ b/acinclude.m4

[ovs-dev] [PATCH v2 23/24] travis: Update kernel list as of 5.8

2020-09-09 Thread Greg Rose
Update the list to more closely track the LTS releases on kernel.org. Signed-off-by: Greg Rose --- .travis.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 43e6a75cc..9fd8bbe01 100644 --- a/.travis.yml +++ b/.travis.yml @@ -38,8 +38,8

[ovs-dev] [PATCH v2 15/24] datapath: fix flow command message size

2020-09-09 Thread Greg Rose
by: Qi Jun Ding Signed-off-by: Paolo Abeni Signed-off-by: David S. Miller Cc: Paolo Abeni Signed-off-by: Greg Rose --- datapath/datapath.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/datapath/datapath.c b/datapath/datapath.c index b9ac67635..047b3312e 10

[ovs-dev] [PATCH v2 18/24] datapath: support asymmetric conntrack

2020-09-09 Thread Greg Rose
t;) Cc: aaron conole Acked-by: Aaron Conole Signed-off-by: Greg Rose --- datapath/conntrack.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/datapath/conntrack.c b/datapath/conntrack.c index 5b4d6cce0..c7a318baf 100644 --- a/datapath/conntrack.c +++ b/datapath/conntrack.c @

[ovs-dev] [PATCH v2 09/24] datapath: simplify the flow_hash

2020-09-09 Thread Greg Rose
Zhang Tested-by: Greg Rose Acked-by: William Tu Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Cc: Tonghao Zhang Reviewed-by: Tonghao Zhang Signed-off-by: Greg Rose --- datapath/flow_table.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git

[ovs-dev] [PATCH v2 24/24] Documentation: Update faq and NEWS for kernel 5.8

2020-09-09 Thread Greg Rose
Update the NEWS and faq now that we will support up to Linux kernel 5.8. Signed-off-by: Greg Rose --- Documentation/faq/releases.rst | 1 + NEWS | 2 ++ 2 files changed, 3 insertions(+) diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst index

[ovs-dev] [PATCH v2 21/24] datapath: use hlist_for_each_entry_rcu instead of hlist_for_each_entry

2020-09-09 Thread Greg Rose
traversing them, use hlist_for_each_entry_rcu. Signed-off-by: Tonghao Zhang Tested-by: Greg Rose Reviewed-by: Greg Rose Signed-off-by: David S. Miller Compat fixup - OVS doesn't support lockdep_ovsl_is_held() yet Cc: Tonghao Zhang Reviewed-by: Tonghao Zhang Signed-o

[ovs-dev] [PATCH v2 12/24] datapath: simplify the ovs_dp_cmd_new

2020-09-09 Thread Greg Rose
Tested-by: Greg Rose Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Cc: Tonghao Zhang Reviewed-by: Tonghao Zhang Signed-off-by: Greg Rose --- datapath/datapath.c | 60 - 1 file changed, 38 insertions(+), 22 deletions(-) diff

[ovs-dev] [PATCH v2 08/24] datapath: optimize flow-mask looking up

2020-09-09 Thread Greg Rose
| M | NULL |... | NULL | NULL| +---+ This patch don't optimize slow or control path, still using ma->max to traverse. Slow path: * tbl_mask_array_realloc * ovs_flow_tbl_lookup_exact * flow_mask_find Signed-off-by: Tonghao Zhang Tested-by: Greg Ros

[ovs-dev] [PATCH v2 03/24] datapath: do not update max_headroom if new headroom is equal to old headroom

2020-09-09 Thread Greg Rose
size would be changed. If the vport which has the largest headroom is deleted, the new max_headroom would be set. But, if the new headroom size is equal to the old headroom size, updating routine is unnecessary. Signed-off-by: Taehee Yoo Tested-by: Greg Rose Reviewed-by

[ovs-dev] [PATCH v2 10/24] datapath: add likely in flow_lookup

2020-09-09 Thread Greg Rose
ly for performance. Signed-off-by: Tonghao Zhang Tested-by: Greg Rose Acked-by: William Tu Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Cc: Tonghao Zhang Reviewed-by: Tonghao Zhang Signed-off-by: Greg Rose --- datapath/flow_table.c | 4 ++-- 1 file chan

[ovs-dev] [PATCH v2 06/24] datapath: fix GFP flags in rtnl_net_notifyid()

2020-09-09 Thread Greg Rose
l Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Backport the datapath.c portion of this fix. Cc: Guillaume Nault Signed-off-by: Greg Rose --- datapath/datapath.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/datapath/datapat

[ovs-dev] [PATCH v2 20/24] datapath: Distribute switch variables for initialization

2020-09-09 Thread Greg Rose
id S. Miller Cc: Kees Cook Signed-off-by: Greg Rose --- datapath/flow_netlink.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/datapath/flow_netlink.c b/datapath/flow_netlink.c index d3fd77106..996041602 100644 --- a/datapath/flow_netlink.c +++ b/dat

[ovs-dev] [PATCH v2 01/24] datapath: return an error instead of doing BUG_ON()

2020-09-09 Thread Greg Rose
returned, so it makes sense to do the same for these two error cases. Reported-by: Davide Caratti Signed-off-by: Eelco Chaudron Acked-by: Flavio Leitner Signed-off-by: David S. Miller Cc: Eelco Chaudron Signed-off-by: Greg Rose --- datapath/datapath.c | 7 +-- 1

[ovs-dev] [PATCH v2 04/24] datapath: Print error when ovs_execute_actions() fails

2020-09-09 Thread Greg Rose
ovs_execute_actions() are silently discarded. This patch prints out an debug message when error happens so as to provide helpful hints for debugging. Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Cc: Yifeng Sun Reviewed-by: Yifeng Sun Signed-off-by: Greg Rose --- datapath

[ovs-dev] [PATCH v2 17/24] datapath: remove another BUG_ON()

2020-09-09 Thread Greg Rose
_flow_cmd_del critical section.") Signed-off-by: Paolo Abeni Signed-off-by: David S. Miller Cc: Paolo Abeni Signed-off-by: Greg Rose --- datapath/datapath.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/datapath/datapath.c b/datapath/datapath.c index 87

[ovs-dev] [PATCH v2 16/24] datapath: drop unneeded BUG_ON() in ovs_flow_cmd_build_info()

2020-09-09 Thread Greg Rose
vSwitch kernel components.") Signed-off-by: Paolo Abeni Signed-off-by: David S. Miller Cc: Paolo Abeni Signed-off-by: Greg Rose --- datapath/datapath.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/datapath/datapath.c b/datapath/datapath.c index 047b3312e..877

[ovs-dev] [PATCH v2 00/24] Add support for Linux kernels up to 5.8.x

2020-09-09 Thread Greg Rose
l not baked - Updates the travis kernel test list - Adds tags from authors from the first patch series. Eelco Chaudron (1): datapath: return an error instead of doing BUG_ON() Enrico Weigelt (1): datapath: drop unneeded likely() call around IS_ERR() Greg Rose (3): acinclude: Enable b

[ovs-dev] [PATCH v2 02/24] datapath: drop unneeded likely() call around IS_ERR()

2020-09-09 Thread Greg Rose
around the !IS_ERR() is not needed. Signed-off-by: Enrico Weigelt Signed-off-by: David S. Miller Cc: Enrico Weigelt Signed-off-by: Greg Rose --- datapath/datapath.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath/datapath.c b/datapath/datapath.c index

[ovs-dev] [PATCH v2 19/24] datapath: use skb_list_walk_safe helper for gso segments

2020-09-09 Thread Greg Rose
se for the new function, keeping the flow of the existing code as intact as possible. Signed-off-by: Jason A. Donenfeld Signed-off-by: David S. Miller Cc: Jason A. Donenfeld Signed-off-by: Greg Rose --- datapath/datapath.c | 11 --- datapath/li

[ovs-dev] [PATCH v2 14/24] datapath: don't call pad_packet if not necessary

2020-09-09 Thread Greg Rose
ngth of attribute including padding. Cc: Joe Stringer Cc: William Tu Signed-off-by: Tonghao Zhang Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Cc: Tonghao Zhang Reviewed-by: Tonghao Zhang Signed-off-by: Greg Rose --- datapath/datapath.c | 22 -

[ovs-dev] [PATCH v2 05/24] datapath: Set OvS recirc_id from tc chain index

2020-09-09 Thread Greg Rose
t the local datapath changes from this patch and add compat layer fixup for the DECLARE_STATIC_KEY_FALSE macro. Cc: Paul Blakey Signed-off-by: Greg Rose --- acinclude.m4 | 3 ++ datapath/datapath.c | 34 --- datapath/datap

[ovs-dev] [PATCH v2 13/24] datapath: select vport upcall portid directly

2020-09-09 Thread Greg Rose
if so select it directly in fast-path. Signed-off-by: Tonghao Zhang Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Cc: Tonghao Zhang Reviewed-by: Tonghao Zhang Signed-off-by: Greg Rose --- datapath/vport.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff -

[ovs-dev] [PATCH] python: Fixup python shebangs to python3

2020-08-21 Thread Greg Rose
://fedoraproject.org/wiki/Changes/Make_ambiguous_python_shebangs_error Signed-off-by: Greg Rose --- V2 - restrict changes to python files and do not replace @PYTHON3@ for .in files. --- ofproto/ipfix-gen-entities| 4 ++-- ovsdb/dot2pic

[ovs-dev] [PATCH 16/23] datapath: fix flow command message size

2020-08-20 Thread Greg Rose
by: Qi Jun Ding Signed-off-by: Paolo Abeni Signed-off-by: David S. Miller Cc: Paolo Abeni Signed-off-by: Greg Rose --- datapath/datapath.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/datapath/datapath.c b/datapath/datapath.c index b9ac676..047b331 100644 ---

[ovs-dev] [PATCH 20/23] datapath: use skb_list_walk_safe helper for gso segments

2020-08-20 Thread Greg Rose
se for the new function, keeping the flow of the existing code as intact as possible. Signed-off-by: Jason A. Donenfeld Signed-off-by: David S. Miller Cc: Jason A. Donenfeld Signed-off-by: Greg Rose --- datapath/datapath.c | 11 --- datapath/li

[ovs-dev] [PATCH 11/23] datapath: add likely in flow_lookup

2020-08-20 Thread Greg Rose
ly for performance. Signed-off-by: Tonghao Zhang Tested-by: Greg Rose Acked-by: William Tu Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Cc: Tonghao Zhang Signed-off-by: Greg Rose --- datapath/flow_table.c | 4 ++-- 1 file changed, 2 insertions(+), 2 del

[ovs-dev] [PATCH 21/23] datapath: Distribute switch variables for initialization

2020-08-20 Thread Greg Rose
id S. Miller Cc: Kees Cook Signed-off-by: Greg Rose --- datapath/flow_netlink.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/datapath/flow_netlink.c b/datapath/flow_netlink.c index d3fd771..9960416 100644 --- a/datapath/flow_netlink.c +++ b/dat

[ovs-dev] [PATCH 17/23] datapath: drop unneeded BUG_ON() in ovs_flow_cmd_build_info()

2020-08-20 Thread Greg Rose
vSwitch kernel components.") Signed-off-by: Paolo Abeni Signed-off-by: David S. Miller Cc: Paolo Abeni Signed-off-by: Greg Rose --- datapath/datapath.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/datapath/datapath.c b/datapath/datapath.c index 047b331..8

[ovs-dev] [PATCH 19/23] datapath: support asymmetric conntrack

2020-08-20 Thread Greg Rose
uot;) Cc: aaron conole Signed-off-by: Greg Rose --- datapath/conntrack.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/datapath/conntrack.c b/datapath/conntrack.c index 5b4d6cc..c7a318b 100644 --- a/datapath/conntrack.c +++ b/datapath/conntrack.c @@ -978,6 +978,17 @@ static

[ovs-dev] [PATCH 18/23] datapath: remove another BUG_ON()

2020-08-20 Thread Greg Rose
_flow_cmd_del critical section.") Signed-off-by: Paolo Abeni Signed-off-by: David S. Miller Cc: Paolo Abeni Signed-off-by: Greg Rose --- datapath/datapath.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/datapath/datapath.c b/datapath/datapath.c index 877c8

[ovs-dev] [PATCH 22/23] datapath: use hlist_for_each_entry_rcu instead of hlist_for_each_entry

2020-08-20 Thread Greg Rose
traversing them, use hlist_for_each_entry_rcu. Signed-off-by: Tonghao Zhang Tested-by: Greg Rose Reviewed-by: Greg Rose Signed-off-by: David S. Miller Compat fixup - OVS doesn't support lockdep_ovsl_is_held() yet Cc: Tonghao Zhang Signed-off-by: Greg Rose --- dat

[ovs-dev] [PATCH 04/23] datapath: do not update max_headroom if new headroom is equal to old headroom

2020-08-20 Thread Greg Rose
size would be changed. If the vport which has the largest headroom is deleted, the new max_headroom would be set. But, if the new headroom size is equal to the old headroom size, updating routine is unnecessary. Signed-off-by: Taehee Yoo Tested-by: Greg Rose Reviewed-by

[ovs-dev] [PATCH 23/23] Documentation: Update faq and NEWS for kernel 5.9

2020-08-20 Thread Greg Rose
Update the NEWS and faq now that we will support up to Linux kernel 5.9. Signed-off-by: Greg Rose --- Documentation/faq/releases.rst | 2 +- NEWS | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/faq/releases.rst b/Documentation/faq

[ovs-dev] [PATCH 12/23] datapath: fix possible memleak on destroy flow-table

2020-08-20 Thread Greg Rose
, so release the flow mask struct. Signed-off-by: Tonghao Zhang Tested-by: Greg Rose Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Added additional compat layer fixup for WRITE_ONCE() Cc: Tonghao Zhang Signed-off-by: Greg Rose --- datapath/flow_table.c

[ovs-dev] [PATCH 15/23] datapath: don't call pad_packet if not necessary

2020-08-20 Thread Greg Rose
ngth of attribute including padding. Cc: Joe Stringer Cc: William Tu Signed-off-by: Tonghao Zhang Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Cc: Tonghao Zhang Signed-off-by: Greg Rose --- datapath/datapath.c | 22 -- 1 file changed, 8

[ovs-dev] [PATCH 09/23] datapath: optimize flow-mask looking up

2020-08-20 Thread Greg Rose
| M | NULL |... | NULL | NULL| +---+ This patch don't optimize slow or control path, still using ma->max to traverse. Slow path: * tbl_mask_array_realloc * ovs_flow_tbl_lookup_exact * flow_mask_find Signed-off-by: Tonghao Zhang Tested-by: Greg Ros

[ovs-dev] [PATCH 07/23] datapath: fix GFP flags in rtnl_net_notifyid()

2020-08-20 Thread Greg Rose
l Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Backport the datapath.c portion of this fix. Cc: Guillaume Nault Signed-off-by: Greg Rose --- datapath/datapath.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/datapath/datapat

[ovs-dev] [PATCH 10/23] datapath: simplify the flow_hash

2020-08-20 Thread Greg Rose
Zhang Tested-by: Greg Rose Acked-by: William Tu Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Cc: Tonghao Zhang Signed-off-by: Greg Rose --- datapath/flow_table.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/datapath/flow_table.c b

[ovs-dev] [PATCH 13/23] datapath: simplify the ovs_dp_cmd_new

2020-08-20 Thread Greg Rose
Tested-by: Greg Rose Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Cc: Tonghao Zhang Signed-off-by: Greg Rose --- datapath/datapath.c | 60 + 1 file changed, 38 insertions(+), 22 deletions(-) diff --git a/datapath

[ovs-dev] [PATCH 03/23] datapath: drop unneeded likely() call around IS_ERR()

2020-08-20 Thread Greg Rose
around the !IS_ERR() is not needed. Signed-off-by: Enrico Weigelt Signed-off-by: David S. Miller Cc: Enrico Weigelt Signed-off-by: Greg Rose --- datapath/datapath.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath/datapath.c b/datapath/datapath.c index

[ovs-dev] [PATCH 06/23] datapath: Set OvS recirc_id from tc chain index

2020-08-20 Thread Greg Rose
t the local datapath changes from this patch and add compat layer fixup for the DECLARE_STATIC_KEY_FALSE macro. Cc: Paul Blakey Signed-off-by: Greg Rose --- acinclude.m4 | 3 +++ datapath/datapath.c | 34 +--- dat

[ovs-dev] [PATCH 14/23] datapath: select vport upcall portid directly

2020-08-20 Thread Greg Rose
if so select it directly in fast-path. Signed-off-by: Tonghao Zhang Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Cc: Tonghao Zhang Signed-off-by: Greg Rose --- datapath/vport.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/datapath/vport.c b/d

[ovs-dev] [PATCH 08/23] datapath: don't unlock mutex when changing the user_features fails

2020-08-20 Thread Greg Rose
lowed. Other kernel thread may be in critical section while we unlock it because of setting user_feature fail. Fixes: 95a7233c4 ("net: openvswitch: Set OvS recirc_id from tc chain index") Cc: Paul Blakey Signed-off-by: Tonghao Zhang Tested-by: Greg Rose Acked

[ovs-dev] [PATCH 02/23] datapath: return an error instead of doing BUG_ON()

2020-08-20 Thread Greg Rose
returned, so it makes sense to do the same for these two error cases. Reported-by: Davide Caratti Signed-off-by: Eelco Chaudron Acked-by: Flavio Leitner Signed-off-by: David S. Miller Cc: Eelco Chaudron Signed-off-by: Greg Rose --- datapath/datapath.c | 7 +-- 1

[ovs-dev] [PATCH 00/23] Add support for Linux kernels up to 5.9.x

2020-08-20 Thread Greg Rose
call around IS_ERR() Greg Rose (2): acinclude: Enable builds up to Linux 5.9 Documentation: Update faq and NEWS for kernel 5.9 Guillaume Nault (1): datapath: fix GFP flags in rtnl_net_notifyid() Jason A. Donenfeld (1): datapath: use skb_list_walk_safe helper for gso segments Kees Co

[ovs-dev] [PATCH 01/23] acinclude: Enable builds up to Linux 5.9

2020-08-20 Thread Greg Rose
Allow building openvswitch against Linux kernels up to and including version 5.9. Signed-off-by: Greg Rose squash --- acinclude.m4 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/acinclude.m4 b/acinclude.m4 index 84f344d..263c9f4 100644 --- a/acinclude.m4 +++ b

[ovs-dev] [PATCH 05/23] datapath: Print error when ovs_execute_actions() fails

2020-08-20 Thread Greg Rose
ovs_execute_actions() are silently discarded. This patch prints out an debug message when error happens so as to provide helpful hints for debugging. Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Cc: Yifeng Sun Signed-off-by: Greg Rose --- datapath/datapath.c | 7 +-- 1

[ovs-dev] [PATCH V2] rhel: ovs-kmod-manage.sh: Disable unneeded warning

2020-08-20 Thread Greg Rose
The script itself says which versions the script is needed for but it is run on RHEL 8.x as well where it is not needed. Disable the warning and change the exit code to zero since it may unnecessarily alarm users and is really only for debugging anyway. Signed-off-by: Greg Rose --- V2 - As per

[ovs-dev] [PATCH] rhel: ovs-kmod-manage.sh: Disable unneeded warning

2020-08-20 Thread Greg Rose
The script itself says which versions the script is needed for but it is run on RHEL 8.x as well where it is not needed. Disable the warning since it may unnecessarily alarm users and is really only for debugging anyway. Signed-off-by: Greg Rose --- rhel/usr_share_openvswitch_scripts_ovs-kmod

[ovs-dev] [PATCH] python: Fixup python shebangs to python3

2020-08-18 Thread Greg Rose
://fedoraproject.org/wiki/Changes/Make_ambiguous_python_shebangs_error Signed-off-by: Greg Rose --- ipsec/ovs-monitor-ipsec.in| 4 ++-- ofproto/ipfix-gen-entities| 4 ++-- ovsdb/dot2pic | 4 ++-- ovsdb

[ovs-dev] [PATCH] rpm-fedora: Add missing dist library

2020-07-14 Thread Greg Rose
libopenvswitchavx512.a is needed for the fedora rpm spec. Signed-off-by: Greg Rose --- rhel/openvswitch-fedora.spec.in | 1 + 1 file changed, 1 insertion(+) diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in index 7bc8c34..154b49e 100644 --- a/rhel/openvswitch

[ovs-dev] [PATCH] compat: Backport ipv6_stub change

2020-05-21 Thread Greg Rose
vxlan and geneve modules. Passes Travis here: https://travis-ci.org/github/gvrose8192/ovs-experimental/builds/689798733 Signed-off-by: Greg Rose --- acinclude.m4 | 2 ++ datapath/linux/compat/geneve.c | 11 ++- datapath/linux/compat/vxlan.c | 18 +

[ovs-dev] [PATCH] Documentation: Fix kernel support matrix

2020-05-19 Thread Greg Rose
-at: https://mail.openvswitch.org/pipermail/ovs-dev/2020-May/370742.html Signed-off-by: Greg Rose --- Documentation/faq/releases.rst | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst index 3903e59..e5cef39

[ovs-dev] [PATCH V2] compat: Fix broken partial backport of extack op parameter

2020-04-14 Thread Greg Rose
ub/gvrose8192/ovs-experimental/builds/674599698 Passes a kernel check-kmod test on several systems, including sles12 sp4 4.12.14-95.48-default kernel, without any regressions. VMWare-BZ: #2544032 Signed-off-by: Greg Rose --- V2 - Fix comment for OVS_FIND_OP_PARAM_IFELSE function and d

[ovs-dev] [PATCH] compat: Fix broken partial backport of extack op parameter

2020-04-14 Thread Greg Rose
ub/gvrose8192/ovs-experimental/builds/674599698 Passes a kernel check-kmod test on several systems, including sles12 sp4 4.12.14-95.48-default kernel, without any regressions. Signed-off-by: Greg Rose --- acinclude.m4 | 34 ++ datapath/

[ovs-dev] [PATCH V2 1/2] compat: Fix nf_ip_hook parameters for RHEL 8

2020-03-24 Thread Greg Rose
From: Greg Rose A RHEL release version check was only checking for RHEL releases greater than 7.0 so that ended up including a compat fixup that is not needed for 8.0. Fix up the version check. Signed-off-by: Greg Rose --- datapath/linux/compat/stt.c | 2 +- 1 file changed, 1 insertion(+), 1

[ovs-dev] [PATCH V2 2/2] Documentation: Add extra repo info for RHEL 8

2020-03-24 Thread Greg Rose
The extra development repo for RHEL 8 has changed. Document it. Signed-off-by: Greg Rose --- V2 - Break long line --- Documentation/intro/install/fedora.rst | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/intro/install/fedora.rst b/Documentation/intro/install/fedora.rst

[ovs-dev] [PATCH 1/2] compat: Fix nf_ip_hook parameters for RHEL 8

2020-03-19 Thread Greg Rose
A RHEL release version check was only checking for RHEL releases greater than 7.0 so that ended up including a compat fixup that is not needed for 8.0. Fix up the version check. Signed-off-by: Greg Rose --- datapath/linux/compat/stt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[ovs-dev] [PATCH 2/2] Documentation: Add extra repo info for RHEL 8

2020-03-19 Thread Greg Rose
The extra development repo for RHEL 8 has changed. Document it. Signed-off-by: Greg Rose --- Documentation/intro/install/fedora.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/intro/install/fedora.rst b/Documentation/intro/install/fedora.rst index 6fe1fb5..de00c4c

[ovs-dev] [PATCH] Documentation: Add note about iproute2 requirements for check-kmod

2020-03-11 Thread Greg Rose
. Signed-off-by: Greg Rose --- Documentation/topics/testing.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/Documentation/topics/testing.rst b/Documentation/topics/testing.rst index 161e9d4..b9fa94d 100644 --- a/Documentation/topics/testing.rst +++ b/Documentation/topics

[ovs-dev] [PATCH V4 1/9] acinclude: Enable Linux kernel 5.5

2020-03-06 Thread Greg Rose
Acked-by: Yi-Hung Wei Signed-off-by: Greg Rose --- V4 - Fix up the error message indicating that kernels greater than 5.5 are not supported. --- acinclude.m4 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/acinclude.m4 b/acinclude.m4 index 9338af9..03d3484 100644

[ovs-dev] [PATCH V4 5/9] datapath: Use sizeof_field macro

2020-03-06 Thread Greg Rose
.bharad...@intel.com Co-developed-by: Kees Cook Signed-off-by: Kees Cook Acked-by: David Miller # for net Also added a compatibility layer macro for older kernels that still use FIELD_SIZEOF Acked-by: Yi-Hung Wei Signed-off-by: Greg Rose --- V3 - As suggested by Yi-Hung go ahead an

[ovs-dev] [PATCH V4 7/9] compat: Use nla_parse deprecated functions

2020-03-06 Thread Greg Rose
changes to support older kernels. Acked-by: Yi-Hung Wei Signed-off-by: Greg Rose --- V3 - As per Yi-Hung's suggestion just backport the upstream patch to stay in sync with upstream kernel code. --- acinclude.m4| 3 +++ datapath/datapath.c

[ovs-dev] [PATCH V4 2/9] compat: Fix up changes to inet frags in 5.1+

2020-03-06 Thread Greg Rose
. Acked-by: Yi-Hung Wei Signed-off-by: Greg Rose --- V3 - Use HAVE_CORRECT_MRU_HANDLING instead of less reliable kernel version check for compile time handling of the rb_fragments change. --- acinclude.m4 | 2 ++ datapath/linux/compat/include/net

[ovs-dev] [PATCH V4 0/9] Add Linux kernel datapath support up to 5.5

2020-03-06 Thread Greg Rose
The patch series enables OVS kernel datapath support up to release 5.5. Updates the faq and NEWS as well. Passes Travis here: https://travis-ci.org/gvrose8192/ovs-experimental/builds/658424074 Passes check-kmod with no regressions on Ubuntu 16.04 and Ubuntu 18.04 distros. Greg Rose (5

<    1   2   3   4   5   6   7   8   9   10   >