[ovs-dev] [PATCH V3 2/9] compat: Fix up changes to inet frags in 5.1+

. Signed-off-by: Greg Rose --- V3 - Use HAVE_CORRECT_MRU_HANDLING instead of less reliable kernel version check for compile time handling of the rb_fragments change. --- acinclude.m4 | 2 ++ datapath/linux/compat/include/net/inet_frag.h | 14

[ovs-dev] [PATCH V3 8/9] datapath: conntrack: mark expected switch fall-through

ough, mark switch cases where we are expecting to fall through. Notice that in this particular case I placed a "fall through" comment on its own line, which is what GCC is expecting to find. Signed-off-by: Gustavo A. R. Silva Signed-off-by: David S. Miller Sign

[ovs-dev] [PATCH V3 9/9] datapath: Update kernel test list

We are adding support for Linux kernels up to 5.5 so update the Travis test list, NEWS and FAQ. Signed-off-by: Greg Rose --- V3 - Squash separate commits for Travis, NEWS and FAQ --- .travis.yml| 2 +- Documentation/faq/releases.rst | 1 + NEWS | 2

[ovs-dev] [PATCH V3 4/9] compat: Remove flex_array code

Flex array support is removed since kernel 5.1. Convert to use kvmalloc_array instead. Signed-off-by: Greg Rose --- datapath/linux/compat/stt.c | 28 ++-- 1 file changed, 10 insertions(+), 18 deletions(-) diff --git a/datapath/linux/compat/stt.c b/datapath/linux/compat

[ovs-dev] [PATCH V3 3/9] compat: Move genl_ops policy to genl_family

support older kernels. Signed-off-by: Greg Rose --- V3 - Add policy back to genl_family instead of completely removing it. --- acinclude.m4 | 3 +++ datapath/conntrack.c | 9 + datapath/datapath.c | 38 ++ datapath/meter.c | 11 +++

[ovs-dev] [PATCH V3 7/9] compat: Use nla_parse deprecated functions

support older kernels. Signed-off-by: Greg Rose --- V3 - As per Yi-Hung's suggestion just backport the upstream patch to stay in sync with upstream kernel code. --- acinclude.m4| 3 +++ datapath/datapath.c | 4 ++-- datapath/flow_

[ovs-dev] [PATCH V3 1/9] acinclude: Enable Linux kernel 5.5

Signed-off-by: Greg Rose --- acinclude.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/acinclude.m4 b/acinclude.m4 index 1212a46..db64267 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -151,7 +151,7 @@ AC_DEFUN([OVS_CHECK_LINUX], [ AC_MSG_RESULT([$kversion

[ovs-dev] [PATCH V2 06/11] compat: Add FIELD_SIZEOF macro

The FIELD_SIZEOF macro is removed in Linux kernel release 5.5 but is still needed in our out of tree kernel module for compatibility with older kernels. Signed-off-by: Greg Rose --- datapath/linux/compat/include/linux/kernel.h | 4 1 file changed, 4 insertions(+) diff --git a/datapath

[ovs-dev] [PATCH V2 08/11] Travis: Update kernel test list

We are adding support for Linux kernels up to 5.5 so update the Travis test list. Signed-off-by: Greg Rose --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index abd2a91..ef9f867 100644 --- a/.travis.yml +++ b/.travis.yml @@ -38,7

[ovs-dev] [PATCH V2 10/11] FAQ: Update with latest Linux 5.5 kernel support

Signed-off-by: Greg Rose --- Documentation/faq/releases.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst index 6ff47d7..a073b97 100644 --- a/Documentation/faq/releases.rst +++ b/Documentation/faq/releases.rst @@ -70,6 +70,7

[ovs-dev] [PATCH V2 03/11] compat: Remove genl_ops policy field for newer kernels

The policy field of the genl_ops structure has been removed in recent kernels. Signed-off-by: Greg Rose --- acinclude.m4 | 3 +++ datapath/conntrack.c | 8 datapath/datapath.c | 32 datapath/meter.c | 10 ++ 4 files changed, 53

[ovs-dev] [PATCH V2 02/11] compat: Fix up changes to inet frags in 5.1+

. Signed-off-by: Greg Rose --- acinclude.m4 | 2 ++ datapath/linux/compat/include/net/inet_frag.h | 21 + 2 files changed, 23 insertions(+) diff --git a/acinclude.m4 b/acinclude.m4 index db64267..cad76c7 100644 --- a/acinclude.m4 +++ b

[ovs-dev] [PATCH V2 09/11] compat: Use nla_parse deprecated functions

Changes for in kernel generated netlink attribute parsing functions require our out of tree driver to use the deprecated forms of those functions. Otherwise the message parsing will return -EINVAL because NLA_F_NESTED is not set in the nla_type field. Signed-off-by: Greg Rose --- acinclude.m4

[ovs-dev] [PATCH V2 07/11] datapath: Kbuild: Add kcompat.h header to front of NOSTDINC

robability of success but something we could ask about. For now we cheat and take the easy way out. Reported-by: David Ahern Signed-off-by: Greg Rose --- datapath/linux/Kbuild.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath/linux/Kbuild.in b/datapath/linux/Kbuil

[ovs-dev] [PATCH V2 05/11] datapath: Fix case statement fall through warning

Add an explicit "Falls Through" comment to fix the warning. Signed-off-by: Greg Rose --- datapath/conntrack.c | 1 + 1 file changed, 1 insertion(+) diff --git a/datapath/conntrack.c b/datapath/conntrack.c index 25da2a5..ad49daa 100644 --- a/datapath/conntrack.c +++ b/datapath/c

[ovs-dev] [PATCH V2 04/11] compat: Remove flex_array code

Flex array support is removed since kernel 5.1. Convert to use kvmalloc_array instead. Signed-off-by: Greg Rose --- datapath/linux/compat/stt.c | 28 ++-- 1 file changed, 10 insertions(+), 18 deletions(-) diff --git a/datapath/linux/compat/stt.c b/datapath/linux/compat

[ovs-dev] [PATCH V2 01/11] acinclude: Enable Linux kernel 5.5

Signed-off-by: Greg Rose --- acinclude.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/acinclude.m4 b/acinclude.m4 index 1212a46..db64267 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -151,7 +151,7 @@ AC_DEFUN([OVS_CHECK_LINUX], [ AC_MSG_RESULT([$kversion

[ovs-dev] [PATCH V2 00/11] Add Linux kernel datapath support up to 5.5

and NEWS updates Greg Rose (11): acinclude: Enable Linux kernel 5.5 compat: Fix up changes to inet frags in 5.1+ compat: Remove genl_ops policy field for newer kernels compat: Remove flex_array code datapath: Fix case statement fall through warning compat: Add FIELD_SIZEOF macro datapath

[ovs-dev] [PATCH V2 11/11] NEWS: Add news about support for Linux kernel 5.5

Signed-off-by: Greg Rose --- NEWS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/NEWS b/NEWS index f62ef1f..6f6b61f 100644 --- a/NEWS +++ b/NEWS @@ -4,6 +4,8 @@ Post-v2.13.0 - OpenFlow: * The OpenFlow ofp_desc/serial_num may now be configured by setting the value

[ovs-dev] [PATCH 4/9] compat: Remove flex_array code

Flex array support is removed since kernel 5.1. Convert to use kvmalloc_array instead. Signed-off-by: Greg Rose --- datapath/linux/compat/stt.c | 28 ++-- 1 file changed, 10 insertions(+), 18 deletions(-) diff --git a/datapath/linux/compat/stt.c b/datapath/linux/compat

[ovs-dev] [PATCH 9/9] compat: Use nla_parse deprecated functions

Changes for in kernel generated netlink attribute parsing functions require our out of tree driver to use the deprecated forms of those functions. Otherwise the message parsing will return -EINVAL because NLA_F_NESTED is not set in the nla_type field. Signed-off-by: Greg Rose --- acinclude.m4

[ovs-dev] [PATCH 1/9] acinclude: Enable Linux kernel 5.5

Signed-off-by: Greg Rose --- acinclude.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/acinclude.m4 b/acinclude.m4 index 1212a46..db64267 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -151,7 +151,7 @@ AC_DEFUN([OVS_CHECK_LINUX], [ AC_MSG_RESULT([$kversion

[ovs-dev] [PATCH 5/9] datapath: Fix case statement fall through warning

Add an explicit "Falls Through" comment to fix the warning. Signed-off-by: Greg Rose --- datapath/conntrack.c | 1 + 1 file changed, 1 insertion(+) diff --git a/datapath/conntrack.c b/datapath/conntrack.c index 25da2a5..ad49daa 100644 --- a/datapath/conntrack.c +++ b/datapath/c

[ovs-dev] [PATCH 7/9] datapath: Kbuild: Add kcompat.h header to front of NOSTDINC

robability of success but something we could ask about. For now we cheat and take the easy way out. Reported-by: David Ahern Signed-off-by: Greg Rose --- datapath/linux/Kbuild.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath/linux/Kbuild.in b/datapath/linux/Kbuil

[ovs-dev] [PATCH 6/9] compat: Add FIELD_SIZEOF macro

The FIELD_SIZEOF macro is removed in Linux kernel release 5.5 but is still needed in our out of tree kernel module for compatibility with older kernels. Signed-off-by: Greg Rose --- datapath/linux/compat/include/linux/kernel.h | 4 1 file changed, 4 insertions(+) diff --git a/datapath

[ovs-dev] [PATCH 3/9] compat: Remove genl_ops policy field for newer kernels

The policy field of the genl_ops structure has been removed in recent kernels. Signed-off-by: Greg Rose --- acinclude.m4 | 3 +++ datapath/conntrack.c | 8 datapath/datapath.c | 32 datapath/meter.c | 10 ++ 4 files changed, 53

[ovs-dev] [PATCH 2/9] compat: Fix up changes to inet frags in 5.1+

. Signed-off-by: Greg Rose --- acinclude.m4 | 2 ++ datapath/linux/compat/include/net/inet_frag.h | 21 + 2 files changed, 23 insertions(+) diff --git a/acinclude.m4 b/acinclude.m4 index db64267..cad76c7 100644 --- a/acinclude.m4 +++ b

[ovs-dev] [PATCH 8/9] Travis: Update kernel test list

We are adding support for Linux kernels up to 5.5 so update the Travis test list. Signed-off-by: Greg Rose --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index abd2a91..ef9f867 100644 --- a/.travis.yml +++ b/.travis.yml @@ -38,7

[ovs-dev] [PATCH] compat: Remove HAVE_BOOL_TYPE

OVS only supports Linux kernels since 3.10 and all kernels since then have the bool type. This check is unnecessary so remove it. Passes Travis: https://travis-ci.org/gvrose8192/ovs-experimental/builds/644103253 Signed-off-by: Greg Rose --- acinclude.m4 | 2

[ovs-dev] [PATCH] kbuild: Include external modules compile flags

e's Kbuild. Make sure to include the external kernel module's Kbuild so that the necessary command line flags from the external module are set. Reported-by: David Ahern CC: Masahiro Yamada Signed-off-by: Greg Rose --- scripts/Makefile.modfinal | 4 1 file changed, 4 insertions(+)

[ovs-dev] [PATCH] compat: Include confirm_neigh parameter if needed

Signed-off-by: Greg Rose --- acinclude.m4 | 2 ++ datapath/linux/compat/ip6_gre.c | 4 datapath/linux/compat/ip_tunnel.c | 5 + 3 files changed, 11 insertions(+) diff --git a/acinclude.m4 b/acinclude.m4 index 542637a..18264c4 100644 --- a/acinclude.m4 +++ b

[ovs-dev] [PATCH] datapath: make generic netlink group const

-experimental/builds/616880002 Cc: Stephen Hemminger Signed-off-by: Greg Rose --- datapath/datapath.c | 21 +++-- datapath/datapath.h | 2 +- 2 files changed, 12 insertions(+), 11 deletions(-) diff --git a/datapath/datapath.c b/datapath/datapath.c index 8a9e54f..853bfb5 100644

[ovs-dev] [PATCH] compat: Add missing inline keyword

The missing inline keyword before the definition of the rpl_nf_ct_tmpl_free() function causes spurious warnings about the function not being used on some older kernels. Add the keyword to suppress the warning. Signed-off-by: Greg Rose --- datapath/linux/compat/include/net/netfilter

[ovs-dev] [PATCH V2] ip_gre: Remove even more unused code

-ci.org/gvrose8192/ovs-experimental/builds/607296133 Fixes: d5822f428814 ("gre: Remove dead ipgre code") Signed-off-by: Greg Rose --- V2 - Send the right patch this time --- datapath/linux/compat/ip_gre.c | 102 - 1 file changed, 102 deletions(-)

[ovs-dev] [PATCH] Revert "ip_gre: Remove even more unused code"

This reverts commit 42a059e02bf343787951be2824c579e1c9a26e12. Not all the necessary ipgre prefixed code was removed that should have been. Another patch will follow with the correct removed code. Signed-off-by: Greg Rose --- datapath/linux/compat/ip_gre.c | 38

[ovs-dev] [PATCH] ip_gre: Remove even more unused code

There is a confusing mix of ipgre and gretap functions with some needed for gretap still having ipgre_ prefixes. This time though I think I got the rest of the unused ipgre code. Fixes: d5822f428814 ("gre: Remove dead ipgre code") Signed-off-by: Greg Rose --- datapath/linux/compa

[ovs-dev] [PATCH] ip_gre: Removed unused ipgre netdev ops

When cleaning up unused ipgre code the ipgre_netdev_ops structure was missed. Get rid of it now. Fixes: d5822f428814 ("gre: Remove dead ipgre code") Signed-off-by: Greg Rose --- datapath/linux/compat/ip_gre.c | 16 1 file changed, 16 deletions(-) diff --git a/data

[ovs-dev] [PATCH] compat: Fix small naming issue

In commit 057772cf2477 the function is missing the rpl_ prefix and the define that replaces the original function should come after the function definition. Fixes: 057772cf2477 ("compat: Backport nf_ct_tmpl_alloc().") Signed-off-by: Greg Rose --- datapath/linux/compat/include/net

[ovs-dev] [PATCH 5/5] datapath: compat: drop bridge nf reset from nf_reset

commit that applies to openvswitch. Cc: Florian Westphal Signed-off-by: Greg Rose --- acinclude.m4 | 1 + datapath/linux/compat/include/linux/skbuff.h | 4 datapath/vport-internal_dev.c| 2 +- 3 files changed, 6 insertions(+), 1 deletion(-) diff --

[ovs-dev] [PATCH 4/5] datapath: rename flow_stats to sw_flow_stats

in OVS to sw_flow_stats since this structure is contained in sw_flow. Signed-off-by: Pablo Neira Ayuso Acked-by: Jiri Pirko Signed-off-by: David S. Miller Cc: Pablo Neira Ayuso Signed-off-by: Greg Rose --- datapath/flow.c | 8 datapath/flow.h | 4

[ovs-dev] [PATCH 3/5] compat: remove the incorrect mtu limit for erspan

f:ff:ff:ff promiscuity 0 minmtu 68 maxmtu 0 Fixes: 61e84623ace3 ("net: centralize net_device min/max MTU checking") Signed-off-by: Haishuang Yan Signed-off-by: David S. Miller Cc: Haishuang Yan Signed-off-by: Greg Rose --- datapath/linux/compat/ip_gre.c | 3 +++ 1 file c

[ovs-dev] [PATCH 2/5] datapath: change type of UPCALL_PID attribute to NLA_UNSPEC

3 ("datapath: Allow each vport to have an array of 'port_id's.") Cc: Li RongQing Signed-off-by: Greg Rose --- datapath/datapath.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath/datapath.c b/datapath/datapath.c index 15af156..a787276 100644 --- a/datap

[ovs-dev] [PATCH 1/5] datapath: hide clang frame-overflow warnings

apath: Avoid using stack larger than 1024.") Signed-off-by: Arnd Bergmann Signed-off-by: David S. Miller Cc: Arnd Bergmann Signed-off-by: Greg Rose --- datapath/datapath.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/datapath/datapath.c

[ovs-dev] [PATCH 0/5] Backport upstream Linux kernel patches

on Ubuntu 16.04 and 18.04 Arnd Bergmann (1): datapath: hide clang frame-overflow warnings Greg Rose (1): datapath: compat: drop bridge nf reset from nf_reset Haishuang Yan (1): compat: remove the incorrect mtu limit for erspan Li RongQing (1): datapath: change type of UPCALL_PID attribute

[ovs-dev] [PATCH 2/2] datapath: Make metadata_dst tunnel work in IP_TUNNEL_INFO_BRIDGE mode

to make the compiler happy. Cc: wenxu Signed-off-by: Greg Rose --- datapath/flow_netlink.c | 46 ++- datapath/linux/compat/include/linux/openvswitch.h | 1 + lib/odp-util.c| 2 + 3 files changed, 39 insertions

[ovs-dev] [PATCH 1/2] compat: Backport IP_TUNNEL_INFO_BRIDGE

. Used by bridge driver later in the series to pass per vlan dst metadata to bridge ports. Signed-off-by: Roopa Prabhu Signed-off-by: David S. Miller Cc: Roopa Prabhu Signed-off-by: Greg Rose --- datapath/linux/compat/include/net/ip_tunnels.h | 1 + 1 file changed, 1 insertion

[ovs-dev] [PATCH] acinclude: Fix false positive search for prandom_u32

/builds/595171808 Signed-off-by: Greg Rose --- acinclude.m4 | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/acinclude.m4 b/acinclude.m4 index c729266..066c134 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -723,7 +723,9 @@ AC_DEFUN([OVS_CHECK_LINUX_COMPAT

[ovs-dev] [PATCH] tests: Only run test on kernel datapath

comments with a short explanation. Fixes: d7fd61a ("tests: Add check for correct l3l4 conntrack frag reassembly") Suggested-by: Darrell Ball Signed-off-by: Greg Rose --- tests/system-kmod-macros.at | 7 +++ tests/system-traffic.at | 5 - tests/system-userspace-macr

[ovs-dev] [PATCH v2] tests: Add check for correct l3l4 conntrack frag reassembly

at the udp srce port is actually the correct value of 5001. Tested by reverting the above commits and observing that the test then fails. Signed-off-by: Greg Rose --- V2 - Break up long lines with dnl to help with email formatting --- tests/system-traffic.at | 26 ++ 1 file ch

[ovs-dev] [PATCH] tests: Add check for correct l3l4 conntrack frag reassembly

at the udp srce port is actually the correct value of 5001. Tested by reverting the above commits and observing that the test then fails. Signed-off-by: Greg Rose --- tests/system-traffic.at | 21 + 1 file changed, 21 insertions(+) diff --git a/tests/system-traffic.at b/tests/sys

[ovs-dev] [PATCH branch-2.8] compat: Fixup ipv6 fragmentation on 4.9.135+ kernels

s://travis-ci.org/gvrose8192/ovs-experimental/builds/587124329 Cc: William Tu Cc: Yi-Hung Wei Cc: Yifeng Sun Acked-by: Yi-Hung Wei Signed-off-by: Greg Rose Signed-off-by: Ben Pfaff --- .travis.yml| 2 +- acinclude.m4 | 3 ++ data

[ovs-dev] [PATCH branch-2.7] compat: Fixup ipv6 fragmentation on 4.9.135+ kernels

vis-ci.org/gvrose8192/ovs-experimental/builds/587124155 Cc: William Tu Cc: Yi-Hung Wei Cc: Yifeng Sun Acked-by: Yi-Hung Wei Signed-off-by: Greg Rose Signed-off-by: Ben Pfaff --- .travis.yml| 2 +- acinclude.m4 | 4 ++- datapath/li

[ovs-dev] [PATCH branch-2.6] compat: Fixup ipv6 fragmentation on 4.9.135+ kernels

perimental/builds/587185472 Cc: William Tu Cc: Yi-Hung Wei Cc: Yifeng Sun Acked-by: Yi-Hung Wei Signed-off-by: Greg Rose Signed-off-by: Ben Pfaff --- acinclude.m4 | 4 ++- datapath/linux/compat/nf_conntrack_reasm.c | 52 -- 2 files c

[ovs-dev] [PATCH V2 branch-2.8 2/2] datapath: Clear the L4 portion of the key for "later" fragments

ater" fragments. This patch clears the L4 fields in that circumstance to prevent sending those garbage values as part of the upcall. Signed-off-by: Justin Pettit Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Signed-off-by: Greg Rose --- V2 - Fix compile

[ovs-dev] [PATCH V2 branch-2.8 1/2] datapath: Properly set L4 keys on "later" IP fragments

Upstream commit: commit ad06a566e118e57b852cab5933dbbbaebb141de3 Author: Greg Rose Date: Tue Aug 27 07:58:09 2019 -0700 openvswitch: Properly set L4 keys on "later" IP fragments When IP fragments are reassembled before being sent to conntrack, the key fro

[ovs-dev] [PATCH V2 branch-2.7 1/2] datapath: Properly set L4 keys on "later" IP fragments

Upstream commit: commit ad06a566e118e57b852cab5933dbbbaebb141de3 Author: Greg Rose Date: Tue Aug 27 07:58:09 2019 -0700 openvswitch: Properly set L4 keys on "later" IP fragments When IP fragments are reassembled before being sent to conntrack, the key fro

[ovs-dev] [PATCH V2 branch-2.7 2/2] datapath: Clear the L4 portion of the key for "later" fragments

ater" fragments. This patch clears the L4 fields in that circumstance to prevent sending those garbage values as part of the upcall. Signed-off-by: Justin Pettit Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Signed-off-by: Greg Rose --- V2 - Fix compile

[ovs-dev] [PATCH V2 branch-2.6 1/2] datapath: Properly set L4 keys on "later" IP fragments

Upstream commit: commit ad06a566e118e57b852cab5933dbbbaebb141de3 Author: Greg Rose Date: Tue Aug 27 07:58:09 2019 -0700 openvswitch: Properly set L4 keys on "later" IP fragments When IP fragments are reassembled before being sent to conntrack, the key fro

[ovs-dev] [PATCH V2 branch-2.6 2/2] datapath: Clear the L4 portion of the key for "later" fragments

ater" fragments. This patch clears the L4 fields in that circumstance to prevent sending those garbage values as part of the upcall. Signed-off-by: Justin Pettit Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Signed-off-by: Greg Rose --- V2 - Fix compile

[ovs-dev] [PATCH V2 branch-2.5 2/2] datapath: Clear the L4 portion of the key for "later" fragments

ater" fragments. This patch clears the L4 fields in that circumstance to prevent sending those garbage values as part of the upcall. Signed-off-by: Justin Pettit Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Signed-off-by: Greg Rose --- V2 - Fix compile

[ovs-dev] [PATCH V2 branch-2.5 1/2] datapath: Properly set L4 keys on "later" IP fragments

Upstream commit: commit ad06a566e118e57b852cab5933dbbbaebb141de3 Author: Greg Rose Date: Tue Aug 27 07:58:09 2019 -0700 openvswitch: Properly set L4 keys on "later" IP fragments When IP fragments are reassembled before being sent to conntrack, the key fro

[ovs-dev] [PATCH] rhel: Revert RHEL 7.4 comp_ver change

I looked at the wrong list of kernels when I changed the value for the RHEL 7.4 comp_ver variable. Revert that part of commit e64c2c1 ("rhel: Fix ovs-kmod-manage.sh to work with RHEL 7.3"). Fixes: e64c2c1 ("rhel: Fix ovs-kmod-manage.sh to work with RHEL 7.3") Signed-off-by:

[ovs-dev] [PATCH] rhel: Fix ovs-kmod-manage.sh to work with RHEL 7.3

Add case for RHEL 7.3. This also fixes commit 22abff2 where I forgot to update the comp_ver variable for RHEL 7.5 and while I was in there I updated comp_ver for the RHEL 7.4 case as well. Fixes: 22abff2 ("rhel: Add case for RHEL 7.5 major version to...") Signed-off-by: Greg Rose

[ovs-dev] [PATCH branch-2.9 2/2] datapath: Clear the L4 portion of the key for "later" fragments

ater" fragments. This patch clears the L4 fields in that circumstance to prevent sending those garbage values as part of the upcall. Signed-off-by: Justin Pettit Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Signed-off-by: Greg Rose Signed-off-by: Justin P

[ovs-dev] [PATCH branch-2.9 1/2] datapath: Properly set L4 keys on "later" IP fragments

Upstream commit: commit ad06a566e118e57b852cab5933dbbbaebb141de3 Author: Greg Rose Date: Tue Aug 27 07:58:09 2019 -0700 openvswitch: Properly set L4 keys on "later" IP fragments When IP fragments are reassembled before being sent to conntrack, the key fro

[ovs-dev] [PATCH branch-2.8 2/2] datapath: Clear the L4 portion of the key for "later" fragments

ater" fragments. This patch clears the L4 fields in that circumstance to prevent sending those garbage values as part of the upcall. Signed-off-by: Justin Pettit Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Signed-off-by: Greg Rose Signed-off-by: Justin P

[ovs-dev] [PATCH branch-2.8 1/2] datapath: Properly set L4 keys on "later" IP fragments

Upstream commit: commit ad06a566e118e57b852cab5933dbbbaebb141de3 Author: Greg Rose Date: Tue Aug 27 07:58:09 2019 -0700 openvswitch: Properly set L4 keys on "later" IP fragments When IP fragments are reassembled before being sent to conntrack, the key fro

[ovs-dev] [PATCH branch-2.7 2/2] datapath: Clear the L4 portion of the key for "later" fragments

ater" fragments. This patch clears the L4 fields in that circumstance to prevent sending those garbage values as part of the upcall. Signed-off-by: Justin Pettit Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Signed-off-by: Greg Rose Signed-off-by: Justin P

[ovs-dev] [PATCH branch-2.7 1/2] datapath: Properly set L4 keys on "later" IP fragments

Upstream commit: commit ad06a566e118e57b852cab5933dbbbaebb141de3 Author: Greg Rose Date: Tue Aug 27 07:58:09 2019 -0700 openvswitch: Properly set L4 keys on "later" IP fragments When IP fragments are reassembled before being sent to conntrack, the key fro

[ovs-dev] [PATCH branch-2.6 2/2] datapath: Clear the L4 portion of the key for "later" fragments

ater" fragments. This patch clears the L4 fields in that circumstance to prevent sending those garbage values as part of the upcall. Signed-off-by: Justin Pettit Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Signed-off-by: Greg Rose Signed-off-by: Justin P

[ovs-dev] [PATCH branch-2.6 1/2] datapath: Properly set L4 keys on "later" IP fragments

Upstream commit: commit ad06a566e118e57b852cab5933dbbbaebb141de3 Author: Greg Rose Date: Tue Aug 27 07:58:09 2019 -0700 openvswitch: Properly set L4 keys on "later" IP fragments When IP fragments are reassembled before being sent to conntrack, the key fro

[ovs-dev] [PATCH branch-2.5 2/2] datapath: Clear the L4 portion of the key for "later" fragments

ater" fragments. This patch clears the L4 fields in that circumstance to prevent sending those garbage values as part of the upcall. Signed-off-by: Justin Pettit Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Signed-off-by: Greg Rose Signed-off-by: Justin P

[ovs-dev] [PATCH branch-2.11 2/2] datapath: Clear the L4 portion of the key for "later" fragments

ater" fragments. This patch clears the L4 fields in that circumstance to prevent sending those garbage values as part of the upcall. Signed-off-by: Justin Pettit Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Signed-off-by: Greg Rose Signed-off-by: Justin P

[ovs-dev] [PATCH branch-2.5 1/2] datapath: Properly set L4 keys on "later" IP fragments

Upstream commit: commit ad06a566e118e57b852cab5933dbbbaebb141de3 Author: Greg Rose Date: Tue Aug 27 07:58:09 2019 -0700 openvswitch: Properly set L4 keys on "later" IP fragments When IP fragments are reassembled before being sent to conntrack, the key fro

[ovs-dev] [PATCH branch-2.11 1/2] datapath: Properly set L4 keys on "later" IP fragments

Upstream commit: commit ad06a566e118e57b852cab5933dbbbaebb141de3 Author: Greg Rose Date: Tue Aug 27 07:58:09 2019 -0700 openvswitch: Properly set L4 keys on "later" IP fragments When IP fragments are reassembled before being sent to conntrack, the key fro

[ovs-dev] [PATCH branch-2.10 2/2] datapath: Clear the L4 portion of the key for "later" fragments

ater" fragments. This patch clears the L4 fields in that circumstance to prevent sending those garbage values as part of the upcall. Signed-off-by: Justin Pettit Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Signed-off-by: Greg Rose Signed-off-by: Justin P

[ovs-dev] [PATCH branch-2.10 1/2] datapath: Properly set L4 keys on "later" IP fragments

Upstream commit: commit ad06a566e118e57b852cab5933dbbbaebb141de3 Author: Greg Rose Date: Tue Aug 27 07:58:09 2019 -0700 openvswitch: Properly set L4 keys on "later" IP fragments When IP fragments are reassembled before being sent to conntrack, the key fro

[ovs-dev] [PATCH 2/2] datapath: Clear the L4 portion of the key for "later" fragments

ater" fragments. This patch clears the L4 fields in that circumstance to prevent sending those garbage values as part of the upcall. Signed-off-by: Justin Pettit Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Cc: Justin Pettit Signed-off-by: Greg Rose ---

[ovs-dev] [PATCH 1/2] datapath: Properly set L4 keys on "later" IP fragments

Upstream commit: commit ad06a566e118e57b852cab5933dbbbaebb141de3 Author: Greg Rose Date: Tue Aug 27 07:58:09 2019 -0700 openvswitch: Properly set L4 keys on "later" IP fragments When IP fragments are reassembled before being sent to conntrack, the key fro

[ovs-dev] [PATCH branch-2.11] rhel: Add case for RHEL 7.5 major version to kmod manage script

A Centos 7.5 kernel with an unencountered set of minor build numbers caused an upgrade bug. Adding the case for the rhel 7.5 kmod management script fixes the problem. Signed-off-by: Greg Rose Reviewed-by: Yifeng Sun Signed-off-by: Gurucharan Shetty --- rhel/usr_share_openvswitch_scripts_ovs

[ovs-dev] [PATCH] rhel: Add case for RHEL 7.5 major version to kmod manage script

A Centos 7.5 kernel with an unencountered set of minor build numbers caused an upgrade bug. Adding the case for the rhel 7.5 kmod management script fixes the problem. Signed-off-by: Greg Rose --- rhel/usr_share_openvswitch_scripts_ovs-kmod-manage.sh | 5 + 1 file changed, 5 insertions

[ovs-dev] [PATCH 2/2] datapath: fix csum updates for MPLS actions

Simon Horman Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Fixes: ccf4378615e9 ("datapath: Add basic MPLS support to kernel") Fixes: b51367aad315 ("datapath: update checksum in {push,pop}_mpls") Cc: John Hurley Signed-off-by: Greg Rose --- datapath/actions.c | 6

[ovs-dev] [PATCH 1/2] compat: ip6_gre: fix possible use-after-free in ip6erspan_rcv

__iptunnel_pull_header Fixes: 1d7e2ed22f8d ("net: erspan: refactor existing erspan code") Signed-off-by: Lorenzo Bianconi Signed-off-by: David S. Miller Fixes: c387d8177f20 ("compat: Add ipv6 GRE and IPV6 Tunneling") Cc: Lorenzo Bianconi Signed-off-by: Greg Rose --- d

[ovs-dev] [PATCH V2 3/3] compat: Clean up tunnel_id_to_key

This function was just a duplicate of tunnel_id_to_key32 - I'm not sure why it was ever needed but let's dump it now. Signed-off-by: Greg Rose Acked-by: William Tu --- datapath/linux/compat/ip_gre.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/datapath/linux

[ovs-dev] [PATCH V2 2/3] compat: Clean up gre_calc_hlen

-by: Greg Rose Acked-by: William Tu --- acinclude.m4| 4 datapath/linux/compat/gre.c | 15 --- datapath/linux/compat/include/net/gre.h | 21 + datapath/linux/compat/ip6_gre.c | 14 -- datapath/linux

[ovs-dev] [PATCH V2 1/3] compat: Remove duplicate metadata destination code

ip_gre.c and ip6_gre.c both had duplicate code for handling the tunnel metadata destinations. Move the duplicate code over into the right header file, dst_metadata.h. Signed-off-by: Greg Rose Acked-by: William Tu --- v1->v2 Remove unwanted comment left over from code reorg --- datapath/li

[ovs-dev] [PATCH 3/3] compat: Clean up tunnel_id_to_key

This function was just a duplicate of tunnel_id_to_key32 - I'm not sure why it was ever needed but let's dump it now. Signed-off-by: Greg Rose --- datapath/linux/compat/ip_gre.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/datapath/linux/compat/ip_gre.c b

[ovs-dev] [PATCH 2/3] compat: Clean up gre_calc_hlen

-by: Greg Rose --- acinclude.m4| 4 datapath/linux/compat/gre.c | 15 --- datapath/linux/compat/include/net/gre.h | 21 + datapath/linux/compat/ip6_gre.c | 14 -- datapath/linux/compat/ip_gre.c

[ovs-dev] [PATCH 1/3] compat: Remove duplicate metadata destination code

ip_gre.c and ip6_gre.c both had duplicate code for handling the tunnel metadata destinations. Move the duplicate code over into the right header file, dst_metadata.h. Signed-off-by: Greg Rose --- datapath/linux/compat/include/net/dst_metadata.h | 136 ++- datapath/linux

[ovs-dev] [PATCH 0/3] Cleanup gre related tunnel code

This patch set passes Travis: https://travis-ci.org/gvrose8192/ovs-experimental/builds/551890800 I ran some light touch tests and the kernel check-kmod test on a few machines with no regressions. There should be no functional change. Greg Rose (3): compat: Remove duplicate metadata

[ovs-dev] [PATCH] ovs-ctl: Remove rtnetlink geneve and vxlan interfaces

. This patch fixes the problem by deleting the rtnetlink based geneve and vxlan interfaces before executing the kernel module reload. VMware-BZ: 2128511 Signed-off-by: Greg Rose --- utilities/ovs-lib.in | 14 ++ 1 file changed, 14 insertions(+) diff --git a/utilities/ovs-lib.in b/utilities

[ovs-dev] [PATCH] rhel: Fix upgrade path

. This scriptlet is called after the symlinks have just been erased and it calls the ovs-kmod-manage.sh script to recreate the symlinks and run depmod -a again so that the correct kernel modules will be found and loaded. VMware-BZ: #236987 Cc: Aaron Conole Cc: Flavio Leitner Signed-off-by: Greg Rose

[ovs-dev] [PATCH] Documentation: Clarify connection tracking tutorial

to scrub the packet and in this case the connection may already be in the "tracked" state. Reported-by: Quan Tian Signed-off-by: Greg Rose --- Documentation/tutorials/ovs-conntrack.rst | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/Documentation/tutorials/ovs-

[ovs-dev] [PATCH] datapath: fix flow actions reallocation

the requested data. BugLink: https://bugs.launchpad.net/bugs/1813244 Signed-off-by: Andrea Righi Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Cc: Andrea Righi Signed-off-by: Greg Rose --- datapath/flow_netlink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[ovs-dev] [PATCH 1/5 V2] datapath: meter: Use struct_size() in kzalloc()

wing patch that converts to use of kvmalloc(). Cc: Gustavo A. R. Silva Signed-off-by: Greg Rose --- V2 - Remove accidental change to manpages.mk --- acinclude.m4 | 6 + datapath/linux/Modules.mk | 4 +- datapath/linux/compat/include/

[ovs-dev] [PATCH 1/5] datapath: meter: Use struct_size() in kzalloc()

wing patch that converts to use of kvmalloc(). Cc: Gustavo A. R. Silva Signed-off-by: Greg Rose --- acinclude.m4 | 6 + datapath/linux/Modules.mk | 4 +- datapath/linux/compat/include/linux/mm.h | 44 datapath/linux/comp

[ovs-dev] [PATCH 5/5] compat: iptunnel: NULL pointer deref for ip_md_tunnel_xmit

d-by: Alexei Starovoitov Tested-by: Anders Roxell Reported-by: Nicolas Dichtel Tested-by: Nicolas Dichtel Acked-by: Nicolas Dichtel Signed-off-by: David S. Miller Fixed up for backward compatibility to our own compat layer ip_tunnel.c module. Cc: Alan Maguire Signed-off-by

[ovs-dev] [PATCH 4/5] datapath: fix missing checks for nla_nest_start

-EMSGSIZE when it fails. Signed-off-by: Kangjie Lu Signed-off-by: David S. Miller Cc: Kangjie Lu Signed-off-by: Greg Rose --- datapath/datapath.c | 8 1 file changed, 8 insertions(+) diff --git a/datapath/datapath.c b/datapath/datapath.c index 1340d6b..94e4f6f 100644

[ovs-dev] [PATCH 3/5] net: openvswitch: fix a NULL pointer dereference

the NULL pointer dereference in this case. Signed-off-by: Kangjie Lu Signed-off-by: David S. Miller Cc: Kangjie Lu Signed-off-by: Greg Rose --- datapath/datapath.c | 4 1 file changed, 4 insertions(+) diff --git a/datapath/datapath.c b/datapath/datapath.c index 2febcb3..1340d6b

[ovs-dev] [PATCH 2/5] datapath: convert to kvmalloc

Cc: Vlad Yasevich Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Cc: Kent Overstreet Signed-off-by: Greg Rose --- datapath/flow.h | 1 - datapath/flow_netlink.h | 1 - datapath/flow_table.c | 51 - datapath/flow_tabl

<    1   2   3   4   5   6   7   8   9   10   >