On 2/28/23 10:33, Wan Junjie wrote:
>>>>>> Hi,
>>>>>>
>>>>>> On Tue, Feb 28, 2023 at 4:03 PM David Marchand
>>>>>> wrote:
>>>>>>>
>>>>>>> Hello,
>>>>>
>On 2/23/23 10:35, Han Ding wrote:
>>
>> When use ovs-vsctl to delete vhostuserclient port while qemu destroy virtio,
>> there is a deadlock between OVS main thread and the vhost-events thread.
>>
>> openvswitch is 2.14 and dpdk is 20.11
>
>FWIW, 2.14
now
is waiting for fdentry to no busy
and circle all the time.
Whether the ovsrcu_synchronize is necessary in destrory_device or the
rte_vhost_driver_unregister is correct in fdset_try_del ?
Best regards, Han Ding.
___
dev mailing list
and target fields. This patch add the check
in function is_garp() whether the arp is a broadcast message and whether
the arp is an arp request or an arp reply.
Signed-off-by: Han Ding
---
Notes:
v2:
- Add the check whether the ARP packet is a broadcast message in is_garp().
v3:
- Add
and target fields. This patch add the check
in function is_garp() whether the arp is a broadcast message and whether
the arp is an arp request or an arp reply.
Signed-off-by: Han Ding
---
Notes:
v2:
- Add the check whether the ARP packet is a broadcast message in is_garp().
v3:
- Add
>On 2/7/23 06:04, Han Ding wrote:
>>
>> Function is_gratuitous_arp() and function is_garp() are all used to judge
>> whether the flow is gratuitous arp. It is not necessary to use two functions
>> to do the same thing and just keep one.
>>
>> Signed-
>On Tue, Feb 07, 2023 at 01:04:41PM +0800, Han Ding wrote:
>>
>> Function is_gratuitous_arp() and function is_garp() are all used to judge
>> whether the flow is gratuitous arp. It is not necessary to use two functions
>> to do the same thing and just keep one.
>
Function is_gratuitous_arp() and function is_garp() are all used to judge
whether the flow is gratuitous arp. It is not necessary to use two functions
to do the same thing and just keep one.
Signed-off-by: Han Ding
---
lib/flow.h | 15 +--
ofproto/ofproto-dpif
>On Tue, Jan 24, 2023 at 12:22:43PM +0100, Ilya Maximets wrote:
>
>...
>
>> I did some research that might answer or maybe clarify the questions above.
>> Namely reading ARP-related RFCs - 826 and 5227. From these I carried
>> following:
>>
>> - Gratuitous ARP / ARP Announcement messages are
Function is_gratuitous_arp() and function is_garp() are all used to judge
whether the flow is gratuitous arp. It is not necessary to use two functions
to do the same thing and just keep one.
Acked-by: Ilya Maximets
Signed-off-by: Han Ding
---
lib/flow.h | 3 ++-
ofproto
--
Han Ding
>On 12/1/22 07:39, Han Ding wrote:
>>
>> Function is_gratuitous_arp() and function is_garp() are all used to judge
>> whether the flow is gratuitous arp. It is not necessary to use two functions
>> to do the same thing and just keep one.
&
Function is_gratuitous_arp() and function is_garp() are all used to judge
whether the flow is gratuitous arp. It is not necessary to use two functions
to do the same thing and just keep one.
Signed-off-by: Han Ding
---
ofproto/ofproto-dpif-xlate.c | 32 ++--
1 file
will not be updated.
Fixes: ba07cf222a0c ("Handle gratuitous ARP requests and replies in
tnl_arp_snoop()")
Fixes: 83c2757bd16e ("xlate: Move tnl_neigh_snoop() to
terminate_native_tunnel()")
Acked-by: Paolo Valerio
Signed-off-by: Han Ding
---
ofproto/ofproto-dpif-xlate.c | 16 ++
will not be updated.
Fixes: ba07cf222a0c ("Handle gratuitous ARP requests and replies in
tnl_arp_snoop()")
Fixes: 83c2757bd16e ("xlate: Move tnl_neigh_snoop() to
terminate_native_tunnel()")
Acked-by: Paolo Valerio
Signed-off-by: Han Ding
---
ofproto/ofproto-dpif-xlate.c | 15 +
Thanks for reviewing. I will change them in next version.
--
Han Ding
>Hello Han,
>
>"Han Ding" writes:
>
>> Commit ba07cf222a add the feature "Handle gratuitous ARP requests and
>> replies in tnl_arp_snoop()". But commit 83c2757bd1
When the bridge protocols is not included Openflow10, printing an error
message "version negotiation failed" when doing "Restoring saved flows".
Signed-off-by: Han Ding
---
utilities/ovs-save | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utilities/
. When ovs receive the
gratuitous ARP from underlay gateway which the source address and destination
address are all gateway IP, tunnel neighbor will not be updated.
Signed-off-by: Han Ding
---
Notes:
v3
Correct the spell mistake.
v2
Change author name.
ofproto/ofproto-dp
tive. When ovs receive the
gratuitous ARP from underlay gateway whitch the source address and destination
address are all gateway IP, tunnel neighbor will not be updated.
Signed-off-by: Han Ding
---
Notes:
Change author name.
ofproto/ofproto-dpif-xlate.c | 10 +++---
tests/tunnel-p
Commit ba07cf222a add the feature "Handle gratuitous ARP requests and
replies in tnl_arp_snoop()". But commit 83c2757bd1 just allow the ARP whitch
the destination address of the ARP is matched against the known xbridge
addresses.
So the modification of commit ba07cf222a is not effective. When
first
and dump br-int next. Then stopping tap1 ovs-tcpdump first, and stopping
br-int second. When we stop ovs-tcpdump for br-int, the screen show the error
like this:
__main__.OVSDBException: Unable to delete Mirror m_br-int
Signed-off-by: Han Ding
---
utilities/ovs-tcpdump.in | 6 ++
1
t;1)? $(NF) :
"OpenFlow14" }'
OpenFlow14
Signed-off-by: Han Ding
Acked-by: Adrian Moreno
---
Notes:
Change the author name to full name.
utilities/ovs-save | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utilities/ovs-save b/utilities/ovs-save
index fb2025b
--
Han Ding
>
>
>On 5/6/22 11:04, Adrian Moreno wrote:
>> Hello,
>>
>> On 4/18/22 10:01, handing wrote:
>>>
>>> When setting just one ofp version to protocols of bridge, The function
>>> get_highest_ofp_version in ovs-save pa
22 matches
Mail list logo
