On Tue, Jun 14, 2022 at 1:08 AM Han Zhou wrote:
>
>
>
> On Mon, Jun 13, 2022 at 6:07 PM Ihar Hrachyshka wrote:
> >
> > On Mon, Jun 13, 2022 at 6:30 PM Han Zhou wrote:
> > >
> > >
> > >
> > > On Mon, Jun 13, 2022 at 11:41 AM Ihar Hrach
s
options:additional-chassis-activated in southbound db.
This feature is useful in live migration scenarios where it's not
advisable to unlock the destination port location prematurily to avoid
duplicate packets originating from the port.
Acked-by: Han Zhou
Signed-off-by: Ihar Hrachyshka
On Mon, Jun 13, 2022 at 6:30 PM Han Zhou wrote:
>
>
>
> On Mon, Jun 13, 2022 at 11:41 AM Ihar Hrachyshka wrote:
> >
> > When options:activation-strategy is set to "rarp" for LSP, when used in
> > combination with multiple chassis names listed in
> >
FYI checked that with -fake-multinode. Also checked that if I modify
start_northd to pass $cmd (as ovsdb-server), it also correctly matches
it (and failing when $cmd is anything different).
On Mon, Jun 13, 2022 at 8:45 PM Ihar Hrachyshka wrote:
>
> [ -z $string ] needs double quotes to
, 2022 at 3:00 PM Ihar Hrachyshka wrote:
> >
> > Signed-off-by: Ihar Hrachyshka
>
> With this patch I also applied, I see the below error
>
> /usr/share/ovn/scripts/ovn-ctl: line 53: test: syntax error: `-s' unexpected
>
> I think it should be - test -s &qu
-used pids in pidfile_is_running")
Signed-off-by: Ihar Hrachyshka
---
v2: fixed several syntax errors.
v2: converted from one liner to a sequence of if-then checks.
v2: squashed with a patch that removes redundant [ -e $file ] check.
v1: initial version
---
utilities/ovn-ctl | 16 ++
On Mon, Jun 13, 2022 at 3:17 PM Han Zhou wrote:
>
>
>
> On Mon, Jun 13, 2022 at 11:40 AM Ihar Hrachyshka wrote:
> >
> > On Thu, Jun 9, 2022 at 3:01 AM Han Zhou wrote:
> > >
> > >
> > >
> > > On Tue, Jun 7, 2022 at 7:06 PM Ihar Hrach
Ouch. I believe this should do:
https://patchwork.ozlabs.org/project/ovn/patch/20220613185922.2700748-1-ihrac...@redhat.com/
Ihar
On Mon, Jun 13, 2022 at 1:47 PM Numan Siddique wrote:
>
> On Thu, Jun 9, 2022 at 2:47 PM Mark Michelson wrote:
> >
> > I added Ihar's Ack and my Ack to both patches
Signed-off-by: Ihar Hrachyshka
---
utilities/ovn-ctl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utilities/ovn-ctl b/utilities/ovn-ctl
index 46cbac4c2..5d74b48ed 100755
--- a/utilities/ovn-ctl
+++ b/utilities/ovn-ctl
@@ -43,7 +43,7 @@ ovn_ic_db_conf_file="$ovn_etcdi
[ -z $string ] needs double quotes to handle zero-length strings
properly.
Fixes: 09dc4866fd32 ("Handle re-used pids in pidfile_is_running")
Signed-off-by: Ihar Hrachyshka
---
utilities/ovn-ctl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utilities/ovn-ctl b/uti
s
options:additional-chassis-activated in southbound db.
This feature is useful in live migration scenarios where it's not
advisable to unlock the destination port location prematurily to avoid
duplicate packets originating from the port.
Signed-off-by: Ihar Hrachyshka
---
v15: remove r
On Thu, Jun 9, 2022 at 3:01 AM Han Zhou wrote:
>
>
>
> On Tue, Jun 7, 2022 at 7:06 PM Ihar Hrachyshka wrote:
> >
> > When options:activation-strategy is set to "rarp" for LSP, when used in
> > combination with multiple chassis names listed in
> >
to avoid unnecessary I-P pflow node activation.
v14: fixed a bug in _run handler for activated_ports where it marked
as UNCHANGED when activated_ports list was not empty.
On Tue, Jun 7, 2022 at 10:06 PM Ihar Hrachyshka wrote:
>
> When options:activation-strategy is set to "rarp" fo
On Mon, Jun 6, 2022 at 3:48 AM Han Zhou wrote:
>
>
>
> On Fri, Jun 3, 2022 at 1:20 PM Ihar Hrachyshka wrote:
> >
> > When options:activation-strategy is set to "rarp" for LSP, when used in
> > combination with multiple chassis names listed in
> >
s
options:additional-chassis-activated in southbound db.
This feature is useful in live migration scenarios where it's not
advisable to unlock the destination port location prematurily to avoid
duplicate packets originating from the port.
Signed-off-by: Ihar Hrachyshka
---
NEWS
The function is called from main thread, and wait_* subprocedures access
data structures that are managed by pinctrl thread, so make sure the
access to them is guarded.
Signed-off-by: Ihar Hrachyshka
---
controller/pinctrl.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/controller
Thanks Numan.
All comments handled in v13 I just sent.
Ihar
On Thu, Jun 2, 2022 at 5:06 PM Numan Siddique wrote:
>
> On Wed, Jun 1, 2022 at 7:00 PM Ihar Hrachyshka wrote:
> >
> > This is the remaining piece in multi-chassis series. This new version
> > has no flow modi
s
options:additional-chassis-activated in southbound db.
This feature is useful in live migration scenarios where it's not
advisable to unlock the destination port location prematurily to avoid
duplicate packets originating from the port.
Signed-off-by: Ihar Hrachyshka
---
v13: use resubmit() act
On Thu, Jun 2, 2022 at 10:34 AM Terry Wilson wrote:
>
> When checking if ovsdb-server is running, ensure that the binary
> we are going to run matches the one actually running with the the
> pid that was in our pidfile.
>
> Signed-off-by: Terry Wilson
Acked-b
nd if it is passed to match the binary against
> /proc/$pid/exe.
>
> Signed-off-by: Terry Wilson
Acked-by: Ihar Hrachyshka
> ---
> utilities/ovn-ctl | 9 -
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/utilities/ovn-ctl b/utilities/o
Fixes fa8c591fa2a7("Support LSP:options:requested-chassis as a list")
Signed-off-by: Ihar Hrachyshka
---
controller/binding.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/controller/binding.c b/controller/binding.c
index 8a8570f13..227957
On Wed, Jun 1, 2022 at 1:26 PM Terry Wilson wrote:
>
> Since pids can be re-used, it is necessary to check that the
> process that is running with a pid matches the one that we expect.
>
> This adds the ability to optionally pass a 'binary' argument to
> pidfile_is_running, and if it is passed to
This is the remaining piece in multi-chassis series. This new version
has no flow modification done in pinctrl thread. Instead, I-P engine
is notified of any newly activated ports, which then triggers pflow
update for lports.
Ihar
On Wed, Jun 1, 2022 at 6:57 PM Ihar Hrachyshka wrote:
>
>
s
options:additional-chassis-activated in southbound db.
This feature is useful in live migration scenarios where it's not
advisable to unlock the destination port location prematurily to avoid
duplicate packets originating from the port.
Signed-off-by: Ihar Hrachyshka
---
NEWS
e similar to fields designed to track the
main chassis (->chassis, ->requested_chassis, ->encap). But because we
support any number of additional chassis, these fields are lists.
Acked-by: Numan Siddique
Signed-off-by: Ihar Hrachyshka
---
NEWS | 1 +
controll
it to additional chassis. When the sending port is bound on
either the main or additional chassis, then handle the packet locally
plus send it to all other chassis.
This is achieved with additional flows in tables 37 and 38.
Acked-by: Numan Siddique
Signed-off-by: Ihar Hrachyshka
---
controller
ets originating from the port.
Signed-off-by: Ihar Hrachyshka
---
NEWS | 2 +
controller/physical.c | 92 +++
controller/pinctrl.c | 226 +-
controller/pinctrl.h | 5 +
include/ovn/actions.h | 3 +
northd/northd.c | 10 ++
northd/ovn-nort
In a future patch, there will be a scenario where the same port has
attachments at multiple (specifically, 2) chassis, so make sure that
'up' property is updated by the main chassis only.
Acked-by: Numan Siddique
Signed-off-by: Ihar Hrachyshka
---
controller/binding.c| 9
rp to allow for other
strategies / having default no-op strategy
v1: implement in-memory port-activated tracking to avoid races
v1: numerous code cleanup / bug fixes
v1: special handling for localnet attached switches
v0: initial draft (single patch)
Ihar Hrachyshka (4):
Update port-up on main c
ets originating from the port.
Signed-off-by: Ihar Hrachyshka
---
NEWS | 2 +
controller/physical.c | 92 +++
controller/pinctrl.c | 226 +-
controller/pinctrl.h | 5 +
include/ovn/actions.h | 3 +
northd/northd.c | 10 ++
northd/ovn-nort
it to additional chassis. When the sending port is bound on
either the main or additional chassis, then handle the packet locally
plus send it to all other chassis.
This is achieved with additional flows in tables 37 and 38.
Signed-off-by: Ihar Hrachyshka
---
controller/binding.c | 2
e similar to fields designed to track the
main chassis (->chassis, ->requested_chassis, ->encap). But because we
support any number of additional chassis, these fields are lists.
Signed-off-by: Ihar Hrachyshka
---
NEWS | 1 +
controll
In a future patch, there will be a scenario where the same port has
attachments at multiple (specifically, 2) chassis, so make sure that
'up' property is updated by the main chassis only.
Acked-by: Numan Siddique
Signed-off-by: Ihar Hrachyshka
---
controller/binding.c| 9
tracking to avoid races
v1: numerous code cleanup / bug fixes
v1: special handling for localnet attached switches
v0: initial draft (single patch)
Ihar Hrachyshka (4):
Update port-up on main chassis only
Support LSP:options:requested-chassis as a list
Clone packets to all port chassi
e similar to fields designed to track the
main chassis (->chassis, ->requested_chassis, ->encap). But because we
support any number of additional chassis, these fields are lists.
Signed-off-by: Ihar Hrachyshka
---
NEWS | 1 +
controll
it to additional chassis. When the sending port is bound on
either the main or additional chassis, then handle the packet locally
plus send it to all other chassis.
This is achieved with additional flows in tables 37 and 38.
Signed-off-by: Ihar Hrachyshka
---
controller/binding.c | 2
ets originating from the port.
Signed-off-by: Ihar Hrachyshka
---
NEWS | 2 +
controller/physical.c | 92 +++
controller/pinctrl.c | 226 +-
controller/pinctrl.h | 5 +
include/ovn/actions.h | 3 +
northd/northd.c | 10 ++
northd/ovn-nort
In a future patch, there will be a scenario where the same port has
attachments at multiple (specifically, 2) chassis, so make sure that
'up' property is updated by the main chassis only.
Acked-by: Numan Siddique
Signed-off-by: Ihar Hrachyshka
---
controller/binding.c| 9
activated tracking to avoid races
v1: numerous code cleanup / bug fixes
v1: special handling for localnet attached switches
v0: initial draft (single patch)
Ihar Hrachyshka (4):
Update port-up on main chassis only
Support LSP:options:requested-chassis as a list
Clone packets to all port chassi
I'm sending another version of the series with some of your comments
handled (plus rebase), while others are still pending clarifications.
See below.
On Fri, May 13, 2022 at 2:37 AM Han Zhou wrote:
>
>
>
> On Thu, May 5, 2022 at 6:38 AM Ihar Hrachyshka wrote:
> >
> >
it to additional chassis. When the sending port is bound on
either the main or additional chassis, then handle the packet locally
plus send it to all other chassis.
This is achieved with additional flows in tables 37 and 38.
Signed-off-by: Ihar Hrachyshka
---
controller/binding.c | 2
e similar to fields designed to track the
main chassis (->chassis, ->requested_chassis, ->encap). But because we
support any number of additional chassis, these fields are lists.
Signed-off-by: Ihar Hrachyshka
---
NEWS | 1 +
controll
In a future patch, there will be a scenario where the same port has
attachments at multiple (specifically, 2) chassis, so make sure that
'up' property is updated by the main chassis only.
Signed-off-by: Ihar Hrachyshka
---
controller/binding.c| 9 ++---
controller/binding.h
tegy
v1: implement in-memory port-activated tracking to avoid races
v1: numerous code cleanup / bug fixes
v1: special handling for localnet attached switches
v0: initial draft (single patch)
Ihar Hrachyshka (3):
Update port-up on main chassis only
Support LSP:options:requested-chassis as a li
it to additional chassis. When the sending port is bound on
either the main or additional chassis, then handle the packet locally
plus send it to all other chassis.
This is achieved with additional flows in tables 37 and 38.
Signed-off-by: Ihar Hrachyshka
---
controller/binding.c | 2
e similar to fields designed to track the
main chassis (->chassis, ->requested_chassis, ->encap). But because we
support any number of additional chassis, these fields are lists.
Signed-off-by: Ihar Hrachyshka
---
NEWS | 1 +
controll
In a future patch, there will be a scenario where the same port has
attachments at multiple (specifically, 2) chassis, so make sure that
'up' property is updated by the main chassis only.
Signed-off-by: Ihar Hrachyshka
---
controller/binding.c| 9 ++---
controller/binding.h
to allow for other
strategies / having default no-op strategy
v1: implement in-memory port-activated tracking to avoid races
v1: numerous code cleanup / bug fixes
v1: special handling for localnet attached switches
v0: initial draft (single patch)
Ihar Hrachyshka (3):
Update port-up on main chas
:
>
>
>
> On Thu, May 5, 2022 at 6:38 AM Ihar Hrachyshka wrote:
> >
> > When the option is set to a comma separated list of chassis names, OVN
> > will attempt to bind the port at any number of other locations in
> > addition to the main chassis.
> >
>
This patch won't be needed after the next iteration of 'Clone
packets...' patch in the set drops. I'm dropping it in the next set.
On Wed, May 11, 2022 at 2:20 AM Han Zhou wrote:
>
>
>
> On Thu, May 5, 2022 at 6:38 AM Ihar Hrachyshka wrote:
> >
> > A next patch m
Correct, I'm handling this in the next iteration.
On Wed, May 11, 2022 at 2:23 AM Han Zhou wrote:
>
>
>
> On Thu, May 5, 2022 at 6:38 AM Ihar Hrachyshka wrote:
> >
> > In a future patch, there will be a scenario where the same port has
> > attachments at multiple
wrote:
>
>
>
> On Thu, May 5, 2022 at 6:38 AM Ihar Hrachyshka wrote:
> >
> > When multiple chassis are set in requested-chassis, port binding is
> > configured in multiple cluster locations. In case of live migration
> > scenario, only one of the locations run
Hi Abhiram,
thanks for sending the patch.
This is *not* a comprehensive review. This is an attempt to clarify
the scope of the feature, its potential crossover with other pending
work, and other high level comments.
API:
1) The proposal more or less directly maps the new OVN mirrors to OVS
it to additional chassis. When the sending port is bound on
either the main or additional chassis, then handle the packet locally
plus send it to all other chassis.
This is achieved with additional flows in tables 37 and 38.
Signed-off-by: Ihar Hrachyshka
---
controller/binding.c | 2
ets originating from the port.
Signed-off-by: Ihar Hrachyshka
---
NEWS | 2 +
controller/physical.c | 79 +++
controller/pinctrl.c | 226 +-
controller/pinctrl.h | 5 +
include/ovn/actions.h | 9 ++
lib/actions.c |
e similar to fields designed to track the
main chassis (->chassis, ->requested_chassis, ->encap). But because we
support any number of additional chassis, these fields are lists.
Signed-off-by: Ihar Hrachyshka
---
NEWS | 1 +
controll
In a future patch, there will be a scenario where the same port has
attachments at multiple (specifically, 2) chassis, so make sure that
'up' property is updated by the main chassis only.
Signed-off-by: Ihar Hrachyshka
---
controller/binding.c| 10 +++---
controller/binding.h
A next patch may need to clone packets to another chassis as part of
"port migration" procedure, but only if they haven't originated at
another chassis. This LOCAL_ONLY tag will enforce the requirement.
Signed-off-by: Ihar Hrachyshka
---
controller/physical.c | 1 +
controller/pinc
-op strategy
v1: implement in-memory port-activated tracking to avoid races
v1: numerous code cleanup / bug fixes
v1: special handling for localnet attached switches
v0: initial draft (single patch)
===
Ihar Hrachyshka (5):
Tag all packets that arrived from a tunnel as LOCAL_ONLY
Update por
In a future patch, there will be a scenario where the same port has
attachments at multiple (specifically, 2) chassis, so make sure that
'up' property is updated by the main chassis only.
Signed-off-by: Ihar Hrachyshka
---
controller/binding.c| 10 +++---
controller/binding.h
ets originating from the port.
Signed-off-by: Ihar Hrachyshka
---
NEWS | 2 +
controller/physical.c | 79 +++
controller/pinctrl.c | 226 +-
controller/pinctrl.h | 5 +
include/ovn/actions.h | 9 ++
lib/actions.c |
it to additional chassis. When the sending port is bound on
either the main or additional chassis, then handle the packet locally
plus send it to all other chassis.
This is achieved with additional flows in tables 37 and 38.
Signed-off-by: Ihar Hrachyshka
---
controller/binding.c | 2
e similar to fields designed to track the
main chassis (->chassis, ->requested_chassis, ->encap). But because we
support any number of additional chassis, these fields are lists.
Signed-off-by: Ihar Hrachyshka
---
NEWS | 1 +
controll
rt-activated tracking to avoid races
v1: numerous code cleanup / bug fixes
v1: special handling for localnet attached switches
v0: initial draft (single patch)
===
Ihar Hrachyshka (5):
Tag all packets that arrived from a tunnel as LOCAL_ONLY
Update port-up on main chassis only
Support LSP:optio
A next patch may need to clone packets to another chassis as part of
"port migration" procedure, but only if they haven't originated at
another chassis. This LOCAL_ONLY tag will enforce the requirement.
Signed-off-by: Ihar Hrachyshka
---
controller/physical.c | 1 +
controller/pinc
On Wed, Apr 20, 2022 at 3:16 PM Numan Siddique wrote:
>
> On Wed, Apr 20, 2022 at 1:15 PM Ihar Hrachyshka wrote:
> >
> > Thanks for your review. See below.
> >
> > On Tue, Apr 19, 2022 at 11:43 AM Numan Siddique wrote:
> > >
> > > On Tue, Mar 2
Signed-off-by: Ihar Hrachyshka
---
ovn-nb.xml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ovn-nb.xml b/ovn-nb.xml
index 9010240a8..e9ad002a0 100644
--- a/ovn-nb.xml
+++ b/ovn-nb.xml
@@ -2365,9 +2365,9 @@
with the highest-
will have QoS applied
UPD: I've posted a tiny series that implements (1) for your consideration here:
https://patchwork.ozlabs.org/project/ovn/list/?series=297048
It would be great if this can be backported to LTS. Seems like a low
risk featurette.
Thanks,
Ihar
On Mon, Apr 25, 2022 at 8:56 PM Ihar Hrachyshka wrote
Reported-At: https://bugzilla.redhat.com/show_bug.cgi?id=2060310
Signed-off-by: Ihar Hrachyshka
---
NEWS | 2 ++
controller/binding.c | 13 ++---
ovn-nb.xml | 5 +
ovn-sb.xml | 5 +
tests/system-ovn.at | 4 +++-
5 files changed, 25
Signed-off-by: Ihar Hrachyshka
---
tests/system-ovn.at | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/tests/system-ovn.at b/tests/system-ovn.at
index 3d2591ee9..1454f99d2 100644
--- a/tests/system-ovn.at
+++ b/tests/system-ovn.at
@@ -6338,11 +6338,15 @@ ovn-nbctl lsp
Reported-At: https://bugzilla.redhat.com/show_bug.cgi?id=2060310
Signed-off-by: Ihar Hrachyshka
---
NEWS | 2 ++
controller/binding.c | 13 ++---
ovn-nb.xml | 5 +
ovn-sb.xml | 5 +
tests/system-ovn.at | 4 +++-
5 files changed, 25
Hi all,
I am working on the following feature request:
https://bugzilla.redhat.com/show_bug.cgi?id=2060310
Request is to maintain neutron OVN driver parity with the legacy
ml2/ovs driver. This means the feature is requested only for ports
attached to VLAN / flat networks (meaning, there's a
When a binding switches to another chassis via requested-chassis
option, controller should stop sending periodic garps for the port.
Signed-off-by: Ihar Hrachyshka
---
v1: initial commit
v2: don't add to sset instead of later deleting it explicitly from the
set
---
controller/pinctrl.c | 5
Thank you, this looks great.
Signed-off-by: Ihar Hrachyshka
On Wed, Apr 20, 2022 at 4:09 AM Ales Musil wrote:
>
> The GARP was sent even on chassis that were not serving
> as l3gw for the specified router. This could lead to race
> on the physical network when multiple chassis s
On Wed, Apr 20, 2022 at 2:46 AM Ales Musil wrote:
>
>
> On Wed, Apr 20, 2022 at 8:14 AM Ales Musil wrote:
>
>> Thank you for the review, see my reply below.
>>
>> On Tue, Apr 19, 2022 at 9:26 PM Ihar Hrachyshka
>> wrote:
>>
>>> Thanks
Thanks for your review. See below.
On Tue, Apr 19, 2022 at 11:43 AM Numan Siddique wrote:
>
> On Tue, Mar 29, 2022 at 8:47 PM Ihar Hrachyshka wrote:
> >
> > This version of the series switched to supporting multiple chassis set in
> > requested-chassis option. This
Thanks for the patch. Two comments for the test case below.
On Tue, Apr 19, 2022 at 1:12 AM Ales Musil wrote:
>
> The GARP was sent even on chassis that were not serving
> as l3gw for the specified router. This could lead to race
> on the physical network when multiple chassis send the same
>
On 4/13/22 11:36 AM, Numan Siddique wrote:
On Tue, Apr 12, 2022 at 8:06 PM Ihar Hrachyshka wrote:
There's a discussion to have on the intended behavior of a port with 2+
chassis when the switch is attached to localnet.
In general, the patch series makes all chassis switch to tunneling when
use in environments
where MTU discrepancy is not an issue the usual approach of switching to
tunneling works fine.
Thoughts?
Ihar
On 3/29/22 8:47 PM, Ihar Hrachyshka wrote:
When chassis-mirroring-enabled is set, controller will not enforce
tunneling for localnet-attached switches. This may b
On 4/8/22 2:34 PM, Mark Michelson wrote:
Hi Ihar,
Patches 1-10 look good to me.
Acked-by: Mark Michelson
I'll have to wait until next week to review patches 11-15.
I have one super minor finding below.
On 3/29/22 20:46, Ihar Hrachyshka wrote:
When the option is set to a comma separated
When a binding switches to another chassis via requested-chassis
option, controller should stop sending periodic garps for the port.
Signed-off-by: Ihar Hrachyshka
---
controller/pinctrl.c | 9 -
tests/ovn.at | 93
2 files changed, 100
ld assign a specific priority value to each
chassis instead of using the order of the items in the list. This is
similar to what is done for other options, like gateway_chassis.
On 2/17/22 10:16, Ihar Hrachyshka wrote:
This version of the series is complete. It contains the previously
missing
When chassis-mirroring-enabled is set, controller will not enforce
tunneling for localnet-attached switches. This may be useful when the
network used to deliver tunnel packets doesn't have MTU headway to
redirect all packets originally sent through localnet port.
Signed-off-by: Ihar Hrachyshka
it to additional chassis. When the sending port is bound on
either the main or additional chassis, then handle the packet locally
plus send it to all other chassis.
This is achieved with additional flows in tables 37 and 38.
Signed-off-by: Ihar Hrachyshka
---
controller/binding.c | 2
Signed-off-by: Ihar Hrachyshka
---
NEWS | 3 +++
1 file changed, 3 insertions(+)
diff --git a/NEWS b/NEWS
index 3e8358723..944401c5c 100644
--- a/NEWS
+++ b/NEWS
@@ -4,6 +4,9 @@ Post v22.03.0
different OVN Interconnection availability zones.
- Replaced the usage of masked ct_label
ets originating from the port.
Signed-off-by: Ihar Hrachyshka
---
controller/physical.c | 78 +
controller/pinctrl.c | 198 +-
controller/pinctrl.h | 5 ++
include/ovn/actions.h | 9 ++
lib/actions.c | 40 -
northd/
It takes some time for vswitchd to remove the blocking flows, so we need
to wait for the flow_mod message handled before reinjecting the received
RARP packet into the pipeline.
Use a barrier to indicate the message processed by vswitchd.
Signed-off-by: Ihar Hrachyshka
---
controller/pinctrl.c
e similar to fields designed to track the
main chassis (->chassis, ->requested_chassis, ->encap). But because we
support any number of additional chassis, these fields are lists.
Signed-off-by: Ihar Hrachyshka
---
controller/binding.c | 274 ---
In a future patch, there will be a scenario where the same port has
attachments at multiple (specifically, 2) chassis, so make sure that
'up' property is updated by the main chassis only.
Signed-off-by: Ihar Hrachyshka
---
controller/binding.c| 10 +++---
controller/binding.h
A next patch may need to clone packets to another chassis as part of
"port migration" procedure, but only if they haven't originated at
another chassis. This LOCAL_ONLY tag will enforce the requirement.
Signed-off-by: Ihar Hrachyshka
---
controller/physical.c | 1 +
controller/pinc
This helper prepares a 'match' struct to match against a datapath and
a port key. All existing spots in the file that use such a 'match'
struct were updated. It will also be reused later.
Signed-off-by: Ihar Hrachyshka
---
controller/physical.c | 65
Signed-off-by: Ihar Hrachyshka
---
controller/physical.c | 50 ---
1 file changed, 19 insertions(+), 31 deletions(-)
diff --git a/controller/physical.c b/controller/physical.c
index 1c31741ea..0426098b2 100644
--- a/controller/physical.c
+++ b/controller
Right now consider_port_binding first extracts *a* tunnel for a
chassis, then later in put_remote_port_redirect_overlay it fetches
*the* proper tunnel before configuring encapsulation.
Instead of doing it in two steps, just extract the proper tunnel info
earlier.
Signed-off-by: Ihar Hrachyshka
Next patches will need the same functionality while passing a
different chassis / encap configuration that is not the primary for a
port binding.
Signed-off-by: Ihar Hrachyshka
---
controller/physical.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/controller
The ovn_port_update_sbrec function became too long, and the next
patches will touch the code to update chassis mapping for ports. This
patch prepares for the next step.
Signed-off-by: Ihar Hrachyshka
---
northd/northd.c | 62 -
1 file changed, 36
This function will be reused later.
Signed-off-by: Ihar Hrachyshka
---
northd/northd.c | 21 +++--
1 file changed, 15 insertions(+), 6 deletions(-)
diff --git a/northd/northd.c b/northd/northd.c
index 2fb0a93c2..17af42ac4 100644
--- a/northd/northd.c
+++ b/northd/northd.c
This tiny helper will be reused later.
Signed-off-by: Ihar Hrachyshka
---
controller/physical.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/controller/physical.c b/controller/physical.c
index 02fcd5ea8..51901395d 100644
--- a/controller/physical.c
+++ b
ddlog implementation
v2: re-inject RARP packet after vswitch updates flows
v3: re-sent as a single series
v4: redesign to reuse requested-chassis option
v4: support >2 chassis per port
v4: allow to disable tunneling enforcement when n_chassis >= 2
Ihar Hrachyshka (15):
Introduce chassis_is_v
he port.
Signed-off-by: Ihar Hrachyshka
---
controller/physical.c | 74 +++
controller/pinctrl.c | 161 +-
controller/pinctrl.h | 2 +
include/ovn/actions.h | 9 +++
lib/actions.c | 40 ++-
northd/northd.c
at the moment of the final port binding location change.
The patch mimics behavior of requested-chassis. Corresponding database
fields (pb->additional_chassis, pb->requested_additional_chassis,
pb->additional_encap) are introduced as part of the patch.
Signed-off-by: Ihar Hrachyshka
---
c
401 - 500 of 750 matches
Mail list logo
