[ovs-dev] [PATCH v9 1/1] netdev-offload-dpdk: Replace action PORT_ID with REPRESENTED_PORT.

2024-01-15 Thread Ivan Malov via dev
Action PORT_ID has been deprecated. Use REPRESENTED_PORT instead. Signed-off-by: Ivan Malov --- v8: split from https://mail.openvswitch.org/pipermail/ovs-dev/2023-June/406049.html v9: address warnings by 0-robot regarding the summary line lib/netdev-offload-dpdk.c | 30

Re: [ovs-dev] [PATCH v2] dpdk: Update to use v23.11.

2024-01-15 Thread Ivan Malov via dev
Hi Ilya, On Tue, 16 Jan 2024, Ilya Maximets wrote: On 1/15/24 17:13, Kevin Traynor wrote: On 15/01/2024 14:28, David Marchand wrote: This commit adds support for DPDK v23.11. It updates the CI script and documentation and includes the following changes coming from the dpdk-latest branch: -

[ovs-dev] [PATCH v8 1/1] netdev-offload-dpdk: replace action PORT_ID with REPRESENTED_PORT

2024-01-15 Thread Ivan Malov via dev
Action PORT_ID has been deprecated. Use REPRESENTED_PORT instead. Signed-off-by: Ivan Malov --- v8: split from https://mail.openvswitch.org/pipermail/ovs-dev/2023-June/406049.html lib/netdev-offload-dpdk.c | 30 +- 1 file changed, 17 insertions(+), 13 deletions

Re: [ovs-dev] [PATCH] dpdk: Update to use v23.11.

2023-12-23 Thread Ivan Malov via dev
Ilya, David, I appreciate your work. With regard to the deferred change waiting to be revisited, do you want me to take some action on it? Rework maybe? Thank you. On Sat, 16 Dec 2023, Ilya Maximets wrote: On 12/13/23 14:06, David Marchand wrote: This commit adds support for DPDK v23.11.

Re: [ovs-dev] [PATCH v7 1/2] netdev-dpdk: negotiate delivery of per-packet Rx metadata

2023-07-16 Thread Ivan Malov via dev
Hi Ilya, A quick follow-up from me: I made a new version of this patch [1]. [1] https://patchwork.ozlabs.org/project/openvswitch/patch/20230716115720.6789-1-ivan.ma...@arknetworks.am/ Thank you. On Fri, 14 Jul 2023, Ilya Maximets wrote: On 6/30/23 04:46, Ivan Malov wrote: This may

[ovs-dev] [PATCH v2 1/1] netdev-dpdk: negotiate delivery of per-packet Rx metadata

2023-07-16 Thread Ivan Malov via dev
This may be required by some PMDs in offload scenarios. Fixes: e8a2b5bf92bb ("netdev-dpdk: implement flow offload with rte flow") Signed-off-by: Ivan Malov --- v2: add missing experimental api ifdef lib/netdev-dpdk.c | 56 +++ 1 file c

[ovs-dev] [PATCH 1/1] netdev-dpdk: negotiate delivery of per-packet Rx metadata

2023-07-16 Thread Ivan Malov via dev
This may be required by some PMDs in offload scenarios. Fixes: e8a2b5bf92bb ("netdev-dpdk: implement flow offload with rte flow") Signed-off-by: Ivan Malov --- lib/netdev-dpdk.c | 54 +++ 1 file changed, 54 insertions(+) diff --git a/

Re: [ovs-dev] [PATCH v7 1/2] netdev-dpdk: negotiate delivery of per-packet Rx metadata

2023-07-16 Thread Ivan Malov via dev
Hi Ilya, Thanks for reviewing this. PSB. On Fri, 14 Jul 2023, Ilya Maximets wrote: On 6/30/23 04:46, Ivan Malov wrote: This may be required by some PMDs in offload scenarios. Signed-off-by: Ivan Malov Hi, Ivan. Thanks for the patch! I suppose, it can be considered as a bug fix. Could

Re: [ovs-dev] [PATCH v6 1/2] netdev-dpdk: negotiate delivery of per-packet Rx metadata

2023-06-29 Thread Ivan Malov via dev
Hi Ilya, Thanks again for reviewing this. I attempted to fix review notes in https://patchwork.ozlabs.org/project/openvswitch/list/?series=361784 . Thank you. On Thu, 29 Jun 2023, Ilya Maximets wrote: On 6/29/23 15:58, Simon Horman wrote: On Tue, Jun 06, 2023 at 03:35:32PM +0400, Ivan Malov

Re: [ovs-dev] [PATCH v6 2/2] netdev-offload-dpdk: replace action PORT_ID with REPRESENTED_PORT

2023-06-29 Thread Ivan Malov via dev
Hi Ilya, Thanks for reviewing this. Please see below. On Thu, 29 Jun 2023, Ilya Maximets wrote: On 6/6/23 13:35, Ivan Malov wrote: Action PORT_ID has been deprecated. Use REPRESENTED_PORT instead. AFAICT, not all drivers moved to a REPRESENTED_PORT action. I don't see support in NFP driver

[ovs-dev] [PATCH v7 1/2] netdev-dpdk: negotiate delivery of per-packet Rx metadata

2023-06-29 Thread Ivan Malov via dev
This may be required by some PMDs in offload scenarios. Signed-off-by: Ivan Malov --- lib/netdev-dpdk.c | 51 +++ 1 file changed, 51 insertions(+) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 63dac689e..d9d1b43f6 100644 --- a/lib/netdev

[ovs-dev] [PATCH v7 2/2] netdev-offload-dpdk: replace action PORT_ID with REPRESENTED_PORT

2023-06-29 Thread Ivan Malov via dev
Action PORT_ID has been deprecated. Use REPRESENTED_PORT instead. Signed-off-by: Ivan Malov --- lib/netdev-offload-dpdk.c | 30 +- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c index 14bc87771

[ovs-dev] [PATCH v7 0/2] DPDK: align flow offloads with 22.11

2023-06-29 Thread Ivan Malov via dev
Simon and Ilya Ivan Malov (2): netdev-dpdk: negotiate delivery of per-packet Rx metadata netdev-offload-dpdk: replace action PORT_ID with REPRESENTED_PORT lib/netdev-dpdk.c | 51 +++ lib/netdev-offload-dpdk.c | 30 +-- 2 files

Re: [ovs-dev] [PATCH v6 1/2] netdev-dpdk: negotiate delivery of per-packet Rx metadata

2023-06-29 Thread Ivan Malov via dev
On Thu, 29 Jun 2023, Simon Horman wrote: On Tue, Jun 06, 2023 at 03:35:32PM +0400, Ivan Malov via dev wrote: This may be required by some PMDs in offload scenarios. Signed-off-by: Ivan Malov --- lib/netdev-dpdk.c | 50 +++ 1 file changed, 50

[ovs-dev] [PATCH v6 2/2] netdev-offload-dpdk: replace action PORT_ID with REPRESENTED_PORT

2023-06-06 Thread Ivan Malov via dev
Action PORT_ID has been deprecated. Use REPRESENTED_PORT instead. Signed-off-by: Ivan Malov --- lib/netdev-offload-dpdk.c | 31 +-- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c index 14bc87771

[ovs-dev] [PATCH v6 0/2] DPDK: align flow offloads with 22.11

2023-06-06 Thread Ivan Malov via dev
: amendments to care about proxy detach and port ID logging v3: a minor adjustment in the cover letter subject line v4: edits to apply review notes and align with 22.11 v5: drop the transfer proxy patch; fix CI in [1/2] v6: another attempt to fix re-configure in [1/2] Ivan Malov (2): netdev-dpdk

[ovs-dev] [PATCH v6 1/2] netdev-dpdk: negotiate delivery of per-packet Rx metadata

2023-06-06 Thread Ivan Malov via dev
This may be required by some PMDs in offload scenarios. Signed-off-by: Ivan Malov --- lib/netdev-dpdk.c | 50 +++ 1 file changed, 50 insertions(+) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 8cb1a7703..98765fe6e 100644 --- a/lib/netdev

[ovs-dev] [PATCH v5 2/2] netdev-offload-dpdk: replace action PORT_ID with REPRESENTED_PORT

2023-06-06 Thread Ivan Malov via dev
Action PORT_ID has been deprecated. Use REPRESENTED_PORT instead. Signed-off-by: Ivan Malov --- lib/netdev-offload-dpdk.c | 31 +-- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c index 14bc87771

[ovs-dev] [PATCH v5 0/2] DPDK: align flow offloads with 22.11

2023-06-06 Thread Ivan Malov via dev
: amendments to care about proxy detach and port ID logging v3: a minor adjustment in the cover letter subject line v4: edits to apply review notes and align with 22.11 v5: drop the transfer proxy patch; fix CI in [1/2] Ivan Malov (2): netdev-dpdk: negotiate delivery of per-packet Rx metadata netdev

[ovs-dev] [PATCH v5 1/2] netdev-dpdk: negotiate delivery of per-packet Rx metadata

2023-06-06 Thread Ivan Malov via dev
This may be required by some PMDs in offload scenarios. Signed-off-by: Ivan Malov --- lib/netdev-dpdk.c | 43 +++ 1 file changed, 43 insertions(+) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 8cb1a7703..774ca8d51 100644 --- a/lib/netdev

Re: [ovs-dev] [PATCH v4 3/3] netdev-offload-dpdk: use flow transfer proxy mechanism

2023-06-06 Thread Ivan Malov via dev
Hi Eli, Thanks for responding. PSB. On Tue, 6 Jun 2023, Eli Britstein wrote: -Original Message- From: Ivan Malov Sent: Sunday, 4 June 2023 15:58 To: Eli Britstein Cc: ovs-dev@openvswitch.org; Ilya Maximets ; Ori Kam ; David Marchand Subject: RE: [PATCH v4 3/3] netdev-offload

Re: [ovs-dev] [PATCH v4 3/3] netdev-offload-dpdk: use flow transfer proxy mechanism

2023-06-04 Thread Ivan Malov via dev
Hi Eli, Thanks for reviewing this. Please see below. On Tue, 21 Feb 2023, Eli Britstein wrote: -Original Message- From: Ivan Malov Sent: Tuesday, 21 February 2023 2:41 To: ovs-dev@openvswitch.org Cc: Ilya Maximets ; Eli Britstein ; Ori Kam ; David Marchand Subject: [PATCH v4 3/3

Re: [ovs-dev] [PATCH dpdk-latest v4 1/5] netdev-dpdk: use flow transfer proxy

2023-05-08 Thread Ivan Malov via dev
Hi Nole, Simon, Ilya, On Mon, 8 May 2023, Nole Zhang wrote: -Original Message- From: Ilya Maximets Sent: Saturday, May 6, 2023 3:07 AM To: Ivan Malov ; Simon Horman Cc: i.maxim...@ovn.org; d...@openvswitch.org; Eli Britstein ; Kevin Liu ; Chaoyong He ; oss-drivers ; Nole Zhang

Re: [ovs-dev] [PATCH dpdk-latest v4 1/5] netdev-dpdk: use flow transfer proxy

2023-05-03 Thread Ivan Malov via dev
Hello Simon, This patch has me intrigued. By the looks of it, it bears uncanny resemblance to patch [1] by another author. Is your patch based on patch [1]? If yes, could you please comment on the following: 1) Your patch does not seem to reference the original author. Why is it so? Is there

[ovs-dev] [PATCH v4 3/3] netdev-offload-dpdk: use flow transfer proxy mechanism

2023-02-20 Thread Ivan Malov via dev
Manage "transfer" flows via the corresponding mechanism. Doing so requires that the traffic source be specified explicitly, via the corresponding pattern item. Signed-off-by: Ivan Malov --- lib/netdev-dpdk.c | 88 +++ lib/netdev-dpdk.h

[ovs-dev] [PATCH v4 0/3] DPDK: align flow offloads with 22.11

2023-02-20 Thread Ivan Malov via dev
) Potential need to manage "transfer" flows via a privileged ("transfer proxy") port. --- v2: amendments to care about proxy detach and port ID logging v3: a minor adjustment in the cover letter subject line v4: edits to apply review notes and align with 22.11 Ivan Malov (3): ne

[ovs-dev] [PATCH v4 1/3] netdev-dpdk: negotiate delivery of per-packet Rx metadata

2023-02-20 Thread Ivan Malov via dev
This may be required by some PMDs in offload scenarios. Signed-off-by: Ivan Malov --- lib/netdev-dpdk.c | 40 1 file changed, 40 insertions(+) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index fb0dd43f7..2cebc3cca 100644 --- a/lib/netdev-dpdk.c

[ovs-dev] [PATCH v4 2/3] netdev-offload-dpdk: replace action PORT_ID with REPRESENTED_PORT

2023-02-20 Thread Ivan Malov via dev
Action PORT_ID has been deprecated. Use REPRESENTED_PORT instead. Signed-off-by: Ivan Malov --- lib/netdev-offload-dpdk.c | 31 +-- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c index b3421c099

[ovs-dev] [PATCH v4 2/3] netdev-offload-dpdk: replace action PORT_ID with REPRESENTED_PORT

2023-02-20 Thread Ivan Malov via dev
Action PORT_ID has been deprecated. Use REPRESENTED_PORT instead. Signed-off-by: Ivan Malov --- lib/netdev-offload-dpdk.c | 31 +-- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c index b3421c099

[ovs-dev] [PATCH v4 1/3] netdev-dpdk: negotiate delivery of per-packet Rx metadata

2023-02-20 Thread Ivan Malov via dev
This may be required by some PMDs in offload scenarios. Signed-off-by: Ivan Malov --- lib/netdev-dpdk.c | 40 1 file changed, 40 insertions(+) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index fb0dd43f7..2cebc3cca 100644 --- a/lib/netdev-dpdk.c

[ovs-dev] [PATCH v4 3/3] netdev-offload-dpdk: use flow transfer proxy mechanism

2023-02-20 Thread Ivan Malov via dev
Manage "transfer" flows via the corresponding mechanism. Doing so requires that the traffic source be specified explicitly, via the corresponding pattern item. Signed-off-by: Ivan Malov --- lib/netdev-dpdk.c | 88 +++ lib/netdev-dpdk.h

[ovs-dev] [PATCH v4 0/3] DPDK: align flow offloads with 22.11

2023-02-20 Thread Ivan Malov via dev
) Potential need to manage "transfer" flows via a privileged ("transfer proxy") port. --- v2: amendments to care about proxy detach and port ID logging v3: a minor adjustment in the cover letter subject line v4: edits to apply review notes and align with 22.11 Ivan Malov (3): ne

Re: [ovs-dev] [PATCH v3 0/3] Rework the usage of DPDK transfer flow offloads

2022-07-22 Thread Ivan Malov
Hi Ilya, Eli, Many thanks for your feedback. Please see below. On Wed, 20 Jul 2022, Ilya Maximets wrote: On 7/20/22 14:18, Ivan Malov wrote: DPDK has got support for offloads involving assignment of per-packet Rx metadata (flag, mark, tunnel ID and the likes). However, delivery

Re: [ovs-dev] [PATCH v3 3/3] netdev-offload-dpdk: use flow transfer proxy mechanism

2022-07-20 Thread Ivan Malov
Hi Eli, Thanks a lot for a prompt review. PSB. On Wed, 20 Jul 2022, Eli Britstein wrote: -Original Message- From: Ivan Malov Sent: Wednesday, July 20, 2022 3:18 PM To: d...@openvswitch.org Cc: Eli Britstein ; Stephen Hemminger ; Ilya Maximets ; Ori Kam ; Maxime Coquelin ; David

Re: [ovs-dev] [PATCH 3/3] netdev-offload-dpdk: use flow transfer proxy mechanism

2022-07-20 Thread Ivan Malov
, too. On Wed, 8 Jun 2022, Eli Britstein wrote: Hi Ivan, -Original Message- From: Ivan Malov Sent: Wednesday, June 8, 2022 10:02 PM To: Eli Britstein Cc: d...@openvswitch.org; Andrew Rybchenko ; Ilya Maximets ; Ori Kam ; NBU-Contact-Thomas Monjalon (EXTERNAL) ; Stephen Hemminger ; David

[ovs-dev] [PATCH v3 3/3] netdev-offload-dpdk: use flow transfer proxy mechanism

2022-07-20 Thread Ivan Malov
Manage "transfer" flows via the corresponding mechanism. Doing so requires that the traffic source be specified explicitly, via the corresponding pattern item. Signed-off-by: Ivan Malov Acked-by: Andrew Rybchenko --- lib/netdev-dpdk.c | 99 --

[ovs-dev] [PATCH v3 2/3] netdev-offload-dpdk: replace action PORT_ID with REPRESENTED_PORT

2022-07-20 Thread Ivan Malov
Action PORT_ID has been deprecated. Use REPRESENTED_PORT instead. Signed-off-by: Ivan Malov Acked-by: Andrew Rybchenko --- lib/netdev-offload-dpdk.c | 32 1 file changed, 32 insertions(+) diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c index

[ovs-dev] [PATCH v3 1/3] netdev-dpdk: negotiate delivery of per-packet Rx metadata

2022-07-20 Thread Ivan Malov
This may be required by some PMDs in offload scenarios. Signed-off-by: Ivan Malov Acked-by: Andrew Rybchenko --- lib/netdev-dpdk.c | 44 1 file changed, 44 insertions(+) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index f9535bfb4..45e5d26d2

[ovs-dev] [PATCH v3 0/3] Rework the usage of DPDK transfer flow offloads

2022-07-20 Thread Ivan Malov
http://mails.dpdk.org/archives/dev/2021-October/224291.html [2] http://mails.dpdk.org/archives/dev/2021-October/224620.html [3] http://mails.dpdk.org/archives/dev/2021-October/225081.html --- v1 -> v2: amendments to care about proxy detach and port ID logging v2 -> v3: a minor adjustment in

[ovs-dev] [PATCH v2 3/3] netdev-offload-dpdk: use flow transfer proxy mechanism

2022-07-20 Thread Ivan Malov
Manage "transfer" flows via the corresponding mechanism. Doing so requires that the traffic source be specified explicitly, via the corresponding pattern item. Signed-off-by: Ivan Malov Acked-by: Andrew Rybchenko --- lib/netdev-dpdk.c | 99 --

[ovs-dev] [PATCH v2 2/3] netdev-offload-dpdk: replace action PORT_ID with REPRESENTED_PORT

2022-07-20 Thread Ivan Malov
Action PORT_ID has been deprecated. Use REPRESENTED_PORT instead. Signed-off-by: Ivan Malov Acked-by: Andrew Rybchenko --- lib/netdev-offload-dpdk.c | 32 1 file changed, 32 insertions(+) diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c index

[ovs-dev] [PATCH v2 0/3] netdev-dpdk: negotiate delivery of per-packet Rx metadata

2022-07-20 Thread Ivan Malov
http://mails.dpdk.org/archives/dev/2021-October/224291.html [2] http://mails.dpdk.org/archives/dev/2021-October/224620.html [3] http://mails.dpdk.org/archives/dev/2021-October/225081.html --- v1 -> v2: amendments to care about proxy detach and port ID logging Ivan Malov (3): netdev-dpdk: n

[ovs-dev] [PATCH v2 1/3] netdev-dpdk: negotiate delivery of per-packet Rx metadata

2022-07-20 Thread Ivan Malov
This may be required by some PMDs in offload scenarios. Signed-off-by: Ivan Malov Acked-by: Andrew Rybchenko --- lib/netdev-dpdk.c | 44 1 file changed, 44 insertions(+) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index f9535bfb4..45e5d26d2

Re: [ovs-dev] [PATCH 3/3] netdev-offload-dpdk: use flow transfer proxy mechanism

2022-06-08 Thread Ivan Malov
Hi Eli, On Wed, 8 Jun 2022, Eli Britstein wrote: Hi Ivan, -Original Message- From: Ivan Malov Sent: Wednesday, June 8, 2022 5:46 PM To: Eli Britstein Cc: d...@openvswitch.org; Andrew Rybchenko ; Ilya Maximets ; Ori Kam ; NBU-Contact-Thomas Monjalon (EXTERNAL) ; Stephen Hemminger

Re: [ovs-dev] [PATCH 3/3] netdev-offload-dpdk: use flow transfer proxy mechanism

2022-06-08 Thread Ivan Malov
Hi Eli, On Wed, 8 Jun 2022, Eli Britstein wrote: Hi Ivan, -Original Message- From: Ivan Malov Sent: Tuesday, June 7, 2022 11:56 PM To: Eli Britstein Cc: d...@openvswitch.org; Andrew Rybchenko ; Ilya Maximets ; Ori Kam ; NBU-Contact-Thomas Monjalon (EXTERNAL) ; Stephen Hemminger

Re: [ovs-dev] [PATCH 3/3] netdev-offload-dpdk: use flow transfer proxy mechanism

2022-06-07 Thread Ivan Malov
dors that don't need the proxy, this will work. For others, it won't. That's OK. -----Original Message- From: Ivan Malov Sent: Monday, May 30, 2022 5:16 PM To: d...@openvswitch.org Cc: Andrew Rybchenko ; Ilya Maximets ; Ori Kam ; Eli Britstein ; NBU-Contact-Thomas Monjalon (EXTERNAL) ; Step

Re: [ovs-dev] [PATCH 1/3] netdev-dpdk: negotiate delivery of per-packet Rx metadata

2022-06-07 Thread Ivan Malov
ery of per-packet Rx metadata External email: Use caution opening links or attachments This may be required by some PMDs in offload scenarios. Signed-off-by: Ivan Malov Acked-by: Andrew Rybchenko --- lib/netdev-dpdk.c | 44 1 file changed, 44

[ovs-dev] [PATCH 0/3] Rework the usage of DPDK transfer flow offloads

2022-05-30 Thread Ivan Malov
http://mails.dpdk.org/archives/dev/2021-October/224291.html [2] http://mails.dpdk.org/archives/dev/2021-October/224620.html [3] http://mails.dpdk.org/archives/dev/2021-October/225081.html Ivan Malov (3): netdev-dpdk: negotiate delivery of per-packet Rx metadata netdev-offload-dpdk: replace actio

[ovs-dev] [PATCH 3/3] netdev-offload-dpdk: use flow transfer proxy mechanism

2022-05-30 Thread Ivan Malov
Manage "transfer" flows via the corresponding mechanism. Doing so requires that the traffic source be specified explicitly, via the corresponding pattern item. Signed-off-by: Ivan Malov Acked-by: Andrew Rybchenko --- lib/netdev-dpdk.c | 73 --

[ovs-dev] [PATCH 2/3] netdev-offload-dpdk: replace action PORT_ID with REPRESENTED_PORT

2022-05-30 Thread Ivan Malov
Action PORT_ID has been deprecated. Use REPRESENTED_PORT instead. Signed-off-by: Ivan Malov Acked-by: Andrew Rybchenko --- lib/netdev-offload-dpdk.c | 32 1 file changed, 32 insertions(+) diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c index

[ovs-dev] [PATCH 1/3] netdev-dpdk: negotiate delivery of per-packet Rx metadata

2022-05-30 Thread Ivan Malov
This may be required by some PMDs in offload scenarios. Signed-off-by: Ivan Malov Acked-by: Andrew Rybchenko --- lib/netdev-dpdk.c | 44 1 file changed, 44 insertions(+) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index f9535bfb4..45e5d26d2

Re: [ovs-dev] [PATCH V6 00/13] Netdev vxlan-decap offload

2021-04-06 Thread Ivan Malov
Hi Eli, Thank you for improving the patch series gradually. May I clarify one extra aspect (and I'm sorry if it has been discussed already): will OvS always insert F1 first and then insert F2? I mean, yes, in the model, F2 should process packets coming from F1, but is it *technically*

Re: [ovs-dev] [PATCH V4 00/14] Netdev vxlan-decap offload

2021-03-25 Thread Ivan Malov
Hello, You know, now you mention it, will action COUNT always go before any other actions in OvS ("tunnel set" and "tunnel match" flows)? If this is the case, then the byte count in the counter of "tunnel set" flow should be "*before* decapsulation" and the byte count in the counter of

Re: [ovs-dev] [PATCH V4 05/14] netdev-offload-dpdk: Implement HW miss packet recover for vport

2021-03-17 Thread Ivan Malov
Hi Eli, On 17/03/2021 09:35, Eli Britstein wrote: +parse_tcp_flags(packet); +if (vport_netdev->netdev_class->pop_header(packet) == NULL) { Thank you for revising the patch series. As far as I can see, in the new revision (patch [06/14]), parsing TCP flags is done after

Re: [ovs-dev] [PATCH V3 05/14] netdev-offload-dpdk: Implement HW miss packet recover for vport

2021-03-15 Thread Ivan Malov
Hi Eli, On 02/03/2021 14:25, Eli Britstein wrote: > +/* For tunnel recovery (RTE_FLOW_RESTORE_INFO_TUNNEL), it is possible > + * to have the packet to still be encapsulated, or not > + * (RTE_FLOW_RESTORE_INFO_ENCAPSULATED). > + * In the case it is on, the

Re: [ovs-dev] [PATCH V2 10/14] netdev-offload-dpdk: Support tunnel pop action

2021-03-02 Thread Ivan Malov
Hi Eli, From what has been discussed so far it follows that JUMP from group 0 to the very same group 0 is intentional and corresponds to dp_netdev_recirculate. But could you please clarify, is OvS supposed to always use the group value of 0 with the tunnel offload model? In other words, can