Re: [ovs-dev] [External] : OVS+OVN Fall Conference 2023 - Day 2 information

2023-12-11 Thread Michael Santana
Hi Brendan, You can check out the ovscon site https://www.openvswitch.org/support/ovscon2023/ We have not yet made the videos available, but once we do they will be published on that site. So please check it regularly. We will also send out an email when we have pushed the videos Thanks! On

[ovs-dev] [OVSCONF] CFP deadline extension

2023-09-05 Thread Michael Santana
Happy September! Given that we had previously moved the conference back a month we have also decided to also move the CFP Deadline. Here are the new dates CFP submissions: October 20th Notification back to speakers: November 3rd Conference: December 6-7 (still the same) Please feel free to

Re: [ovs-dev] [OVSCONF] OVS+OVN '23: Call for Participation

2023-07-11 Thread Michael Santana
Just a small update, We have moved the conference dates to December 6-7, 2023 so as to not overlap with another networking conference happening around the same time. Stay tuned for further updates! Thank you! Conference Team On Fri, Jul 7, 2023 at 1:23 PM Michael Santana wrote: > >

[ovs-dev] [OVSCONF] OVS+OVS '23: Call for Participation

2023-07-07 Thread Michael Santana
Hello everyone! We are happy to announce this year's Open vSwitch and OVN conference! The conference will be on November 1-2, 2023 and will be a fully virtual event. We are seeking long and short ("lightning") talks on topics related to Open vSwitch and OVN. We expect long talks to last 25

[ovs-dev] [Notice] 0day-bot host down for scheduled power outage Thursday June 1st

2023-05-31 Thread Michael Santana
Hi all, There will be a scheduled power outage this Thursday June 1st. The host running 0daybot will be safely powered off tonight and powered back on as soon as power is restored Best ___ dev mailing list d...@openvswitch.org

[ovs-dev] [OVS-Conf] Last chance to submit feedback on OVS Conference 2023 dates and attendance

2023-05-31 Thread Michael Santana
Hi all, We are closing the survey this Friday. Thanks for all the feedback! We are asking you to fill out this survey as it will help us plan for the OVS Conference 2023. We are trying to gather your preferences for the 2023 conference for dates, in person or virtual, and location if in person!

[ovs-dev] [OVS-Conf] OVS Conference 2023 dates and attendance Survey

2023-05-18 Thread Michael Santana
Hi all, Thank you to those who attended the OVS conference 2022! We are looking forward to another awesome conference in 2023! We are asking you to fill out this survey as it will help us plan for the OVS Conference 2023. We are trying to gather your preferences for the 2023 conference for dates,

[ovs-dev] [Notice] 0day-bot host scheduled for a system update & backup on Monday, May 22nd

2023-05-17 Thread Michael Santana
Hi all, We are scheduling a system update and backup for the 0day-bot host on Monday, May 22nd. This means 0daybot, Github Actions and other CI tools will be down for the duration of the update & backup. It is expected to be back online at the end of business day. Best

Re: [ovs-dev] [PATCH] Handlers: Allow to explicitly set the number of handlers

2023-04-25 Thread Michael Santana
On Tue, Dec 6, 2022 at 7:22 AM Ilya Maximets wrote: > > On 11/25/22 13:37, Adrian Moreno wrote: > > On 10/25/22 21:18, Michael Santana wrote: > >> Currently n-handler-threads is ignored when using per-cpu mode. There > >> are some small situations where manually

Re: [ovs-dev] [PATCH 2/2] ovs-thread: fix cpus not read for the first 10s

2023-03-27 Thread Michael Santana
t;ovs-thread: Detect changes in number of CPUs.") Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2180460 Suggested-by: Ilya Maximets Signed-off-by: Adrian Moreno Acked-by: Michael Santana --- lib/ovs-thread.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [ovs-dev] [PATCH 1/2] dpif-netlink: always create at least 1 handler

2023-03-27 Thread Michael Santana
(such as this case) goes wrong Fixes: a5cacea5f988 ("handlers: Create additional handler threads when using CPU isolation.") Cc: msant...@redhat.com Suggested-by: Aaron Conole Signed-off-by: Adrian Moreno Acked-by: Michael Santana --- lib/dpif-netlink.c | 2 +- 1 file changed, 1 inser

[ovs-dev] [NOTICE] 0daybot CI down Today - System backup & Update

2023-03-20 Thread Michael Santana
We are performing a regular backup & update on the 0daybot CI host system today. This means 0daybot, Github Actions and other CI tools will be down for today We expect that it will be completed by EOB Best, ___ dev mailing list d...@openvswitch.org

[ovs-dev] [NOTICE] 0daybot CI down March 20th - System backup & Update

2023-03-13 Thread Michael Santana
We will be performing a regular backup & update on the 0daybot CI host system on Monday, March 20th. We expect that it will be completed by EOB that same day. Best, ___ dev mailing list d...@openvswitch.org

[ovs-dev] 0day-bot system is shutting down for electrical work

2023-02-09 Thread Michael Santana
Hi all, We are shutting down 0day-bot for scheduled electrical work in the lab. We will be back online next week the latest Best ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] github: Test building Fedora RPMs.

2023-01-19 Thread Michael Santana
On 1/19/23 08:14, Ilya Maximets wrote: Testing that RPMs can be built to catch possible spec file issues like missing dependencies. GitHub seems to have an agreement with Docker Hub about rate limiting of image downloads, so it should not affect us. We may switch to quay.io if that will ever

Re: [ovs-dev] [PATCH v2] netdev-offload-tc: Preserve tc statistics when flow gets modified.

2023-01-12 Thread Michael Santana
On 12/15/22 09:52, Eelco Chaudron wrote: When a flow gets modified, i.e. the actions are changes, the tc layer will remove, and re-add the flow. This is causing all the counters to be reset. This patch will remember the previous tc counters and adjust any requests for statistics. This is

Re: [ovs-dev] [PATCH] travis: Drop support.

2023-01-11 Thread Michael Santana
configuration from our repository and clean references in the documentation. Signed-off-by: David Marchand 'Tis a sad day indeed :'( Acked-by: Michael Santana --- .ci/linux-build.sh| 31 +- .ci/linux-prepare.sh | 9

[ovs-dev] [RFC PATCH] ovs-vsctl: Be more strict in cli arguments

2023-01-11 Thread Michael Santana
.com/show_bug.cgi?id=1990130 Signed-off-by: Michael Santana --- lib/db-ctl-base.c | 67 +++ 1 file changed, 67 insertions(+) diff --git a/lib/db-ctl-base.c b/lib/db-ctl-base.c index 134496ef3..b35ec99c7 100644 --- a/lib/db-ctl-base.c +++ b/lib/db-ctl-base

Re: [ovs-dev] [PATCH v2] ofproto-dpif-upcall: Use last known stats ukey stats on revalidate missed dp flows.

2023-01-11 Thread Michael Santana
. In addition if the 'ofproto-dpif-upcall: Don't set statistics to 0 when they jump back' patch get's applied, the packet count will become even more exotic, as 0 - 'a few packets' results in a huge value for stats to be pushed. Signed-off-by: Eelco Chaudron Acked-by: Michael Santana --- ofproto

[ovs-dev] 0day-bot system is shutting down for system update

2023-01-09 Thread Michael Santana
Hi all, We are shutting down 0day-bot for today for a system update. We will be back online later by the end of the day EST. Best ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Use last known stats ukey stats on revalidate missed dp flows.

2023-01-04 Thread Michael Santana
On 12/22/22 03:58, Eelco Chaudron wrote: Instead of using all zero stats when executing a revalidate for missed dp flows, use the last known stats to avoid odd statistics being used. This feels like it's missing some context. What kind of statistics are you seeing with using all zeros?

Re: [ovs-dev] [PATCH] [ovs-dev v3] dpctl: Add support to count upcall packets

2023-01-04 Thread Michael Santana
, I dont have any comments outside the ones made by eelco. It looks funtionally good Reviewed-by: Michael Santana --- Since v1: - Patch of add support Since v2: - Modify format of code include/linux/openvswitch.h | 14 ++ include/openvswitch/netdev.h | 4 lib/dpctl.c

Re: [ovs-dev] [PATCH] vswitchd: Publish per iface received multicast packets.

2022-11-15 Thread Michael Santana
On Wed, Nov 9, 2022 at 3:32 PM David Marchand wrote: > > The count of received multicast packets has been computed internally, > but not exposed to ovsdb. Fix this. > > Signed-off-by: David Marchand Acked-by: Michael Santana > --- > Strictly speaking, nothing was broken s

[ovs-dev] [PATCH] Handlers: Allow to explicitly set the number of handlers

2022-10-25 Thread Michael Santana
=2106570 Signed-off-by: Michael Santana --- lib/dpif-netlink.c| 20 +++- lib/dpif-provider.h | 2 +- lib/dpif.c| 4 ++-- lib/dpif.h| 2 +- ofproto/ofproto-dpif-upcall.c | 3 +++ ofproto/ofproto-dpif.c| 5

[ovs-dev] [OVSCON] Early Bird Registration ends October 1st!

2022-09-27 Thread Michael Santana
Greetings! Early bird registration will close this Saturday October 1st. Starting October 2nd you will still be able to register for the OVS OVN Conference through late registration https://www.eventbrite.com/e/ovsovn-2022-fall-conference-tickets-403901198357 Ticket cost for in person: Early

[ovs-dev] OVSCI Automation Upgrade planned for Friday 9/9/22

2022-09-08 Thread Michael Santana
Hi all, We are planning on doing a system upgrade on our OVSCI automation system this Friday 9/9/22. This will affect our upstream robots (i.e. ovs, ovn, dpdk). This affects patchwork sync and github actions sync, etc. After the upgrade is completed the robots will be started again and expected

[ovs-dev] [PATCH v7 2/2] handlers: Fix handlers mapping

2022-08-09 Thread Michael Santana
o-authored-by: Aaron Conole signed-off-by: Aaron Conole Signed-off-by: Michael Santana --- lib/dpif-netlink.c | 31 +-- lib/ovs-numa.c | 28 lib/ovs-numa.h | 1 + 3 files changed, 54 insertions(+), 6 deletions(-) diff --git a/lib/dpif-

[ovs-dev] [PATCH v7 1/2] handlers: Create additional handler threads when using CPU isolation

2022-08-09 Thread Michael Santana
: handlers_n = min(next_prime(active_cores+1), total_cores) Assume default behavior when total_cores <= 2, that is do not create additional threads when we have less than 2 total cores on the system Fixes: b1e517bd2f81 ("dpif-netlink: Introduce per-cpu upcall dispatch.") Signed-of

[ovs-dev] [PATCH v6 2/2] handlers: Fix handlers mapping

2022-07-19 Thread Michael Santana
prime bias) fashion as follows: [S0, S1, S2, S3, S4, S5, S6, S0, S1, S2, S3, S4] Fixes: b1e517bd2f81 ("dpif-netlink: Introduce per-cpu upcall dispatch.") Co-authored-by: Aaron Conole signed-off-by: Aaron Conole Signed-off-by: Michael Santana --- lib/dpif-netlink.c | 18 --

[ovs-dev] [PATCH v6 1/2] handlers: Create additional handler threads when using CPU isolation

2022-07-19 Thread Michael Santana
res on the system Fixes: b1e517bd2f81 ("dpif-netlink: Introduce per-cpu upcall dispatch.") Signed-off-by: Michael Santana --- lib/dpif-netlink.c | 83 -- lib/ovs-thread.c | 17 ++ lib/ovs-thread.h | 1 + 3 files changed, 99 ins

Re: [ovs-dev] [PATCH v5 1/2] handlers: Create additional handler threads when using CPU isolation

2022-07-05 Thread Michael Santana
On 7/4/22 09:46, Ilya Maximets wrote: Hi, Michael. Thanks for the new version! Hi Ilya, thanks for the response On 6/6/22 20:59, Michael Santana wrote: Additional threads are required to service upcalls when we have CPU isolation (in per-cpu dispatch mode). The reason additional threads

Re: [ovs-dev] [PATCH v5 1/2] handlers: Create additional handler threads when using CPU isolation

2022-06-21 Thread Michael Santana
On Fri, Jun 17, 2022 at 12:10 PM Mike Pattrick wrote: > > On Mon, Jun 6, 2022 at 3:00 PM Michael Santana wrote: > > > > Additional threads are required to service upcalls when we have CPU > > isolation (in per-cpu dispatch mode). The reason additional threads >

Re: [ovs-dev] [PATCH] odp-util: Ignore unknown attributes in parse_key_and_mask_to_match()

2022-06-15 Thread Michael Santana
1 > Signed-off-by: Eelco Chaudron Reviewed-by: Michael Santana I would probably just have gotten rid of out_of_range_attr entirely in the code base, but I guess this requires a little more work and has a higher chance of breaking things. Your approach is safer and it gets the job

[ovs-dev] [PATCH v5 2/2] handlers: Fix handlers mapping

2022-06-06 Thread Michael Santana
prime bias) fashion as follows: [S0, S1, S2, S3, S4, S5, S6, S0, S1, S2, S3, S4] Fixes: b1e517bd2f81 ("dpif-netlink: Introduce per-cpu upcall dispatch.") Co-authored-by: Aaron Conole signed-off-by: Aaron Conole Signed-off-by: Michael Santana --- lib/dpif-netlink.c | 18 --

[ovs-dev] [PATCH v5 1/2] handlers: Create additional handler threads when using CPU isolation

2022-06-06 Thread Michael Santana
<= 2, that is do not create additional threads when we have less than 2 total cores on the system Fixes: b1e517bd2f81 ("dpif-netlink: Introduce per-cpu upcall dispatch.") Signed-off-by: Michael Santana --- lib/dpif-netlink.c | 86 -- lib

[ovs-dev] [PATCH 2/2] handlers: Fix handlers mapping

2022-06-01 Thread Michael Santana
prime bias) fashion as follows: [S0, S1, S2, S3, S4, S5, S6, S0, S1, S2, S3, S4] Fixes: b1e517bd2f81 ("dpif-netlink: Introduce per-cpu upcall dispatch.") Co-authored-by: Aaron Conole signed-off-by: Aaron Conole Signed-off-by: Michael Santana --- lib/dpif-netlink.c | 18 --

[ovs-dev] [PATCH 1/2] handlers: Create additional handler threads when using CPU isolation

2022-06-01 Thread Michael Santana
;) Signed-off-by: Michael Santana --- lib/dpif-netlink.c | 87 -- lib/ovs-thread.c | 16 + lib/ovs-thread.h | 1 + 3 files changed, 102 insertions(+), 2 deletions(-) diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c index 06e1e8ca0..355

Re: [ovs-dev] [PATCH v4 2/2] handlers: Fix handlers mapping

2022-05-31 Thread Michael Santana
On 5/27/22 13:18, Michael Santana wrote: The handler and CPU mapping in upcalls are incorrect, and this is specially noticeable systems with cpu isolation enabled. Say we have a 12 core system where only every even number CPU is enabled C0, C2, C4, C6, C8, C10 This means we will create

Re: [ovs-dev] [PATCH v4 1/2] handlers: Create additional handler threads when using CPU isolation

2022-05-31 Thread Michael Santana
On 5/31/22 09:01, Aaron Conole wrote: Michael Santana writes: Additional threads are required to service upcalls when we have CPU isolation (in per-cpu dispatch mode). The formula used to calculate the number of handler threads to create is as follows handlers_n = min(next_prime

[ovs-dev] [PATCH v4 2/2] handlers: Fix handlers mapping

2022-05-27 Thread Michael Santana
prime bias) fashion as follows: [S0, S1, S2, S3, S4, S5, S6, S0, S1, S2, S3, S4] Fixes: b1e517bd2f81 ("dpif-netlink: Introduce per-cpu upcall dispatch.") Co-authored-by: Aaron Conole signed-off-by: Aaron Conole Signed-off-by: Michael Santana --- lib/dpif-netlink.c | 20 +---

[ovs-dev] [PATCH v4 1/2] handlers: Create additional handler threads when using CPU isolation

2022-05-27 Thread Michael Santana
the next numeric prime number that is strictly greater than active_cores Fixes: b1e517bd2f81 ("dpif-netlink: Introduce per-cpu upcall dispatch.") Signed-off-by: Michael Santana --- lib/dpif-netlink.c | 32 - lib/ovs-threa

Re: [ovs-dev] [PATCH v3 1/2] handlers: Fix handlers mapping

2022-05-27 Thread Michael Santana
On Fri, May 27, 2022 at 6:48 AM Ilya Maximets wrote: > > On 5/27/22 08:46, Michael Santana wrote: > > > > > > On 5/27/22 02:37, Michael Santana wrote: > >> The handler and CPU mapping in upcalls are incorrect, and this is > >> specially noticeable systems

Re: [ovs-dev] [PATCH v3 1/2] handlers: Fix handlers mapping

2022-05-27 Thread Michael Santana
On 5/27/22 02:37, Michael Santana wrote: The handler and CPU mapping in upcalls are incorrect, and this is specially noticeable systems with cpu isolation enabled. Say we have a 12 core system where only every even number CPU is enabled C0, C2, C4, C6, C8, C10 This means we will create

[ovs-dev] [PATCH v3 2/2] handlers: Add additional handler threads for inactive cores

2022-05-27 Thread Michael Santana
Signed-off-by: Michael Santana --- lib/dpif-netlink.c | 14 lib/ovs-thread.c | 53 ++ lib/ovs-thread.h | 4 3 files changed, 71 insertions(+) diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c index 77a97beac..556596a13 100644

[ovs-dev] [PATCH v3 1/2] handlers: Fix handlers mapping

2022-05-27 Thread Michael Santana
as follows: [S0, S1, S2, S3, S4, S5, S0, S1, S2, S3, S4, S5] Fixes: b1e517bd2f81 ("dpif-netlink: Introduce per-cpu upcall dispatch.") Co-authored-by: Aaron Conole signed-off-by: Aaron Conole Signed-off-by: Michael Santana --- lib/dpif-netlink.c | 18 -- lib

Re: [ovs-dev] [PATCH v2] handlers: Fix handlers mapping

2022-05-23 Thread Michael Santana
On Thu, May 19, 2022 at 8:26 PM Ilya Maximets wrote: > > On 5/19/22 23:02, Aaron Conole wrote: > > Ilya Maximets writes: > > > >> On 5/5/22 05:52, Michael Santana wrote: > >>> On Mon, Apr 25, 2022 at 2:32 PM Ilya Maximets wrote: > >>&

Re: [ovs-dev] [PATCH v2] handlers: Fix handlers mapping

2022-05-04 Thread Michael Santana
On Mon, Apr 25, 2022 at 2:32 PM Ilya Maximets wrote: > > On 4/19/22 05:19, Michael Santana wrote: > > On Tue, Apr 5, 2022 at 6:32 PM Ilya Maximets wrote: > >> > >> On 4/4/22 14:36, Michael Santana wrote: > >>> The handler and CPU mapping in upcalls

Re: [ovs-dev] [PATCH v2] handlers: Fix handlers mapping

2022-04-18 Thread Michael Santana
On Tue, Apr 5, 2022 at 6:32 PM Ilya Maximets wrote: > > On 4/4/22 14:36, Michael Santana wrote: > > The handler and CPU mapping in upcalls are incorrect, and this is > > specially noticeable systems with cpu isolation enabled. > > > > Say we have a 12 core system wh

[ovs-dev] [PATCH v2] handlers: Fix handlers mapping

2022-04-04 Thread Michael Santana
S2, S3, S3, S4, S4, S5, S5, S0] This guarantees that regardless of which CPU a packet comes in the kernel will correctly map it to the correct socket Co-authored-by: Aaron Conole signed-off-by: Aaron Conole Signed-off-by: Michael Santana --- lib/dpif-netlink.c | 28 +++

[ovs-dev] [PATCH] handlers: Fix handlers mapping

2022-04-01 Thread Michael Santana
S2, S3, S3, S4, S4, S5, S5, S0] This guarantees that regardless of which CPU a packet comes in the kernel will correctly map it to the correct socket Co-authored-by: Aaron Conole Signed-off-by: Michael Santana --- lib/dpif-netlink.c | 28 +++- lib/ovs-threa

Re: [ovs-dev] [PATCH 0/3] Support geneve offloads

2022-01-04 Thread Michael Santana
On 12/29/21 03:35, Eli Britstein via dev wrote: Add support for dpdk geneve tunnel offloads. Series looks goods to me. The code looks to take inspiration from the vxlan code. I guess if that works then this should too. GitHub actions: v1:

Re: [ovs-dev] [PATCH] tests: Handle endianness in netlink policy test

2021-11-18 Thread Michael Santana
On 11/18/21 3:26 AM, Frode Nordahl wrote: The netlink policy unit test contains test fixture data that is subject to endianness and currently fails on big endian systems. Add helper that ensures correct byte order for the affected data. Fixes: bfee9f6c0115 ("netlink: Add support for parsing

Re: [ovs-dev] [PATCH v1] acinclude: Provide error info when linking fails with DPDK.

2021-11-12 Thread Michael Santana
On 11/10/21 5:07 AM, Sunil Pai G wrote: Currently the configure script provides no infomation but to update the pkg-config path on failure to link with DPDK. Fix this to provide more information to the user on failure. Before: checking whether linking with dpdk works... no configure: error:

[ovs-dev] [PATCH] TCP Stream: Use TCP keepalive by default

2021-10-25 Thread Michael Santana
In the case that a client disables jsonrpc probes the client would fail to detect if the connection to the server has dropped. To workaround such case TCP keepalive is enabled. Signed-off-by: Michael Santana --- lib/socket-util.c | 13 + lib/socket-util.h | 1 + lib/stream-fd.c

Re: [ovs-dev] [PATCH] ovsdb-server: add inactivity probe arg to ovsdb server

2021-10-15 Thread Michael Santana
On 10/14/21 8:45 PM, Seena Fallah wrote: Hi, I've made a patch in GitHub https://github.com/openvswitch/ovs/pull/371 Please review it. Hi Seena, We don't review pull request on github. The way to contribute is to send your patch to the mailing list. Take a look at the other patches on the

Re: [ovs-dev] [PATCH v2] ovsdb-server: Log database transactions for user requested tables.

2021-09-23 Thread Michael Santana
On 9/22/21 12:29 PM, Dumitru Ceara wrote: On 9/22/21 5:25 PM, Michael Santana wrote: On 9/22/21 3:24 AM, Dumitru Ceara wrote: On 9/21/21 6:12 PM, Michael Santana wrote: On 9/16/21 11:37 AM, Dumitru Ceara wrote: Add a new command, 'ovsdb-server/log-db-ops DB TABLE on|off', which allows

Re: [ovs-dev] [PATCH v2] sflow functions: fix unused parameter warnings for sflow functions

2021-09-22 Thread Michael Santana
warnings. You are right. The parameter 'now' is not used the poller, sampler, and receiver functions and should be removed. It looks like copy-paste error from sfl_agent_tick() since it has the same parameter signature Reviewed-by: Michael Santana Also, according to the 'utilities/checkpatch.py

Re: [ovs-dev] [PATCH ovn] controller: add memory accounting for if_status_mgr module

2021-09-22 Thread Michael Santana
On 9/16/21 8:56 AM, Lorenzo Bianconi wrote: Introduce memory accounting for data structures in ovn-controller if_status_mgr module. Signed-off-by: Lorenzo Bianconi --- controller/if-status.c | 23 +++ controller/if-status.h | 3 +++

Re: [ovs-dev] [PATCH v2] ovsdb-server: Log database transactions for user requested tables.

2021-09-22 Thread Michael Santana
On 9/22/21 3:24 AM, Dumitru Ceara wrote: On 9/21/21 6:12 PM, Michael Santana wrote: On 9/16/21 11:37 AM, Dumitru Ceara wrote: Add a new command, 'ovsdb-server/log-db-ops DB TABLE on|off', which allows the user to enable/disable transaction logging for specific databases and tables

Re: [ovs-dev] [PATCH v2] ovsdb-server: Log database transactions for user requested tables.

2021-09-21 Thread Michael Santana
On 9/16/21 11:37 AM, Dumitru Ceara wrote: Add a new command, 'ovsdb-server/log-db-ops DB TABLE on|off', which allows the user to enable/disable transaction logging for specific databases and tables. By default, logging is disabled. Once enabled, logs are generated with level INFO and are

Re: [ovs-dev] [PATCH] include/windows/unistd.h: fixed type cast warning on Windows

2021-09-03 Thread Michael Santana
` macros to use different cast functions, we can perform this cast directly. Signed-off-by: Sergey Madaminov Acked-by: Michael Santana --- include/windows/unistd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/windows/unistd.h b/include/windows/unistd.h index

Re: [ovs-dev] [PATCH] include/windows/unistd.h: fixed type cast warning on Windows

2021-09-02 Thread Michael Santana
On 8/26/21 11:45 AM, Sergey Madaminov wrote: Currently, the function call type cast for getting file handle produces a warning during OvS compilation on Windows with the following message: ``` ..\include\windows\unistd.h:97:25: warning: cast from function call of type 'intptr_t' (aka 'int')

Re: [ovs-dev] [PATCH] netdev-dpdk: Fix RSS configuration for virtio.

2021-09-02 Thread Michael Santana
Acked-by: Michael Santana Signed-off-by: David Marchand --- lib/netdev-dpdk.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 45a96b9be2..ca92c947a2 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -961,14

Re: [ovs-dev] [PATCH ovn v2] checkpatch: Avoid a case of catastrophic backtracking

2021-08-29 Thread Michael Santana
On Fri, Aug 27, 2021 at 12:18 PM Mark Michelson wrote: > > Hi Frode, > > This looks good to me, so > > Acked-by: Mark Michelson Acked-by: Michael Santana > > I have one small nit below, but I don't think you need to submit a v3 of > the patch. I think

Re: [ovs-dev] [PATCH] ovsdb-idl : Add APIs to query if a table and a column is present or not.

2021-08-20 Thread Michael Santana
On Wed, Aug 18, 2021 at 8:43 PM wrote: > > From: Numan Siddique > > This patch adds 2 new APIs in the ovsdb-idl client library > - ovsdb_idl_has_table() and ovsdb_idl_has_column_in_table() to > query if a table and a column is present in the IDL or not. This > is required for scenarios where

Re: [ovs-dev] [PATCH] python: Set probe interval before the connection is open

2021-08-20 Thread Michael Santana
gned-off-by: Renat Nurgaliyev Small enough change Acked-by Michael Santana > --- > python/ovs/jsonrpc.py | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/python/ovs/jsonrpc.py b/python/ovs/jsonrpc.py > index d5127268a..c60133369 100644 > --- a/p

Re: [ovs-dev] [PATCH ovn] checkpatch: Avoid a case of catastrophic backtracking

2021-08-20 Thread Michael Santana
On Fri, Aug 20, 2021 at 1:09 AM Frode Nordahl wrote: > > The checkpatch script will hang forever on line 282 of a otherwise > valid patch [0]. While the root of the issue is probably > somewhere between the regex itself and the Python re > implementation, this patch provides an early return to

Re: [ovs-dev] [PATCH] conntrack: remove the nat_action_info from the conn

2021-08-10 Thread Michael Santana
On Mon, Aug 9, 2021 at 11:41 PM wenxu wrote: > > > > > > > > > From: Michael Santana > Date: 2021-08-09 23:17:06 > To: we...@ucloud.cn > Cc: b...@ovn.org,Ilya Maximets > ,dlu...@gmail.com,d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH]

Re: [ovs-dev] [PATCH] conntrack: remove the nat_action_info from the conn

2021-08-09 Thread Michael Santana
nat_info->nat_action On Wed, Aug 4, 2021 at 11:20 PM wrote: > > From: wenxu > > Only the nat_action in the nat_action_info is used for conn > packet forward and other item such as min/max_ip/port only > used for the new conn operation. So the whole nat_ction_info > no need store in conn. This

Re: [ovs-dev] [PATCH 1/2] dpdk: Remove default values for socket-mem and limit.

2021-06-30 Thread Michael Santana
On Wed, Jun 30, 2021 at 4:48 PM Rosemarie O'Riorden wrote: > > From: Rosemarie O'Riorden > > This change removes the default values for EAL args socket-mem and > socket-limit. As DPDK supports dynamic memory allocation, there is no > need to allocate a certain amount of memory on start-up, nor

Re: [ovs-dev] [PATCH 2/2] dpdk: Stop configuring socket-limit with the value of socket-mem.

2021-06-30 Thread Michael Santana
On Wed, Jun 30, 2021 at 4:48 PM Rosemarie O'Riorden wrote: > > From: Rosemarie O'Riorden > > This change removes the automatic memory limit on start-up of OVS with > DPDK. As DPDK supports dynamic memory allocation, there is no > need to limit the amount of memory available, if not requested. >

Re: [ovs-dev] [PATCH branch-2.8/2.7] ovsdb-monitor.at: Use correct perl scripts.

2019-03-06 Thread Michael Santana Francisco
On 3/6/19 2:57 AM, Ilya Maximets wrote: On 06.03.2019 0:01, Michael Santana Francisco wrote: On 3/5/19 3:30 PM, Aaron Conole wrote: Ilya Maximets writes: Python scripts appeared only since OVS 2.9. This fixes unit test 'monitor-cond-change with many sessions pending'. Issue appered while

Re: [ovs-dev] [PATCH branch-2.8/2.7] ovsdb-monitor.at: Use correct perl scripts.

2019-03-05 Thread Michael Santana Francisco
sue on 2.7 and 2.8, but I had not yet seen your patch until a couple of minutes ago. I made the same exact fix you made, tested it, made a patch, I was getting ready to submit the patch, then I saw your patch and realized you already submitted a fix for it. It works, thanks. Acked-by: Micha

[ovs-dev] [BUILD branch-2.6-8, 11] Failure when executing 'make check'

2019-02-26 Thread Michael Santana Francisco
Hello all, I have been trying build OVS using `make check` but I have been getting errors on a couple of branches. All of the mentioned branches were built with this script. ./boot.sh ./configure --enable-Werror make check On each I got these results: branch-2.6    Build hung forever. I