[ovs-dev] [PATCH v8 7/8] ovn: avoid snat recirc only on gateway routers

-by: Mickey Spiegel <mickeys@gmail.com> --- include/ovn/actions.h | 3 +++ ovn/controller/lflow.c | 10 ++ ovn/lib/actions.c | 15 +-- tests/ovn.at | 2 +- 4 files changed, 23 insertions(+), 7 deletions(-) diff --git a/include/ovn/actions.h b/include/ovn/act

[ovs-dev] [PATCH v8 6/8] ovn: move load balancing flows after NAT flows

This will make it easy for distributed NAT to reuse some of the existing code for NAT flows, while leaving load balancing and defrag as functionality specific to gateway routers. There is no intent to change any functionality in this patch. Signed-off-by: Mickey Spiegel <mickeys@gmail.

[ovs-dev] [PATCH v8 4/8] ovn: Introduce distributed gateway port and "chassisredirect" port binding

edirect-chassis" option. There is no explicit notion of a "chassisredirect" port in the NB database. The expectation is when capabilities are implemented that take advantage of "chassisredirect" ports (e.g. distributed gateway ports), flows specifying a "chassisredirect&quo

[ovs-dev] [PATCH v8 5/8] ovn: add egress loopback capability

. Tests specific to egress loopback may be added once the capability to inject a packet with one of the flags bits set is added. Signed-off-by: Mickey Spiegel <mickeys@gmail.com> --- ovn/controller/physical.c | 38 ++ ovn/lib/logical-fields.c

[ovs-dev] [PATCH v8 1/8] ovn: specify addresses of type "router" lsps as "router"

itch ARP and ND replies. Since ipam already looks at logical router ports, the only ipam modification necessary is to skip logical switch ports with addresses "router". Signed-off-by: Mickey Spiegel <mickeys@gmail.com> Acked-by: Ben Pfaff <b...@ovn.or

[ovs-dev] [PATCH v8 2/8] ovn: document logical routers and logical patch ports in ovn-architecture

This patch adds a description of logical routers and logical patch ports, including gateway routers, to ovn/ovn-architecture.7.xml. Signed-off-by: Mickey Spiegel <mickeys@gmail.com> --- ovn/ovn-architecture.7.xml | 148 ++--- 1 file change

Re: [ovs-dev] [PATCH v7 3/7] ovn: Introduce "chassisredirect" port binding

On Fri, Jan 6, 2017 at 4:21 PM, Mickey Spiegel <mickeys@gmail.com> wrote: > > On Fri, Jan 6, 2017 at 4:11 PM, Ben Pfaff <b...@ovn.org> wrote: > >> On Fri, Jan 06, 2017 at 03:47:03PM -0800, Mickey Spiegel wrote: >> > On Fri, Jan 6, 2017 at 3:2

Re: [ovs-dev] [PATCH v7 3/7] ovn: Introduce "chassisredirect" port binding

On Fri, Jan 6, 2017 at 3:47 PM, Mickey Spiegel <mickeys@gmail.com> wrote: > > > On Fri, Jan 6, 2017 at 3:20 PM, Ben Pfaff <b...@ovn.org> wrote: > >> On Fri, Jan 06, 2017 at 12:00:30PM -0800, Mickey Spiegel wrote: >> > Currently OVN handles all logic

[ovs-dev] [PATCH v7 6/7] ovn: avoid snat recirc only on gateway routers

-by: Mickey Spiegel <mickeys@gmail.com> --- include/ovn/actions.h | 3 +++ ovn/controller/lflow.c | 10 ++ ovn/lib/actions.c | 15 +-- tests/ovn.at | 2 +- 4 files changed, 23 insertions(+), 7 deletions(-) diff --git a/include/ovn/actions.h b/include/ovn/act

[ovs-dev] [PATCH v7 5/7] ovn: move load balancing flows after NAT flows

This will make it easy for distributed NAT to reuse some of the existing code for NAT flows, while leaving load balancing and defrag as functionality specific to gateway routers. There is no intent to change any functionality in this patch. Signed-off-by: Mickey Spiegel <mickeys@gmail.

[ovs-dev] [PATCH v7 3/7] ovn: Introduce "chassisredirect" port binding

The expectation is when capabilities are implemented that take advantage of "chassisredirect" ports (e.g. NAT), the addition of flows specifying a "chassisredirect" port as the outport will also be triggered by the presence of the "redirect-chassis" option. Such flows a

[ovs-dev] [PATCH v7 4/7] ovn: add egress loopback capability

. Tests specific to egress loopback may be added once the capability to inject a packet with one of the flags bits set is added. Signed-off-by: Mickey Spiegel <mickeys@gmail.com> --- ovn/controller/physical.c | 38 ++ ovn/lib/logical-fields.c

[ovs-dev] [PATCH v7 2/7] ovn: add is_chassis_resident match expression component

". This allows higher level features to specify flows that are only installed on some chassis rather than on all chassis with the corresponding datapath. Suggested-by: Ben Pfaff <b...@ovn.org> Signed-off-by: Mickey Spiegel <mickeys@gmail.com> --- include/ovn/expr.h

[ovs-dev] [PATCH v7 1/7] ovn: specify addresses of type "router" lsps as "router"

itch ARP and ND replies. Since ipam already looks at logical router ports, the only ipam modification necessary is to skip logical switch ports with addresses "router". Signed-off-by: Mickey Spiegel <mickeys@gmail.com> Acked-by: Ben Pfaff <b...@ovn.or

[ovs-dev] [PATCH v7 0/7] ovn: add distributed NAT capability

utomated tests for is_chassis_resident (which is ready for review) and chassisredirect patches. Added flows to limit ICMP echo replies for router IPs on the gateway interface, so that they are only generated on the redirect-chassis. Mickey Spiegel (7): ovn: specify addresses of type "rout

Re: [ovs-dev] [PATCH v6 2/7] ovn: add is_chassis_resident match expression component

It looks like a commit yesterday https://github.com/openvswitch/ovs/commit/b34e898f3c2956bed4703aeebb7d454a72a69eed is causing the mismatch. Starting to rebase now. Mickey On Fri, Jan 6, 2017 at 9:23 AM, Ben Pfaff <b...@ovn.org> wrote: > On Thu, Jan 05, 2017 at 02:46:18AM -0800, Micke

Re: [ovs-dev] [PATCH v2 3/4] New action "ct_clear".

e another use case arises > later. > > Reported-by: Mickey Spiegel <mickeys@gmail.com> > Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2017- > January/326981.html > Fixes: 7ae62a676d3a ("ofp-actions: Add clone action.") > Signed-off-by: Ben Pfaff &l

Re: [ovs-dev] [PATCH 3/5] ofproto-dpif-xlate: Make "clone" save action set and stack.

ere can do much damage. > > Reported-by: Mickey Spiegel <mickeys@gmail.com> > Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2017- > January/326981.html > Fixes: 7ae62a676d3a ("ofp-actions: Add clone action.") > Signed-off-by: Ben Pfaff &l

Re: [ovs-dev] [PATCH 1/5] ovs-ofctl: Document the "clone" action.

On Thu, Jan 5, 2017 at 4:28 PM, Ben Pfaff <b...@ovn.org> wrote: > This was overlooked when "clone" was introduced. > > Fixes: 7ae62a676d3a ("ofp-actions: Add clone action.") > Signed-off-by: Ben Pfaff <b...@ovn.org> >

Re: [ovs-dev] Issues with the use of the clone action for resubmission to the pipeline

On Thu, Jan 5, 2017 at 4:28 PM, Ben Pfaff <b...@ovn.org> wrote: > On Tue, Jan 03, 2017 at 02:55:19AM -0800, Mickey Spiegel wrote: > > One of the motivations for clone is to use it as a lightweight way to > > resubmit to an earlier table at the beginning of the pipeline, with

[ovs-dev] [PATCH v6 6/7] ovn: avoid snat recirc only on gateway routers

-by: Mickey Spiegel <mickeys@gmail.com> --- include/ovn/actions.h | 3 +++ ovn/controller/lflow.c | 10 ++ ovn/lib/actions.c | 15 +-- tests/ovn.at | 2 +- 4 files changed, 23 insertions(+), 7 deletions(-) diff --git a/include/ovn/actions.h b/include/ovn/act

[ovs-dev] [PATCH v6 3/7] ovn: Introduce "chassisredirect" port binding

The expectation is when capabilities are implemented that take advantage of "chassisredirect" ports (e.g. NAT), the addition of flows specifying a "chassisredirect" port as the outport will also be triggered by the presence of the "redirect-chassis" option. Such flows a

[ovs-dev] [PATCH v6 1/7] ovn: specify addresses of type "router" lsps as "router"

itch ARP and ND replies. Since ipam already looks at logical router ports, the only ipam modification necessary is to skip logical switch ports with addresses "router". Signed-off-by: Mickey Spiegel <mickeys@gmail.com> --- ovn/northd/ovn-northd.c | 31

[ovs-dev] [PATCH v6 2/7] ovn: add is_chassis_resident match expression component

". This allows higher level features to specify flows that are only installed on some chassis rather than on all chassis with the corresponding datapath. Suggested-by: Ben Pfaff <b...@ovn.org> Signed-off-by: Mickey Spiegel <mickeys@gmail.com> --- include/ovn/expr.h

[ovs-dev] [PATCH v6 0/7] ovn: add distributed NAT capability

ateway router terminology. RFC v2 -> RFC v3 Reordered the first two patches. Moved non-NAT specific flows from patch 5 to patch 2. Added automated tests for is_chassis_resident (which is ready for review) and chassisredirect patches. Added flows to limit ICMP echo replies for router IPs on the

Re: [ovs-dev] [PATCH v5 0/6] ovn: add distributed NAT capability

On Wed, Jan 4, 2017 at 9:33 AM, Guru Shetty <g...@ovn.org> wrote: > > > On 3 January 2017 at 01:33, Mickey Spiegel <mickeys@gmail.com> wrote: > >> Currently OVN supports NAT functionality by connecting each distributed >> logical router to a central

[ovs-dev] Issues with the use of the clone action for resubmission to the pipeline

One of the motivations for clone is to use it as a lightweight way to resubmit to an earlier table at the beginning of the pipeline, without incurring all of the overhead associated with openflow patch ports. One such usage is in OVN, where a recent patch set replaced the use of openflow patch

[ovs-dev] [PATCH v5 6/6] ovn: distributed NAT flows

h NAT traffic, with most east/west traffic not requiring NAT. Automated tests are currently limited to only a single node. The single node automated tests cover both north/south and east/west traffic flows. Signed-off-by: Mickey Spiegel <mickeys@gmail.com> --- ovn/controlle

[ovs-dev] [PATCH v5 5/6] ovn: avoid snat recirc only on gateway routers

-by: Mickey Spiegel <mickeys@gmail.com> --- include/ovn/actions.h | 3 +++ ovn/controller/lflow.c | 10 ++ ovn/lib/actions.c | 15 +-- tests/ovn.at | 2 +- 4 files changed, 23 insertions(+), 7 deletions(-) diff --git a/include/ovn/actions.h b/include/ovn/act

[ovs-dev] [PATCH v5 2/6] ovn: Introduce "chassisredirect" port binding

The expectation is when capabilities are implemented that take advantage of "chassisredirect" ports (e.g. NAT), the addition of flows specifying a "chassisredirect" port as the outport will also be triggered by the presence of the "redirect-chassis" option. Signed-off-by: Mic

[ovs-dev] [PATCH v5 4/6] ovn: move load balancing flows after NAT flows

This will make it easy for distributed NAT to reuse some of the existing code for NAT flows, while leaving load balancing and defrag as functionality specific to gateway routers. There is no intent to change any functionality in this patch. Signed-off-by: Mickey Spiegel <mickeys@gmail.

[ovs-dev] [PATCH v5 3/6] ovn: add egress loopback capability

. Tests specific to egress loopback may be added once the capability to inject a packet with one of the flags bits set is added. Signed-off-by: Mickey Spiegel <mickeys@gmail.com> --- ovn/controller/physical.c | 38 ++ ovn/lib/logical-fields.c

[ovs-dev] [PATCH v5 1/6] ovn: add is_chassis_resident match expression component

". This allows higher level features to specify flows that are only installed on some chassis rather than on all chassis with the corresponding datapath. Suggested-by: Ben Pfaff <b...@ovn.org> Signed-off-by: Mickey Spiegel <mickeys@gmail.com> --- include/ovn/expr.h

[ovs-dev] [PATCH v5 0/6] ovn: add distributed NAT capability

dded flows to limit ICMP echo replies for router IPs on the gateway interface, so that they are only generated on the redirect-chassis. Mickey Spiegel (6): ovn: add is_chassis_resident match expression component ovn: Introduce "chassisredirect" port binding ovn: add egress loopback capabilit

Re: [ovs-dev] ovn ping from VM to external gateway IP failed.

On Mon, Jan 2, 2017 at 8:59 PM, Numan Siddique <nusid...@redhat.com> wrote: > > > On Tue, Jan 3, 2017 at 2:06 AM, Mickey Spiegel <mickeys@gmail.com> > wrote: > >> >> On Mon, Jan 2, 2017 at 3:46 AM, Numan Siddique <nusid...@redhat.com> >> w

Re: [ovs-dev] ovn ping from VM to external gateway IP failed.

On Mon, Jan 2, 2017 at 3:46 AM, Numan Siddique <nusid...@redhat.com> wrote: > > > On Mon, Jan 2, 2017 at 2:07 AM, Mickey Spiegel <mickeys@gmail.com> > wrote: > >> >> On Sun, Jan 1, 2017 at 10:31 AM, Numan Siddique <nusid...@redhat.com> >> w

Re: [ovs-dev] ovn ping from VM to external gateway IP failed.

On Sun, Jan 1, 2017 at 10:31 AM, Numan Siddique <nusid...@redhat.com> wrote: > > > On Sun, Jan 1, 2017 at 6:39 AM, Mickey Spiegel <mickeys@gmail.com> > wrote: > >> >> On Sat, Dec 31, 2016 at 1:19 AM, Mickey Spiegel <mickeys@gmail.com> >>

[ovs-dev] [PATCH] ofproto-dpif-xlate: After thawing, retrieve tunnel table from thawed xbridge

a packet from localnet to br-int, then freezing (e.g. for NAT on a gateway router or for distributed NAT), then attempting to send out a tunnel. Signed-off-by: Mickey Spiegel <mickeys@gmail.com> --- ofproto/ofproto-dpif-xlate.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

Re: [ovs-dev] ovn ping from VM to external gateway IP failed.

On Fri, Dec 30, 2016 at 11:37 AM, Mickey Spiegel <mickeys@gmail.com> wrote: > > On Fri, Dec 30, 2016 at 7:46 AM, Numan Siddique <nusid...@redhat.com> > wrote: > >> On Fri, Dec 30, 2016 at 5:36 PM, Dong Jun <do...@dtdream.com> wrote: >> > > &g

Re: [ovs-dev] ovn ping from VM to external gateway IP failed.

On Fri, Dec 30, 2016 at 7:46 AM, Numan Siddique wrote: > On Fri, Dec 30, 2016 at 5:36 PM, Dong Jun wrote: > > ​ > Hi Dong Jun, I am also facing the same issue on my setup. > ​ > These are the findings of my investigation so far > > Looks like this

[ovs-dev] [PATCH v4 6/6] ovn: distributed NAT flows

h NAT traffic, with most east/west traffic not requiring NAT. Automated tests are currently limited to only a single node. The single node automated tests cover both north/south and east/west traffic flows. Signed-off-by: Mickey Spiegel <mickeys@gmail.com> --- ovn/controlle

[ovs-dev] [PATCH v4 5/6] ovn: avoid snat recirc only on gateway routers

-by: Mickey Spiegel <mickeys@gmail.com> --- include/ovn/actions.h | 3 +++ ovn/controller/lflow.c | 10 ++ ovn/lib/actions.c | 15 +-- tests/ovn.at | 2 +- 4 files changed, 23 insertions(+), 7 deletions(-) diff --git a/include/ovn/actions.h b/include/ovn/act

[ovs-dev] [PATCH v4 2/6] ovn: Introduce "chassisredirect" port binding

The expectation is when capabilities are implemented that take advantage of "chassisredirect" ports (e.g. NAT), the addition of flows specifying a "chassisredirect" port as the outport will also be triggered by the presence of the "redirect-chassis" option. Signed-off-by: Mic

[ovs-dev] [PATCH v4 1/6] ovn: add is_chassis_resident match expression component

". This allows higher level features to specify flows that are only installed on some chassis rather than on all chassis with the corresponding datapath. Suggested-by: Ben Pfaff <b...@ovn.org> Signed-off-by: Mickey Spiegel <mickeys@gmail.com> --- include/ovn/expr.h

[ovs-dev] [PATCH v4 0/6] ovn: add distributed NAT capability

MP echo replies for router IPs on the gateway interface, so that they are only generated on the redirect-chassis. Mickey Spiegel (6): ovn: add is_chassis_resident match expression component ovn: Introduce "chassisredirect" port binding ovn: add egress loopback capability ovn: move loa

[ovs-dev] [PATCH v3 6/6] ovn: distributed NAT flows

h NAT traffic, with most east/west traffic not requiring NAT. Automated tests are currently limited to only a single node. The single node automated tests cover both north/south and east/west traffic flows. Signed-off-by: Mickey Spiegel <mickeys@gmail.com> --- ovn/controlle

[ovs-dev] [PATCH v3 4/6] ovn: move load balancing flows after NAT flows

This will make it easy for distributed NAT to reuse some of the existing code for NAT flows, while leaving load balancing and defrag as functionality specific to gateway routers. There is no intent to change any functionality in this patch. Signed-off-by: Mickey Spiegel <mickeys@gmail.

[ovs-dev] [PATCH v3 3/6] ovn: add egress loopback capability

. Tests specific to egress loopback may be added once the capability to inject a packet with one of the flags bits set is added. Signed-off-by: Mickey Spiegel <mickeys@gmail.com> --- ovn/controller/physical.c | 38 ++ ovn/lib/logical-fields.c

[ovs-dev] [PATCH v3 2/6] ovn: Introduce "chassisredirect" port binding

The expectation is when capabilities are implemented that take advantage of "chassisredirect" ports (e.g. NAT), the addition of flows specifying a "chassisredirect" port as the outport will also be triggered by the presence of the "redirect-chassis" option. Signed-off-by: Mic

[ovs-dev] [PATCH v3 0/6] ovn: add distributed NAT capability

gateway interface, so that they are only generated on the redirect-chassis. Mickey Spiegel (6): ovn: add is_chassis_resident match expression component ovn: Introduce "chassisredirect" port binding ovn: add egress loopback capability ovn: move load balancing flows after NA

[ovs-dev] [PATCH v3 1/6] ovn: add is_chassis_resident match expression component

". This allows higher level features to specify flows that are only installed on some chassis rather than on all chassis with the corresponding datapath. Suggested-by: Ben Pfaff <b...@ovn.org> Signed-off-by: Mickey Spiegel <mickeys@gmail.com> --- include/ovn/expr.h

[ovs-dev] [PATCH v2 6/6] ovn: distributed NAT flows

h NAT traffic, with most east/west traffic not requiring NAT. Automated tests are currently limited to only a single node. The single node automated tests cover both north/south and east/west traffic flows. Signed-off-by: Mickey Spiegel <mickeys@gmail.com> --- ovn/controlle

[ovs-dev] [PATCH v2 2/6] ovn: Introduce "chassisredirect" port binding

The expectation is when capabilities are implemented that take advantage of "chassisredirect" ports (e.g. NAT), the addition of flows specifying a "chassisredirect" port as the outport will also be triggered by the presence of the "redirect-chassis" option. Signed-off-by: Mic

[ovs-dev] [PATCH v2 4/6] ovn: move load balancing flows after NAT flows

This will make it easy for distributed NAT to reuse some of the existing code for NAT flows, while leaving load balancing and defrag as functionality specific to gateway routers. There is no intent to change any functionality in this patch. Signed-off-by: Mickey Spiegel <mickeys@gmail.

[ovs-dev] [PATCH v2 3/6] ovn: add egress loopback capability

. Tests specific to egress loopback may be added once the capability to inject a packet with one of the flags bits set is added. Signed-off-by: Mickey Spiegel <mickeys@gmail.com> --- ovn/controller/physical.c | 38 ++ ovn/lib/logical-fields.c

[ovs-dev] [PATCH v2 1/6] ovn: add is_chassis_resident match expression component

". This allows higher level features to specify flows that are only installed on some chassis rather than on all chassis with the corresponding datapath. Suggested-by: Ben Pfaff <b...@ovn.org> Signed-off-by: Mickey Spiegel <mickeys@gmail.com> --- include/ovn/expr.h

[ovs-dev] [PATCH v2 0/6] ovn: add distributed NAT capability

Added automated tests for is_chassis_resident (which is ready for review) and chassisredirect patches. Added flows to limit ICMP echo replies for router IPs on the gateway interface, so that they are only generated on the redirect-chassis. Mickey Spiegel (6): ovn: add is_chassis_resident match express

Re: [ovs-dev] [PATCH] ovs-advanced.rst: Add missing \ to a few examples.

On Tue, Dec 20, 2016 at 5:06 PM, Ben Pfaff <b...@ovn.org> wrote: > This makes these examples easier to cut and paste into a terminal, and > makes them consistent with the other examples. > > Signed-off-by: Ben Pfaff <b...@ovn.org> > Acked-by: Mickey Spi

[ovs-dev] [PATCH 5/6] ovn: avoid snat recirc only on gateway routers

-by: Mickey Spiegel <mickeys@gmail.com> --- include/ovn/actions.h | 3 +++ ovn/controller/lflow.c | 10 ++ ovn/lib/actions.c | 15 +-- tests/ovn.at | 2 +- 4 files changed, 23 insertions(+), 7 deletions(-) diff --git a/include/ovn/actions.h b/include/ovn/act

[ovs-dev] [PATCH 4/6] ovn: move load balancing flows after NAT flows

This will make it easy for distributed NAT to reuse some of the existing code for NAT flows, while leaving load balancing and defrag as functionality specific to gateway routers. There is no intent to change any functionality in this patch. Signed-off-by: Mickey Spiegel <mickeys@gmail.

[ovs-dev] [PATCH 2/6] ovn: Introduce "chassisredirect" port binding

The expectation is when capabilities are implemented that take advantage of "chassisredirect" ports (e.g. NAT), the addition of flows specifying a "chassisredirect" port as the outport will also be triggered by the presence of the "redirect-chassis" option. Signed-off-by: Mic

[ovs-dev] [PATCH 3/6] ovn: add egress loopback capability

. Tests specific to egress loopback may be added once the capability to inject a packet with one of the flags bits set is added. Signed-off-by: Mickey Spiegel <mickeys@gmail.com> --- ovn/controller/physical.c | 38 ++ ovn/lib/logical-fields.c

[ovs-dev] [PATCH 1/6] ovn: add is_chassis_resident match expression component

". This allows higher level features to specify flows that are only installed on some chassis rather than on all chassis with the corresponding datapath. Suggested-by: Ben Pfaff <b...@ovn.org> Signed-off-by: Mickey Spiegel <mickeys@gmail.com> --- include/ovn/expr.h

[ovs-dev] [PATCH 0/6] ovn: add distributed NAT capability

ch 5 to patch 2. Added automated tests for is_chassis_resident (which is ready for review) and chassisredirect patches. Added flows to limit ICMP echo replies for router IPs on the gateway interface, so that they are only generated on the redirect-chassis. Mickey Spiegel (6): ovn: add is_chassis_

[ovs-dev] [RFC v4 5/5] ovn: distributed NAT flows

h NAT traffic, with most east/west traffic not requiring NAT. Automated tests are currently limited to a single node with only north/south traffic. While the design accommodates east/west traffic, it depends on the presence of egress loopback, which has not yet been developed. Tests for east/west

[ovs-dev] [RFC v4 4/5] ovn: avoid snat recirc only on gateway routers

-by: Mickey Spiegel <mickeys@gmail.com> --- include/ovn/actions.h | 3 +++ ovn/controller/lflow.c | 10 ++ ovn/lib/actions.c | 15 +-- tests/ovn.at | 2 +- 4 files changed, 23 insertions(+), 7 deletions(-) diff --git a/include/ovn/actions.h b/include/ovn/act

[ovs-dev] [RFC v4 3/5] ovn: move load balancing flows after NAT flows

This will make it easy for distributed NAT to reuse some of the existing code for NAT flows, while leaving load balancing and defrag as functionality specific to gateway routers. There is no intent to change any functionality in this patch. Signed-off-by: Mickey Spiegel <mickeys@gmail.

[ovs-dev] [RFC v4 2/5] ovn: Introduce "chassisredirect" port binding

The expectation is when capabilities are implemented that take advantage of "chassisredirect" ports (e.g. NAT), the addition of flows specifying a "chassisredirect" port as the outport will also be triggered by the presence of the "redirect-chassis" option. Signed-off-by: Mic

[ovs-dev] [RFC v4 1/5] ovn: add is_chassis_resident match expression component

". This allows higher level features to specify flows that are only installed on some chassis rather than on all chassis with the corresponding datapath. Suggested-by: Ben Pfaff <b...@ovn.org> Signed-off-by: Mickey Spiegel <mickeys@gmail.com> --- include/ovn/expr.h

[ovs-dev] [PATCH] ovn: Log chassis claiming lport only when changes occur

generated when there is a change, for example when the chassis claims an lport the first time. Signed-off-by: Mickey Spiegel <mickeys@gmail.com> --- ovn/controller/binding.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/ovn/controller/bindi

Re: [ovs-dev] [PATCH v3 00/16] ovn: get rid of most uses of patch ports

On Sun, Dec 18, 2016 at 12:18 AM, Ben Pfaff wrote: > v1->v2: >- Fixed some bugs reported by Mickey throughout the series. >- Patches 1 and 2 are new. >- Patch 3 is modified in various ways, most notably to avoid using the >datapath "sample" action, to add a test,

Re: [ovs-dev] [PATCH v3 14/16] ovn-controller: Rename all_lports to local_lports.

-off-by: Ben Pfaff <b...@ovn.org> > Acked-by: Mickey Spiegel <mickeys@gmail.com> --- > ovn/controller/binding.c| 25 + > ovn/controller/ovn-controller.c | 14 ++ > 2 files changed, 23 insertions(+), 16 deletions(-) > > dif

Re: [ovs-dev] [PATCH v3 13/16] ovn-controller: Drop most uses of OVS patch ports.

ing rid of most of the patch ports > previously created by ovn-controller. > > Signed-off-by: Ben Pfaff <b...@ovn.org> > Acked-by: Mickey Spiegel <mickeys@gmail.com> --- > ovn/controller/binding.c| 19 > ovn/

Re: [ovs-dev] [PATCH v3 12/16] ovn-controller: Avoid code duplication getting chassis record.

On Sun, Dec 18, 2016 at 12:18 AM, Ben Pfaff <b...@ovn.org> wrote: > Signed-off-by: Ben Pfaff <b...@ovn.org> > Acked-by: Mickey Spiegel <mickeys@gmail.com> --- > ovn/controller/binding.c| 26 ++ > ovn/controller/binding.h

Re: [ovs-dev] [PATCH v3 11/16] pnysical: Factor code out of consider_port_binding().

On Sun, Dec 18, 2016 at 12:18 AM, Ben Pfaff <b...@ovn.org> wrote: > These functions will have an additional user in an upcoming commit. > > Signed-off-by: Ben Pfaff <b...@ovn.org> > Acked-by: Mickey Spiegel <mickeys@gmail.com> --- >

Re: [ovs-dev] [PATCH v3 10/16] ovn-controller: Handle only relevant ports and flows.

to > include any other datapath that can be reached from a VIF on the local > hypervisor, which is a simplification that makes the code easier to > understand in a few places. > > CC: Gurucharan Shetty <g...@ovn.org> > Signed-off-by: Ben Pfaff <b...@ovn.org> > Acked

Re: [ovs-dev] [PATCH v3 07/16] lport: Be a little more careful building lport index.

-off-by: Ben Pfaff <b...@ovn.org> Acked-by: Mickey Spiegel <mickeys@gmail.com> --- > ovn/controller/lport.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/ovn/controller/lport.c b/ovn/controller/lport.c > index e1ecf21..3484c2c 1

Re: [ovs-dev] [PATCH v3 06/16] ovn-controller: Make indexes more broadly available.

On Sun, Dec 18, 2016 at 12:18 AM, Ben Pfaff <b...@ovn.org> wrote: > This will allow binding_run() to use them in an upcoming commit. > > Signed-off-by: Ben Pfaff <b...@ovn.org> Acked-by: Mickey Spiegel <mickeys@gmail.com> --- > ovn/controller/ovn-controller.c

Re: [ovs-dev] [PATCH v2 00/11] ovn: get rid of most uses of patch ports

On Fri, Dec 16, 2016 at 2:51 PM, Guru Shetty wrote: > On 16 December 2016 at 14:25, Ben Pfaff wrote: > > > At least a v3 will be forthcoming to incorporate Darrell and Liran's > > "datapaths of interest" concept, but I said yesterday that I'd send a > > revised

Re: [ovs-dev] [PATCH 9/9] ovn-controller: Drop most uses of OVS patch ports.

On Thu, Dec 15, 2016 at 10:15 AM, Ben Pfaff wrote: > On Wed, Dec 07, 2016 at 10:46:22AM -0800, Ben Pfaff wrote: > > On Wed, Dec 07, 2016 at 10:08:25AM -0800, Guru Shetty wrote: > > > On 4 December 2016 at 23:17, Ben Pfaff wrote: > > > > > > > Until now,

[ovs-dev] [RFC v3 3/5] ovn: move load balancing flows after NAT flows

This will make it easy for distributed NAT to reuse some of the existing code for NAT flows, while leaving load balancing and defrag as functionality specific to gateway routers. There is no intent to change any functionality in this patch. Signed-off-by: Mickey Spiegel <mickeys@gmail.

[ovs-dev] [RFC v3 0/5] ovn: add distributed NAT capability

face, so that they are only generated on the redirect-chassis. Mickey Spiegel (5): ovn: add is_chassis_resident match expression component ovn: Introduce "chassisredirect" port binding ovn: move load balancing flows after NAT flows ovn: avoid snat recirc only on gatew

[ovs-dev] [RFC v3 5/5] ovn: distributed NAT flows

Tests for east/west traffic will be added in the future. Signed-off-by: Mickey Spiegel <mickeys@gmail.com> --- ovn/controller/ovn-controller.c | 6 +- ovn/northd/ovn-northd.8.xml | 271 +-- ovn/northd/ovn-northd.c | 344 ++

[ovs-dev] [RFC v3 2/5] ovn: Introduce "chassisredirect" port binding

The expectation is when capabilities are implemented that take advantage of "chassisredirect" ports (e.g. NAT), the addition of flows specifying a "chassisredirect" port as the outport will also be triggered by the presence of the "redirect-chassis" option. Signed-off-by:

Re: [ovs-dev] [patch_v10] ovn: Add datapaths of interest filtering.

On Tue, Dec 6, 2016 at 7:53 PM, Darrell Ball <db...@vmware.com> wrote: > > > On 12/4/16, 9:48 PM, "ovs-dev-boun...@openvswitch.org on behalf of Mickey > Spiegel" <ovs-dev-boun...@openvswitch.org on behalf of > mickeys@gmail.com> wrote: > > On Sun

Re: [ovs-dev] [PATCH 9/9] ovn-controller: Drop most uses of OVS patch ports.

See my comments. SNAT and DNAT zones should be based on peer when sending the packet back around to ingress. Mickey On Wed, Dec 7, 2016 at 10:46 AM, Ben Pfaff wrote: > On Wed, Dec 07, 2016 at 10:08:25AM -0800, Guru Shetty wrote: > > On 4 December 2016 at 23:17, Ben Pfaff

Re: [ovs-dev] [PATCH 5/9] lport: Add index for logical datapaths.

etion should not be in this patch, it should be in patch 6. Acked-by: Mickey Spiegel <mickeys@gmail.com> > Signed-off-by: Ben Pfaff <b...@ovn.org> > --- > ovn/controller/lport.c | 62 ++ > +++ > ovn/controller/lport.h | 33 +

Re: [ovs-dev] [PATCH 4/9] lport: Tolerate null pointers in destroy functions.

On Sun, Dec 4, 2016 at 11:17 PM, Ben Pfaff <b...@ovn.org> wrote: > The coding style says to do this. > > The actual caller doesn't pass a null pointer. > Acked-by: Mickey Spiegel <mickeys@gmail.com> > Signed-off-by: Ben Pfaff <b...@ovn.org> > --- > o

Re: [ovs-dev] [PATCH 3/9] lport: Be a little more careful building lport index.

On Sun, Dec 4, 2016 at 11:17 PM, Ben Pfaff <b...@ovn.org> wrote: > It seems like a good idea to check for and warn about all kinds of > duplicates, and to avoid segfaulting if a datapath column is empty. > (However, the database schema should prevent both issues.) > Acked-

Re: [ovs-dev] [PATCH 6/9] ovn-controller: Handle only relevant ports and flows.

On Sun, Dec 4, 2016 at 11:17 PM, Ben Pfaff wrote: > On a particular hypervisor, ovn-controller only needs to handle ports > and datapaths that have some relationship with it, that is, the > ports that actually reside on the hypervisor, plus all the other ports on > those ports'

Re: [ovs-dev] [PATCH 9/9] ovn-controller: Drop most uses of OVS patch ports.

On Sun, Dec 4, 2016 at 11:17 PM, Ben Pfaff wrote: > Until now, ovn-controller has implemented OVN logical patch ports and > l3gateway ports in terms of OVS patch ports. It is a hassle to create and > destroy ports, and it is also wasteful compared to what the patch ports >

Re: [ovs-dev] [patch_v10] ovn: Add datapaths of interest filtering.

On Sun, Dec 4, 2016 at 4:13 PM, Darrell Ball wrote: > This patch adds datapaths of interest support where only datapaths of > local interest are monitored by the ovn-controller ovsdb client. The > idea is to do a flood fill in ovn-controller of datapath associations >

Re: [ovs-dev] [patch_v9] ovn: Add datapaths of interest filtering.

On Thu, Dec 1, 2016 at 8:07 PM, Darrell Ball wrote: > This patch adds datapaths of interest support where only datapaths of > local interest are monitored by the ovn-controller ovsdb client. The > idea is to do a flood fill in ovn-controller of datapath associations >

Re: [ovs-dev] [PATCH v2] ovn-controller: Remove unused members from local_datapath.

it is safer to remove it. Acked-by: Mickey Spiegel <mickeys@gmail.com> > > Signed-off-by: Ben Pfaff <b...@ovn.org> > --- > v1->v2: I found some more members that were unused. > > ovn/controller/binding.c| 2 -- > ovn/controller/ovn-controller.c |

Re: [ovs-dev] [PATCH v4] ovn-northd: Force SNAT for multiple gateway routers.

On Tue, Nov 29, 2016 at 9:12 AM, Guru Shetty <g...@ovn.org> wrote: > > > On 28 November 2016 at 19:33, Mickey Spiegel <mickeys@gmail.com> > wrote: > >> Acked-by: Mickey Spiegel <mickeys@gmail.com> >> > > Thank you for the thorough review

Re: [ovs-dev] [PATCH v4] ovn-northd: Force SNAT for multiple gateway routers.

Acked-by: Mickey Spiegel <mickeys@gmail.com> A few comments and nits below. On Thu, Nov 17, 2016 at 10:17 PM, Gurucharan Shetty <g...@ovn.org> wrote: > When multiple gateway routers exist, a packet can > enter any gateway router. Once the packet reaches its > des

Re: [ovs-dev] [PATCH v3 2/2] ovn-northd: Force SNAT for multiple gateway routers.

On Sun, Nov 13, 2016 at 11:15 PM, Gurucharan Shetty wrote: > When multiple gateway routers exist, a packet can > enter any gateway router. Once the packet reaches its > destination, its reverse direction should be via the > same gateway router. This is achieved by doing a SNAT >

<    1   2