Re: [ovs-dev] [RFC] tc: use pedit add actions for ipv4 and ipv6 dec ttl

2022-03-01 Thread Pieter Jansen van Vuuren
On 01/03/2022 08:33, Eelco Chaudron wrote: > CAUTION: This message has originated from an External Source. Please use > proper judgment and caution when opening attachments, clicking links, or > responding to this email. > > > On 28 Feb 2022, at 19:01, Pieter Janse

Re: [ovs-dev] [RFC] tc: use pedit add actions for ipv4 and ipv6 dec ttl

2022-02-28 Thread Pieter Jansen van Vuuren
On 25/02/2022 13:20, Eelco Chaudron wrote: > CAUTION: This message has originated from an External Source. Please use > proper judgment and caution when opening attachments, clicking links, or > responding to this email. > > > On 25 Feb 2022, at 13:57, Pieter Janse

Re: [ovs-dev] [RFC] tc: use pedit add actions for ipv4 and ipv6 dec ttl

2022-02-25 Thread Pieter Jansen van Vuuren
On 25/02/2022 10:08, Simon Horman wrote: > Hi Pieter, > > nice to hear from you :) Hi Simon. Thank you for the insightful feedback. > > On Tue, Feb 22, 2022 at 12:17:40PM +, pieter.jansen-van-vuu...@amd.com > wrote: >> From: Pieter Jansen van Vuuren >>

Re: [ovs-dev] [RFC/PATCH] tc: use pedit add actions for ipv4 and ipv6 dec ttl

2022-02-24 Thread Pieter Jansen van Vuuren
-vuu...@xilinx.com wrote: > >> From: Pieter Jansen van Vuuren >> >> Previously when making use of the tc datapath to achieve decrement ttl, we >> would >> install a filter that matches on the ttl/hoplimit field and use a pedit set >> action >> to set

Re: [ovs-dev] [PATCH v2 1/2] netdev-linux: Add coverage counters for netdev_set_policing when ingress tc-offload

2019-04-09 Thread Pieter Jansen van Vuuren
On 07/04/2019 16:10, Tonghao Zhang wrote: > When enable tc-offload, we should add coverage counters for > netdev_set_policing. > > Fixes: e7f6ba220e10 ("lib/tc: add ingress ratelimiting support for > tc-offload") > Cc: Pieter Jansen van Vuuren > Signed-off-

[ovs-dev] [RFC v1] lib/tc: add ingress ratelimiting support for tc-offload

2019-02-01 Thread Pieter Jansen van Vuuren
-vsctl list interface _uuid : 2ca774e8-8b95-430f-a2c2-f8f742613ab1 admin_state : up ... ingress_policing_burst: 100 ingress_policing_rate: 5000 ... type: "" Signed-off-by: Pieter Jansen van Vuuren Reviewed-by: Simon Horman --- include/linux/pkt_cl

[ovs-dev] [RFC v3 3/4] lib/tc: add set ipv4 dscp and ecn action offload via pedit

2019-01-28 Thread Pieter Jansen van Vuuren
Add setting of ipv4 dscp and ecn fields in tc offload using pedit. Signed-off-by: Pieter Jansen van Vuuren Signed-off-by: Louis Peens Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 6 +- lib/tc.c | 5 + lib/tc.h | 1 + 3 files changed, 11

[ovs-dev] [RFC v3 4/4] lib/tc: add set ipv6 traffic class action offload via pedit

2019-01-28 Thread Pieter Jansen van Vuuren
Extend ovs-tc translation by allowing non-byte-aligned fields for set actions. Use new boundary shifts and add set ipv6 traffic class action offload via pedit. Signed-off-by: Pieter Jansen van Vuuren Signed-off-by: Louis Peens Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 4

[ovs-dev] [RFC v3 1/4] lib/tc: make pedit mask calculations byte order agnostic

2019-01-28 Thread Pieter Jansen van Vuuren
although we are not in a position to test that. Signed-off-by: Pieter Jansen van Vuuren Reviewed-by: Simon Horman --- include/sparse/automake.mk | 3 ++- include/sparse/linux/tc_act/tc_pedit.h | 29 ++ lib/tc.c | 22

[ovs-dev] [RFC v3 2/4] lib/tc: fix 32 bits shift for pedit offset calculation

2019-01-28 Thread Pieter Jansen van Vuuren
relied on, and appears logically correct as the desire is for no trailing bytes (or bits!) to be omitted from the set action. Signed-off-by: Pieter Jansen van Vuuren Reviewed-by: Simon Horman --- lib/tc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/tc.c b/lib/tc.c

[ovs-dev] [RFC v3 0/4] extend ovs-tc offload for more pedit action

2019-01-28 Thread Pieter Jansen van Vuuren
ork around be32 issue. - Fix big endian issue (patch 1). - Fix 32 bit shift (patch 2). v1 -> v2: - Move helpers from byte-order.h to local tc.c - Swap htonl/ntohl and reword comment. Pieter Jansen van Vuuren (4): lib/tc: make pedit mask calculations byte order agnostic lib/tc: fix 32 bits

Re: [ovs-dev] [RFC v2 2/2] lib/tc: add set ipv6 traffic class action offload via pedit

2019-01-18 Thread Pieter Jansen van Vuuren
On 17/01/2019 17:26, Ben Pfaff wrote: > On Thu, Jan 17, 2019 at 12:55:54PM +0000, Pieter Jansen van Vuuren wrote: >> On 16/01/2019 18:38, Ben Pfaff wrote: >>> On Wed, Jan 16, 2019 at 09:04:16AM +0000, Pieter Jansen van Vuuren wrote: >>>> +/* These functions spe

Re: [ovs-dev] [RFC v2 2/2] lib/tc: add set ipv6 traffic class action offload via pedit

2019-01-17 Thread Pieter Jansen van Vuuren
On 16/01/2019 18:38, Ben Pfaff wrote: > On Wed, Jan 16, 2019 at 09:04:16AM +0000, Pieter Jansen van Vuuren wrote: >> +/* These functions specifically help shifting values that are in >> + * network byte order but stored in uint32_t variables. */ >> +static uint32_t shift_o

[ovs-dev] [RFC v2 2/2] lib/tc: add set ipv6 traffic class action offload via pedit

2019-01-16 Thread Pieter Jansen van Vuuren
Extend ovs-tc translation by allowing non-byte-aligned fields for set actions. Use new boundary shifts and add set ipv6 traffic class action offload via pedit. Signed-off-by: Pieter Jansen van Vuuren Signed-off-by: Louis Peens Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 4

[ovs-dev] [RFC v2 1/2] lib/tc: add set ipv4 dscp and ecn action offload via pedit

2019-01-16 Thread Pieter Jansen van Vuuren
Add setting of ipv4 dscp and ecn fields in tc offload using pedit. Signed-off-by: Pieter Jansen van Vuuren Signed-off-by: Louis Peens Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 6 +- lib/tc.c | 5 + lib/tc.h | 1 + 3 files changed, 11

[ovs-dev] [RFC v2 0/2] extend ovs-tc offload for more pedit action

2019-01-16 Thread Pieter Jansen van Vuuren
to be offloaded. v1 -> v2: - Move helpers from byte-order.h to local tc.c - Swap htonl/ntohl and reword comment. Pieter Jansen van Vuuren (2): lib/tc: add set ipv4 dscp and ecn action offload via pedit lib/tc: add set ipv6 traffic class action offload via pedit lib/netdev-tc-offloads.c |

Re: [ovs-dev] [RFC 2/2] lib/tc: add set ipv6 traffic class action offload via pedit

2019-01-13 Thread Pieter Jansen van Vuuren
On 11/01/2019 18:02, Ben Pfaff wrote: > On Fri, Jan 11, 2019 at 05:35:45PM +0000, Pieter Jansen van Vuuren wrote: >> On 11/01/2019 16:49, Ben Pfaff wrote: >>> On Fri, Jan 11, 2019 at 11:51:53AM +0000, Pieter Jansen van Vuuren wrote: >>>> +/* These functions sp

Re: [ovs-dev] [RFC 2/2] lib/tc: add set ipv6 traffic class action offload via pedit

2019-01-11 Thread Pieter Jansen van Vuuren
On 11/01/2019 16:49, Ben Pfaff wrote: > On Fri, Jan 11, 2019 at 11:51:53AM +0000, Pieter Jansen van Vuuren wrote: >> +/* These functions specifically help shifting words in network >> + * byte order, given that they are specified in host order. */ >> +static inline uint32_t &g

[ovs-dev] [RFC 1/2] lib/tc: add set ipv4 dscp and ecn action offload via pedit

2019-01-11 Thread Pieter Jansen van Vuuren
Add setting of ipv4 dscp and ecn fields in tc offload using pedit. Signed-off-by: Pieter Jansen van Vuuren Signed-off-by: Louis Peens Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 6 +- lib/tc.c | 5 + lib/tc.h | 1 + 3 files changed, 11

[ovs-dev] [RFC 0/2] extend ovs-tc offload for more pedit action

2019-01-11 Thread Pieter Jansen van Vuuren
to be offloaded. Pieter Jansen van Vuuren (2): lib/tc: add set ipv4 dscp and ecn action offload via pedit lib/tc: add set ipv6 traffic class action offload via pedit lib/byte-order.h | 18 +++ lib/netdev-tc-offloads.c | 10 +- lib/tc.c | 66

[ovs-dev] [PATCH v4 0/2] add TC offload support for geneve with options

2018-09-18 Thread Pieter Jansen van Vuuren
This series adds match and action support for TC offload of geneve tunnel with options. Pieter Jansen van Vuuren (2): lib/tc: add geneve with option encap action offload lib/tc: add geneve with option match offload include/linux/pkt_cls.h | 25 ++ include/linux/tc_act

[ovs-dev] [PATCH v4 1/2] lib/tc: add geneve with option encap action offload

2018-09-18 Thread Pieter Jansen van Vuuren
Add TC offload support for encapsulating geneve tunnels with options. Signed-off-by: Pieter Jansen van Vuuren Reviewed-by: Simon Horman --- include/linux/tc_act/tc_tunnel_key.h | 23 lib/netdev-tc-offloads.c | 30 + lib/tc.c | 157

[ovs-dev] [PATCH v4 2/2] lib/tc: add geneve with option match offload

2018-09-18 Thread Pieter Jansen van Vuuren
Add TC offload support for classifying geneve tunnels with options. Signed-off-by: Pieter Jansen van Vuuren Reviewed-by: Simon Horman --- include/linux/pkt_cls.h | 25 + lib/netdev-tc-offloads.c | 64 + lib/tc.c | 198

[ovs-dev] [PATCH branch-2.10] lib/tc: treat vlan id and prio as independent fields

2018-09-13 Thread Pieter Jansen van Vuuren
Signed-off-by: Pieter Jansen van Vuuren Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 2 ++ lib/tc.c | 6 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/lib/netdev-tc-offloads.c b/lib/netdev-tc-offloads.c index 64f431c8d..f998ddfe1 100644 --- a/lib

Re: [ovs-dev] [PATCH] lib/tc: treat vlan id and prio as independent fields

2018-09-11 Thread Pieter Jansen van Vuuren
On 10/09/2018 14:24, Simon Horman wrote: > On Mon, Sep 10, 2018 at 11:08:25AM +0100, Pieter Jansen van Vuuren wrote: >> Previously the key was used to check the presence of vlan id and >> prio fields instead of using the mask. Additionally the vlan id >> field was considered

[ovs-dev] [PATCH] lib/tc: treat vlan id and prio as independent fields

2018-09-10 Thread Pieter Jansen van Vuuren
Signed-off-by: Pieter Jansen van Vuuren Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 4 lib/tc.c | 12 ++-- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/lib/netdev-tc-offloads.c b/lib/netdev-tc-offloads.c index f7a175484..090662d54 100644

[ovs-dev] [PATCH v3 2/2] lib/tc: add geneve with option match offload

2018-09-05 Thread Pieter Jansen van Vuuren
Add TC offload support for classifying geneve tunnels with options. Signed-off-by: Pieter Jansen van Vuuren Reviewed-by: Simon Horman --- include/linux/pkt_cls.h | 25 +++ lib/netdev-tc-offloads.c | 14 ++ lib/tc.c | 96 lib

[ovs-dev] [PATCH v3 1/2] lib/tc: add geneve with option encap action offload

2018-09-05 Thread Pieter Jansen van Vuuren
Add TC offload support for encapsulating geneve tunnels with options. Signed-off-by: Pieter Jansen van Vuuren Reviewed-by: Simon Horman --- include/linux/tc_act/tc_tunnel_key.h | 23 ++ lib/netdev-tc-offloads.c | 30 +++ lib/tc.c | 114

[ovs-dev] [PATCH v3 0/2] add TC offload support for geneve with options

2018-09-05 Thread Pieter Jansen van Vuuren
This series adds match and action support for TC offload of geneve tunnel with options. Pieter Jansen van Vuuren (2): lib/tc: add geneve with option encap action offload lib/tc: add geneve with option match offload include/linux/pkt_cls.h | 25 include/linux/tc_act

[ovs-dev] [PATCH v2] lib/tc: add single mpls match offload support

2018-09-02 Thread Pieter Jansen van Vuuren
Add TC offload support for classifying single MPLS tagged traffic. Signed-off-by: Pieter Jansen van Vuuren Reviewed-by: Simon Horman Reviewed-by: John Hurley --- lib/netdev-tc-offloads.c | 14 ++-- lib/tc.c | 69 lib/tc.h

[ovs-dev] [PATCH v2 2/2] lib/tc: add geneve with option match offload

2018-09-02 Thread Pieter Jansen van Vuuren
Add TC offload support for classifying geneve tunnels with options. Signed-off-by: Pieter Jansen van Vuuren Reviewed-by: Simon Horman --- include/linux/pkt_cls.h | 25 +++ lib/netdev-tc-offloads.c | 14 ++ lib/tc.c | 94 lib

[ovs-dev] [PATCH v2 1/2] lib/tc: add geneve with option encap action offload

2018-09-02 Thread Pieter Jansen van Vuuren
Add TC offload support for encapsulating geneve tunnels with options. Signed-off-by: Pieter Jansen van Vuuren Reviewed-by: Simon Horman --- include/linux/tc_act/tc_tunnel_key.h | 23 ++ lib/netdev-tc-offloads.c | 30 +++ lib/tc.c | 113

[ovs-dev] [PATCH v2 0/2] add TC offload support for geneve with options

2018-09-02 Thread Pieter Jansen van Vuuren
This series adds match and action support for TC offload of geneve tunnel with options. Pieter Jansen van Vuuren (2): lib/tc: add geneve with option encap action offload lib/tc: add geneve with option match offload include/linux/pkt_cls.h | 25 include/linux/tc_act

Re: [ovs-dev] [PATCH ovs 1/2] lib/tc: add geneve with option encap action offload

2018-08-30 Thread Pieter Jansen van Vuuren
On 30/08/2018 14:33, Simon Horman wrote: > Hi Pieter, > > On Tue, Aug 21, 2018 at 02:49:45PM +0100, Pieter Jansen van Vuuren wrote: >> Add TC offload support for encapsulating geneve tunnels with options. >> >> Signed-off-by: Pieter Jansen van Vuuren >> >>

Re: [ovs-dev] [PATCH] lib/tc: add single mpls match offload support

2018-08-30 Thread Pieter Jansen van Vuuren
On 30/08/2018 14:28, Simon Horman wrote: > Hi Pieter, > > On Thu, Aug 23, 2018 at 03:47:58PM +0100, Pieter Jansen van Vuuren wrote: >> Add TC offload support for classifying single MPLS tagged traffic. >> >> Signed-off-by: Pieter Jansen van Vuuren >> >>

[ovs-dev] [PATCH] lib/tc: add single mpls match offload support

2018-08-23 Thread Pieter Jansen van Vuuren
Add TC offload support for classifying single MPLS tagged traffic. Signed-off-by: Pieter Jansen van Vuuren Reviewed-by: Simon Horman Reviewed-by: John Hurley --- lib/netdev-tc-offloads.c | 14 ++-- lib/tc.c | 69 lib/tc.h

[ovs-dev] [PATCH ovs 2/2] lib/tc: add geneve with option match offload

2018-08-21 Thread Pieter Jansen van Vuuren
Add TC offload support for classifying geneve tunnels with options. Signed-off-by: Pieter Jansen van Vuuren Reviewed-by: Simon Horman --- include/linux/pkt_cls.h | 25 +++ lib/netdev-tc-offloads.c | 14 ++ lib/tc.c | 94 lib

[ovs-dev] [PATCH ovs 1/2] lib/tc: add geneve with option encap action offload

2018-08-21 Thread Pieter Jansen van Vuuren
Add TC offload support for encapsulating geneve tunnels with options. Signed-off-by: Pieter Jansen van Vuuren Reviewed-by: Simon Horman --- include/linux/tc_act/tc_tunnel_key.h | 23 ++ lib/netdev-tc-offloads.c | 30 lib/tc.c | 106

[ovs-dev] [PATCH ovs 0/2] add TC offload support for geneve with options

2018-08-21 Thread Pieter Jansen van Vuuren
This series adds match and action support for TC offload of geneve tunnel with options. Pieter Jansen van Vuuren (2): lib/tc: add geneve with option encap action offload lib/tc: add geneve with option match offload include/linux/pkt_cls.h | 25 include/linux/tc_act