Re: [ovs-dev] [PATCH v4 0/9] Add offload support for sFlow

2020-10-11 Thread Roni Bar Yanai
Hi Ilya, please see inline >-Original Message- >From: Chris Mi >Sent: Friday, September 25, 2020 3:40 PM >To: Roni Bar Yanai ; i.maxim...@ovn.org; >d...@openvswitch.org >Cc: sriharsha.basavapa...@broadcom.com; Eli Britstein ; >hemal.s...@broadcom.com; ian.st

Re: [ovs-dev] OvS-DPDK change interface MAC

2020-05-17 Thread Roni Bar Yanai
Hi Ravi, The patch only configures internal ports of OVS, other ports are blocked (you can look at the code). We currently looking for a solution for setting the MAC in case of switchmod when VF is in passthrough and VM is untrusted. why do you need to change the mac address on the fly?

Re: [ovs-dev] [PATCH 1/1] vswitchd: Allow setting MAC on DPDK interfaces

2020-04-20 Thread Roni Bar Yanai
defend against misuse of bifurcated drivers. Any thoughts? >-Original Message- >From: dev On Behalf Of Roni Bar Yanai >Sent: Sunday, January 26, 2020 9:47 AM >To: Ben Pfaff >Cc: d...@openvswitch.org; Adrian Chiris ; Ilya Maximets >; Ameer Mahagneh ; Eveline >Raine &

Re: [ovs-dev] [PATCH] docs: Update conntrack established state description

2020-02-24 Thread Roni Bar Yanai
>-Original Message- >From: Yi-Hung Wei >Sent: Saturday, February 22, 2020 12:51 AM >To: d...@openvswitch.org; Roni Bar Yanai >Cc: Yi-Hung Wei >Subject: [PATCH] docs: Update conntrack established state description > >Patch a867c010ee91 ("conntrack: Fi

Re: [ovs-dev] [PATCH] conntrack: Fix conntrack new state

2020-02-20 Thread Roni Bar Yanai
Hi Yi-Hung, >From the man page, it looks like the +est is the result of committing action >and not related to the TCP state machine itself. I'm aware that this is not how it works in kernel conntrack, if you want to align both , the description might need an update. new (0x01)

Re: [ovs-dev] [PATCH 1/1] vswitchd: Allow setting MAC on DPDK interfaces

2020-01-25 Thread Roni Bar Yanai
Thanks Ben. >-Original Message- >From: Ben Pfaff >Sent: Thursday, January 23, 2020 11:33 PM >To: Roni Bar Yanai >Cc: Ilya Maximets ; Ophir Munk >; Eveline Raine ; >d...@openvswitch.org; Moshe Levi ; Adrian Chiris >; Majd Dibbiny ; Ameer >Mahagneh >Sub

Re: [ovs-dev] [PATCH 1/1] vswitchd: Allow setting MAC on DPDK interfaces

2020-01-22 Thread Roni Bar Yanai
t;From: Roni Bar Yanai >Sent: Monday, January 13, 2020 1:24 PM >To: Ilya Maximets ; Ophir Munk >; Ben Pfaff >Cc: Eveline Raine ; d...@openvswitch.org; Moshe Levi >; Adrian Chiris ; Majd Dibbiny >; Ameer Mahagneh >Subject: RE: [PATCH 1/1] vswitchd: Allow setting MAC on DPDK inter

Re: [ovs-dev] [PATCHv6] userspace: Add GTP-U support.

2020-01-21 Thread Roni Bar Yanai
Hi William, Two comments, please inline. >-Original Message- >From: William Tu >Sent: Thursday, January 16, 2020 9:45 PM >To: d...@openvswitch.org >Cc: Roni Bar Yanai ; acon...@redhat.com; >yangy...@inspur.com; fhal...@redhat.com; ashishvarma@gmail.com; >

Re: [ovs-dev] [PATCH 1/1] vswitchd: Allow setting MAC on DPDK interfaces

2020-01-13 Thread Roni Bar Yanai
>-Original Message- >From: Ilya Maximets >Sent: Thursday, January 9, 2020 3:28 PM >To: Ophir Munk ; Ben Pfaff ; Ilya >Maximets >Cc: Eveline Raine ; d...@openvswitch.org; Moshe Levi >; Adrian Chiris ; Majd Dibbiny >; Roni Bar Yanai ; Ameer >Mahagneh >Sub

[ovs-dev] [RFC] odp-execute: dp_hash HW offload inconsistency.

2020-01-08 Thread Roni Bar Yanai
Hi Ilya, I have a setup with vxlan, and then I do dp_hash (after pop). First packet does pop in SW, so RSS is invalidated (and anyway it was probably calculated on outer), dp_hash is calculated again SW. Following packet will do decap in HW so packet has a valid internal RSS (mark+rss), And

Re: [ovs-dev] [PATCHv4] userspace: Add GTP-U support.

2020-01-06 Thread Roni Bar Yanai
Hi William, See inline >-Original Message- >From: William Tu >Sent: Thursday, December 12, 2019 7:25 PM >To: Roni Bar Yanai >Cc: d...@openvswitch.org >Subject: Re: [ovs-dev] [PATCHv4] userspace: Add GTP-U support. > >On Thu, Dec 12, 2019 at 07:28:27AM +, Ron

Re: [ovs-dev] [PATCHv4] userspace: Add GTP-U support.

2019-12-11 Thread Roni Bar Yanai
to the same core (per direction, according to RSS symmetric cfg). See inline. >-Original Message- >From: William Tu >Sent: Wednesday, December 11, 2019 8:20 PM >To: Roni Bar Yanai >Cc: d...@openvswitch.org >Subject: Re: [ovs-dev] [PATCHv4] userspace: Add GTP-U support.

Re: [ovs-dev] [PATCHv4] userspace: Add GTP-U support.

2019-12-08 Thread Roni Bar Yanai
Hi William, GTP-U header size is not constant, you *must* take into account the flags, mainly the sequence. The use of sequence in GTP-U is optional but some devices do use it. see from 3GPP definition: "For PGW, SGW and eNodeB the usage of sequence numbers in G-PDUs is optional, but if

[ovs-dev] [RFC v2] netdev-dpdk: setting VF MAC address

2019-10-30 Thread Roni Bar Yanai
On cloud topology with hardware offload, when SR-IOV is used there is an architecture limitation to configure the VF from the host. The port representor is attached to OVS, while the VF is usually configured in pass through to the VM. In such topology the MAC address of the VF is configured by

Re: [ovs-dev] [PATCH ovs v3 0/2] Introduce dpdkvdpa netdev

2019-10-28 Thread Roni Bar Yanai
Hi ilya, please see inline >-Original Message- >From: Ilya Maximets >Sent: Monday, October 28, 2019 3:46 PM >To: Noa Levy ; ovs-dev@openvswitch.org; Roni Bar Yanai > >Cc: Oz Shlomo ; Majd Dibbiny ; >Ameer Mahagneh ; Eli Britstein >; William Tu ; Simon Horman

[ovs-dev] [RFC} netdev-dpdk: setting VF MAC address

2019-09-24 Thread Roni Bar Yanai
On cloud topology with hardware offload, when SR-IOV is used there is an architecture limitation to configure the VF from the host. The port representor is attached to OVS, while the VF is usually configured in pass through to the VM. In such topology the MAC address of the VF is configured by the

Re: [ovs-dev] [PATCH v4 1/4] netdev: Dynamic per-port Flow API.

2019-06-10 Thread Roni Bar Yanai
Hi Ilya, See inline >-Original Message- >From: Ilya Maximets >Sent: Thursday, June 6, 2019 2:19 PM >To: Roni Bar Yanai ; Ophir Munk >; Roi Dayan ; ovs- >d...@openvswitch.org >Cc: Ian Stokes ; Flavio Leitner ; >Kevin >Traynor ; Finn Christensen ; Ben >Pfaf

Re: [ovs-dev] [PATCH v4 1/4] netdev: Dynamic per-port Flow API.

2019-06-06 Thread Roni Bar Yanai
e should block this as well. BR, Roni >-Original Message- >From: Ilya Maximets >Sent: Monday, June 3, 2019 6:30 PM >To: Ophir Munk ; Roi Dayan ; >ovs-dev@openvswitch.org >Cc: Ian Stokes ; Flavio Leitner ; >Kevin >Traynor ; Roni Bar Yanai ; Finn >Christensen

Re: [ovs-dev] [PATCH 0/2] dpif-netdev: Flow mark leak + cross-dp offloading.

2019-06-06 Thread Roni Bar Yanai
Acked-By: Roni Bar Yanai >-Original Message- >From: Ilya Maximets >Sent: Thursday, June 6, 2019 1:16 PM >To: ovs-dev@openvswitch.org >Cc: Ian Stokes ; Flavio Leitner ; >Ophir >Munk ; Kevin Traynor ; Roni >Bar Yanai >Subject: Re: [PATCH 0/2] dpif-netdev

Re: [ovs-dev] [RFC V2] netdev-rte-offloads: HW offload virtio-forwarder

2019-05-27 Thread Roni Bar Yanai
that works with virtio hw-offload. We are checking your patch, let's see the performance we can get. >-Original Message- >From: Ilya Maximets >Sent: Monday, May 27, 2019 11:32 AM >To: Roni Bar Yanai ; Simon Horman > >Cc: ovs-dev@openvswitch.org; Ian Stokes ; Kevin Traynor >;

Re: [ovs-dev] [RFC V2] netdev-rte-offloads: HW offload virtio-forwarder

2019-05-24 Thread Roni Bar Yanai
Hi Ilya, (S See inline. >-Original Message- >From: Ilya Maximets >Sent: Friday, May 24, 2019 3:21 PM >To: Simon Horman ; Roni Bar Yanai > >Cc: ovs-dev@openvswitch.org; Ian Stokes ; Kevin Traynor >; Oz Shlomo ; Eli Britstein >; Eyal Lavee ; Rony Efraim >; Be

Re: [ovs-dev] [RFC V2] netdev-rte-offloads: HW offload virtio-forwarder

2019-05-16 Thread Roni Bar Yanai
>-Original Message- >From: Ilya Maximets >Sent: Wednesday, May 15, 2019 4:37 PM >To: Roni Bar Yanai ; ovs-dev@openvswitch.org; Ian >Stokes ; Kevin Traynor >Cc: Eyal Lavee ; Oz Shlomo ; Eli >Britstein ; Rony Efraim ; Asaf >Penso >Subject: Re: [RFC V2] netd

Re: [ovs-dev] [RFC V2] netdev-rte-offloads: HW offload virtio-forwarder

2019-05-15 Thread Roni Bar Yanai
age- >From: Ilya Maximets >Sent: Wednesday, May 15, 2019 2:25 PM >To: Roni Bar Yanai ; ovs-dev@openvswitch.org; Ian >Stokes ; Kevin Traynor >Cc: Eyal Lavee ; Oz Shlomo ; Eli >Britstein ; Rony Efraim ; Asaf >Penso >Subject: Re: [RFC V2] netdev-rte-offloads:

[ovs-dev] [RFC V2] netdev-rte-offloads: HW offload virtio-forwarder

2019-05-06 Thread Roni Bar Yanai
Background == OVS HW offload solution is consisted of forwarding and control. HW implements embedded switch that connects SRIOV VF's and forwards packets according to the dynamically configured HW rules (packets can be altered by HW rules). Packets that have no forwarding rule, called

[ovs-dev] [RFC] netdev-rte-offloads: HW offload virtio-forwarder

2019-05-06 Thread Roni Bar Yanai
Background == OVS HW offload solution is consisted of forwarding and control. HW implements embedded switch that connects SRIOV VF's and forwards packets according to the dynamically configured HW rules (packets can be altered by HW rules). Packets that have no forwarding rule, called

Re: [ovs-dev] [ovs-dev, v1] netdev-rte-offloads: Reassign vport netdev functions.

2019-04-30 Thread Roni Bar Yanai
Aaron, please see inline. >-Original Message- >From: ovs-dev-boun...@openvswitch.org >On Behalf Of Aaron Conole >Sent: Monday, April 29, 2019 4:44 PM >To: Ilya Maximets >Cc: ovs-dev@openvswitch.org; Thomas Monjalon >Subject: Re: [ovs-dev] [ovs-dev, v1] netdev-rte-offloads: Reassign

Re: [ovs-dev] [PATCH] netdev: Dynamic per-port Flow API.

2019-04-24 Thread Roni Bar Yanai
Hi Ilya, Please see comment/clarification inline. Thanks, Roni >-Original Message- >From: Ilya Maximets >Sent: Wednesday, April 24, 2019 6:12 PM >To: Ophir Munk ; ovs-dev@openvswitch.org >Cc: Ian Stokes ; Flavio Leitner ; >Kevin >Traynor ; Roni Bar Yanai ; Finn >

Re: [ovs-dev] [PATCH v1] netdev-vport: Check DPDK_NETDEV for offloaded API.

2019-04-10 Thread Roni Bar Yanai
>-Original Message- >From: Ilya Maximets >Sent: Wednesday, April 10, 2019 5:21 PM >To: Ophir Munk ; ovs-dev@openvswitch.org >Cc: Ian Stokes ; Olga Shern ; >Kevin Traynor ; Asaf Penso ; >Roni Bar Yanai ; Paul Blakey ; >Roi Dayan ; Flavio Leitner >Subject:

Re: [ovs-dev] [PATCH] netdev-rte-offloads: Fix printing masks with wrong byte order.

2019-03-31 Thread Roni Bar Yanai
Looks good. > -Original Message- > From: Ilya Maximets > Sent: Tuesday, March 26, 2019 2:43 PM > To: ovs-dev@openvswitch.org; Ian Stokes > Cc: Ophir Munk ; Roni Bar Yanai > ; Ilya Maximets > Subject: [PATCH] netdev-rte-offloads: Fix printing masks with wrong byte

Re: [ovs-dev] [PATCH] netdev-rte-offloads: Add thread-safety notes.

2019-03-21 Thread Roni Bar Yanai
Looks good. > -Original Message- > From: Ilya Maximets > Sent: Wednesday, March 20, 2019 1:15 PM > To: ovs-dev@openvswitch.org; Ian Stokes > Cc: Flavio Leitner ; Ophir Munk > ; Kevin Traynor ; Roni Bar > Yanai ; Finn Christensen ; Asaf > Penso ; Ilya Maximets &

Re: [ovs-dev] [PATCH v1] dpif: Add marked packets stats

2019-03-12 Thread Roni Bar Yanai
> -Original Message- > From: Ilya Maximets > Sent: Tuesday, March 12, 2019 5:25 PM > To: Roni Bar Yanai ; Ophir Munk > ; ovs-dev@openvswitch.org > Cc: Asaf Penso ; Ian Stokes ; > Shahaf Shuler ; Olga Shern > ; Kevin Traynor > Subject: Re: [PATCH v1] dpi

Re: [ovs-dev] [PATCH v1] dpif: Add marked packets stats

2019-03-12 Thread Roni Bar Yanai
> -Original Message- > From: Ilya Maximets > Sent: Tuesday, March 12, 2019 11:11 AM > To: Ophir Munk ; ovs-dev@openvswitch.org > Cc: Asaf Penso ; Ian Stokes ; > Shahaf Shuler ; Olga Shern > ; Kevin Traynor ; Roni Bar > Yanai > Subject: Re: [PATCH v1] dpi

Re: [ovs-dev] [PATCH v2 2/3] netdev-dpdk: Move offloading-code to a new file

2019-02-26 Thread Roni Bar Yanai
> -Original Message- > From: Ilya Maximets > Sent: Tuesday, February 26, 2019 4:38 PM > To: Roni Bar Yanai ; Ophir Munk > ; ovs-dev@openvswitch.org > Cc: Ian Stokes ; Olga Shern ; > Kevin Traynor ; Asaf Penso ; > Flavio Leitner > Subject: Re: [PATC

Re: [ovs-dev] [PATCH v2 1/3] netdev-dpdk: Expose flow creation/destruction calls

2019-02-22 Thread Roni Bar Yanai
> -Original Message- > From: Ilya Maximets > Sent: Friday, February 22, 2019 1:26 PM > To: Roni Bar Yanai ; Ophir Munk > ; ovs-dev@openvswitch.org > Cc: Ian Stokes ; Olga Shern ; > Kevin Traynor ; Asaf Penso ; > Flavio Leitner > Subject: Re: [PATCH v2 1/

Re: [ovs-dev] [PATCH v2 1/3] netdev-dpdk: Expose flow creation/destruction calls

2019-02-21 Thread Roni Bar Yanai
> -Original Message- > From: Ilya Maximets > Sent: Thursday, February 21, 2019 5:27 PM > To: Ophir Munk ; ovs-dev@openvswitch.org > Cc: Ian Stokes ; Olga Shern ; > Kevin Traynor ; Asaf Penso ; > Roni Bar Yanai ; Flavio Leitner > Subject: Re: [PATCH v2 1/3]

Re: [ovs-dev] [PATCH v2 2/3] netdev-dpdk: Move offloading-code to a new file

2019-02-21 Thread Roni Bar Yanai
> -Original Message- > From: Ilya Maximets > Sent: Thursday, February 21, 2019 6:20 PM > To: Ophir Munk ; ovs-dev@openvswitch.org > Cc: Ian Stokes ; Olga Shern ; > Kevin Traynor ; Asaf Penso ; > Roni Bar Yanai ; Flavio Leitner > Subject: Re: [PATCH v2 2/3] netd

Re: [ovs-dev] [PATCH v1 0/3] Move offloading-code into a new file

2019-02-21 Thread Roni Bar Yanai
> -Original Message- > From: Flavio Leitner > Sent: Thursday, February 21, 2019 1:40 PM > To: Ophir Munk > Cc: Ilya Maximets ; ovs-dev@openvswitch.org; > Ian Stokes ; Olga Shern ; > Kevin Traynor ; Asaf Penso ; > Roni Bar Yanai ; Shahaf Shuler > ; Finn

Re: [ovs-dev] [PATCH v1 0/3] Move offloading-code into a new file

2019-02-20 Thread Roni Bar Yanai
dpdk_port. RTE_FLOW is a framework on top of DPDK. BR, Roni > -Original Message- > From: Ilya Maximets > Sent: Wednesday, February 20, 2019 7:06 PM > To: Ophir Munk ; ovs-dev@openvswitch.org > Cc: Ian Stokes ; Olga Shern ; > Kevin Traynor ; Asaf Penso ; > Roni Bar