[ovs-dev] [PATCH] ofproto-dpif: Fix vxlan with different name del/add failed.

2024-03-12 Thread Tao Liu
ge_add_ports bridge_add_ports__ iface_create iface_do_create ofproto_port_add<-- p1 add failed Fixes: fe83f81df977 ("netdev: Remove netdev from global shash when the user is changing interface configuration.") Signed-off-by: Tao Liu --- of

Re: [ovs-dev] [RFC] bridge: Retry tunnel port addition for conflict.

2024-03-12 Thread Tao Liu
On 03/11 , Ilya Maximets wrote: > On 3/11/24 06:17, Han Zhou wrote: > > > > > > On Fri, Mar 8, 2024 at 12:17 AM Tao Liu > <mailto:taoliu...@163.com>> wrote: > >> > >> > >> On 3/7/24 5:39 AM, Ilya Maximets wrote: > >> > O

Re: [ovs-dev] [RFC] bridge: Retry tunnel port addition for conflict.

2024-03-08 Thread Tao Liu
On 3/7/24 5:39 AM, Ilya Maximets wrote: On 2/27/24 20:14, Han Zhou wrote: For kernel datapath, when a new tunnel port is created in the same transaction in which an old tunnel port with the same tunnel configuration is deleted, the new tunnel port creation will fail and left in an error state.

Re: [ovs-dev] [PATCH] ovsdb-idl: Reparse reference src before dst is deleted

2024-01-04 Thread Tao Liu
On 1/4/24 7:56 PM, Ilya Maximets wrote: On 7/4/23 12:41, Tao Liu wrote: Hi, Ilya. Thanks for your comment. On 7/4/23 4:10 AM, Ilya Maximets wrote: On 7/2/23 11:59, Tao Liu wrote: Commit 02f31a1262fc has fixed the row references when insertion and deletion execute in one IDL run. However

Re: [ovs-dev] [PATCH] ovsdb-idl: Reparse reference src before dst is deleted

2023-07-04 Thread Tao Liu
Hi, Ilya. Thanks for your comment. On 7/4/23 4:10 AM, Ilya Maximets wrote: On 7/2/23 11:59, Tao Liu wrote: Commit 02f31a1262fc has fixed the row references when insertion and deletion execute in one IDL run. However, we can still hit ovn-controller crash in pressure test where pb->datap

[ovs-dev] [PATCH] ovsdb-idl: Reparse reference src before dst is deleted

2023-07-02 Thread Tao Liu
ert port_binding insert datapath_binding update2: delete datapath_binding delete port_binding Fix it by reparse reference src before dst deletion. Fixes: 02f31a1262fc ("ovsdb-idl: Preserve references for rows deleted in same IDL run as their insertion.") Signed-off-by: Tao

Re: [ovs-dev] [PATCH 1/2] ovn-controller.c: Fix assertion failure during address set update.

2023-07-02 Thread Tao Liu
Sorry to send wrong patch. On 7/2/23 5:57 PM, Tao Liu wrote: From: Han Zhou When an address set is deleted and a new one is created immediately with the same name, the OVSDB deletion and creation notifications can come to ovn-controller within the same message, and the order of the deletion

[ovs-dev] [PATCH 1/2] ovn-controller.c: Fix assertion failure during address set update.

2023-07-02 Thread Tao Liu
From: Han Zhou When an address set is deleted and a new one is created immediately with the same name, the OVSDB deletion and creation notifications can come to ovn-controller within the same message, and the order of the deletion and addition in the IDL is undefined. In this case, if the

[ovs-dev] [PATCH ovn v2] northd: fix use-after-free after lrp destroyed

2023-05-04 Thread Tao Liu
ld_lflows(). CallTrace: build_lswitch_rport_arp_req_flows build_lswitch_ip_unicast_lookup build_lswitch_and_lrouter_iterate_by_op build_lflows en_lflow_run engine_recompute engine_run inc_proc_northd_run main Fixes: 3044132261d3 ("northd: Enhance implementation of port tunnel key requests."

Re: [ovs-dev] [PATCH ovn] northd: fix use-after-free after lrp destroyed

2023-05-04 Thread Tao Liu
On 4/24/23 9:06 PM, Simon Horman wrote: On Thu, Apr 20, 2023 at 01:24:08PM +0800, Tao Liu wrote: In vxlan mode with more than 2047 lrp in router, build_ports() prints "all port tunnel ids exhausted", and frees the lrp port. However, lsp of type "router" connected to

[ovs-dev] [PATCH ovn] northd: fix use-after-free after lrp destroyed

2023-04-20 Thread Tao Liu
ld_lflows(). CallTrace: build_lswitch_rport_arp_req_flows build_lswitch_ip_unicast_lookup build_lswitch_and_lrouter_iterate_by_op build_lflows en_lflow_run engine_recompute engine_run inc_proc_northd_run main Fixes: 3044132261d3 ("northd: Enhance implementation of port tunnel key reques

Re: [ovs-dev] [PATCH v3 1/2] netdev: clear auto_classified if netdev reopens of type system

2022-07-04 Thread Tao Liu
On 07/04 , Roi Dayan wrote: > > > On 2022-06-30 11:34 AM, Tao Liu wrote: > > When netdev first opened by netdev_open(..., NULL, ...), netdev_class sets > > to system by default, and auto_classified sets to true. > > > > If netdev reopens by netdev_open(...

[ovs-dev] [PATCH v3 2/2] netdev-linux: do not touch LAG slaves if master is not attached to ovs.

2022-06-30 Thread Tao Liu
tc q ls dev net3 ingress Fixes: d22f8927c3c9 ("netdev-linux: monitor and offload LAG slaves to TC") Signed-off-by: Tao Liu --- lib/netdev-linux.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c index 9d12502..b9e0

[ovs-dev] [PATCH v3 1/2] netdev: clear auto_classified if netdev reopens of type system

2022-06-30 Thread Tao Liu
2c225e481d ("netdev: Fix netdev_open() to track and recreate classless interfaces") Signed-off-by: Tao Liu --- lib/netdev.c | 41 +++-- 1 file changed, 23 insertions(+), 18 deletions(-) diff --git a/lib/netdev.c b/lib/netdev.c index 8305f6c..b97408b 10064

Re: [ovs-dev] [PATCH v2] netdev-linux: do not touch LAG slaves if master is not attached to ovs.

2022-06-29 Thread Tao Liu
On Mon, Jun 27, 2022 at 03:47:34PM +0300, Roi Dayan wrote: > > could it be your bond0 configuration? > beside doing +bond0 into /sys/class/net/bonding_masters how do you > config bond0 and its slave? > > I don't have any static config file and use ip commands > as follows: > > ip link add name

Re: [ovs-dev] [PATCH v2] netdev-linux: do not touch LAG slaves if master is not attached to ovs.

2022-06-27 Thread Tao Liu
On Mon, Jun 27, 2022 at 11:51:48AM +0300, Roi Dayan wrote: > > > On 2022-06-27 10:49 AM, Tao Liu wrote: > > On Mon, Jun 27, 2022 at 09:40:38AM +0300, Roi Dayan wrote: > > > > > > > > > On 2022-06-23 12:42 PM, Roi Dayan wrote: > > > > &g

Re: [ovs-dev] [PATCH v2] netdev-linux: do not touch LAG slaves if master is not attached to ovs.

2022-06-27 Thread Tao Liu
On Mon, Jun 27, 2022 at 09:40:38AM +0300, Roi Dayan wrote: > > > On 2022-06-23 12:42 PM, Roi Dayan wrote: > > > > > > On 2022-06-22 11:56 PM, Marcelo Ricardo Leitner wrote: > > > On Wed, Jun 22, 2022 at 11:10:17AM +0800, Tao Liu wrote: > > > > O

Re: [ovs-dev] [PATCH v2] netdev-linux: do not touch LAG slaves if master is not attached to ovs.

2022-06-21 Thread Tao Liu
On Tue, Jun 21, 2022 at 06:49:42AM -0700, Marcelo Ricardo Leitner wrote: > Hi, > > On Tue, Jun 21, 2022 at 02:10:39PM +0800, Tao Liu wrote: > > Bond master netdev may be created without a classification type, due > > to routing or tunneling code. > > Can

[ovs-dev] [PATCH v2] netdev-linux: do not touch LAG slaves if master is not attached to ovs.

2022-06-21 Thread Tao Liu
: d22f8927c3c9 ("netdev-linux: monitor and offload LAG slaves to TC") Signed-off-by: Tao Liu --- lib/netdev-linux.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c index 9d12502..b9e0c99 100644 --- a/lib/netdev-linux.c +++ b/

Re: [ovs-dev] [PATCH] netdev-tc-offloads: avoid dup ufid in mapping

2022-06-13 Thread Tao Liu
On Mon, May 30, 2022 at 06:01:56PM +0300, Roi Dayan wrote: > > > On 2022-03-22 2:04 PM, Tao Liu wrote: > > If netdev goes away(i.e. qemu with a vnet shutdown), kernel delete all tc > > filters, those tcf_id related to the netdev will be left in ufid_to_tc > >

Re: [ovs-dev] [PATCH v2 1/3] ofproto-dpif-xlate: No clone when tunnel push is last action

2022-04-13 Thread Tao Liu
On Wed, Apr 13, 2022 at 05:30:19PM -0400, Rosemarie O'Riorden wrote: > When OVS sees a tunnel push with a nested list next, it will not > clone the packet, as a clone is not needed. However, a clone action will > still be created with the tunnel push encapulated inside. There is no > need to

Re: [ovs-dev] [PATCH] netdev-tc-offloads: avoid dup ufid in mapping

2022-03-29 Thread Tao Liu
On Tue, Mar 29, 2022 at 11:25:38AM +0200, Eelco Chaudron wrote: > > > On 29 Mar 2022, at 10:37, Tao Liu wrote: > > > On Mon, Mar 28, 2022 at 04:08:29PM +0200, Eelco Chaudron wrote: > >> On Mon, Mar 28, 2022 at 3:15 PM Eelco Chaudron wrote: > >> > >&g

Re: [ovs-dev] [PATCH] netdev-tc-offloads: avoid dup ufid in mapping

2022-03-29 Thread Tao Liu
On Mon, Mar 28, 2022 at 04:08:29PM +0200, Eelco Chaudron wrote: > On Mon, Mar 28, 2022 at 3:15 PM Eelco Chaudron wrote: > > > > > > > On 25 Mar 2022, at 18:05, Tao Liu wrote: > > > > > On Fri, Mar 25, 2022 at 12:08:20PM +0100, Eelco Chaudron wrote: > &

Re: [ovs-dev] [PATCH] netdev-tc-offloads: avoid dup ufid in mapping

2022-03-25 Thread Tao Liu
On Fri, Mar 25, 2022 at 12:08:20PM +0100, Eelco Chaudron wrote: > > > On 22 Mar 2022, at 13:04, Tao Liu wrote: > > > If netdev goes away(i.e. qemu with a vnet shutdown), kernel delete all tc > > filters, those tcf_id related to the netdev will be left in ufid_to_tc &g

[ovs-dev] [PATCH] netdev-tc-offloads: avoid dup ufid in mapping

2022-03-22 Thread Tao Liu
will insert before the new one, delete or modify tc flow will always fail. So delete the stale entry to avoid a duplicated ufid in hashmap. Fixes: dd8ca104acd7 ("netdev-tc-offloads: Don't delete ufid mapping if fail to delete filter"))) Signed-off-by: Tao Liu --- lib/netdev-offload

[ovs-dev] [PATCH net v2] openvswitch: meter: fix race when getting now_ms.

2021-05-13 Thread Tao Liu
ovn.org/ Fixes: 96fbc13d7e77 ("openvswitch: Add meter infrastructure") Signed-off-by: Tao Liu Suggested-by: Ilya Maximets --- Changelog: v2: just set negative long_delta_ms to zero in case of race for meter lock. v1: make now_ms protected by meter lock. --- net/openvswitch/meter.c | 8 ++

[ovs-dev] [PATCH net] openvswitch: meter: fix race when getting now_ms.

2021-05-13 Thread Tao Liu
gt;bucket += delta_ms * band->rate; then we get a wrong band->bucket. Fixes: 96fbc13d7e77 ("openvswitch: Add meter infrastructure") Signed-off-by: Tao Liu --- net/openvswitch/meter.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/openvswitch/meter.c b/net/

[ovs-dev] [PATCH] netdev-linux: do not touch LAG slaves if master is not attached to ovs.

2021-03-19 Thread Tao Liu
Bond master netdev may be created without a classification type, due to routing or tunneling code. If bond master is not attached to ovs, the slaves shoud not be updated. Fixes: d22f8927c3c9 ("netdev-linux: monitor and offload LAG slaves to TC") CC: John Hurley Signed-off-by: Tao Liu

[ovs-dev] [PATCH] netdev-linux: do not touch LAG slaves if master is not attached to ovs.

2021-03-19 Thread Tao Liu
Bond master netdev may be created without a classification type, due to routing or tunneling code. If bond master is not attached to ovs, the slaves shoud not be updated. Fixes: d22f8927c3c9 ("netdev-linux: monitor and offload LAG slaves to TC") CC: John Hurley Signed-off-by: Tao Liu