[ovs-dev] [PATCH v8] rhel: Make the version, displayed to the user, customizable.

2024-04-15 Thread Timothy Redaelli
an OVS version suffix that should be shown to the user via ovs-vsctl -V and, so, also on database, on ovs-vsctl show and the other utilities. --with-version-suffix is used in Fedora/CentOS/RHEL spec file in order to have the version be aligned with the downstream one. Signed-off-by: Timothy Redaelli

[ovs-dev] [PATCH v7] rhel: make the version, displayed to the user, customizable

2024-04-03 Thread Timothy Redaelli
an OVS version suffix that should be shown to the user via ovs-vsctl -V and, so, also on database, on ovs-vsctl show and the other utilities. --with-version-suffix is used in Fedora/CentOS/RHEL spec file in order to have the version be aligned with the downstream one. Signed-off-by: Timothy Redaelli

[ovs-dev] [PATCH v2] bfd: Improve state change log message.

2024-03-05 Thread Timothy Redaelli
-> (bfd.SessionState: up, bfd.LocalDiag: "Neighbor Signaled Session Down") Reported-by: Alex Stupnikov Reported-at: https://bugzilla.redhat.com/2258496 Signed-off-by: Timothy Redaelli --- v1 -> v2: Restructured the message format as suggested by Ilya Maximets and Eelco Chaudron

[ovs-dev] [PATCH] tests: Fix "SSL db: implementation" test with openssl > 3.2.0.

2024-03-05 Thread Timothy Redaelli
and the post-openssl 3.2.0 error message: "ssl/tls alert certificate unknown". Signed-off-by: Timothy Redaelli --- tests/ovsdb-server.at | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/ovsdb-server.at b/tests/ovsdb-server.at index b8ccc4c8e..35447a52e 10

[ovs-dev] [PATCH] bfd: Improve state change log message.

2024-02-04 Thread Timothy Redaelli
t failure: "Neighbor Signaled Session Down". Reported-by: Alex Stupnikov Reported-at: https://bugzilla.redhat.com/2258496 Signed-off-by: Timothy Redaelli --- lib/bfd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/bfd.c b/lib/bfd.c index 9698576d0..8033c51

[ovs-dev] [PATCH v6] rhel: make the version, displayed to the user, customizable

2023-08-09 Thread Timothy Redaelli
an OVS version suffix that should be shown to the user via ovs-vsctl -V and, so, also on database, on ovs-vsctl show and the other utilities. --with-version-suffix is used in Fedora/CentOS/RHEL spec file in order to have the version be aligned with the downstream one. Signed-off-by: Timothy Redaelli

[ovs-dev] [PATCH v5] rhel: make the version, displayed to the user, customizable

2023-06-27 Thread Timothy Redaelli
an OVS version suffix that should be shown to the user via ovs-vsctl -V and, so, also on database, on ovs-vsctl show and the other utilities. --with-version-suffix is used in Fedora/CentOS/RHEL spec file in order to have the version be aligned with the downstream one. Signed-off-by: Timothy Redaelli

[ovs-dev] [PATCH v4] rhel: make the version, displayed to the user, customizable

2023-06-20 Thread Timothy Redaelli
an OVS version suffix that should be shown to the user via ovs-vsctl -V and, so, also on database, on ovs-vsctl show and the other utilities. --with-version-suffix is used in Fedora/CentOS/RHEL spec file in order to have the version be aligned with the downstream one. Signed-off-by: Timothy Redaelli

[ovs-dev] [PATCH v2 1/1] utilities/bashcomp: Fix PS1 generation on new bash

2023-05-26 Thread Timothy Redaelli
on Bash >= 4.4. Reported-at: https://bugzilla.redhat.com/2170344 Reported-by: Martin Necas Signed-off-by: Timothy Redaelli --- utilities/ovs-appctl-bashcomp.bash | 7 +++ utilities/ovs-vsctl-bashcomp.bash | 7 +++ 2 files changed, 14 insertions(+) diff --git a/utilities/ovs-app

[ovs-dev] [PATCH v2 0/1] Fix PS1 generation on new bash

2023-05-26 Thread Timothy Redaelli
v1 -> v2: Split if to avoid line > 79 characters Timothy Redaelli (1): utilities/bashcomp: Fix PS1 generation on new bash utilities/ovs-appctl-bashcomp.bash | 7 +++ utilities/ovs-vsctl-bashcomp.bash | 7 +++ 2 files changed, 14 insertions(+) --

[ovs-dev] [PATCH] utilities/bashcomp: Fix PS1 generation on new bash

2023-05-26 Thread Timothy Redaelli
on Bash >= 4.4. Reported-at: https://bugzilla.redhat.com/2170344 Reported-by: Martin Necas Signed-off-by: Timothy Redaelli --- utilities/ovs-appctl-bashcomp.bash | 6 ++ utilities/ovs-vsctl-bashcomp.bash | 6 ++ 2 files changed, 12 insertions(+) diff --git a/utilities/ovs-app

[ovs-dev] [PATCH v3] rhel: make the version, displayed to the user, customizable

2023-05-26 Thread Timothy Redaelli
an OVS version suffix that should be shown to the user via ovs-vsctl -V and, so, also on database, on ovs-vsctl show and the other utilities. --with-version-suffix is used in Fedora/CentOS/RHEL spec file in order to have the version be aligned with the downstream one. Signed-off-by: Timothy Redaelli

[ovs-dev] [PATCH] rhel: avoid creating an empty database file

2022-12-16 Thread Timothy Redaelli
itch owner to openvswitch:hugetlbfs, if built with dpdk, or openvswitch:openvswitch. Fixes: 59e8cb8a053d ("rhel: Move conf.db to /var/lib/openvswitch, using symlinks.") Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2022-December/400045.html Reported-by: Roi Dayan Signed-off-by: Timothy

Re: [ovs-dev] [PATCH v2] rhel: move conf.db to /var/lib/openvswitch, using symlinks

2022-12-15 Thread Timothy Redaelli
On Tue, 13 Dec 2022 12:57:08 +0100 Ilya Maximets wrote: > On 12/5/22 15:36, Ilya Maximets wrote: > > On 12/4/22 09:23, Roi Dayan wrote: > >> > >> > >> On 30/11/2022 17:55, Ilya Maximets wrote: > >>> On 11/14/22 20:41, Timothy Redaelli wrote:

[ovs-dev] [PATCH v2] rhel: move conf.db to /var/lib/openvswitch, using symlinks

2022-11-14 Thread Timothy Redaelli
for backward compatibility. Reported-at: https://bugzilla.redhat.com/1830857 Reported-by: Yedidyah Bar David Signed-off-by: Timothy Redaelli --- v1 -> v2: - Use hugetlbfs group instead of openvswitch when the package is built with dpdk (as reported by Flavio) --- rhel/openvswi

Re: [ovs-dev] [PATCH] rhel: move conf.db to /var/lib/openvswitch, using symlinks

2022-11-11 Thread Timothy Redaelli
On Thu, 17 Sep 2020 17:24:49 -0300 Flavio Leitner wrote: > On Thu, Sep 10, 2020 at 03:38:04PM +0200, Timothy Redaelli wrote: > > conf.db is by default at /etc/openvswitch, but it should be at > > /var/lib/openvswitch like on Debian or like ovnnb_db.db and ovnsb_db.db. > > &

[ovs-dev] [PATCH v2] rhel: make the version, displayed to the user, customizable

2022-11-09 Thread Timothy Redaelli
an OVS version suffix that should be shown to the user via ovs-vsctl -V and, so, also on database and on ovs-vsctl show. --with-version-suffix is used in Fedora/CentOS/RHEL spec file in order to have the version be aligned with the downstream one. Signed-off-by: Timothy Redaelli --- acinclude.m4

[ovs-dev] [PATCH 2/2] Add support for OpenSSL 3.0 functions

2022-09-22 Thread Timothy Redaelli
In OpenSSL 3.0 some functions were deprecated and replaced. This commit adds some #ifdef to build without warning on both OpenSSL 1.x and OpenSSL 3.x. For OpenSSL 3.x, the default built-in DH parameters are used (as suggested by SSL_CTX_set_dh_auto manpage). Signed-off-by: Timothy Redaelli

[ovs-dev] [PATCH 0/2] Remove deprecated OpenSSL functions on openssl 3.0

2022-09-22 Thread Timothy Redaelli
to generate lib/dhparams.c using OpenSSL 3.0 and to replace the deprecated function by using the new one. OpenSSL team also suggests using SSL_CTX_set_dh_auto to set DH keys instead of use build-time hardcoded keys (it's also a good idea for FIPS compliance). Timothy Redaelli (2): dhparams: Fix .c file

[ovs-dev] [PATCH 1/2] dhparams: Fix .c file generation with OpenSSL >= 3.0

2022-09-22 Thread Timothy Redaelli
ectly. The generated file won't be used on OpenSSL >= 3.0, but it's still needed to be generated if OVS is built on OpenSSL < 3.0. Signed-off-by: Timothy Redaelli --- build-aux/generate-dhparams-c | 79 +++ 1 file changed, 71 insertions(+), 8 deletions(-)

Re: [ovs-dev] [PATCH v2] python: Do not send non-zero flag for a SSL socket

2022-08-10 Thread Timothy Redaelli
n stuff from the deprecated pyOpenSSL to ssl module and unluckily no tests detected this problem, since it's only executed in case of socket errors Acked-By: Timothy Redaelli ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] python: Send non-zero flag for a SSL socket

2022-08-08 Thread Timothy Redaelli
On Mon, 8 Aug 2022 11:42:55 +0200 Ilya Maximets wrote: > On 8/8/22 04:27, Miro Tomaska wrote: > > Python std library SSLSocket.send does not allow non-zero value for the > > optional flag. > > > > pyOpenSSL was recently switched for the Python standard library ssl module > > commit

[ovs-dev] [PATCH] rhel: make the version, displayed to the user, customizable

2022-08-01 Thread Timothy Redaelli
to set an OVS version that should be shown to the user via ovs-vsctl -V and, so, also on database and on ovs-vsctl show. DISPLAY_VERSION is used in Fedora/CentOS/RHEL spec file in order to have the version be aligned with the downstream one. Signed-off-by: Timothy Redaelli --- configure.ac

[ovs-dev] [PATCH v2 2/2] python-c-ext: fix a couple of build warnings

2022-07-18 Thread Timothy Redaelli
ovs/_json.c:67:20: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] ovs/_json.c:132:27: warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare] Signed-off-by: Timothy

[ovs-dev] [PATCH v2 0/2] fix a couple of build warnings

2022-07-18 Thread Timothy Redaelli
v1 -> v2: - Removed Python 2 support as requested by Ilya Timothy Redaelli (2): python-c-ext: Remove Python 2 support python-c-ext: fix a couple of build warnings python/ovs/_json.c | 38 +++--- 1 file changed, 3 insertions(+), 35 deletions(-) -- 2.3

[ovs-dev] [PATCH v2 1/2] python-c-ext: Remove Python 2 support

2022-07-18 Thread Timothy Redaelli
Since Python 2 is not supported anymore, remove Python 2 support from C extension too Fixes: 1ca0323e7c29 ("Require Python 3 and remove support for Python 2.") Signed-off-by: Timothy Redaelli --- python/ovs/_json.c | 34 +- 1 file changed, 1 insert

[ovs-dev] [PATCH] python-c-ext: fix a couple of build warnings

2022-06-30 Thread Timothy Redaelli
ovs/_json.c:67:20: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] ovs/_json.c:132:27: warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare] Signed-off-by: Timothy

[ovs-dev] [PATCH v2] python: use setuptools instead of distutils

2022-06-29 Thread Timothy Redaelli
ase, distutils.errors is still used. Signed-off-by: Timothy Redaelli --- v1 -> v2: - As reported by Mike Pattrick, use distutils.errors if setuptools.errors is not available (for setuptools < 59.0). --- python/setup.py | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git

[ovs-dev] [RFC PATCH 0/2] rhel: use the complete version as OVS version

2022-06-10 Thread Timothy Redaelli
with the downstream one. Timothy Redaelli (2): selinux: restore static versioning rhel: use the complete version as OVS version rhel/openvswitch-fedora.spec.in | 3 +++ selinux/openvswitch-custom.te.in | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) -- 2.36.1

[ovs-dev] [RFC PATCH 2/2] rhel: use the complete version as OVS version

2022-06-10 Thread Timothy Redaelli
with the downstream one. Signed-off-by: Timothy Redaelli --- rhel/openvswitch-fedora.spec.in | 3 +++ 1 file changed, 3 insertions(+) diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in index 16ef1ac3a..f8398c74c 100644 --- a/rhel/openvswitch-fedora.spec.in +++ b/rhel

[ovs-dev] [RFC PATCH 1/2] selinux: restore static versioning

2022-06-10 Thread Timothy Redaelli
This is needed for the upcoming commit that changes the version of OVS, on Fedora/CentOS/RHEL, by using the complete version that includes a dash, but dashes are not valid in selinux version. Signed-off-by: Timothy Redaelli --- selinux/openvswitch-custom.te.in | 2 +- 1 file changed, 1

[ovs-dev] [PATCH] python: use setuptools instead of distutils

2022-05-11 Thread Timothy Redaelli
On Python 3.12, distutils will be removed and it's currently (3.10+) deprecated (see PEP 632). Since the suggested and simplest replacement is setuptools, this commit replaces distutils to use setuptools instead. Signed-off-by: Timothy Redaelli --- python/setup.py | 9 - 1 file changed

Re: [ovs-dev] [PATCH v4] python: Politely handle misuse of table.condition

2022-04-26 Thread Timothy Redaelli
IdlTable/IdlColumn objects which hold Idl-specific data and > adds a 'condition' property to TableSchema that maintains the old > interface. > > Fixes: 46d44cf3b ("python: idl: Add monitor_cond_since support") > Signed-off-by: Terry Wilson > --- LGTM Acked-By: Timoth

[ovs-dev] [PATCH] python: regenerate dirs.py when Makefile is updated

2022-03-25 Thread Timothy Redaelli
build system values") Signed-off-by: Timothy Redaelli --- python/automake.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/python/automake.mk b/python/automake.mk index c32ac3b6a..e36094168 100644 --- a/python/automake.mk +++ b/python/automake.mk @@ -106,7 +106,7 @

[ovs-dev] [PATCH] python: don't ship dirs.py in tarball

2022-03-25 Thread Timothy Redaelli
-at: https://bugzilla.redhat.com/2055576 Fixes: 943c4a325045 ("python: set ovs.dirs variables with build system values") Signed-off-by: Timothy Redaelli --- python/automake.mk | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/python/automake.mk b/python/automak

Re: [ovs-dev] [PATCH v1 02/18] python: add mask, ip and eth decoders

2021-11-22 Thread Timothy Redaelli
On Mon, 22 Nov 2021 12:22:40 +0100 Adrian Moreno wrote: > Add more decoders that can be used by KVParser. > > For IPv4 and IPv6 addresses, create a new class that wraps > netaddr.IPAddress. > For Ethernet addresses, create a new class that wraps netaddr.EUI. > For Integers, create a new class

[ovs-dev] [PATCH v4 2/2] python: replace pyOpenSSL with ssl

2021-10-29 Thread Timothy Redaelli
SSL socket to be created before connecting it, so SSLStream._open needs to create the socket, create SSL socket and then connect the SSL socket. Reported-by: Timothy Redaelli Reported-at: https://bugzilla.redhat.com/1988429 Signed-off-by: Timothy Redaelli --- v3 -> v4: - Remove usele

[ovs-dev] [PATCH v3 2/2] python: replace pyOpenSSL with ssl

2021-10-25 Thread Timothy Redaelli
SSL socket to be created before connecting it, so SSLStream._open needs to create the socket, create SSL socket and then connect the SSL socket. Reported-by: Timothy Redaelli Reported-at: https://bugzilla.redhat.com/1988429 Signed-off-by: Timothy Redaelli --- .ci/linux-prepare.sh | 2 +- .

[ovs-dev] [PATCH v3 1/2] socket-util: split inet_open_active function and use connect_ex

2021-10-25 Thread Timothy Redaelli
inet_create_socket_active and inet_connect_active. Signed-off-by: Timothy Redaelli --- python/ovs/socket_util.py | 36 ++-- 1 file changed, 22 insertions(+), 14 deletions(-) diff --git a/python/ovs/socket_util.py b/python/ovs/socket_util.py index 3faa64e9d..651012bf0 100644

[ovs-dev] [PATCH v3 0/2] replace pyOpenSSL with ssl

2021-10-25 Thread Timothy Redaelli
ors returned by connect are a subclass of socket.error, or better OSError, so the errno can be used directly. Added a comment in "python: replace pyOpenSSL with ssl" patch that explains why TCPStream._open cannot be used. Timothy Redaelli (2): socket-util: split inet_open_active fun

Re: [ovs-dev] [RFC ovn 0/5] Facilitate external use of ovn-detrace

2021-10-18 Thread Timothy Redaelli
On Mon, 18 Oct 2021 18:18:07 +0200 Adrian Moreno wrote: > > > On 10/18/21 14:51, Dumitru Ceara wrote: > > On 10/14/21 6:41 PM, Adrian Moreno wrote: > >> ovn-detrace is a very useful tool for debugging OVN issues. > >> > >> It's core logic (mapping openflow cookies / ports with OVN objects) can

Re: [ovs-dev] [RFC ovn 3/5] ovn-detrace: rename ovn-detrace to ovn_detrace.py

2021-10-18 Thread Timothy Redaelli
On Thu, 14 Oct 2021 18:41:28 +0200 Adrian Moreno wrote: > For external python programs to be able to load ovn-detrace as a python > module easily, it should end in .py and should have underscores. > > Move ovn-detrace to ovn-detrac.py and create a symlink with the old name > for backwards

Re: [ovs-dev] [RFC ovn 3/5] ovn-detrace: rename ovn-detrace to ovn_detrace.py

2021-10-18 Thread Timothy Redaelli
On Thu, 14 Oct 2021 18:41:28 +0200 Adrian Moreno wrote: > For external python programs to be able to load ovn-detrace as a python > module easily, it should end in .py and should have underscores. > > Move ovn-detrace to ovn-detrac.py and create a symlink with the old name Nit: multiple typo

Re: [ovs-dev] [PATCH] tunnel-push-pop.at: Mask source port in tunnel header.

2021-10-13 Thread Timothy Redaelli
On Tue, 12 Oct 2021 15:33:07 +0200 Ilya Maximets wrote: > Source port is based on a packet hash and hash depends on a chosen > implementation. Masking it to avoid test failures with '-msse4.2'. > > Fixes: 7e6b41ac8d9d ("dpif-netdev: Fix crash when PACKET_OUT is metered.") > Reported-by: Kumar

Re: [ovs-dev] [PATCH] [python] Avoid alloc of an attr dict/row+column

2021-10-13 Thread Timothy Redaelli
13 bytes (w/o patch) vs 114605277 bytes (with patch) Acked-by: Timothy Redaelli Tested-by: Timothy Redaelli ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH v2] python: replace pyOpenSSL with ssl

2021-10-06 Thread Timothy Redaelli
tream recv and send had to be splitted as _recv and _send, since SSLError is a subclass of socket.error and so it was not possible to except for SSLWantReadError and SSLWantWriteError in recv and send of SSLStream. Reported-by: Timothy Redaelli Reported-at: https://bugzilla.redhat.com/1988429

[ovs-dev] [PATCH] python: replace pyOpenSSL with ssl

2021-09-10 Thread Timothy Redaelli
tream recv and send had to be splitted as _recv and _send, since SSLError is a subclass of socket.error and so it was not possible to except for SSLWantReadError and SSLWantWriteError in recv and send of SSLStream. Reported-by: Timothy Redaelli Reported-at: https://bugzilla.redhat.com/1988429

[ovs-dev] [PATCH v2] checkpatch: check if some tags are wrongly written

2021-09-10 Thread Timothy Redaelli
by the commit are: Acked-by, Reported-at, Reported-by, Requested-by, Reviewed-by, Submitted-at and Suggested-by. It's not necessary to add "Signed-off-by" since it's already checked in checkpatch. Signed-off-by: Timothy Redaelli --- v2: - Removed multiple spaces to make fl

Re: [ovs-dev] [PATCH] rhel: Fix dual kernel rpm install for RHEL 8.4

2021-09-08 Thread Timothy Redaelli
[ "$major_rev" = "305" ]; then > +echo "rhel84" Are you sure you need that echo since it's commented on the other entries and it seems only used for debugging / development? > +comp_ver=9 > +ver_offset=4 > +installed_ver="$

[ovs-dev] [PATCH] checkpatch: check if some tags are wrongly written

2021-08-10 Thread Timothy Redaelli
by the commit are: Reported-by, Requested-by, Suggested-by, Reported-at, and Submitted-at It's not necessary to add "Signed-off-by" since it's already checked in checkpatch. Signed-off-by: Timothy Redaelli --- tests/checkpatch.at | 44 +

Re: [ovs-dev] [PATCH v4 1/2] ovs-save: Save igmp flows in ofp_parse syntax

2021-07-26 Thread Timothy Redaelli
s in stable > branches, so this patch creates a workaround within ovs-save by converting any > instances of "igmp" within $bridge.flows.dump into "ip, nw_proto=2". > > Signed-off-by: Salvatore Daniele > Acked-by: Aaron Conole Acked-by: Timothy Redaelli __

[ovs-dev] [PATCH v2] dpif-netdev: apply subtable-lookup-prio-set on any datapath

2021-06-23 Thread Timothy Redaelli
or if you have only one datapath, the behaviour is the same as now, but without the confusing error when you don't have any datapath. Fixes: 3d018c3ea79d ("dpif-netdev: add subtable lookup prio set command.") Cc: harry.van.haa...@intel.com Signed-off-by: Timothy Redaelli -- v2: - Fixed o

[ovs-dev] [PATCH] dpif-netdev: apply subtable-lookup-prio-set on any datapath

2021-06-23 Thread Timothy Redaelli
have only one datapath, the behaviour is the same as now, but without the confusing error when you don't have any datapath. Signed-off-by: Timothy Redaelli Fixes: 3d018c3ea79d ("dpif-netdev: add subtable lookup prio set command.") Cc: harry.van.haa...@intel.com --- lib/dpif-net

[ovs-dev] [PATCH] dpif-netlink: "bonding_masters" is a reserved name

2021-06-23 Thread Timothy Redaelli
to avoid that bonding module can't work if it's loaded after "bonding_masters" interface is created. Reported-at: https://bugzilla.redhat.com/1974303 Signed-off-by: Timothy Redaelli --- lib/dpif-netlink.c | 8 1 file changed, 8 insertions(+) diff --git a/lib/dpif-netlink.c

Re: [ovs-dev] [PATCH v2 1/2] Remove Python 2 leftovers.

2021-06-10 Thread Timothy Redaelli
On Wed, 9 Jun 2021 17:25:45 -0400 Rosemarie O'Riorden wrote: > Fixes: 1ca0323e7c29 ("Require Python 3 and remove support for Python 2.") > Reported at: https://bugzilla.redhat.com/show_bug.cgi?id=1949875 > Signed-off-by: Rosemarie O'Riorden > --- > Fix import errors in v1. > Remove lines that

Re: [ovs-dev] [PATCH v2] ofproto-dpif-xlate: avoid successive ct_clear datapath actions

2021-05-24 Thread Timothy Redaelli
+ > 2 files changed, 28 insertions(+), 1 deletion(-) Acked-By: Timothy Redaelli ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [v2 v2 0/6] MFEX Infrastructure + Optimizations

2021-05-13 Thread Timothy Redaelli
On Thu, 13 May 2021 10:27:19 -0400 Jean Hsiao wrote: > > On 5/11/21 7:35 AM, Van Haaren, Harry wrote: > >> -Original Message----- > >> From: Timothy Redaelli > >> Sent: Monday, May 10, 2021 6:43 PM > >> To: Amber, Kumar ; d...@openvswitch.org >

[ovs-dev] [PATCH] ovs-dpctl-top: fix ovs-dpctl-top via pipe

2021-05-12 Thread Timothy Redaelli
to flows_read instead of re-opening it without buffering. Signed-off-by: Timothy Redaelli --- utilities/ovs-dpctl-top.in | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/utilities/ovs-dpctl-top.in b/utilities/ovs-dpctl-top.in index fbe6e4f56..2c1766eff 100755 --- a/utilities/ovs

[ovs-dev] [PATCH] rhel: use /run instead of /var/run

2021-05-12 Thread Timothy Redaelli
Systemd unit file generates warnings about PID file path since /var/run is a legacy path so just use /run instead of /var/run. /var/run is a symlink of /run starting from RHEL7 (and any other distribution that uses systemd). Reported-at: https://bugzilla.redhat.com/1952081 Signed-off-by: Timothy

Re: [ovs-dev] [v2 v2 0/6] MFEX Infrastructure + Optimizations

2021-05-10 Thread Timothy Redaelli
On 4/28/21 11:19 AM, Kumar Amber wrote: v2 updates: - reabse on to latest DPIF v11 This patchset introduces miniflow extract Infrastructure changes which allows user to choose different type of ISA based optimized miniflow extract variants which can be user choosen or set based on packets

Re: [ovs-dev] Add ability to override default Release suffix in RPM packages

2021-05-05 Thread Timothy Redaelli
On Tue, 4 May 2021 06:24:33 + Guzowski Adrian via dev wrote: > In some cases, like building OvS packages in Jenkins, it may be > useful to set a custom version suffix that will correspond with > job's build number, etc. Currently, version number is explicitly > set to 1. This change adds a

Re: [ovs-dev] [PATCH v2] rpm: Don't mangle shebangs when building DKMS RPM package

2021-05-05 Thread Timothy Redaelli
On Wed, 5 May 2021 05:37:41 + Guzowski Adrian via dev wrote: > While building the package, some .in files are being subject to shebang > substitution, but the process fails, because given scripts have > placeholders in place of shebangs. In order to fix the issue, don't mangle > shebangs in

Re: [ovs-dev] [v2 v2 4/6] dpif-netdev: add avx512 miniflow extract for traffic ip/udp

2021-04-29 Thread Timothy Redaelli
On Wed, 28 Apr 2021 14:49:29 +0530 Kumar Amber wrote: > This patch introduces avx512 optimized function > pointer for IP/UDP traffic type and supporting > functions in dpif-netdev-extract-avx512. > > Signed-off-by: Harry van Haaren > Co-authored-by: Kumar Amber > Signed-off-by: Kumar Amber >

Re: [ovs-dev] [PATCH] xml2nroff: Fix formatting of action headers in ovs-actions(7) manpage.

2021-04-16 Thread Timothy Redaelli
t; the problem. > > Signed-off-by: Ben Pfaff > --- > python/build/nroff.py | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) Patch applied, manpages rebuilt and did "man -l lib/ovs-actions.7" Acked-By: Timothy Redaelli Tested-By: Timothy Redaelli ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] rhel: increase timeout of ovsdb-server.service to 300s

2021-03-08 Thread Timothy Redaelli
On Fri, 5 Mar 2021 10:34:36 -0800 Ben Pfaff wrote: > On Fri, Mar 05, 2021 at 12:47:05PM +0100, Timothy Redaelli wrote: > > In some scenarios starting ovsdb-server takes more than 90 seconds and > > so ovsdb-server.service is marked as failed. > > > > Signed-off-by:

[ovs-dev] [PATCH] rhel: increase timeout of ovsdb-server.service to 300s

2021-03-05 Thread Timothy Redaelli
In some scenarios starting ovsdb-server takes more than 90 seconds and so ovsdb-server.service is marked as failed. Signed-off-by: Timothy Redaelli --- NOTE: Currently systemd will not start openvswitch.service and ovs-vswitchd.service if ovsdb-server.service is automatically restarted after

[ovs-dev] [PATCH] rhel: Update for DPDK 20.11

2021-01-22 Thread Timothy Redaelli
("dpdk: Update to use DPDK v20.11.") Signed-off-by: Timothy Redaelli --- rhel/openvswitch-fedora.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in index 2c0c4fa18..21929e6cf 100644 --- a/rhel/o

Re: [ovs-dev] [PATCH v4 2/2] python: set ovs.dirs variables with build system values

2020-11-12 Thread Timothy Redaelli
ot set, from > the build system. > > Signed-off-by: Mark Gray Acked-By: Timothy Redaelli ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v3 2/2] python: set ovs.dirs variables with build system values

2020-11-09 Thread Timothy Redaelli
On Tue, 27 Oct 2020 10:45:18 -0400 Mark Gray wrote: > ovs/dirs.py should be auto-generated using the template > ovs/dirs.py.template at build time. This will set the > ovs.dirs python variables with a value specified by the > environment or, if the environment variable is not set, from > the

[ovs-dev] [PATCH] Documentation: Fix rendering of extra repo info for RHEL 8

2020-11-03 Thread Timothy Redaelli
ns. Fixes: a82083ee3091 ("Documentation: Add extra repo info for RHEL 8") Cc: gvrose8...@gmail.com Signed-off-by: Timothy Redaelli --- Documentation/intro/install/fedora.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/intro/install/fedora.rst b/Documentation/intr

[ovs-dev] [PATCH 2/1] tests: Add parse-flow tests for MPLS fields

2020-10-26 Thread Timothy Redaelli
Currently "ovs-ofctl parse-flows (NXM)" test doesn't test MPLS fields at all. This commit adds a test for the the 4 MPLS fields (mpls_label, mpls_tc, mpls_bos and mpls_ttl) to "ovs-ofctl parse-flows (NXM)" test. Signed-off-by: Timothy Redaelli --- tests/ovs-ofctl.at | 2 +

[ovs-dev] [PATCH] ofp-actions: Fix userspace support for mpls_ttl

2020-09-18 Thread Timothy Redaelli
Currently mpls_ttl is ignored when a flow is added because MFF_MPLS_TTL is not handled in nx_put_raw(). This commit adds the correct handling of MFF_MPLS_TTL in nx_put_raw(). Fixes: bef3f465bcd5 ("openflow: Support matching and modifying MPLS TTL field.") Cc: b...@ovn.org Signed-off-b

[ovs-dev] [PATCH] rhel: move conf.db to /var/lib/openvswitch, using symlinks

2020-09-10 Thread Timothy Redaelli
for backward compatibility. Reported-at: https://bugzilla.redhat.com/1830857 Reported-by: Yedidyah Bar David Signed-off-by: Timothy Redaelli --- rhel/openvswitch-fedora.spec.in | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/rhel/openvswitch

[ovs-dev] [PATCH v2] Remove manpages.mk from git

2020-09-03 Thread Timothy Redaelli
manpages.mk is generated at build-time using sodepends.py and so there is no need to keep it in git. Signed-off-by: Timothy Redaelli --- v2: generate manpages.mk in builddir instead of srcdir and add it to CLEANFILES to make "make distcleancheck" happy. Thank you Ilya

Re: [ovs-dev] [PATCH] Remove manpages.mk from git

2020-09-01 Thread Timothy Redaelli
On Wed, 12 Aug 2020 16:12:03 -0300 Flavio Leitner wrote: > On Wed, Aug 05, 2020 at 01:38:47PM +0200, Timothy Redaelli wrote: > > manpages.mk is generated at build-time using sodepends.py and so there is no > > need to keep it in git. > > > > Sign

[ovs-dev] [PATCH] meta-flow: fix a typo in "MPLS Bottom of Stack Field" paragraph

2020-08-06 Thread Timothy Redaelli
...@ovn.org Reported-at: https://bugzilla.redhat.com/1842032 Reported-by: Guillaume Nault Signed-off-by: Timothy Redaelli --- lib/meta-flow.xml | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/meta-flow.xml b/lib/meta-flow.xml index 154675874..e72ba52ec 100644 --- a/lib

[ovs-dev] [PATCH] Remove manpages.mk from git

2020-08-05 Thread Timothy Redaelli
manpages.mk is generated at build-time using sodepends.py and so there is no need to keep it in git. Signed-off-by: Timothy Redaelli --- .gitignore | 1 + Makefile.am | 2 +- manpages.mk | 266 3 files changed, 2 insertions(+), 267

Re: [ovs-dev] [PATCH] acinclude: Remove libmnl for MLX5 PMD

2020-06-25 Thread Timothy Redaelli
On Thu, 25 Jun 2020 09:32:23 +0200 Thomas Monjalon wrote: > On Tue, Jun 23, 2020 at 6:49 PM Timothy Redaelli wrote: > > > > libmnl is not used anymore for MLX5 PMD since DPDK 19.08. > > Why don't you use pkg-config? > All these kind of dependencies are managed th

[ovs-dev] [PATCH] acinclude: Remove libmnl for MLX5 PMD

2020-06-23 Thread Timothy Redaelli
libmnl is not used anymore for MLX5 PMD since DPDK 19.08. Signed-off-by: Timothy Redaelli --- acinclude.m4 | 1 - 1 file changed, 1 deletion(-) diff --git a/acinclude.m4 b/acinclude.m4 index 8847b8145..5be2a2f1c 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -368,7 +368,6 @@ AC_DEFUN

[ovs-dev] [PATCH v2] ovs-dpctl-top: Skip "eth()" element

2020-06-19 Thread Timothy Redaelli
the parsing of the empty "eth()" element. Fixes: efde188622ae ("odp-util: Print eth() for Ethernet flows if packet_type is absent.") Cc: b...@ovn.org Signed-off-by: Timothy Redaelli --- v2: - Added missing Signed-off-by utilities/ovs-dpctl-top.in | 2 ++ 1 file changed, 2 insert

[ovs-dev] [PATCH v2] ovs-dpctl-top: Open stdin in binary mode

2020-06-19 Thread Timothy Redaelli
On Python3 buffering can only be disabled on files opened in binary mode. Signed-off-by: Timothy Redaelli --- v2: - Added missing Signed-off-by utilities/ovs-dpctl-top.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utilities/ovs-dpctl-top.in b/utilities/ovs-dpctl-top.in

[ovs-dev] [PATCH] ovs-dpctl-top: open stdin in binary mode

2020-06-19 Thread Timothy Redaelli
On Python3 buffering can only be disabled on files opened in binary mode. --- utilities/ovs-dpctl-top.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utilities/ovs-dpctl-top.in b/utilities/ovs-dpctl-top.in index fbe6e4f56..97dc12f27 100755 --- a/utilities/ovs-dpctl-top.in

[ovs-dev] [PATCH] ovs-dpctl-top: Skip "eth()" element

2020-06-19 Thread Timothy Redaelli
With commit efde188622ae ("odp-util: Print eth() for Ethernet flows if packet_type is absent.") "eth()" is printed for Ethernet flows if packet_type is absent, but this broke "ovs-dpctl-top" since it expects that every element has a value. This commit skips the parsing of the empty "eth()"

[ovs-dev] [PATCH v2] bugtool: Fix for Python3

2020-03-19 Thread Timothy Redaelli
-by: Timothy Redaelli --- Changes since v1: * Converted StringIO to BytesIO * Fix some other string/bytes conversion --- utilities/bugtool/ovs-bugtool.in | 45 1 file changed, 22 insertions(+), 23 deletions(-) diff --git a/utilities/bugtool/ovs-bugtool.in b/utilities

Re: [ovs-dev] [PATCH] bugtool: Fix for Python3

2020-03-19 Thread Timothy Redaelli
On Wed, 18 Mar 2020 14:25:43 -0700 William Tu wrote: > On Wed, Mar 18, 2020 at 8:23 AM Timothy Redaelli wrote: > > > > Currently ovs-bugtool tool doesn't start on Python3. > > This commit fixes ovs-bugtool to make it works on Python.3 > > > > Reported-at: ht

[ovs-dev] [PATCH] bugtool: Fix for Python3

2020-03-18 Thread Timothy Redaelli
Currently ovs-bugtool tool doesn't start on Python3. This commit fixes ovs-bugtool to make it works on Python.3 Reported-at: https://bugzilla.redhat.com/1809241 Reported-by: Flavio Leitner Signed-off-by: Timothy Redaelli --- utilities/bugtool/ovs-bugtool.in | 27 +-- 1

[ovs-dev] [PATCH ovn] automake.mk: Use PYTHON3 to generate the ovn-ic-{n, sb} pics

2020-02-18 Thread Timothy Redaelli
3 variable that is defined by the build system (in OVN_CHECK_PYTHON3). Fixes: 2992f74bf515 ("ovn-ic-nb: Interconnection northbound DB schema and CLI.") Fixes: 1c3c4108e602 ("ovn-ic-sb: Interconnection southbound DB schema and CLI.") Cc: hz...@ovn.org Signed-off-by: Timothy Redaelli

[ovs-dev] [PATCH] Documentation: Fix building with Python 3.9

2020-01-16 Thread Timothy Redaelli
/bugzilla.redhat.com/1791681 Reported-by: Miro Hrončok Signed-off-by: Timothy Redaelli --- Documentation/conf.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/conf.py b/Documentation/conf.py index 6bbfc02bd..37d92c36f 100644 --- a/Documentation/conf.py +++ b/D

[ovs-dev] [PATCH] ovs-tcpdump: Fallback to read /proc/net/dev on Linux

2020-01-13 Thread Timothy Redaelli
is not available) to read the list of the network interfaces by reading "/proc/net/dev". Signed-off-by: Timothy Redaelli --- utilities/ovs-tcpdump.in | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/utilities/ovs-tcpdump.in b/utilities/ovs-tcpdum

[ovs-dev] [PATCH] acinclude: Use RTE_IBVERBS_LINK_DLOPEN

2020-01-08 Thread Timothy Redaelli
On DPDK 19.11 RTE_IBVERBS_LINK_DLOPEN is used by Mellanox PMDs (mlx4 and mlx5) instead of RTE_LIBRTE_MLX{4,5}_DLOPEN_DEPS. Without this commit is not possible to statically link OVS with DPDK when MLX4 or MLX5 PMDs are enabled. Signed-off-by: Timothy Redaelli --- acinclude.m4 | 4 ++-- 1 file

[ovs-dev] [PATCH v2 1/2] Remove dependency on python3-six

2019-12-20 Thread Timothy Redaelli
Signed-off-by: Timothy Redaelli --- .cirrus.yml | 2 +- .travis/linux-prepare.sh | 2 +- .travis/osx-prepare.sh| 1 - Documentation/intro/install/general.rst | 6 +- Documentation/intro/install/netbsd.rst

[ovs-dev] [PATCH v2 2/2] Revert "docs: To build OVS on RHEL7 EPEL is needed"

2019-12-20 Thread Timothy Redaelli
This reverts commit 9e334d91b3ea95e2b96f7b3edcb2ba9c3353288a. This commit is not needed since OVS doesn't use six anymore. Signed-off-by: Timothy Redaelli --- Documentation/intro/install/fedora.rst | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Documentation/intro

[ovs-dev] [PATCH v2 0/2] Remove dependency on python3-six

2019-12-20 Thread Timothy Redaelli
nges in v2: - Fixed a typo in commit message "Moveover" => "Moreover" - Added missing "Signed-off-by" in Revert "docs: To build OVS on RHEL7 EPEL is needed" Timothy Redaelli (2): Remove dependency on python3-six Revert "

[ovs-dev] [PATCH 1/2] Remove dependency on python3-six

2019-12-20 Thread Timothy Redaelli
Signed-off-by: Timothy Redaelli --- .cirrus.yml | 2 +- .travis/linux-prepare.sh | 2 +- .travis/osx-prepare.sh| 1 - Documentation/intro/install/general.rst | 6 +- Documentation/intro/install/netbsd.rst

[ovs-dev] [PATCH 2/2] Revert "docs: To build OVS on RHEL7 EPEL is needed"

2019-12-20 Thread Timothy Redaelli
This reverts commit 9e334d91b3ea95e2b96f7b3edcb2ba9c3353288a. This commit is not needed since OVS doesn't use six anymore. --- Documentation/intro/install/fedora.rst | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Documentation/intro/install/fedora.rst

[ovs-dev] [PATCH 0/2] Remove dependency on python3-six

2019-12-20 Thread Timothy Redaelli
ed locally and with travis: https://travis-ci.org/drizzt/ovs/builds/627763532 Timothy Redaelli (2): Remove dependency on python3-six Revert "docs: To build OVS on RHEL7 EPEL is needed" .cirrus.yml | 2 +- .travis/linux-prepare.sh

Re: [ovs-dev] [PATCH] travis: Use pip3 to install the python packages on linux

2019-12-19 Thread Timothy Redaelli
On Wed, 18 Dec 2019 16:50:05 -0800 Ben Pfaff wrote: > On Wed, Dec 18, 2019 at 04:53:10PM +0100, Timothy Redaelli wrote: > > Currently pip is used to install the python packages on linux by travis, > > but pip3 should be used since pip is a symlink of pip2. > > > > Fi

[ovs-dev] [PATCH] travis: Use pip3 to install the python packages on linux

2019-12-18 Thread Timothy Redaelli
Currently pip is used to install the python packages on linux by travis, but pip3 should be used since pip is a symlink of pip2. Fixes: 1ca0323e7c29 ("Require Python 3 and remove support for Python 2.") Cc: b...@ovn.org Signed-off-by: Timothy Redaelli --- .travis.yml | 1

[ovs-dev] [PATCH] docs: To build OVS on RHEL7 EPEL is needed

2019-10-25 Thread Timothy Redaelli
Since Python 3 is now mandatory, Extra Packages for Enterprise Linux (EPEL) repository is needed in order to build OVS on RHEL7. Signed-off-by: Timothy Redaelli --- Documentation/intro/install/fedora.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/intro

Re: [ovs-dev] [PATCH 1/2] fedora: Ability to auto enable openvswitch service.

2019-05-10 Thread Timothy Redaelli
On Fri, 3 May 2019 00:05:34 -0700 Gurucharan Shetty wrote: > We currently have rhel/openvswitch.spec.in that automatically > enables openvswitch service when the package is installed using > chkconfig. > > But fedora rpm may not enable openvswitch service automatically. > The macro currently

  1   2   3   >