[ovs-dev] [PATCH] rhel: Add support for "systemctl reload openvswitch"

/README.RHEL.rst). Signed-off-by: Timothy Redaelli <tredae...@redhat.com> --- rhel/automake.mk | 1 + rhel/openvswitch-fedora.spec.in | 5 rhel/usr_lib_systemd_system_openvswitch.service | 2 +- rhel/usr_lib_systemd_system_ovsdb-server.s

[ovs-dev] [PATCH] rhel: Use python2-sphinx as BuildRequires on Fedora

cy") Signed-off-by: Timothy Redaelli <tredae...@redhat.com> --- rhel/openvswitch-fedora.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in index 8d6239350..edfc2303d 100644 --- a/rhel/openvswitch-fed

[ovs-dev] [PATCH] fedora: Use python2-sphinx as dependency instead of python-sphinx

python-* package names are deprecated (https://fedoraproject.org/wiki/Packaging:Naming#Python2_binary_package_naming) so use python2-sphinx instead. CC: Gurucharan Shetty <g...@ovn.org> Fixes: fc9669525f3f ("rhel, fedora: Add python-sphinx as a dependency.") Signed-off-by:

[ovs-dev] [PATCH v2 2/3] ovs-save: Use a file to restore flows instead of heredoc

This patch makes ovs-save to use a file to restore flows instead of using shell script here-document. This is needed since eval + here-documents are much slower than reading a file with the rules directly. Signed-off-by: Timothy Redaelli <tredae...@redhat.com> --- utilities/ovs-sav

[ovs-dev] [PATCH v2 3/3] ovs-save: Replace "echo -n" with "printf"

This is neeed since "echo -n" is not POSIX and may not work with some shells. Signed-off-by: Timothy Redaelli <tredae...@redhat.com> --- utilities/ovs-save | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/utilities/ovs-save b/utilities/ovs-save index da65

[ovs-dev] [PATCH v2 1/3] ovs-save: Use --bundle to restore flows (on OpenFlow 1.4+)

-off-by: Timothy Redaelli <tredae...@redhat.com> --- utilities/ovs-save | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/utilities/ovs-save b/utilities/ovs-save index 8b8dbf421..fc9418c3d 100755 --- a/utilities/ovs-save +++ b/utilities/ovs-save @@

[ovs-dev] [PATCH v2 0/3] ovs-save: Some refactors to speed-up save-flows

v1->v2: Splitted up to multiple patches and fixed workdir usage Was: https://patchwork.ozlabs.org/patch/811532/ Timothy Redaelli (3): ovs-save: Use --bundle to restore flows (on OpenFlow 1.4+) ovs-save: Use a file to restore flows instead of heredoc ovs-save: Replace "echo -n"

[ovs-dev] [PATCH v4 2/2] rhel: Add systemd support to delete transient ports only on boot

Using the dependencies feature of systemd ovs-delete-transient-ports.service is only started once and so transient ports are only deleted only the first time after boot. Acked-by: Aaron Conole <acon...@redhat.com> Signed-off-by: Timothy Redaelli <tredae...@redhat.com> --- rhel

[ovs-dev] [PATCH v4 1/2] ovs-ctl: Add delete-transient-ports command

Add a command to delete all ports that have the other_config:transient value set to true. Acked-by: Aaron Conole <acon...@redhat.com> Signed-off-by: Timothy Redaelli <tredae...@redhat.com> --- utilities/ovs-ctl.8 | 6 ++ utilities/ovs-ctl.in | 24 ++-- 2 f

[ovs-dev] [PATCH v4 0/2] Add system service to delete transient ports on boot.

in the database. v4: Changed approach to do not use run directory, but to use an additional systemd service instead. v3: Added coverletter. Rebased and modified due to non-root user patchsets. v2: Added --delete-transient-ports-on-boot flag to manpage. Timothy Redaelli (2

[ovs-dev] [PATCH] ovs-save: Use --bundle to restore flows (on OpenFlow 1.4+)

ho -n" with "printf" since "echo -n" is not POSIX and may not work with some shells. Signed-off-by: Timothy Redaelli <tredae...@redhat.com> --- This is a pre-requisite for the new patchset of patch with patchwok id 799223 --- utilities/ovs-save | 27 +++

[ovs-dev] [PATCH v3 2/2] rhel: delete transient ports on boot when starting ovsdb-server

Use ovs-ctl --delete-transient-ports-on-boot to start ovsdb-server. This feature can be disabled by appending --no-delete-transient-ports-on-boot to OPTIONS in /etc/sysconfig/openvswitch Signed-off-by: Timothy Redaelli <tredae...@redhat.com> --- rhel/usr_lib_systemd_system_ovsdb-server.s

[ovs-dev] [PATCH v3 1/2] ovs-ctl: Add option to delete transient ports only on boot.

The first time after boot, when openvswitch is started by using --delete-transient-ports-on-boot ovs-ctl option, all transient ports will be removed. Signed-off-by: Timothy Redaelli <tredae...@redhat.com> --- utilities/ovs-ctl.8 | 13 - utilities/ovs-ctl.in | 6 ++ 2

[ovs-dev] [PATCH v3 0/2] Add option to delete transient ports only on boot.

in the database. v3: Added coverletter. Rebased and modified due to non-root user patchsets. v2: Added --delete-transient-ports-on-boot flag to manpage. Timothy Redaelli (2): ovs-ctl: Add option to delete transient ports only on boot. rhel: delete transient ports on boot when starting

[ovs-dev] [PATCH] rhel: Add support for "systemctl reload openvswitch"

). It also uses --bundle, when available, in order to minimize the downtime. Signed-off-by: Timothy Redaelli <tredae...@redhat.com> --- rhel/automake.mk | 1 + rhel/openvswitch-fedora.spec.in | 5 ++ rhel/usr_lib_systemd_system_openvswitch.s

[ovs-dev] [RFC PATCH] rhel: Add support for "systemctl reload openvswitch"

). It also uses --bundle, when available, in order to minimize the downtime. Signed-off-by: Timothy Redaelli <tredae...@redhat.com> --- rhel/automake.mk | 1 + rhel/openvswitch-fedora.spec.in | 5 ++ rhel/usr_lib_systemd_system_openvswitch.s

[ovs-dev] [PATCH] rhel: Fix typo in README.RHEL.rst

Replace systemctk with systemctl Signed-off-by: Timothy Redaelli <tredae...@redhat.com> --- rhel/README.RHEL.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rhel/README.RHEL.rst b/rhel/README.RHEL.rst index 1845e8fd..6affdba9 100644 --- a/rhel/README.RHEL.rst +++

[ovs-dev] [PATCH] ovs-ovctl: Fix "OpenFlow versions" in ovs-ofctl -V

Fix the output of "ovs-ofctl -V" to show OpenFlow 1.4 as max supported versions since OpenFlow 1.4 was enabled by default in commit 8d3485791188 ("OpenFlow: Enable OpenFlow 1.4 by default.") CC: Ben Pfaff <b...@ovn.org> Signed-off-by: Timothy Redaelli <tredae...@red

[ovs-dev] [PATCH] ovs-ctl: Remove a leftover restore_interfaces in restart

es: c416eaf8c247 ("ovs-ctl: Remove code for upgrading from Open vSwitch 1.9 and earlier.") Signed-off-by: Timothy Redaelli <tredae...@redhat.com> --- utilities/ovs-ctl.in | 3 --- 1 file changed, 3 deletions(-) diff --git a/utilities/ovs-ctl.in b/utilities/ovs-ctl.in index 85ce6baef..

[ovs-dev] [PATCH] tests: Disable no-format-truncation warnings

test_snprintf function (tests/test-util.c) tests snprintf with shorter length, but this emit a warning on GCC 7.0 or later. This commit disables that warning on tests only. Signed-off-by: Timothy Redaelli <tredae...@redhat.com> --- configure.ac | 1 + tests/automake.mk | 5 + 2

[ovs-dev] [PATCH] ovs-ctl: Fix typo in a comment

s/conenct/connect/ Signed-off-by: Timothy Redaelli <tredae...@redhat.com> --- utilities/ovs-ctl.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utilities/ovs-ctl.in b/utilities/ovs-ctl.in index 575ffa039..85ce6baef 100755 --- a/utilities/ovs-ctl.in +++ b/utiliti

[ovs-dev] [PATCH] Fix some -Wimplicit-fallthrough warnings building with GCC 7

-Wimplicit-fallthrough warns when a switch case falls through and since this warning is enabled by -Wextra it breaks building with --enable-Werror. Added "/* fall through */" comment when needed in order to avoid the warning. Signed-off-by: Timothy Redaelli <tredae...@redhat.com>

[ovs-dev] [PATCH] Use @PYTHON@ directly instead of "#! /usr/bin/env"

In some installed python scripts /usr/bin/env is unnecessarily used in shebang, replace it directly with @PYTHON@. This will also avoid implicit dependency to /usr/bin/env in RPM distributions and it will correctly add implicit dependency to /usr/bin/python instead. Signed-off-by: Timothy

[ovs-dev] [PATCH] Add configuration option to link ovs binaries statically

is specified the binaries are already statically linked and if only --enable-shared is specified the binaries cannot link with nonbuilt static libraries. Signed-off-by: Timothy Redaelli <tredae...@redhat.com> --- configure.ac| 1 + m4/openvswitch.m4

[ovs-dev] [RFC PATCH v2] make logs not readable by other

-off-by: Timothy Redaelli <tredae...@redhat.com> --- Changes since v1: * Change spec file for commit 2f4f43bfddfd ("rhel: fix the fedora spec"). * Make logs group- as well as owner-readable. Please deprecate "[RFC] make logs readable only by owner" since subjec

[ovs-dev] [PATCH v2 1/2] ovs-ctl: Add option to delete transient ports only on boot.

The first time after boot, when openvswitch is started by using --delete-transient-ports-on-boot ovs-ctl option, all transient ports will be removed. Signed-off-by: Timothy Redaelli <tredae...@redhat.com> --- Changed since v1: * Added --delete-transient-ports-on-boot flag to m

[ovs-dev] [PATCH RFC] Drop support for RHEL 5 and 6

RHEL 6 is not supported anymore since it uses Python 2.6 and GCC 4.4.x, but Open vSwitch needs, at least, Python 2.7 and GCC 4.6 to build correctly. http://docs.openvswitch.org/en/latest/intro/install/general/#build-requirements Signed-off-by: Timothy Redaelli <tredae...@redhat.

[ovs-dev] [PATCH v2] tests/ofproto.at: Workaround some races

1.5)" Do not use "sleep 1", but wait for log file to have (at least) the same number of lines we expect (it generally waits less time). Sometimes one of these tests fails because the OFPT_BARRIER_REPLY is printed before the other message we expect to have. Suggested-by: Lance Rich

[ovs-dev] [PATCH] tests/ofproto.at: Workaround some races

" Sometimes one of these tests fails because the OFPT_BARRIER_REPLY is printed before the other message we expect to have. Suggested-by: Lance Richardson <lrich...@redhat.com> Signed-off-by: Timothy Redaelli <tredae...@redhat.com> --- tests/ofproto.at | 12 1 file changed, 4

[ovs-dev] [PATCH branch-2.6] travis: Fix path of DPDK directory

Call configure with --with-dpdk=./dpdk-stable-$DPDK_VER/build instead of --with-dpdk=./dpdk-$DPDK_VER/build Fixes: c007c58af492 ("docs: Use DPDK 16.07.2 stable release") CC: Ian Stokes <ian.sto...@intel.com> Tested-at: https://travis-ci.org/drizzt/ovs/builds/226330348 Signed

[ovs-dev] [PATCH] ovn-detrace: add generated files to .gitignore.

Signed-off-by: Timothy Redaelli <tredae...@redhat.com> --- ovn/utilities/.gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ovn/utilities/.gitignore b/ovn/utilities/.gitignore index 2c06825..dbc3719 100644 --- a/ovn/utilities/.gitignore +++ b/ovn/utilities/.gitignore @@ -5,

[ovs-dev] [PATCH] gitignore: Ignore /docs-check instead of /htmldocs-check

Fixes: fd0837a76f4c ("doc: Convert ovs-vlan-test to rST") CC: Stephen Finucane <step...@that.guru> Signed-off-by: Timothy Redaelli <tredae...@redhat.com> --- .gitignore | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index d

[ovs-dev] [PATCH] tests/pmd.at: Fix race in "PMD - change numa node" test

il.com> Fixes: a12e2a88d672 ("test: Add more pmd tests.") Signed-off-by: Timothy Redaelli <tredae...@redhat.com> --- tests/pmd.at | 28 ++-- 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/tests/pmd.at b/tests/pmd.at index 5686bedc..2816d45c 10064

[ovs-dev] [PATCH 2/2] rhel: Avoid logrotate error if /var/run/openvswitch does not exist

Avoid also errors if an ovs server didn't start correctly or it crashed without deleting the pid file. Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1441524 Signed-off-by: Timothy Redaelli <tredae...@redhat.com> --- rhel/etc_logrotate.d_openvswitch | 8 +--- 1 file chan

[ovs-dev] [PATCH 1/2] rhel/etc_logrotate.d_openvswitch: Fix coding style

Replace tabs by 4 spaces and indent the postrotate script like the examples in 'man logrotate.conf' Signed-off-by: Timothy Redaelli <tredae...@redhat.com> --- rhel/etc_logrotate.d_openvswitch | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

[ovs-dev] [PATCH] Documentation: Add a new topic document about ofproto/trace

Add a new document "Tracing packets inside Open vSwitch" that explains how to use "ofproto/trace" to debug flows inside the vswitch. Signed-off-by: Timothy Redaelli <tredae...@redhat.com> --- Documentation/topics/index.rst | 1 + Documentatio

[ovs-dev] [PATCH] Documentation: fix typo in documentation-style.rst

s/indenation/indentation/ Signed-off-by: Timothy Redaelli <tredae...@redhat.com> --- Documentation/internals/contributing/documentation-style.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/internals/contributing/documentation-style.rst b/Documen

[ovs-dev] [PATCH] m4: Add hard requirements for python in "configure"

Since Python 2.7 and python-six are needed to build Open vSwitch, ./configure should return an error if they are missing or if they are too old Signed-off-by: Timothy Redaelli <tredae...@redhat.com> --- m4/openvswitch.m4 | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-)

[ovs-dev] [PATCH] Documentation: fix 3 typos in testing.rst

Signed-off-by: Timothy Redaelli <tredae...@redhat.com> --- Documentation/topics/testing.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/topics/testing.rst b/Documentation/topics/testing.rst index 8c9c235..f48665b 100644 --- a/Documentation/

[ovs-dev] [RFC] make logs readable only by owner

-by: Timothy Redaelli <tredae...@redhat.com> --- lib/vlog.c | 2 +- utilities/ovs-lib.in | 5 +++-- utilities/ovs-pki.in | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) I didn't change the MKDIR_P in automake.mk since it will be removed in https://patchwork.ozlabs.org/patch/

[ovs-dev] [PATCH v2] ofproto: Add some examples for 'ofproto/trace' in ovs-vswitchd man page

Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1339097 Signed-off-by: Timothy Redaelli <tredae...@redhat.com> --- Changes in v2: - Don't use mask, but use an example MAC address for dl_dst ofproto/ofproto-unixctl.man | 36 1 file chang

[ovs-dev] [PATCH] ofproto: Add some examples for 'ofproto/trace' in ovs-vswitchd man page

Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1339097 Signed-off-by: Timothy Redaelli <tredae...@redhat.com> --- ofproto/ofproto-unixctl.man | 34 ++ 1 file changed, 34 insertions(+) diff --git a/ofproto/ofproto-unixctl.man b/ofproto/ofproto-unixc

[ovs-dev] [PATCH RFC] doc: Add some version prerequisites

Currently to build ovs, you need the following version: - GCC 4.6 or later (old GCCs have some bugs with unnamed fields) - python six library 1.4.0 or later (for six.moves.range) - kernel 2.6.36 or later (for RTA_MARK) Signed-off-by: Timothy Redaelli <tredae...@redhat.com> --- Documen

Re: [ovs-dev] [PATCH] Makefile.am: Suppress echoing of "Avoid include/ depending on lib/" commands

On Wed, Feb 22, 2017 at 10:03 PM, Joe Stringer <j...@ovn.org> wrote: > On 22 February 2017 at 08:18, Timothy Redaelli <tredae...@redhat.com> wrote: > I suggest the following instead, does this work for you? > > diff --git a/Makefile.am b/Makefile.am > index 7ff66f

[ovs-dev] [PATCH] Makefile.am: Suppress echoing of "Avoid include/ depending on lib/" commands

Build check added in commit c458e4a3 Signed-off-by: Timothy Redaelli <tredae...@redhat.com> --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 7ff66fe..147152d 100644 --- a/Makefile.am +++ b/Makefile.am @@ -230,7 +230,7 @@ co

[ovs-dev] [PATCH] fedora: Add python3-openvswitch split package

Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1412694 Signed-off-by: Timothy Redaelli <tredae...@redhat.com> --- Documentation/intro/install/fedora.rst | 1 + Vagrantfile| 1 + rhel/openvswitch-fedora.spec.in

[ovs-dev] [PATCH] ofproto: Remove 'ofproto/self-check' from ovs-vswitchd manpage

ofproto/self-check was removed in commit e79a6c83, so this patch removes the man page item. Signed-off-by: Timothy Redaelli <tredae...@redhat.com> --- ofproto/ofproto-unixctl.man | 7 --- 1 file changed, 7 deletions(-) diff --git a/ofproto/ofproto-unixctl.man b/ofproto/ofproto-unixc

[ovs-dev] [PATCH] rhel: Fix dpdk-devel version and dependencies in fedora packager

Now dpdk-devel >= 16.11 is needed and also libpcap-devel numactl-devel Tested on mock with rawhide chroot and Fedora 23 vagrant machine by using the rawhide dpdk and dpdk-devel packages Signed-off-by: Timothy Redaelli <tredae...@redhat.com> --- rhel/openvswitch-fedora.spec.in | 3 ++

[ovs-dev] [PATCH] vagrant: Use official boxes for Fedora and Centos

Change CentOS version to last 7 (7.3 at the moment) since old kernel-devel version is no longer available Add net-tools to CentOS since netstat is needed for some tests Signed-off-by: Timothy Redaelli <tredae...@redhat.com> --- Vagrantfile | 9 + 1 file changed, 5 insertions

<    1   2   3