> .
> .IP "\fBdpif-netdev/pmd-rxq-rebalance\fR [\fIdp\fR]"
> Reassigns rxqs to pmds in the datapath \fIdp\fR based on their current
> usage.
> +.
> +.IP "\fBdpif-netdev/bond-show\fR [\fIdp\fR]"
> +When "other_config:lb-output-action" is set to "true", the userspace
> datapath
> +handles the
>
> Hi. Thanks for the new version it works fine. In order to speed things
> up I prepared an incremental patch with one bug fix and some changes
> that I think are necessary to keep the code clean. Don't be afraid of
> the patch size, there are very few functional changes, most of other
>
>
> Hi. Thanks for the new version it works fine. In order to speed things
> up I prepared an incremental patch with one bug fix and some changes
> that I think are necessary to keep the code clean. Don't be afraid of
> the patch size, there are very few functional changes, most of other
>
v2:
Updated datapath action to hash + lb-output.
Updated throughput test observations.
Rebased to OVS master.
Signed-off-by: Manohar Krishnappa Chidambaraswamy
Co-authored-by: Manohar Krishnappa Chidambaraswamy
Signed-off-by: Vishal Deep Ajmera
CC: Ilya Maximets
CC: Eelco Chaudron
CC:
tes.
Signed-off-by: Manohar Krishnappa Chidambaraswamy
Co-authored-by: Manohar Krishnappa Chidambaraswamy
Signed-off-by: Vishal Deep Ajmera
CC: Matteo Croce
CC: Eelco Chaudron
CC: Ilya Maximets
CC: Jan Scheurich
CC: Venkatesan Pradeep
CC: Ben Pfaff
CC: Ian Stokes
CC: David Marchand
Signed-of
> >
> > Any thoughts on this? Should I write an equivalent of flow_wc_map() and
> use
> > it in xlate_wc_finish()
> > or we use a stricter version i.e. flow_wildcards_init_for_packet() and
use
> > in revalidate_ukey__?
>
> My big problem for review here is that I don't understand the motivation
>
> > Hi Matteo,
> >
> > Thanks for the patch. But I fail to understand why there is a memory leak.
> > In fact when I tested in my setup, the test ran without any leak.
>
> The main part is:
> '_REFILL_' loop removes packets from the original batch and
> dp_execute_output_action()
> doesn't free
Hi Matteo,
Thanks for the patch. But I fail to understand why there is a memory leak.
In fact when I tested in my setup, the test ran without any leak.
The functions dp_execute_lb_output_action and dp_execute_output_action, both
return 'false' if current batch is non-empty.
case
size 64 bytes.
Signed-off-by: Manohar Krishnappa Chidambaraswamy
Co-authored-by: Manohar Krishnappa Chidambaraswamy
Signed-off-by: Vishal Deep Ajmera
CC: Jan Scheurich
CC: Venkatesan Pradeep
CC: Ben Pfaff
CC: Ilya Maximets
CC: Ian Stokes
CC: David Marchand
CC: Matteo Croce
CC: Eelco Chaud
o-authored-by: Manohar Krishnappa Chidambaraswamy
Signed-off-by: Vishal Deep Ajmera
CC: Jan Scheurich
CC: Venkatesan Pradeep
CC: Ben Pfaff
CC: Ilya Maximets
CC: Ian Stokes
CC: David Marchand
CC: Matteo Croce
CC: Eelco Chaudron
Vishal Deep Ajmera (1):
Avoid dp_hash recirculation fo
> > Currently fast-failover group does not support checking liveness of
> controller
> > port (OFPP_CONTROLLER). However this feature can be useful for selecting
> > alternate pipeline when controller connection itself is down for e.g.
> > by using local DHCP server to reply for any DHCP request
> > I am inclined to use option 2 to have per-pmd cmap of bonds however,
> > I see that even in this option we will need to have one cmap (or hmap)
> > of bonds at global datapath level. This will take care of
> > reconfigure_pmd_threads
> > scenario. New PMDs needs to be configured with bond cmap
>
> Currently fast-failover group does not support checking liveness of
controller
> port (OFPP_CONTROLLER). However this feature can be useful for selecting
> alternate pipeline when controller connection itself is down for e.g.
> by using local DHCP server to reply for any DHCP request
> To me it looks like we will need an equivalent of flow_wc_map() which is
> less stricter than
> flow_wildcards_init_for_packet() if we want to add this check in
> xlate_wc_finish().
>
> Let me know if the current solution has issues. I can try to move this
check
> to
> xlate_wc_finish()
size 64 bytes.
Signed-off-by: Manohar Krishnappa Chidambaraswamy
Co-authored-by: Manohar Krishnappa Chidambaraswamy
Signed-off-by: Vishal Deep Ajmera
CC: Jan Scheurich
CC: Venkatesan Pradeep
CC: Ben Pfaff
CC: Ilya Maximets
CC: Ian Stokes
CC: David Marchand
CC: Matteo Croce
---
datapath/l
sed to OVS master.
Signed-off-by: Manohar Krishnappa Chidambaraswamy
Co-authored-by: Manohar Krishnappa Chidambaraswamy
Signed-off-by: Vishal Deep Ajmera
CC: Jan Scheurich
CC: Venkatesan Pradeep
CC: Ben Pfaff
CC: Ilya Maximets
CC: Ian Stokes
CC: David Marchand
CC: Matteo Croce
Vishal De
> >
> > So, the root cause of all the issues in this patch, in my understanding,
> > is the fact that you need to collect statistics for all the bond hashes
> > in order to be able to rebalance traffic. This forces you to have access
> > to PMD local caches.
> >
> > The basic idea how to overcome
> Thanks for reviewing the patch. When I use the same fix in
xlate_wc_finish()
> I get several unit test failures: 0738 0756 0763 0768 2247 2251 2255
> 2256.
>
> 0738:
> -Megaflow:
>
recirc_id=0,eth,ip,tun_id=0,tun_src=1.1.1.1,tun_dst=2.2.2.2,tun_tos=3,tun_fl
>
> >
> > Please add an item to NEWS.
> >
> > OVS is currently in "soft freeze" for the next release. We should fork
> > for the next release at the end of the week. Therefore, please resubmit
> > your patch next week.
>
> Thanks Ben. Sure I will post new patch after fork is done.
>
Hi Ben,
I
:,
bucket=watch_port:1,actions:
Signed-off-by: Vishal Deep Ajmera
---
NEWS | 1 +
lib/ofp-group.c | 3 ++-
ofproto/ofproto-dpif-xlate.c | 5 -
ofproto/ofproto-dpif.c | 10 ++
ofproto/ofproto-dpif.h | 3 +++
ofproto/ofproto.c
>
> So, the root cause of all the issues in this patch, in my understanding,
> is the fact that you need to collect statistics for all the bond hashes
> in order to be able to rebalance traffic. This forces you to have access
> to PMD local caches.
>
> The basic idea how to overcome this issue is
> This is clever! I think that this kind of approach is the right one.
>
> I don't yet understand why this should be moved from xlate_wc_finish()
> to revalidate_ukey__(). Can you help me understand that?
Hi Ben,
Thanks for reviewing the patch. When I use the same fix in xlate_wc_finish()
I
> >
> > Thanks for the patch!
> >
> > I have a few minor stylistic suggestions, see below.
> >
> > I'd like to hear Ilya's opinion on this.
>
> Thanks Ben for review! I'll take another look at this patch in a next
> couple of days.
>
> >
Hi Ilya, Ben,
Let me know if you have any comments. Can
by the revalidator thread. This
cycle will continue and will significantly degrade performance.
An earlier patch fixing the issue for MPLS and VLAN was sent.
However similar problem now appears for IPv6 datapath flows.
This patch addresses the issue in a generic way.
Signed-off-by: Vishal Deep Ajmera
>
> Thanks for the new feature.
>
> Please add an item to NEWS.
>
> OVS is currently in "soft freeze" for the next release. We should fork
> for the next release at the end of the week. Therefore, please resubmit
> your patch next week.
Thanks Ben. Sure I will post new patch after fork is
:,
bucket=watch_port:1,actions:
Signed-off-by: Vishal Deep Ajmera
---
lib/ofp-group.c | 3 ++-
ofproto/ofproto-dpif-xlate.c | 5 -
ofproto/ofproto-dpif.c | 10 ++
ofproto/ofproto-dpif.h | 3 +++
ofproto/ofproto.c| 3 ++-
5 files changed, 21
size 64 bytes.
Signed-off-by: Manohar Krishnappa Chidambaraswamy
Co-authored-by: Manohar Krishnappa Chidambaraswamy
Signed-off-by: Vishal Deep Ajmera
CC: Jan Scheurich
CC: Venkatesan Pradeep
CC: Nitin Katiyar
---
datapath/linux/compat/include/linux/openvswitch.h | 1 +
lib/dpif-netdev.
hroughput test observations.
Rebased to OVS master.
Signed-off-by: Manohar Krishnappa Chidambaraswamy
Co-authored-by: Manohar Krishnappa Chidambaraswamy
Signed-off-by: Vishal Deep Ajmera
CC: Jan Scheurich
CC: Venkatesan Pradeep
Vishal Deep Ajmera (1):
Avoid dp_hash recirculation for bala
>
> I'm not sure what's happened here but this patch really really fails to
> apply:
>
> Applying: Avoid dp_hash recirculation for balance-tcp bond selection
> mode
> error: patch failed:
> datapath/linux/compat/include/linux/openvswitch.h:994
> error:
OVS master.
Signed-off-by: Manohar Krishnappa Chidambaraswamy
Co-authored-by: Manohar Krishnappa Chidambaraswamy
Signed-off-by: Vishal Deep Ajmera
CC: Jan Scheurich
CC: Venkatesan Pradeep
Vishal Deep Ajmera (1):
Avoid dp_hash recirculation for balance-tcp bond selection mode
datapath/li
size 64 bytes.
Signed-off-by: Manohar Krishnappa Chidambaraswamy
Co-authored-by: Manohar Krishnappa Chidambaraswamy
Signed-off-by: Vishal Deep Ajmera
CC: Jan Scheurich
CC: Venkatesan Pradeep
CC: Nitin Katiyar
---
datapath/linux/compat/include/linux/openvswitch.h | 1 +
lib/dpif-netdev.
>
> I took a look. The underlying issue is that code here mixes integers,
> ofp_port_t, and odp_port_t. OVS uses "sparse" annotations to keep these
> from being confused, since they are different in important ways. I
> spent some time working through the types here and appended a patch that
>
rge issue.
v1->v2:
Updated datapath action to hash + lb-output.
Updated throughput test observations.
Rebased to OVS master.
Vishal Deep Ajmera (1):
Avoid dp_hash recirculation for balance-tcp bond selection mode
datapath/linux/compat/include/linux/openvswitch.h | 1
size 64 bytes.
Signed-off-by: Manohar Krishnappa Chidambaraswamy
Co-authored-by: Manohar Krishnappa Chidambaraswamy
Signed-off-by: Vishal Deep Ajmera
CC: Jan Scheurich
CC: Venkatesan Pradeep
---
datapath/linux/compat/include/linux/openvswitch.h | 1 +
lib/dpif-netdev.
> Thanks, applied to master.
Thanks Ben.
Warm Regards,
Vishal Ajmera
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
will continue and will significantly degrade performance.
This patch fixes the issue by wildcarding flow fields which are not present
in the incoming packet.
Signed-off-by: Vishal Deep Ajmera
---
ofproto/ofproto-dpif-xlate.c | 20
1 file changed, 20 insertions(+)
diff --git a/ofproto
Hi Darrell, Ben
Sent v2 patch for branch 2.6. It will also apply cleanly to branch 2.7. If
looks ok, kindly merge.
Warm Regards,
Vishal Ajmera
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
space connection tracker.")
CC: Daniele Di Proietto
Reported-at:
https://mail.openvswitch.org/pipermail/ovs-dev/2019-August/361949.html
Reported-by: Vishal Deep Ajmera
Signed-off-by: Vishal Deep Ajmera
Co-authored-by: Vishal Deep Ajmera
Signed-off-by: Darrell Ball
---
lib/conntr
>
> Thanks Darrell. I have sent patches for branch 2.8 and 2.9.
> For branches before 2.7 & 2.6 it is giving quite a few conflicts.
> Can you please have a look at it?
>
Hi Darrell, Ben
I have tried manual merge on OVS 2.6 branch and sent a patch.
Can you please review and apply it on branch?
space connection tracker.")
CC: Daniele Di Proietto
Reported-at:
https://mail.openvswitch.org/pipermail/ovs-dev/2019-August/361949.html
Reported-by: Vishal Deep Ajmera
Signed-off-by: Vishal Deep Ajmera
Co-authored-by: Vishal Deep Ajmera
Signed-off-by: Darrell Ball
Signed-off-by: Ben Pfaff
(che
>
> Thanks
> This is eligible to go back to 2.6; it should apply cleanly back to 2.9; I
> can look into the remaining ones,
> unless Vishal would like to do those.
Thanks Darrell. I have sent patches for branch 2.8 and 2.9.
For branches before 2.7 & 2.6 it is giving quite a few conflicts.
Can
space connection tracker.")
CC: Daniele Di Proietto
Reported-at:
https://mail.openvswitch.org/pipermail/ovs-dev/2019-August/361949.html
Reported-by: Vishal Deep Ajmera
Signed-off-by: Vishal Deep Ajmera
Co-authored-by: Vishal Deep Ajmera
Signed-off-by: Darrell Ball
Signed-off-by: Ben Pfaff
(che
space connection tracker.")
CC: Daniele Di Proietto
Reported-at:
https://mail.openvswitch.org/pipermail/ovs-dev/2019-August/361949.html
Reported-by: Vishal Deep Ajmera
Signed-off-by: Vishal Deep Ajmera
Co-authored-by: Vishal Deep Ajmera
Signed-off-by: Darrell Ball
Signed-off-by: Ben Pfaff
(che
> >
> > I'll be able to provide the patches but you will need to test them
> > since I no longer have an
> > environment that will build branches older than 2.8. I'll post
> > patches for 2.8, 2.7 and 2.6
> > in a bit.
>
> The patches are posted Vishal, please test and review.
>
Thanks Greg. I
> > Upstream commit 648700f76b03 ("inet: frags: use rhashtables...") changed
> > how ipv6 fragmentation is implemented. This patch was backported to
> > the upstream stable 4.9.x kernel starting at 4.9.135.
> >
> > This patch creates the compatibility layer changes required to both
> > compile
>
> All unit test passed, plus others I did.
>
> Tested-by: Matteo Croce
>
Thank you Matteo for your efforts in testing this patch.
Warm Regards,
Vishal Ajmera
___
dev mailing list
d...@openvswitch.org
> >
> Let me check this in my setup. I always used 'netdev' bridges for testing my
> patch.
> May be I need to be check for data path support in the display function as
> well.
Hi,
I have sent v7 version of patch fixing this issue.
Warm Regards,
Vishal Ajmera
ets per second.
Signed-off-by: Manohar Krishnappa Chidambaraswamy
Co-authored-by: Manohar Krishnappa Chidambaraswamy
Signed-off-by: Vishal Deep Ajmera
CC: Jan Scheurich
CC: Venkatesan Pradeep
CC: Nitin Katiyar
---
datapath/linux/compat/include/linux/openvswitch.h | 2 +
lib/dpif-netdev.
ased to OVS master.
Vishal Deep Ajmera (1):
Avoid dp_hash recirculation for balance-tcp bond selection mode
datapath/linux/compat/include/linux/openvswitch.h | 2 +
lib/dpif-netdev.c | 515 --
lib/dpif-netlink.c
> >
> > I confirm a decent performance improvement with DPDK and balance-tcp
> bonding:
> >
> > lb-output-action=false
> >
> > rx: 740 Mbps 1446 kpps
> >
> > lb-output-action=true
> >
> > rx: 860 Mbps 1680 kpps
> >
> > I'm running a very simple test with a tweaked version of testpmd which
> >
million packets per second.
Signed-off-by: Manohar Krishnappa Chidambaraswamy
Co-authored-by: Manohar Krishnappa Chidambaraswamy
Signed-off-by: Vishal Deep Ajmera
CC: Jan Scheurich
CC: Venkatesan Pradeep
CC: Nitin Katiyar
---
datapath/linux/compat/include/linux/o
comments.
https://mail.openvswitch.org/pipermail/ovs-dev/2019-July/360452.html
v2->v3:
Rebased to OVS master.
Fixed git merge issue.
v1->v2:
Updated datapath action to hash + lb-output.
Updated throughput test observations.
Rebased to OVS master.
Vishal Deep Ajmera (1):
Avoid dp_has
Thanks Darrell. Patch looks ok to me.
Warm Regards,
Vishal Ajmera
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
That is interesting
i just tried applying on top of tree and I see that the git applies some
changes (2 lines)
in extract_l4_icmp6() rather the intended extract_l4_icmp() as in the patch I
sent out.
My guess is that the surrounding lines are identical in the 2 functions and I
had other
patches
Thanks Ilya for comments. I will address them in the next patch-set.
Warm Regards,
Vishal Ajmera
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
> Hi Vishal,
>
> I quickly tested your patch on two servers with 2 ixgbe cards each linked via
> a
> juniper switch with LACP.
> With testpmd using a single core the switching rate raised from ~2.0 Mpps to
> ~2.4+ Mpps, so I read at least a +20% gain.
>
> Please add an example command on how
Hi Darrell,
Thanks for the patch. When I applied the patch to latest master,
I see that we take care of length check (< 8) only for ICMPv6 and
not for ICMPv4. We need to do it for ICMPv4 as well.
Also, we are already using 'related' to skip or not to skip length check.
* If 'related' is
Hi Darrell,
Can we get this merged into master as well as backports to affected branches?
Warm Regards,
Vishal Ajmera
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Hi Ilya, Ben,
Any thoughts on patch-set v5? Rebalancing is now supported with optimized tcp
bond implementation.
Warm Regards,
Vishal Ajmera
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> On Behalf Of Vishal Deep Ajmera
> Sent: Frid
for TCP header
length (20 bytes). Since TCP header is partial the length check fails and
packet is erroneously dropped.
This patch fixes length check for TCP header when processing ICMP data
fields.
Signed-off-by: Vishal Deep Ajmera
---
lib/conntrack.c | 14 +++---
lib/packets.h | 1 +
2
>
> Hi,
>
> why not a static function in the header file? So it gets inlined.
>
> Regards,
> --
> Matteo Croce
> per aspera ad upstream
Thanks Matteo for looking into this patch-set. Yes I agree. I will address your
suggestion in the next revision.
Warm Regards,
Vishal
> Comments for v2 wasn't addressed and still valid:
> https://protect2.fireeye.com/url?k=c85828c4-94d1f2d4-c858685f-
> 0cc47ad93e2a-
> cd974aa1a210bc2b=1=https%3A%2F%2Fmail.openvswitch.org%2Fpiperma
> il%2Fovs-dev%2F2019-July%2F360452.html
Patch-set v5 set for review. It now includes
v2:
Updated datapath action to hash + lb-output.
Updated throughput test observations.
Rebased to OVS master.
Vishal Deep Ajmera (1):
Avoid dp_hash recirculation for balance-tcp bond selection mode
datapath/linux/compat/include/linux/openvswitch.h | 2 +
lib/d
+
mpps: million packets per second.
Signed-off-by: Manohar Krishnappa Chidambaraswamy
Co-authored-by: Manohar Krishnappa Chidambaraswamy
Signed-off-by: Vishal Deep Ajmera
CC: Jan Scheurich
CC: Venkatesan Pradeep
CC: Nitin Katiyar
---
datapath/linux/compat/include/linux/o
>
> Applied to master, thanks!
Thanks Ben.
Warm Regards,
Vishal Ajmera
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
+
mpps: million packets per second.
Signed-off-by: Manohar Krishnappa Chidambaraswamy
Co-authored-by: Manohar Krishnappa Chidambaraswamy
Signed-off-by: Vishal Deep Ajmera
CC: Jan Scheurich
CC: Venkatesan Pradeep
CC: Nitin Katiyar
---
datapath/linux/compat/include/linux/o
l
Vishal Deep Ajmera (1):
Avoid dp_hash recirculation for balance-tcp bond selection mode
datapath/linux/compat/include/linux/openvswitch.h | 2 +
lib/dpif-netdev.c | 462 --
lib/dpif-netlink.c| 2 +
lib/dpif-p
>
> This patch wildcards UDP ports when using select group with SYMMETRIC_L4
> hash function.
>
Hi Ben,
Any thoughts on this patch ? This looks like a bug in OVS master.
Warm Regards,
Vishal Ajmera
___
dev mailing list
d...@openvswitch.org
source and destination ports unnecessarily and causes significant performance
deterioration when the megaflow cache limit is reached.
This patch wildcards UDP ports when using select group with SYMMETRIC_L4
hash function.
Signed-off-by: Vishal Deep Ajmera
CC: Jan Scheurich
---
lib/flow.c | 7
>
> I've been taking a look at this patch for the last few minutes. It
> introduces a lot
> of mechanism for the use case. Did you consider any simpler mechanisms to
> achieve the same effect? What prevented them from working?
>
I agree Ben. This change does bring some complexity to the
+
mpps: million packets per second.
Signed-off-by: Manohar Krishnappa Chidambaraswamy
Co-authored-by: Manohar Krishnappa Chidambaraswamy
Signed-off-by: Vishal Deep Ajmera
CC: Jan Scheurich
CC: Venkatesan Pradeep
CC: Nitin Katiyar
---
datapath/linux/compat/include/linux/o
v1->v2:
Updated datapath action to hash + lb-output.
Updated throughput test observations.
Rebased to OVS master.
v2->v3:
Rebased to OVS master.
Fixed git merge issue.
Vishal Deep Ajmera (1):
Avoid dp_hash recirculation for balance-tcp bond selection mode
datapath/linux/compat/i
>
> Thanks for the patch.
>
> I wasn't able to apply this patch. In two places, the patch was corrupted
> (the
> patch didn't properly represent page-break characters in the source code but
> transformed them into blank lines). I fixed that up after figuring out what
> was
> going on, but
V2 patch- set is posted for review.
>
> One more thing:
> Despite of usual OVS bonding, this implementation doesn't support
> shifting the load between ports. Am I right?
> This could be an issue, because few heavy flows could be mapped to
> a single port, while other ports
500k 2.254.2789.23
+--+
mpps: million packets per second.
Signed-off-by: Manohar Krishnappa Chidambaraswamy
Co-authored-by: Manohar Krishnappa Chidambaraswamy
Signed-off-by: Vishal Deep Ajmera
CC: Jan Scheurich
CC: Venkatesan Pradeep
C
v1->v2:
Updated datapath action to hash + lb-output.
Updated throughput test observations.
Rebased to OVS master.
Vishal Deep Ajmera (1):
Avoid dp_hash recirculation for balance-tcp bond selection mode
datapath/linux/compat/include/linux/openvswitch.h | 2 +
lib/dpif-netde
>
> This patch fixes both the above issue by retaining the ofport number till
> ofport
> entry exists in the OVSDB.
>
> Warm Regards,
> Vishal Ajmera
Hi Ben,
Did you get a chance to review this patch ?
Warm Regards,
Vishal Ajmera
___
dev mailing
> >
> > This patch reserves the ofport port number for the duration the ofport
> > entry persists in the ovsdb. Once the entry is deleted from ovsdb the
> > ofport number is recirculated on LRU basis.
> >
> > Signed-off-by: Vishal Deep Ajmera
>
> This i
the ofport port number for the duration the ofport
entry persists in the ovsdb. Once the entry is deleted from ovsdb the
ofport number is recirculated on LRU basis.
Signed-off-by: Vishal Deep Ajmera
---
ofproto/ofproto.c | 17 +--
ofproto/ofproto.h | 2 +
vswitchd/bridge.c | 145
ng these fields from an ICMPv6 packet header
> > and extending the OpenFlow protocol with specifications for these new
> > OXM fields for matching, copying and setting.
> >
> > Signed-off-by: Vishal Deep Ajmera
> > Co-authored-by:
>
> Currently OVS supports all ARP protocol fields as OXM match fields to
> implement the relevant ARP procedures for IPv4. This includes support
> for matching copying and setting ARP fields. In IPv6 ARP has been
> replaced by ICMPv6 neighbor discovery (ND) procedures, neighbor
> advertisement
>
> 'conn_key_extract()' in userspace conntrack is including L2
> (Ethernet) pad bytes for both L3 and L4 sizes. One problem is any packet with
> non-zero L2 padding can incorrectly fail L4 checksum validation.
>
> This patch fixes conn_key_extract() by ignoring L2 pad bytes.
>
Thanks Darrell
, copying and setting.
Signed-off-by: Vishal Deep Ajmera
Co-authored-by: Ashvin Lakshmikantha
Signed-off-by: Ashvin Lakshmikantha
---
NEWS | 2 +
build-aux/extract-ofp-fields | 1 +
datapath/linux/compat/include/linux/openvswitch.h
rsing test in odp.at. Rebased to latest master.
Vishal Deep Ajmera (1):
Support for match & set ICMPv6 reserved and options type fields
NEWS | 2 +
build-aux/extract-ofp-fields | 1 +
datapath/linux/compat/include/linu
by ignoring L2 pad bytes for L4
checksum validation.
Signed-off-by: Vishal Deep Ajmera
Co-authored-by: Venkatesan Pradeep
Co-authored-by: Nitin Katiyar
Signed-off-by: Venkatesan Pradeep
Signed-off-by: Nitin Katiyar
---
lib/conntrack.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
> -Original Message-
> From: Ben Pfaff
> Sent: Saturday, January 19, 2019 12:04 AM
> To: Vishal Deep Ajmera
> Cc: d...@openvswitch.org; Ashvin Lakshmikantha
>
> Subject: Re: [ovs-dev] [PATCH v2] Support for match & set ICMPv6 reserved and
> options typ
, copying and setting.
Signed-off-by: Vishal Deep Ajmera
Co-authored-by: Ashvin Lakshmikantha
Signed-off-by: Ashvin Lakshmikantha
---
NEWS | 2 +
build-aux/extract-ofp-fields | 1 +
datapath/linux/compat/include/linux/openvswitch.h
This patch adds support for match and set ICMPv6
"reserved" and "nd options type" fields.
v1->v2: Fixed compiler and sparse warnings.
v2->v3: Updated NEWS, simplified miniflow_extract for ICMPv6,
updated usage for tcp_flags and igmpgroup_ipv4.
Vishal Deep Ajmera (1):
> -Original Message-
> From: Ben Pfaff
> Sent: Thursday, January 17, 2019 6:11 AM
> To: Vishal Deep Ajmera
> Cc: d...@openvswitch.org; Ashvin Lakshmikantha
>
> Subject: Re: [ovs-dev] [PATCH] Support for match & set ICMPv6 reserved and
> options type fiel
, copying and setting.
Signed-off-by: Vishal Deep Ajmera
Co-authored-by: Ashvin Lakshmikantha
Signed-off-by: Ashvin Lakshmikantha
---
build-aux/extract-ofp-fields | 1 +
datapath/linux/compat/include/linux/openvswitch.h | 8 ++
include/openvswitch/match.h
This patch adds support for match and set ICMPv6
"reserved" and "nd options type" fields.
v1->v2: Fixed compiler and sparse warnings.
Vishal Deep Ajmera (1):
Support for match & set ICMPv6 reserved and options type fields
build-aux/extract-ofp-fields
> >
> > That is good to know, but the inner struct is not the main issue as I see
> > it.
> > The main issue is that the change breaks the ABI. This change must be
> > implemented in some way that does not break the ABI.
>
> Hi Ben,
> Are there any guidelines or mechanism available to extend
> > Thanks Ben. Yes, the inner structure is not required. Earlier we
> > defined it as union and later changed it to structure. Instead those
> > fields can be simply defined outside of inner structure. I will fix this in
> > v2
> patch.
>
> That is good to know, but the inner struct is not
>
> Thanks for working on making OVS better support IPv6.
>
> The following change stood out to me. It appears to break ABI compatibility
> in the kernel datapath. Is there some reason it's OK? I especially don't
> understand why it adds a nested inner struct.
>
Thanks Ben. Yes, the inner
, copying and setting.
Signed-off-by: Ashvin Lakshmikantha
Signed-off-by: Vishal Deep Ajmera
Co-authored-by: Vishal Deep Ajmera
---
build-aux/extract-ofp-fields | 2 +-
datapath/linux/compat/include/linux/openvswitch.h | 10 +++--
include/openvswitch/match.h
Thanks Ian and Ben.
Warm Regards,
Vishal Ajmera
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> On Behalf Of Ben Pfaff
> Sent: Tuesday, August 28, 2018 2:00 AM
> To: Ian Stokes
> Cc: d...@openvswitch.org
> Subject: Re: [ovs-dev] OVS DPDK:
in a permanent drop in
performance in OVS with no automatic recovery.
This patch fixes the conditional check for increasing flow limit.
Signed-off-by: Vishal Deep Ajmera
---
ofproto/ofproto-dpif-upcall.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ofproto/ofproto-dpif
> Have you tried solution with direct pushing of all the packets to
> 'flow_map' and per-flow batching only at the end of 'dp_netdev_input__()'?
>
> Is it really slower?
> If you have some performance data, I'd like to see it, because it looks
> like code should be simpler without this
are *appended* to per-flow buffer.
Signed-off-by: Vishal Deep Ajmera
Co-authored-by: Venkatesan Pradeep
Signed-off-by: Venkatesan Pradeep
---
lib/dpif-netdev.c | 125 +-
1 file changed, 106 insertions(+), 19 deletions(-)
diff --git a/lib/dpif-netdev.c b
Hi Ian, Ilya,
If there are no more comments, can I request to please include the fix
in this week's pull request?
Warm Regards,
Vishal Ajmera
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
1 - 100 of 149 matches
Mail list logo
