put dump-meters' result in one line so add-meters can handle.
save and restore meters when restart ovs.
bundle functions are not implemented in this patch.
Signed-off-by: Wan Junjie
---
v11:
add OFP_ prefix to macro
add testcases for meters
v10:
merge oneline to verbosity in parse_op
.
This patch will skip the invalid flows and continue the process so
all valid flows will be added during the ovs restart. An destructed vm
will not affect those normal vm traffic.
Signed-off-by: Wan Junjie
---
v2:
handle vconn_transact_noreply's return error and reply seperately
code
On Thu, May 4, 2023 at 7:08 PM Ilya Maximets wrote:
>
> On 4/11/23 15:25, Wan Junjie via dev wrote:
> > put dump-meters' result in one line so add-meters can handle.
> > save and restore meters when restart ovs.
> > bundle functions are not implemented in this patc
On Wed, Apr 26, 2023 at 8:57 PM Simon Horman wrote:
>
> On Mon, Apr 24, 2023 at 02:01:03PM +0800, Wan Junjie via dev wrote:
> > ovs-save will do replace-flows for ovs restart. For some reason, ovs
> > could have an invalid action, like invalid meter. Then adding flows
> >
On Wed, Apr 26, 2023 at 4:19 PM Ilya Maximets wrote:
>
> On 4/21/23 15:07, Wan Junjie via dev wrote:
> > Deployment with dpdk and spdk should limit the core of non-pmd
> > threads. When starting ovs with ovs-ctl or systemd, the process will
> > inherit the affinity of its
.
This patch will skip the invalid flows and continue the process so
all valid flows will be added during the ovs restart. An destructed vm
will not affect those normal vm traffic.
Signed-off-by: Wan Junjie
---
include/openvswitch/vconn.h | 2 +-
lib/vconn.c | 23
start daemon, so it will set the
affinity each time starting the ovs.
Signed-off-by: Wan Junjie
---
Documentation/ref/ovs-ctl.8.rst | 5 +
utilities/ovs-ctl.in| 8 ++--
utilities/ovs-lib.in| 6 ++
3 files changed, 17 insertions(+), 2 deletions(-)
diff --git a
put dump-meters' result in one line so add-meters can handle.
save and restore meters when restart ovs.
bundle functions are not implemented in this patch.
Signed-off-by: Wan Junjie
---
v10:
merge oneline to verbosity in parse_options
ofp_to_string__ handle verbosity bits right
v9
On Tue, Apr 11, 2023 at 7:45 PM Simon Horman wrote:
>
> On Tue, Apr 11, 2023 at 11:03:46AM +0800, Wan Junjie wrote:
> > put dump-meters' result in one line so add-meters can handle.
> > save and restore meters when restart ovs.
> > bundle functions are
put dump-meters' result in one line so add-meters can handle.
save and restore meters when restart ovs.
bundle functions are not implemented in this patch.
Signed-off-by: Wan Junjie
---
v9:
fix verbosity mask bits for testcase
apologies for mess
v8:
fix missing code for testcase
v7:
ty
put dump-meters' result in one line so add-meters can handle.
save and restore meters when restart ovs.
bundle functions are not implemented in this patch.
Signed-off-by: Wan Junjie
---
v8:
fix missing code for testcase
v7:
typo in code
v6:
code style
v5:
merge oneline to verbosity h
put dump-meters' result in one line so add-meters can handle.
save and restore meters when restart ovs.
bundle functions are not implemented in this patch.
Signed-off-by: Wan Junjie
---
v7:
typo in code
v6:
code style
v5:
merge oneline to verbosity higher bits
remove duplicate dump_m
put dump-meters' result in one line so add-meters can handle.
save and restore meters when restart ovs.
bundle functions are not implemented in this patch.
Signed-off-by: Wan Junjie
---
v6:
code style
v5:
merge oneline to verbosity higher bits
remove duplicate dump_meters code
v4:
Hi Simon,
On Wed, Mar 29, 2023 at 11:57 PM Simon Horman wrote:
>
> On Fri, Mar 10, 2023 at 09:03:48PM +0800, Wan Junjie wrote:
> > put dump-meters' result in one line so add-meters can handle.
> > save and restore meters when restart ovs.
> > bundle functions are
Hi Adrian,
On Sat, Apr 1, 2023 at 12:39 AM Adrian Moreno wrote:
>
> Hi Wan,
>
> Thanks for submitting this patch.
>
> On 11/18/22 09:13, Wan Junjie wrote:
> > According to the ovs-fields manpage, 'TLVs must be ordered so that
> > a field’s prerequisite
put dump-meters' result in one line so add-meters can handle.
save and restore meters when restart ovs.
bundle functions are not implemented in this patch.
Signed-off-by: Wan Junjie
---
v5:
merge oneline to verbosity higher bits
remove duplicate dump_meters code
v4:
code refactor accordi
Hi Simon Horman,
Thanks for your review.
On Mon, Mar 6, 2023 at 11:23 PM Simon Horman wrote:
>
> On Sat, Mar 04, 2023 at 11:23:50AM +0800, Wan Junjie wrote:
> > Hi Simon,
> >
> > Thanks for the review.
>
> Hi Wan Junjie,
>
> Thanks for responding.
>
&g
Hi Simon,
Thanks for the review.
On Fri, Mar 3, 2023 at 11:06 PM Simon Horman wrote:
>
> On Wed, Mar 01, 2023 at 04:05:17PM +0800, Wan Junjie wrote:
> > put dump-meters' result in one line so add-meters can handle.
> > save and restore meters when restart ovs.
>
put dump-meters' result in one line so add-meters can handle.
save and restore meters when restart ovs.
bundle functions are not implemented in this patch.
Signed-off-by: Wan Junjie
---
v4:
code refactor according to comments
v3:
add '--oneline' option for dump-meter(s) command
Hi,
On Tue, Feb 28, 2023 at 4:03 PM David Marchand
wrote:
>
> Hello,
>
> On Fri, Feb 24, 2023 at 2:55 AM Han Ding wrote:
> > >On 2/23/23 10:35, Han Ding wrote:
> > >>
> > >> When use ovs-vsctl to delete vhostuserclient port while qemu destroy
> > >> virtio,
> > >> there is a deadlock between OV
Hi Adrian,
Thank you for your review.
On Sat, Feb 25, 2023 at 1:17 AM Adrian Moreno wrote:
>
> Hi Wan,
>
> Sorry for the delay in the review.
> I've started looking at this patch. Please see some initial comments below.
> I'll
> continue on Monday.
>
> Than
m
load and remove. Use command for a afxdp type interface like below:
ovs-vsctl set int xxx options:inhibit=true
--
v2: fix some code missing
Signed-off-by: Wan Junjie
---
lib/netdev-afxdp.c | 45 +++---
lib/netdev-linux-private.h | 3 +++
2 files c
m
load and remove. Use command for a afxdp type interface like below:
ovs-vsctl set int xxx options:inhibit=true
Signed-off-by: Wan Junjie
---
lib/netdev-afxdp.c | 31 ++-
lib/netdev-linux-private.h | 3 +++
2 files changed, 25 insertions(+), 9 deletions(-)
di
limitation here make
sure that the order should be respected.
Signed-off-by: Wan Junjie
---
lib/ofp-flow.c| 3 +++
tests/ofproto-dpif.at | 8
tests/ovs-ofctl.at| 15 +++
3 files changed, 22 insertions(+), 4 deletions(-)
diff --git a/lib/ofp-flow.c b/lib/ofp-flow.c
inde
put dump-meters' result in one line so add-meters can handle.
save and restore meters when restart ovs.
bundle functions are not implemented in this patch.
Signed-off-by: Wan Junjie
---
v3:
add '--oneline' option for dump-meter(s) command
v2:
fix failed testcases, as dump-meters
On Tue, May 17, 2022 at 2:56 AM Ilya Maximets wrote:
>
> On 3/9/22 15:19, Wan Junjie wrote:
> > When several pmd threads race for the meter lock, the time 'now' each pmd
> > runs will
> > have no guarantee in the order they really happen.
> >
> > Fo
On Fri, May 6, 2022 at 4:43 PM Adrian Moreno wrote:
>
> On 2/28/22 12:40, Wan Junjie wrote:
> > put dump-meters' result in one line so add-meters can handle.
> > save and restore meters when restart ovs.
> > bundle functions are not implemented in this patch.
>
On Sat, Apr 2, 2022 at 12:25 AM Kevin Traynor wrote:
>
> On 29/03/2022 04:26, Wan Junjie wrote:
> > Hi Kevin,
> >
> > Thanks for your comments.
> >
> > On Fri, Mar 25, 2022 at 8:17 PM Kevin Traynor wrote:
> >>
> >> Hi Wan Junjie,
> &g
Hi Kevin,
Thanks for your comments.
On Fri, Mar 25, 2022 at 8:17 PM Kevin Traynor wrote:
>
> Hi Wan Junjie,
>
> Not a full code review, but comments on the feature below.
>
> On 02/03/2022 10:59, Wan Junjie wrote:
> > A pmd would poll all rxqs with no weight
On Fri, Mar 18, 2022 at 1:49 PM Tonghao Zhang wrote:
>
> On Wed, Mar 9, 2022 at 10:20 PM Wan Junjie wrote:
> >
> > When several pmd threads race for the meter lock, the time 'now' each pmd
> > runs will
> > have no guarantee in the order they really happe
we expect. With really high thoughput and more than
four
pmd threads, the deviation here will grow up very high.
This fix makes sure the time will only be added up.
Signed-off-by: Wan Junjie
---
lib/dpif-netdev.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/lib
to 'single'
And it works fairly well when n_rxq of dpdk phy port equals to
number of dpdk pmds, which means one n_rxq for one pmd
Signed-off-by: Wan Junjie
Reviewed-by: He Peng
---
lib/dpif-netdev.c | 133 ++
1 file changed, 1
put dump-meters' result in one line so add-meters can handle.
save and restore meters when restart ovs.
bundle functions are not implemented in this patch.
Signed-off-by: Wan Junjie
---
v2:
fix failed testcases, as dump-meters format changes
---
include/openvswitch/ofp-meter.h | 6 +++
li
put dump-meters' result in one line so add-meters can handle.
save and restore meters when restart ovs.
bundle functions are not implemented in this patch.
Signed-off-by: Wan Junjie
---
include/openvswitch/ofp-meter.h | 6 +++
lib/ofp-meter.c
Kindly reminder here.
Not sure if I have put the right reviewer in the Cc list.
On Tue, Feb 15, 2022 at 5:53 PM Wan Junjie wrote:
>
> When we create two or more tunnels with the same type, only the first
> tunnel will be added by dpif since they share the same datapath port.
> Set t
ned-off-by: Wan Junjie
---
ofproto/ofproto-dpif.c | 4
1 file changed, 4 insertions(+)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index 8143dd965..938967d19 100644
--- a/ofproto/ofproto-dpif.c
+++ b/ofproto/ofproto-dpif.c
@@ -3963,6 +3963,10 @@ port_add(struct ofproto *ofprot
s 70% usage. Enabling cross-numa polling
> > for a vhu port would give us more benefits in this case. Overloads of
> > different
> > pmds on both numa would be balanced.
> > As you have mentioned, there is no code to apply this config for vhu while
> > crea
give us more benefits in this
case. Overloads of different pmds on both numa would be balanced.
As you have mentioned, there is no code to apply this config for vhu
while creating them. A global setting would save us from dynamically
detecting the vhu name or any new creation.
Regards,
Wan Junjie
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Hi Kevin,
Thanks for your reply.
Sorry about forgetting the cc, repost it.
On Sat, Feb 12, 2022 at 1:09 AM Kevin Traynor wrote:
>
> Hi Wan Junjie,
>
> On 27/01/2022 11:43, Wan Junjie wrote:
> > When assign a rxq to a pmd, the rxq will only be assigned to
> > the numa
qs on these pmds became the bottle neck.
pmd-rxq-numa=false would ignore the rxq's numa attribute when
assign rxq to pmds. This could make full use of the cores from
different numas while we have limited core resources for pmds.
Signed-off-by: Wan Junjie
---
lib/dpif-netdev.
d (request=,
conn=0x55fb517f0770) at lib/unixctl.c:308
- 2 run_connection (conn=0x55fb517f0770) at lib/unixctl.c:342
- 3 unixctl_server_run (server=0x55fb4fef9300) at lib/unixctl.c:393
- 4 0x55fb4df73c0f in main (argc=, argv=) at
v$witchd/ovs-v$witchd.c:140
Signed-off-by: Wan Junjie
---
ofpro
The ```rte_mempool_avail_count``` and ```rte_mempool_in_use_count```
can tell us the usage of the mempool. It could be helpful for debug
on any memleak in the mempool.
Add a line in the cmd's output.
- Count: avail (118988), in use (12084)
Acked-by: Aaron Conole
Signed-off-by: Wan Junjie
-
The ```rte_mempool_avail_count``` and ```rte_mempool_in_use_count```
can tell us the usage of the mempool. It could be helpful for debug
on any memleak in the mempool.
Add a line in the cmd's output.
- Count: avail (118988), in use (12084)
Signed-off-by: Wan Junjie
---
lib/netdev-dpdk.
On Wed, Oct 13, 2021 at 5:12 AM Aaron Conole wrote:
>
> Ilya Maximets writes:
>
> > IP fragmentation engine may not only steal the packet but also add
> > more. For example, after receiving the last fragment, it will
> > add all previous fragments to a batch. Unfortunately, it will also
> > fre
be
> > reinserted into the packet batch. Subsequent valgrind runs show that
> > the packets are not leaked from the batch any longer.
> >
> > Fixes: 640d4db788ed ("ipf: Fix a use-after-free error, and remove the
> > 'do_not_steal' flag.")
>
> Not s
ovs source first,
Then use command like below to generate the packages:
DATAPATH_CONFIGURE_OPTS='--with-ovs-source=path/to/ovs'
DEB_BUILD_OPTIONS='parallel=8 nocheck' fakeroot debian/rules binary
Signed-off-by: Wan Junjie
---
v2,v3:
fix patch
ovs source first,
Then use command like below to generate the packages:
DATAPATH_CONFIGURE_OPTS='--with-ovs-source=path/to/ovs'
DEB_BUILD_OPTIONS='parallel=8 nocheck' fakeroot debian/rules binary
Signed-off-by: Wan Junjie
---
v2:
fix patch
47 matches
Mail list logo
