[ovs-dev] [PATCH v3] route-table: Add support for v4 via v6 route.

2024-05-13 Thread William Tu via dev
in the packet header, but only used for lookup the out dev br-phy. Currently OVS can only support either all-ipv4 or all-ipv6, the patch adds support for such use case. Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2024-January/052908.html Acked-by: Simon Horman Signed-off-by: William Tu

[ovs-dev] [PATCH RFCv2] route-table: Add support for v4 via v6 route.

2024-04-27 Thread William Tu via dev
support for such use case. Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2024-January/052908.html Signed-off-by: William Tu --- v2: fix CI errors RFC: wait for Derrick to verify vxlan use case --- lib/ovs-router.c | 34 -- lib/route-table.c

[ovs-dev] [PATCH RFC] route-table: Add support for v4 via v6 route.

2024-04-27 Thread William Tu via dev
for such use case. Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2024-January/052908.html Signed-off-by: William Tu --- Need Derrick to verify it's working on tunnel --- lib/ovs-router.c | 34 -- lib/route-table.c | 26

[ovs-dev] [PATCH RFC] route-table: Add support for v4 via v6 route.

2024-04-26 Thread William Tu via dev
for such use case. Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2024-January/052908.html Signed-off-by: William Tu --- Need Derrick to verify it's working on tunnel --- lib/ovs-router.c | 34 -- lib/route-table.c | 26

Re: [ovs-dev] [PATCH 3/3] netdev-offload-tc: Add VxLAN encap support.

2023-07-06 Thread William Tu
On Mon, Jun 26, 2023 at 7:53 AM Simon Horman wrote: > > On Wed, Jul 08, 2020 at 09:10:36AM -0700, William Tu wrote: > > The patch adds VxLAN encap tc-offload support. The userspace datapath, > > dpif-netdev, > > flow format differs than the kernel datapath in case of tu

Re: [ovs-dev] [PATCH v2] MAINTAINERS.rst: Move several people to emeritus status

2023-05-26 Thread William Tu
> > CC: Ian Stokes > > CC: Ilya Maximets > > CC: Jarno Rajahalme > > CC: Jesse Gross > > CC: Justin Pettit > > CC: Pravin B Shelar > > CC: Simon Horman > > CC: Thomas Graf > > CC: William Tu > > CC: YAMAMOTO Takashi > > ---

Re: [ovs-dev] [PATCH] datapath-windows: Detect CT timeout.

2022-05-31 Thread William Tu
On Tue, May 31, 2022 at 12:09 PM Ilya Maximets wrote: > > On 5/31/22 20:29, William Tu wrote: > > CT timeout is not supported in Windows datapath, but > > currently it incorrectly reports to ovs-vswitchd as supported blow > > "system@ovs-system: Datapath support

Re: [ovs-dev] [PATCH] datapath-windows: Detect truncate action.

2022-05-31 Thread William Tu
On Tue, May 31, 2022 at 12:06 PM Ilya Maximets wrote: > > On 5/31/22 20:27, William Tu wrote: > > Truncate action is not supported in Windows datapath, but > > currently it incorrectly reports to ovs-vswitchd as supported blow > > "system@ovs-system: Data

[ovs-dev] [PATCH] datapath-windows: Detect CT timeout.

2022-05-31 Thread William Tu
Signed-off-by: William Tu --- datapath-windows/ovsext/Conntrack.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/datapath-windows/ovsext/Conntrack.c b/datapath-windows/ovsext/Conntrack.c index 471bf961b..b33676cc1 100644 --- a/datapath-windows/ovsext/Conntrack.c +++ b/datapath-wind

[ovs-dev] [PATCH] datapath-windows: Detect truncate action.

2022-05-31 Thread William Tu
Truncate action is not supported in Windows datapath, but currently it incorrectly reports to ovs-vswitchd as supported blow "system@ovs-system: Datapath supports truncate action". The patches detects it and returns not support. Cc: Alin-Gabriel Serdean Cc: Wilson Peng Signed-off-by:

[ovs-dev] [PATCH v2] datapath-windows: Add ERSPAN v1 support.

2022-05-29 Thread William Tu
th ERSPAN tunnel type. 1. https://cloudbase.it/open-vswitch-2-5-hyper-v-gre-part-3/ A short demo using One Linux server and one Windows server: https://youtu.be/_01lWBRnrd4 Cc: Alin-Gabriel Serdean Signed-off-by: William Tu --- v2: fix tab and replaced with space Tested-at: https://g

[ovs-dev] [PATCH v2] datapath-windows: Fix GRE/VxLAN/STT Tunnel RX.

2022-05-29 Thread William Tu
ot;) Cc: Alin-Gabriel Serdean Signed-off-by: William Tu --- v2: talked to Wilson and add fixes to Vxlan.c and Stt.c --- datapath-windows/ovsext/Gre.c | 5 - datapath-windows/ovsext/Stt.c | 6 -- datapath-windows/ovsext/Vxlan.c | 5 - 3 files changed, 16 deletions(-) diff --git a/dat

[ovs-dev] [PATCH] datapath-windows: Add ERSPAN v1 support.

2022-05-28 Thread William Tu
th ERSPAN tunnel type. 1. https://cloudbase.it/open-vswitch-2-5-hyper-v-gre-part-3/ A short demo using One Linux server and one Windows server: https://youtu.be/_01lWBRnrd4 Cc: Alin-Gabriel Serdean Signed-off-by: William Tu --- Documentation/faq/releases.rst | 2

[ovs-dev] [PATCH] datapath-windows: Fix GRE tunnel.

2022-05-27 Thread William Tu
Alin-Gabriel Serdean Signed-off-by: William Tu --- datapath-windows/ovsext/Gre.c | 5 - 1 file changed, 5 deletions(-) diff --git a/datapath-windows/ovsext/Gre.c b/datapath-windows/ovsext/Gre.c index d87864029303..54725dd176c1 100644 --- a/datapath-windows/ovsext/Gre.c +++ b/datapath-windows

Re: [ovs-dev] [PATCH v2] daemon-unix: Close log file in monitor process while waiting on child.

2022-02-14 Thread William Tu
On Sat, Jan 29, 2022 at 11:38 AM Ben Pfaff wrote: > > Until now, the monitor process held its log file open while it waited for > the child to exit, and then it reopened it after the child exited. Holding > the log file open this way prevented log rotation from freeing disk space. > This commit

[ovs-dev] [PATCH] acinclude: Detect avx512 vpopcntdq compiler support.

2022-01-26 Thread William Tu
ml The patch detects vpopcntdq and disables AVX512 when not found. Reported-by: Greg Rose Signed-off-by: William Tu --- acinclude.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/acinclude.m4 b/acinclude.m4 index 5c971e98ce91..0c360fd1ef73 100644 --- a/acinclude.m4 +++ b/a

Re: [ovs-dev] [PATCH] daemon-unix: Close log file in monitor process while waiting on child.

2022-01-26 Thread William Tu
On Wed, Jan 26, 2022 at 8:56 AM Ben Pfaff wrote: > > Until now, the monitor process held its log file open while it waited for > the child to exit, and then it reopened it after the child exited. Holding > the log file open this way prevented log rotation from freeing disk space. > This commit

[ovs-dev] [PATCH RFC v2] netdev-dpdk: Add Windows support.

2021-11-05 Thread William Tu
.org/project/openvswitch/cover/20210808014931.320242-1-sergey.madami...@gmail.com/ [3] https://doc.dpdk.org/guides/windows_gsg/ [4] Porting OvS-DPDK to Windows with Meson https://github.com/smadaminov/ovs-dpdk-meson-issues [5] ebpf-for-windows: https://github.com/microsoft/ebpf-for-windows Signed-off-by: Willia

Re: [ovs-dev] [PATCH] RFC: netdev-dpdk: Add Windows support.

2021-11-04 Thread William Tu
On Thu, Nov 4, 2021 at 4:35 AM Thomas Monjalon wrote: > > 06/10/2021 19:00, William Tu: > > The patch adds OVS-DPDK supports on Windows. > [...] > > Implementation on Windows > > - > > It's harder than I thought due to my Linux only backgr

[ovs-dev] [PATCH] RFC: netdev-dpdk: Add Windows support.

2021-10-06 Thread William Tu
/project/openvswitch/cover/20210808014931.320242-1-sergey.madami...@gmail.com/ [3] https://doc.dpdk.org/guides/windows_gsg/ [4] Porting OvS-DPDK to Windows with Meson https://github.com/smadaminov/ovs-dpdk-meson-issues Signed-off-by: William Tu --- ovs/config.h.meson | 7 - ovs

Re: [ovs-dev] [PATCH ovn] MAINTAINERS: Transition myself to emeritus status.

2021-10-05 Thread William Tu
On Tue, Oct 5, 2021 at 8:05 PM William Tu wrote: > > On Tue, Oct 5, 2021 at 11:33 AM Numan Siddique wrote: > > > > On Tue, Oct 5, 2021 at 1:46 PM Han Zhou wrote: > > > > > > On Tue, Oct 5, 2021 at 9:39 AM Ben Pfaff wrote: > > > > > > >

Re: [ovs-dev] [PATCH ovn] MAINTAINERS: Transition myself to emeritus status.

2021-10-05 Thread William Tu
On Tue, Oct 5, 2021 at 11:33 AM Numan Siddique wrote: > > On Tue, Oct 5, 2021 at 1:46 PM Han Zhou wrote: > > > > On Tue, Oct 5, 2021 at 9:39 AM Ben Pfaff wrote: > > > > > > I have not been actively maintaining OVN for some time now. I don't > > expect > > > that to change. I think that the

Re: [ovs-dev] [PATCH] rhel: Fix dual kernel rpm install for RHEL 8.4

2021-09-03 Thread William Tu
On Wed, Aug 25, 2021 at 3:08 PM Gregory Rose wrote: > > > > On 8/25/2021 11:42 AM, Yifeng Sun wrote: > > LGTM, thanks Greg. > > > > Reviewed-by: Yifeng Sun > Thanks, I pushed to master. William ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH RFC 0/1] use meson and ninja as a build system for ovs

2021-08-13 Thread William Tu
> >>> Meson is a nice system in many aspects, but its support for tests is very > >>> limited. IIUC, it can only run a single binary and check the error codes. > >>> Most of our tests starts several daemons and performs several fairly > >>> complex > >>> operations and checks. I'm afraid that

Re: [ovs-dev] [PATCH RFC 0/1] use meson and ninja as a build system for ovs

2021-08-09 Thread William Tu
Hi Ilya, Thanks for your feedback! > Hi, Sergey and William. Thanks for working on this. > > I think that it might be a good idea to move to a different build system > that will not be that painful to run on Windows. I'm not working on > Windows parts, but it would be great to have a fast CI

Re: [ovs-dev] [PATCH v4] netlink: removed incorrect optimization

2021-06-15 Thread William Tu
On Tue, Jun 15, 2021 at 11:43 AM Ansis wrote: > > On Mon, Jun 14, 2021 at 10:22 PM Ansis wrote: > > > > On Mon, Jun 7, 2021 at 1:31 PM Toms Atteka wrote: > > > > > > This optimization caused FLOW_TNL_F_UDPIF flag not to be used in > > > hash calculation for geneve tunnel when revalidating flows

Re: [ovs-dev] [PATCH 2/5] odp-util: Fix use of uninitialized erspan metadata.

2021-04-05 Thread William Tu
read-2.28.so) > by 0x69ECF72: clone (in /usr/lib64/libc-2.28.so) > Uninitialised value was created by a stack allocation > at 0x4B1CE0: tun_key_to_attr (odp-util.c:3129) > > CC: William Tu > Fixes: 98514eea21f4 ("erspan: add kernel datapath support"

Re: [ovs-dev] [PATCH] RFC: netdev-afxdp: Support for XDP metadata HW hints.

2021-03-05 Thread William Tu
Thanks Björn and Jesper for feedbacks. On Fri, Mar 5, 2021 at 7:34 AM Björn Töpel wrote: > > On 2021-03-05 16:07, Jesper Dangaard Brouer wrote: > > On Fri, 5 Mar 2021 14:56:02 +0100 > > Björn Töpel wrote: > > > >> On 2021-03-05 11:13, Jesper Dangaard Brouer wrote: > > > [...] > >> > >> You'd

[ovs-dev] [PATCH] RFC: netdev-afxdp: Support for XDP metadata HW hints.

2021-03-04 Thread William Tu
-vswitchd[.] pmd_perf_start_iteration Signed-off-by: William Tu --- lib/netdev-afxdp.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/lib/netdev-afxdp.c b/lib/netdev-afxdp.c index 482400d8d135..49881a8cc0cb 100644 --- a/lib/netdev-afxdp.c +++ b/lib/netdev-afxdp.c @@ -169,

Re: [ovs-dev] [PATCH] tunnel:fix vlan bug for tunnel forwarding

2021-03-01 Thread William Tu
On Mon, Mar 1, 2021 at 3:47 AM Ilya Maximets wrote: > > On 1/10/21 3:16 AM, Hongzhi Guo wrote: > > From: hongzhi guo > > > > I found the basic vxlan topology cannot work when upgrade ovs 2.12 version. > > Through debugging, I found that when the native tunnel forward, > > the inner vlan was used

Re: [ovs-dev] [ovs-dev v2] ofproto: add refcount to ofproto to fix crash at ofproto_destroy

2021-02-27 Thread William Tu
Hi Hepeng, Thanks, now I understand. On Sat, Feb 27, 2021 at 12:54 AM 贺鹏 wrote: > > Hi, > > Thanks William and Ilya for a detailed revisiting of the origin of the > problem. I learned a lot. > > I now understand that the mix using of RCU and refcounts is not > intended in the first place. > But

Re: [ovs-dev] [PATCH v4 0/5] XDP offload using flow API provider

2021-02-25 Thread William Tu
On Thu, Feb 25, 2021 at 7:26 AM Toshiaki Makita wrote: > > On 2021/02/24 3:37, William Tu wrote: > >>>>> I don't know if this is too much to ask for. > >>>>> I wonder if you, or we can work together, to add at least a tunnel > >>>>&g

Re: [ovs-dev] [ovs-dev v2] ofproto: add refcount to ofproto to fix crash at ofproto_destroy

2021-02-25 Thread William Tu
On Thu, Feb 25, 2021 at 4:54 AM Ilya Maximets wrote: > > On 2/25/21 4:32 AM, Guohongzhi (Russell Lab) wrote: > > Refcount and RCU are not mutually exclusive. > > IMO, the main reason for this problem is that the rule uses both refcount > > and rcu, while the ofproto uses only rcu, and the rule

Re: [ovs-dev] [ovs-discuss] Do you know how I can set nd_options_type field for ipv6 ND message?

2021-02-24 Thread William Tu
On Tue, Feb 23, 2021 at 6:03 PM Yi Yang (杨燚)-云服务集团 wrote: > > Out of curious, I remember OVN doesn't support OVS DPDK, I believe OVN also > does IPv6 ND by openflow, is it acceptable to use slow path to handle IPv6 ND > for OVS kernel datapath? > Maybe OVN uses IPv6 ND, but not setting/matching

Re: [ovs-dev] [PATCH v1 6/9] conntrack: Do not schedule zero ms timers

2021-02-24 Thread William Tu
On Tue, Feb 23, 2021 at 4:35 PM Gaëtan Rivet wrote: > > On Tue, Feb 23, 2021, at 22:56, William Tu wrote: > > On Wed, Feb 17, 2021 at 8:34 AM Gaetan Rivet wrote: > > > > > > When ct_sweep() is far behind on its work, the 'next_wake' returned can > > >

Re: [ovs-dev] [PATCH v1 1/9] conntrack: Use rcu-lists to store conn expirations

2021-02-24 Thread William Tu
On Tue, Feb 23, 2021 at 4:34 PM Gaëtan Rivet wrote: > > > > On Tue, Feb 23, 2021, at 22:55, William Tu wrote: > > Hi Gaetan, > > > > Thanks for the patch, looks very useful. > > I haven't tested it yet. > > Minor question/comments inline

Re: [ovs-dev] [PATCH v1 9/9] conntrack: Use an atomic conn expiration value

2021-02-23 Thread William Tu
ng an atomic will ensure the same write consistency while > keeping the same (lack of) guarantee for reads. Reading the atomic will > however be less costly than taking and releasing the lock. > > Signed-off-by: Gaetan Rivet > Reviewed-by: Eli Br

Re: [ovs-dev] [PATCH v1 6/9] conntrack: Do not schedule zero ms timers

2021-02-23 Thread William Tu
On Wed, Feb 17, 2021 at 8:34 AM Gaetan Rivet wrote: > > When ct_sweep() is far behind on its work, the 'next_wake' returned can > be before the moment it started. When it happens, the thread schedules a > zero ms timer that is logged as an error. > > Instead, mark the thread for immediate wake in

Re: [ovs-dev] [PATCH v1 7/9] conntrack: Do not rate limit ct-sweep

2021-02-23 Thread William Tu
On Wed, Feb 17, 2021 at 8:34 AM Gaetan Rivet wrote: > > The current rate limit is set to allow other threads to update the > connections when applicable. This was valid when taking the 'ct_lock' > was needed with a global critical section. > > Now that the size of the critical section for

Re: [ovs-dev] [PATCH v1 8/9] conntrack: Do not log empty ct-sweep

2021-02-23 Thread William Tu
On Wed, Feb 17, 2021 at 8:34 AM Gaetan Rivet wrote: > > Do not add noise to the DBG log for empty sweeps. > Only log time taken when some connections were cleaned. > > Signed-off-by: Gaetan Rivet > Reviewed-by: Eli Britstein > --- LGTM Acked-by: William Tu > lib/con

Re: [ovs-dev] [PATCH v1 5/9] conntrack: Inverse conn and ct lock precedence

2021-02-23 Thread William Tu
On Wed, Feb 17, 2021 at 8:34 AM Gaetan Rivet wrote: > > The lock priority order is for the global 'ct_lock' to be taken first > and then 'conn->lock'. This is an issue, as multiple operations on > connections are thus blocked between threads contending on the > global 'ct_lock'. > > This was

Re: [ovs-dev] [PATCH v1 4/9] conntrack-tp: Use a cmap to store timeout policies

2021-02-23 Thread William Tu
). Using a CMAP reduces multiple lock taking and releasing in > the connection insertion path. > > Signed-off-by: Gaetan Rivet > Reviewed-by: Eli Britstein > --- Read through the patch and everything looks good to me Acked-by: William Tu

Re: [ovs-dev] [PATCH v1 2/9] conntrack: Use a cmap to store zone limits

2021-02-23 Thread William Tu
Thanks, I have one question inline. On Wed, Feb 17, 2021 at 8:34 AM Gaetan Rivet wrote: > > Change the data structure from hmap to cmap for zone limits. > As they are shared amongst multiple conntrack users, multiple > readers want to check the current zone limit state before progressing in >

Re: [ovs-dev] [PATCH v1 3/9] conntrack: Init hash basis first at creation

2021-02-23 Thread William Tu
module is affected, making the default policy being > referenced using an incorrect hash value. > > Fixes: 2078901a4c14 ("userspace: Add conntrack timeout policy support.") > Signed-off-by: Gaetan Rivet > Reviewed-by: Eli Britstein > --- LGTM, thanks for the fix. Acked-by: Wi

Re: [ovs-dev] [PATCH v1 1/9] conntrack: Use rcu-lists to store conn expirations

2021-02-23 Thread William Tu
Hi Gaetan, Thanks for the patch, looks very useful. I haven't tested it yet. Minor question/comments inline. On Wed, Feb 17, 2021 at 8:34 AM Gaetan Rivet wrote: > > Change the connection expiration lists from ovs_list to rculist. > This is a pre-step towards reducing the granularity of

Re: [ovs-dev] [PATCH v4 3/5] netdev-offload: Add xdp flow api provider

2021-02-23 Thread William Tu
> >>> + > >>> +return 0; > >>> +} > >>> +#endif > >>> + > >>> static int > >>> xsk_load_prog(struct netdev *netdev, const char *path, > >>> struct bpf_object **pobj, int *prog_fd) > >>> { > >>> +struct netdev_linux *dev OVS_UNUSED = netdev_linux_cast(netdev); > >>>

Re: [ovs-dev] [PATCH v4 0/5] XDP offload using flow API provider

2021-02-23 Thread William Tu
> >>> I don't know if this is too much to ask for. > >>> I wonder if you, or we can work together, to add at least a tunnel > >>> support, ex: vxlan? > >>> The current version is a good prototype for people to test an L2/L3 > >>> XDP offload switch, > >>> but without a good use case, it's hard to

Re: [ovs-dev] [ovs-discuss] Do you know how I can set nd_options_type field for ipv6 ND message?

2021-02-23 Thread William Tu
On Sun, Feb 21, 2021 at 9:39 PM Yi Yang (杨燚)-云服务集团 wrote: > > Thanks William, it is my ovs-ofctl issue, my ovs-vswitchd is new, but > ovs-ofctl is old, but after I used ovs-ofctl, I still saw issues: > > OFPT_ERROR (OF1.3) (xid=0x6): OFPBAC_BAD_SET_ARGUMENT > OFPT_FLOW_MOD (OF1.3) (xid=0x6): ADD

Re: [ovs-dev] [ovs-discuss] Do you know how I can set nd_options_type field for ipv6 ND message?

2021-02-21 Thread William Tu
On Sat, Feb 20, 2021 at 2:11 AM Yi Yang (杨燚)-云服务集团 wrote: > > Hi, folks > > > > I need to set nd_options_type to 2 for NS message to respond IPv6 NS, my flow > is below, why nd_options_type can’t be set? Per commit > 9b2b84973db76e1138d9234ff1b84bb6bb156011, it should work, what’s wrong? >

Re: [ovs-dev] [PATCHv2] connmgr: Check nullptr inside ofmonitor_report()

2021-02-21 Thread William Tu
On Fri, Feb 19, 2021 at 6:29 PM 贺鹏 wrote: > > Hi, Ilya > > Ilya Maximets 于2021年2月19日周五 下午7:19写道: > > > > On 2/19/21 3:12 AM, 贺鹏 wrote: > > > Hi, > > > > > > Looks like this bug is caused by violating the fact that if a rule is > > > referenced, the related ofproto should not be destroyed. > > >

Re: [ovs-dev] [PATCHv2] connmgr: Check nullptr inside ofmonitor_report()

2021-02-18 Thread William Tu
o was already deallocated: > > (gdb) print *ofproto > $1 = ..., name = 0x55d907602820 "nsx-managed", ..., ports = {..., > one = 0x0, mask = 63, n = 0}, ..., connmgr = 0x0, ... > > This patch fixes it. > > VMware-BZ: #2700626 > Signed-off-by: Yifeng Sun >

[ovs-dev] [PATCHv2] Documentation: Fix DPDK qos example.

2021-02-18 Thread William Tu
Fixes: e61bdffc2a98 ("netdev-dpdk: Add new DPDK RFC 4115 egress policer") Signed-off-by: William Tu --- Documentation/topics/dpdk/qos.rst | 14 -- vswitchd/vswitch.xml | 6 -- 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/Documentation/t

Re: [ovs-dev] [PATCH] Documentation: Fix DPDK qos example.

2021-02-18 Thread William Tu
On Thu, Feb 18, 2021 at 6:55 AM Eelco Chaudron wrote: > > > > On 18 Feb 2021, at 15:40, William Tu wrote: > > > On Thu, Feb 18, 2021 at 1:23 AM Eelco Chaudron > > wrote: > >> > >> > >> > >> On 17 Feb 2021, at 18:41, William Tu wrote:

Re: [ovs-dev] [PATCH] Documentation: Fix DPDK qos example.

2021-02-18 Thread William Tu
On Thu, Feb 18, 2021 at 1:23 AM Eelco Chaudron wrote: > > > > On 17 Feb 2021, at 18:41, William Tu wrote: > > >> > >>>> Information Rate). High priority traffic is routed to queue 10, > >>>> which marks > >>>>

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Fix ukey leak on udpif destroy.

2021-02-17 Thread William Tu
on exit by > > default.") > > Reported-by: Dumitru Ceara > > Signed-off-by: Ilya Maximets > > --- LGTM. LeakSanitizer is pretty useful. Acked-by: William Tu ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] Documentation: Fix DPDK qos example.

2021-02-17 Thread William Tu
> > >> Information Rate). High priority traffic is routed to queue 10, > >> which marks > >> all traffic as CIR, i.e. Green. All low priority traffic, queue 20, > >> is > >> marked as EIR, i.e. Yellow:: > >> > >> $ ovs-vsctl --timeout=5 set port dpdk1 qos=@myqos -- \ > >>

Re: [ovs-dev] [PATCH] Documentation: Fix DPDK qos example.

2021-02-17 Thread William Tu
On Wed, Feb 17, 2021 at 8:21 AM Eelco Chaudron wrote: > > > > On 17 Feb 2021, at 9:23, Eelco Chaudron wrote: > > > On 17 Feb 2021, at 4:39, William Tu wrote: > > > >> RFC4115 says "The CIR and EIR are both measured in bits/s." > >> Fix the

Re: [ovs-dev] [PATCH] connmgr: Check nullptr inside ofmonitor_report()

2021-02-16 Thread William Tu
On Tue, Feb 16, 2021 at 1:40 PM Yi-Hung Wei wrote: > > On Tue, Feb 16, 2021 at 1:06 PM Yifeng Sun wrote: > > > > ovs-vswitchd could crash under these circumstances: > > 1. When one bridge is being destroyed, ofproto_destroy() is called and > > connmgr pointer of its ofproto struct is nullified.

[ovs-dev] [PATCH] Documentation: Fix DPDK qos example.

2021-02-16 Thread William Tu
RFC4115 says "The CIR and EIR are both measured in bits/s." Fix the example use case based on the decription. 64-Byte packet * 8 * 1000 pps = 512000 Fixes: e61bdffc2a98 ("netdev-dpdk: Add new DPDK RFC 4115 egress policer") Signed-off-by: William Tu --- Documentation/topi

Re: [ovs-dev] [PATCH] ofp-actions: Fix use-after-free while decoding RAW_ENCAP.

2021-02-16 Thread William Tu
ressSanitizer enabled. > > Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=27851 > Fixes: f839892a206a ("OF support and translation of generic encap and decap") > Signed-off-by: Ilya Maximets LGTM. Acked-by: William Tu ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] conntrack: Add a test for IPv4 UDP zero checksum

2021-02-16 Thread William Tu
Hi Aaron, Should we also consider the case where udp checksum is 0x? I saw in netdev_tnl_calc_udp_csum, we set to 0x when a packet has udp checksum = 0. Thanks William On Wed, Feb 10, 2021 at 12:15 PM Flavio Leitner wrote: > > On Wed, Feb 10, 2021 at 02:45:06PM -0500, Aaron Conole

[ovs-dev] [PATCH] netdev-linux: Fix indentation.

2021-02-16 Thread William Tu
Remove one extra space. No actual code logic changed. Fixes: 2109841b79845 ("Use batch process recv for tap and raw socket in netdev datapath") Signed-off-by: William Tu --- lib/netdev-linux.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-)

Re: [ovs-dev] [PATCH] pcap-file: Fix calculation of TCP payload length in tcp_reader_run().

2021-02-16 Thread William Tu
I see, thanks. On Tue, Feb 16, 2021 at 12:52 PM Ben Pfaff wrote: > > On Fri, Feb 12, 2021 at 11:15:46AM -0800, William Tu wrote: > > I'm confused with what l2_pad_size is. > > I thought it's between L2 and L3 header, there is a 2-byte padding to > > make it 16-byte alignm

Re: [ovs-dev] [PATCH v4 0/5] XDP offload using flow API provider

2021-02-15 Thread William Tu
On Tue, Feb 9, 2021 at 1:39 AM Toshiaki Makita wrote: > > On 2021/02/05 2:36, William Tu wrote: > > Hi Toshiaki, > > > > Thanks for the patch. I've been testing it for a couple days. > > I liked it a lot! The compile and build process all work without any issues. &

Re: [ovs-dev] [PATCH] pcap-file: Fix calculation of TCP payload length in tcp_reader_run().

2021-02-12 Thread William Tu
On Tue, Feb 2, 2021 at 10:00 AM Ben Pfaff wrote: > > On Tue, Feb 02, 2021 at 05:11:09PM +0100, Ilya Maximets wrote: > > On 1/21/21 11:33 PM, Ben Pfaff wrote: > > > The calculation in tcp_reader_run() failed to account for L2 padding. > > > This fixes the problem, by moving the existing function >

[ovs-dev] [RFC PATCH] dp-packet-gso: Add GSO support.

2021-02-09 Thread William Tu
10.1.1.2 ip netns exec at_ns1 ethtool -K p1 tx off ip netns exec at_ns1 iperf -s ip netns exec at_ns0 iperf -c 10.1.1.2 -t1 Tested-at: https://github.com/williamtu/ovs-travis/actions/runs/553156643 Signed-off-by: William Tu --- lib/automake.mk |

Re: [ovs-dev] [PATCH] netdev-afxdp: Add start qid support.

2021-02-08 Thread William Tu
On Mon, Feb 8, 2021 at 4:58 AM Ilya Maximets wrote: > > On 2/7/21 5:05 PM, Toshiaki Makita wrote: > > On 2021/02/07 2:00, William Tu wrote: > >> On Fri, Feb 5, 2021 at 1:08 PM Gregory Rose wrote: > >>> On 2/4/2021 7:08 PM, William Tu wrote: > >>>

Re: [ovs-dev] 答复: 答复: [PATCH V3 2/4] Add GSO support for DPDK data path

2021-02-08 Thread William Tu
se to trigger that issue. > > > > -邮件原件- > > 发件人: William Tu [mailto:u9012...@gmail.com] > > 发送时间: 2021年2月7日 23:46 > > 收件人: Yi Yang (杨燚)-云服务集团 > > 抄送: i.maxim...@ovn.org; yang_y...@163.com; ovs-dev@openvswitch.org; > > f...@sysclose.org > >

Re: [ovs-dev] 答复: 答复: [PATCH] netdev-dpdk: fix incorrect shinfo initialization

2021-02-08 Thread William Tu
On Mon, Feb 8, 2021 at 8:57 AM Ilya Maximets wrote: > > On 2/6/21 5:15 PM, William Tu wrote: > > On Mon, Feb 1, 2021 at 5:48 PM Yi Yang (杨燚)-云服务集团 > > wrote: > >> > >> Thanks Ilya, net_tap PMD is handling tap device on host side, so it can > >> leve

Re: [ovs-dev] 答复: [PATCH V3 2/4] Add GSO support for DPDK data path

2021-02-07 Thread William Tu
On Tue, Oct 27, 2020 at 6:02 PM Yi Yang (杨燚)-云服务集团 wrote: > > -邮件原件- > 发件人: dev [mailto:ovs-dev-boun...@openvswitch.org] 代表 Ilya Maximets > 发送时间: 2020年10月27日 21:03 > 收件人: yang_y...@163.com; ovs-dev@openvswitch.org > 抄送: f...@sysclose.org; i.maxim...@ovn.org > 主题: Re: [ovs-dev] [PATCH V3

Re: [ovs-dev] [PATCH] netdev-afxdp: Add start qid support.

2021-02-06 Thread William Tu
On Fri, Feb 5, 2021 at 1:08 PM Gregory Rose wrote: > > > > On 2/4/2021 7:08 PM, William Tu wrote: > > On Thu, Feb 4, 2021 at 3:17 PM Gregory Rose wrote: > >> > >> > >> > >> On 2/3/2021 1:21 PM, William Tu wrote: > >>> M

Re: [ovs-dev] 答复: 答复: [PATCH] netdev-dpdk: fix incorrect shinfo initialization

2021-02-06 Thread William Tu
On Mon, Feb 1, 2021 at 5:48 PM Yi Yang (杨燚)-云服务集团 wrote: > > Thanks Ilya, net_tap PMD is handling tap device on host side, so it can > leverage vnet header to do TSO/GSO, maybe net_pmd authors don't know how to > do this, from source code, tap fd isn't enabled vnet header and TSO. > thanks,

Re: [ovs-dev] 答复: [PATCH V3 3/4] Add VXLAN TCP and UDP GRO support for DPDK data path

2021-02-06 Thread William Tu
On Tue, Oct 27, 2020 at 5:50 PM Yi Yang (杨燚)-云服务集团 wrote: > > -邮件原件- > 发件人: dev [mailto:ovs-dev-boun...@openvswitch.org] 代表 Ilya Maximets > 发送时间: 2020年10月27日 21:12 > 收件人: yang_y...@163.com; ovs-dev@openvswitch.org > 抄送: f...@sysclose.org; i.maxim...@ovn.org > 主题: Re: [ovs-dev] [PATCH V3

Re: [ovs-dev] [PATCH] netdev-afxdp: Add start qid support.

2021-02-04 Thread William Tu
On Thu, Feb 4, 2021 at 3:17 PM Gregory Rose wrote: > > > > On 2/3/2021 1:21 PM, William Tu wrote: > > Mellanox card has different XSK design. It requires users to create > > dedicated queues for XSK. Unlike Intel's NIC which loads XDP program > > to all queues, M

Re: [ovs-dev] [PATCH v4 3/5] netdev-offload: Add xdp flow api provider

2021-02-04 Thread William Tu
On Thu, Feb 4, 2021 at 5:15 PM William Tu wrote: > > Hi Toshiaki, > > Thanks for the patch. I have some questions inline. > > On Thu, Jul 30, 2020 at 7:55 PM Toshiaki Makita > wrote: > > > > This provider offloads classifier to software XDP. > > >

Re: [ovs-dev] [PATCH v4 3/5] netdev-offload: Add xdp flow api provider

2021-02-04 Thread William Tu
Hi Toshiaki, Thanks for the patch. I have some questions inline. On Thu, Jul 30, 2020 at 7:55 PM Toshiaki Makita wrote: > > This provider offloads classifier to software XDP. > > It works only when a custom XDP object is loaded by afxdp netdev. > The BPF program needs to implement classifier

Re: [ovs-dev] [PATCH v4 2/5] netdev-offload: Add "offload-driver" other_config to specify offload driver

2021-02-04 Thread William Tu
On Thu, Jul 30, 2020 at 7:55 PM Toshiaki Makita wrote: > > The following commit will introduce another offload driver using XDP. > When using afxdp netdev, both of TC and XDP will be supported, so let's > add an other_config to specify which offload driver is preferable. > When not specified and

Re: [ovs-dev] [PATCH v4 1/5] netdev-afxdp: Enable loading XDP program.

2021-02-04 Thread William Tu
On Thu, Jul 30, 2020 at 7:55 PM Toshiaki Makita wrote: > > From: William Tu > > Now netdev-afxdp always forwards all packets to userspace because > it is using libbpf's default XDP program, see 'xsk_load_xdp_prog'. > There are some cases when users want to keep packets

Re: [ovs-dev] [PATCH] netdev-natvie-tnl: Fix geneve tunnel flag

2021-02-04 Thread William Tu
On Thu, Feb 4, 2021 at 10:08 AM Cpp Code wrote: > > The patch is ready, I am writing a test for this. Maybe it was worth checking > this in and adding test later!? > I'd suggest having a test case together with the patch, since this isn't a trivial issue. William

Re: [ovs-dev] [PATCH v4 0/5] XDP offload using flow API provider

2021-02-04 Thread William Tu
Hi Toshiaki, Thanks for the patch. I've been testing it for a couple days. I liked it a lot! The compile and build process all work without any issues. On Thu, Jul 30, 2020 at 7:55 PM Toshiaki Makita wrote: > > This patch adds an XDP-based flow cache using the OVS netdev-offload > flow API

Re: [ovs-dev] [PATCH v2] rhel: Add option to enable AF_XDP on rpm package

2021-02-04 Thread William Tu
On Wed, Feb 3, 2021 at 4:33 PM Yi-Hung Wei wrote: > > This patch adds an RPMBUILD_OPT so that user can enable > AF_XDP support in the rpm package by: > > $ make rpm-fedora RPMBUILD_OPT="--with afxdp" > > Signed-off-by: Yi-Hung Wei &

[ovs-dev] [PATCH] netdev-afxdp: Add start qid support.

2021-02-03 Thread William Tu
additionally add flow-redirect rule to queue 1 Tested-at: https://github.com/williamtu/ovs-travis/actions/runs/535141041 Signed-off-by: William Tu --- Documentation/intro/install/afxdp.rst | 2 ++ lib/netdev-afxdp.c| 23 ++- lib/netdev-linux-private.h

[ovs-dev] [RFC PATCH] userspace: Enable tunnel with TSO.

2021-02-03 Thread William Tu
nel, the TCP sender sending huge packet size will fail. I have to segment the inner TCP packet before pushing the outer tunnel header. Signed-off-by: William Tu --- lib/netdev-linux.c | 2 +- lib/netdev-native-tnl.c | 11 ++- lib/netdev.c| 18

Re: [ovs-dev] [PATCH] netdev-natvie-tnl: Fix geneve tunnel flag

2020-12-15 Thread William Tu
fdd52a86..09cff3a1fc7d 100644 > --- a/lib/netdev-native-tnl.c > +++ b/lib/netdev-native-tnl.c > @@ -1015,9 +1015,11 @@ netdev_geneve_pop_header(struct dp_packet *packet) > tnl->tun_id = htonll(ntohl(get_16aligned_be32(>vni)) >> 8); >

Re: [ovs-dev] [PATCH v2] bugtool: Fix for Python3

2020-11-05 Thread William Tu
On Thu, Nov 5, 2020 at 4:48 AM Ilya Maximets wrote: > > On 4/10/20 12:03 AM, William Tu wrote: > > On Wed, Mar 25, 2020 at 05:33:51PM -0700, William Tu wrote: > >> On Thu, Mar 19, 2020 at 12:20:19PM -0700, William Tu wrote: > >>> On Thu, Mar 19, 2020 at 12:05

[ovs-dev] [PATCH] ovs-bugtool: Fix crash when enable --ovs.

2020-11-04 Thread William Tu
imeError: dictionary changed size during iteration The patch fixes it by making a copy of the key and value. VMware-BZ: #2663359 Signed-off-by: William Tu --- utilities/bugtool/ovs-bugtool.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/utilities/bugtool/ovs-bugtool.in b/u

Re: [ovs-dev] [PATCH] dpif-netdev: Add miniflow bits to dump-flows.

2020-10-21 Thread William Tu
On Wed, Oct 21, 2020 at 8:47 AM Stokes, Ian wrote: > > > On 6/8/20 5:36 PM, William Tu wrote: > > > On Mon, Jun 8, 2020 at 7:01 AM Ilya Maximets wrote: > > >> > > >> On 5/14/20 4:11 PM, William Tu wrote: > > >>> The 'dpctl/dump-flows -m' o

Re: [ovs-dev] [PATCH branch-2.13 0/2] Release patches for v2.13.1.

2020-08-04 Thread William Tu
On Tue, Aug 4, 2020 at 7:24 AM Ilya Maximets wrote: > > On 8/4/20 3:19 PM, William Tu wrote: > > On Mon, Aug 3, 2020 at 2:23 PM Ilya Maximets wrote: > >> > >> On 7/30/20 12:44 AM, Ilya Maximets wrote: > >>> > >>> Ilya Maximets (2): > >

Re: [ovs-dev] [PATCH branch-2.13 0/2] Release patches for v2.13.1.

2020-08-04 Thread William Tu
On Mon, Aug 3, 2020 at 2:23 PM Ilya Maximets wrote: > > On 7/30/20 12:44 AM, Ilya Maximets wrote: > > > > Ilya Maximets (2): > > Set release date for 2.13.1. > > Prepare for 2.13.2. > > > > NEWS | 14 +- > > configure.ac | 2 +- > > debian/changelog | 8 +++-

Re: [ovs-dev] [PATCH branch-2.5 2/2] Prepare for 2.5.11.

2020-08-04 Thread William Tu
On Wed, Jul 29, 2020 at 3:42 PM Ilya Maximets wrote: > > Signed-off-by: Ilya Maximets > --- LGTM, Acked-by: William Tu ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-2.5 1/2] Set release date for 2.5.10.

2020-08-04 Thread William Tu
On Wed, Jul 29, 2020 at 3:42 PM Ilya Maximets wrote: > > Signed-off-by: Ilya Maximets > --- LGTM, Acked-by: William Tu ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-2.6 2/2] Prepare for 2.6.9.

2020-08-04 Thread William Tu
On Wed, Jul 29, 2020 at 3:43 PM Ilya Maximets wrote: > > Signed-off-by: Ilya Maximets > --- LGTM, Acked-by: William Tu ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-2.6 1/2] Set release date for 2.6.8.

2020-08-04 Thread William Tu
On Wed, Jul 29, 2020 at 3:43 PM Ilya Maximets wrote: > > Signed-off-by: Ilya Maximets > --- LGTM, Acked-by: William Tu ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-2.7 2/2] Prepare for 2.7.12.

2020-08-04 Thread William Tu
On Wed, Jul 29, 2020 at 3:43 PM Ilya Maximets wrote: > > Signed-off-by: Ilya Maximets > --- LGTM, Acked-by: William Tu ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-2.7 1/2] Set release date for 2.7.11.

2020-08-04 Thread William Tu
On Wed, Jul 29, 2020 at 3:43 PM Ilya Maximets wrote: > > Signed-off-by: Ilya Maximets > --- LGTM, Acked-by: William Tu ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-2.8 2/2] Prepare for 2.8.10.

2020-08-04 Thread William Tu
On Wed, Jul 29, 2020 at 3:44 PM Ilya Maximets wrote: > > Signed-off-by: Ilya Maximets > --- LGTM, Acked-by: William Tu ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-2.8 1/2] Set release date for 2.8.9.

2020-08-04 Thread William Tu
On Wed, Jul 29, 2020 at 3:43 PM Ilya Maximets wrote: > > Signed-off-by: Ilya Maximets > --- LGTM, Acked-by: William Tu ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-2.9 2/2] Prepare for 2.9.8.

2020-08-04 Thread William Tu
On Wed, Jul 29, 2020 at 3:44 PM Ilya Maximets wrote: > > Signed-off-by: Ilya Maximets > --- LGTM, Acked-by: William Tu ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-2.9 1/2] Set release date for 2.9.7.

2020-08-04 Thread William Tu
On Wed, Jul 29, 2020 at 3:43 PM Ilya Maximets wrote: > > Signed-off-by: Ilya Maximets > --- LGTM, Acked-by: William Tu ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-2.10 2/2] Prepare for 2.10.6.

2020-08-04 Thread William Tu
On Wed, Jul 29, 2020 at 3:44 PM Ilya Maximets wrote: > > Signed-off-by: Ilya Maximets > --- LGTM, Acked-by: William Tu ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

  1   2   3   4   5   6   7   8   9   10   >