From: Lin Huang
Coverity reports a false positive below:
Ofproto_class_find__() may return NULL, and dereference it to cause segfault.
This patch is made just to avoid false-positive Coverity report.
Tested-by: Zhang YuHuang
Signed-off-by: Lin Huang
---
ofproto/ofproto.c | 2 +-
1 file
From: miter
ofproto: Fix NULL deref reported by Coverity.
Lin Huang (1):
ofproto: Fix NULL deref reported by Coverity.
ofproto/ofproto.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.39.3
___
dev mailing list
d...@openvswitch.org
From: miter
Ofproto_class_find__() may return NULL, and dereference it to cause
segfault.
Tested-by: Zhang YuHuang
Signed-off-by: Lin Huang
---
ofproto/ofproto.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
index
From: Lin Huang
OvS has supported packet-per-second policer which can be set at ingress
and egress side in kernel datapath. But the userspace datapath dosen't
support for ingress and egress packet-per-second policing now.
So, this patch add support for userspace ingress pps policing by using
From: Lin Huang
Now, token-bucket 'last_fill' is updated by token_bucket_withdraw() itself.
Add a new function parameter 'now' to update timestamp by caller.
Signed-off-by: Lin Huang
---
include/openvswitch/token-bucket.h | 3 ++-
lib/token-bucket.c | 4 ++--
lib/vlog.c
From: Lin Huang
OvS has supported packet-per-second policer which can be set at ingress
and egress side in kernel datapath. But the userspace datapath doesn't
support for ingress and egress packet-per-second policing now.
So, this patch add support for userspace egress pps policing by using
From: Lin Huang
Currently srtcm_policer free packet one by one, if packets are exceed rate
limit.
That is a inefficient way to free memory which we have to call
rte_pktmbuf_free()
pkt_cnt times.
To improve this, we can use rte_pktmbuf_free_bulk() function to free arrays of
mbufs instead of
From: Lin Huang
v9->v10: fix code by reviewing.
v8->v9: fix qos.rst:40:Title underline too short.
v7->v8: fix cody by reviewing.
v6->v7: split pps and bps policer.
v5->v6: fix code by reviewing.
v5->v4: police pkts bps and pps at the same time.
Get the maximum from the number of
From: Lin Huang
OvS has supported packet-per-second policer which can be set at ingress
and egress side in kernel datapath. But the userspace datapath doesn't
support for ingress and egress packet-per-second policing now.
So, this patch add support for userspace egress pps policing by using
From: Lin Huang
Now, token-bucket 'last_fill' is updated by token_bucket_withdraw() itself.
Add a new function parameter 'now' to update timestamp by caller.
Signed-off-by: Lin Huang
---
include/openvswitch/token-bucket.h | 3 ++-
lib/token-bucket.c | 4 ++--
lib/vlog.c
From: Lin Huang
OvS has supported packet-per-second policer which can be set at ingress
and egress side in kernel datapath. But the userspace datapath dosen't
support for ingress and egress packet-per-second policing now.
So, this patch add support for userspace ingress pps policing by using
From: Lin Huang
v8->v9: fix qos.rst:40:Title underline too short.
v7->v8: fix cody by reviewing.
v6->v7: split pps and bps policer.
v5->v6: fix code by reviewing.
v5->v4: police pkts bps and pps at the same time.
Get the maximum from the number of dropped packets, and drop that.
From: Lin Huang
Currently srtcm_policer free packet one by one, if packets are exceed rate
limit.
This patch change srtcm_policer to free pkts by bulk using
rte_pktmbuf_free_bulk().
Signed-off-by: Lin Huang
---
lib/netdev-dpdk.c | 11 +++
1 file changed, 7 insertions(+), 4
From: Lin Huang
OvS has supported packet-per-second policer which can be set at ingress
and egress side in kernel datapath. But the userspace datapath dosen't
support for ingress and egress packet-per-second policing now.
So, this patch add support for userspace ingress pps policing by using
From: Lin Huang
OvS has supported packet-per-second policer which can be set at ingress
and egress side in kernel datapath. But the userspace datapath doesn't
support for ingress and egress packet-per-second policing now.
So, this patch add support for userspace egress pps policing by using
From: Lin Huang
Currently srtcm_policer free packet one by one, if packets are exceed rate
limit.
This patch change srtcm_policer to free pkts by bulk using
rte_pktmbuf_free_bulk().
Signed-off-by: Lin Huang
---
lib/netdev-dpdk.c | 11 +++
1 file changed, 7 insertions(+), 4
From: Lin Huang
Now, token-bucket 'last_fill' is updated by token_bucket_withdraw() itself.
Add a new function parameter 'now' to update timestamp by caller.
Signed-off-by: Lin Huang
---
include/openvswitch/token-bucket.h | 3 ++-
lib/token-bucket.c | 4 ++--
lib/vlog.c
From: Lin Huang
v7->v8: fix cody by reviewing.
v6->v7: split pps and bps policer.
v5->v6: fix code by reviewing.
v5->v4: police pkts bps and pps at the same time.
Get the maximum from the number of dropped packets, and drop that.
v4->v3: rewrite egress_policer_details_to_param func.
From: Lin Huang
OvS has supported packet-per-second policer which can be set at ingress
and egress side in kernel datapath. But the userspace datapath dosen't
support for ingress and egress packet-per-second policing now.
So, this patch add support for userspace ingress pps policing by using
From: Lin Huang
Currently srtcm_policer free packet one by one, if packets are exceed rate
limit.
This patch change srtcm_policer to free pkts by bulk using
rte_pktmbuf_free_bulk().
Signed-off-by: Lin Huang
---
lib/netdev-dpdk.c | 11 +++
1 file changed, 7 insertions(+), 4
From: Lin Huang
OvS has supported packet-per-second policer which can be set at ingress
and egress side in kernel datapath. But the userspace datapath doesn't
support for ingress and egress packet-per-second policing now.
So, this patch add support for userspace egress pps policing by using
From: Lin Huang
Now, token-bucket 'last_fill' is updated by token_bucket_withdraw() itself.
Add a new function parameter 'now' to update timestamp by caller.
Signed-off-by: Lin Huang
---
include/openvswitch/token-bucket.h | 3 ++-
lib/token-bucket.c | 4 ++--
lib/vlog.c
From: Lin Huang
v6->v7: split pps and bps policer.
v5->v6: fix code by reviewing.
v5->v4: police pkts bps and pps at the same time.
Get the maximum from the number of dropped packets, and drop that.
v4->v3: rewrite egress_policer_details_to_param func.
add a new
From: Lin Huang
OvS has supported packet-per-second policer which can be set at ingress
and egress side in kernel datapath. But the userspace datapath dosen't
support for ingress and egress packet-per-second policing now.
So, this patch add support for userspace ingress pps policing by using
From: Lin Huang
OvS has supported packet-per-second policer which can be set at ingress
and egress side in kernel datapath. But the userspace datapath doesn't
support for ingress and egress packet-per-second policing now.
So, this patch add support for userspace egress pps policing by using
From: Lin Huang
Now srtcm_policer will free pkts, if packets are exceed rate limit.
This patch change srtcm_policer not to free pkts, just count dropped packets.
Signed-off-by: Lin Huang
---
lib/netdev-dpdk.c | 30 +++---
1 file changed, 15 insertions(+), 15
From: Lin Huang
Now, token-bucket 'last_fill' is updated by token_bucket_withdraw() itself.
Add a new function parameter 'now' to update timestamp by caller.
Signed-off-by: Lin Huang
---
include/openvswitch/token-bucket.h | 3 ++-
lib/token-bucket.c | 4 ++--
lib/vlog.c
From: Lin Huang
v5->v6: fix code by reviewing.
v5->v4: police pkts bps and pps at the same time.
Get the maximum from the number of dropped packets, and drop that.
v4->v3: rewrite egress_policer_details_to_param func.
add a new pkts_policer_profile_config func.
v2->v3: police
From: Lin Huang
OvS has supported packet-per-second policer which can be set at ingress
and egress side in kernel datapath. But the userspace datapath dosen't
support for ingress and egress packet-per-second policing now.
So, this patch add support for userspace ingress pps policing by using
From: Lin Huang
Now, token-bucket 'last_fill' is updated by token_bucket_withdraw() itself.
Add a new function parameter 'now' to update timestamp by caller.
Signed-off-by: Lin Huang
---
include/openvswitch/token-bucket.h | 3 ++-
lib/token-bucket.c | 4 ++--
lib/vlog.c
From: Lin Huang
OvS has supported packet-per-second policer which can be set at ingress
and egress side in kernel datapath. But the userspace datapath doesn't
support for ingress and egress packet-per-second policing now.
So, this patch add support for userspace egress pps policing by using
From: Lin Huang
Now srtcm_policer will free pkts, if packets are exceed rate limit.
This patch change srtcm_policer not to free pkts, just count dropped packets.
Signed-off-by: Lin Huang
---
lib/netdev-dpdk.c | 21 +++--
1 file changed, 7 insertions(+), 14 deletions(-)
diff
From: Lin Huang
v5->v4: police pkts bps and pps at the same time.
Get the maximum from the number of dropped packets, and drop that.
v4->v3: rewrite egress_policer_details_to_param func.
add a new pkts_policer_profile_config func.
v2->v3: police and free pkts by bulk.
From: Lin Huang
Currently, a meter's timestamp 'now' is set by 'pmd->ctx.now' which updated
by pmd_thread_ctx_time_update().
Before processing of the new packet batch:
- dpif_netdev_execute()
- dp_netdev_process_rxq_port()
There is a problem when user want to police the rate to a low pps by
From: Lin Huang
OvS has supported packet-per-second policer which can be set at ingress
and egress side in kernel datapath. But the userspace datapath dosen't
support for ingress and egress packet-per-second policing now.
So, this patch add support for userspace ingress pps policing by using
From: Lin Huang
v4->v3: rewrite egress_policer_details_to_param func.
add a new pkts_policer_profile_config func.
v2->v3: police and free pkts by bulk.
fix the appropriate error code.
v1->v2: delete duplicated code.
Lin Huang (2):
netdev-dpdk: Add support for egress
From: Lin Huang
OvS has supported packet-per-second policer which can be set at ingress
and egress side in kernel datapath. But the userspace datapath doesn't
support for ingress and egress packet-per-second policing now.
So, this patch add support for userspace egress pps policing by using
From: Lin Huang
OvS has supported packet-per-second policer which can be set at ingress
and egress side in kernel datapath. But the userspace datapath dosen't
support for ingress and egress packet-per-second policing now.
So, this patch add support for userspace ingress pps policing by using
From: Lin Huang
OvS has supported packet-per-second policer which can be set at ingress
and egress side in kernel datapath. But the userspace datapath dosen't
support for ingress and egress packet-per-second policing now.
So, this patch add support for userspace egress pps policing by using
From: Lin Huang
v2->v3: police and free pkts by bulk.
fix the appropriate error code.
v1->v2: delete duplicated code.
Lin Huang (2):
netdev-dpdk: Add support for userspace port-based egress
packet-per-second policing.
netdev-dpdk: Add support for userspace port-based ingress
From: Lin Huang
OvS has supported packet-per-second policer which can be set at ingress and
egress
side in kernel datapath. But the userspace datapath dosen't support for ingress
and
egress packet-per-second policing now.
So, this patch add support for userspace egress pps policing by using
From: Lin Huang
OvS has supported packet-per-second policer which can be set at ingress and
egress
side in kernel datapath. But the userspace datapath dosen't support for ingress
and
egress packet-per-second policing now.
So, this patch add support for userspace ingress pps policing by using
From: Lin Huang
v1->v2: delete duplicated code.
Lin Huang (2):
* netdev-dpdk: Add support for userspace port-based egress
packet-per-second policing.
* netdev-dpdk: Add support for userspace port-based ingress
packet-per-second policing.
NEWS | 11 ++
From: Lin Huang
add netdev-dpdk ingress pkts policer.
Signed-off-by: Lin Huang
---
lib/netdev-dpdk.c | 115 --
1 file changed, 111 insertions(+), 4 deletions(-)
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index 6709c459c..b645b3907 100644
From: Lin Huang
add netdev-dpdk egress pkts policer.
Signed-off-by: Lin Huang
---
lib/netdev-dpdk.c| 118 +++
vswitchd/vswitch.xml | 32
2 files changed, 150 insertions(+)
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index
From: Lin Huang
This series patch set adds ingress and egress pkts policer support for
netdev-dpdk
device.
Lin Huang (2):
netdev-dpdk: add netdev-dpdk egress pkts policer.
netdev-dpdk: add netdev-dpdk ingress pkts policer.
lib/netdev-dpdk.c| 233
From: Lin Huang
Declaration of 'struct conn' will not be visible outside of this function.
Declaration of 'struct conntrack' will not be visible outside of this function.
Declaration of 'struct timeout_policy' will not be visible outside of this
function.
---
lib/conntrack-tp.h | 7 +++
1
From: Lin Huang
Declaration of 'struct conn' will not be visible outside of this function.
Declaration of 'struct conntrack' will not be visible outside of this function.
Declaration of 'struct timeout_policy' will not be visible outside of this
function.
Signed-off-by: Lin Huang
---
From: Lin Huang
After user add a static fdb entry, the get_lru() function will always return
the static fdb entry. That's normal fdb entries will not age out through
mac_learning_run().
Fix the issue by modify the get_lru() function to check the entry->expires
field and
not return the entry
From: Lin Huang
Changes since v1:
1. Revised according to the suggestions and comments of the reviewers
Lin Huang (1):
mac-learning: Fix learned fdb entries not age out issue.
lib/mac-learning.c| 37 ++---
tests/ofproto-dpif.at | 23
From: Lin Huang
After user add a static fdb entry, the get_lru() function will always return
the static fdb entry. That's normal fdb entries will not age out through
mac_learning_run().
Fix the issue by modify the get_lru() function to check the entry->expires
field and
not return the entry
From: Lin Huang
Currently the ovs-tcpdump utility creates a tap port to capture the
frames of a bond port.
If a user want to capture the packets from the bond port which member
interface's mtu is more than 1500. By default the utility creates a
tap port which mtu is 1500, regardless the member
From: Lin Huang
Currently the ovs-tcpdump utility creates a tap port to capture the
frames of a bond port.
If a user want to capture the packets from the bond port which member
interface's mtu is more than 1500. By default the utility creates a
tap port which mtu is 1500, regardless the member
From: Lin Huang
After user add a static fdb entry, the get_lru() function will always return the
static fdb entry. That's normal fdb entries will not age out through
mac_learning_run().
Fix the issue by modify the get_lru() function to check the entry->expires
field and
not return the entry
From: Lin Huang
Currently the pmd-auto-lb-rebal-interval's value was not been
checked properly.
It maybe a negative, or too big value (>2 weeks between rebalances),
which will be lead to a big unsigned value. So reset it to default
if the value exceeds the max permitted as described in
From: Lin Huang
The ALB parameters should never be negative.
So it's to use unsigned smap_get versions to get it properly, and
update VLOG formatting.
Fixes: 5bf84282482a ("Adding support for PMD auto load balancing")
Signed-off-by: Lin Huang
---
lib/dpif-netdev.c | 23 ---
From: Lin Huang
This series fix ALB parameters type mismatch and set a hard limit
to rebalance_intvl.
It also includes some self-tests.
Changes since v3:
1. Fix CI warnings
Changes since v2:
1. Fix type mismatch int dpif-netdev.c.
Changes since v1:
1. Fix the commit message and
From: Lin Huang
Fix comment typo.
Signed-off-by: Lin Huang
---
lib/ofp-msgs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/ofp-msgs.c b/lib/ofp-msgs.c
index 93aa81297..fdb898064 100644
--- a/lib/ofp-msgs.c
+++ b/lib/ofp-msgs.c
@@ -148,7 +148,7 @@ struct raw_instance
From: Lin Huang
The ALB parameters should never be negative.
So it's to use smap_get_ulonglong() or smap_get_uint() to get it properly.
Fixes: 5bf84282482a ("Adding support for PMD auto load balancing")
Signed-off-by: Lin Huang
---
lib/dpif-netdev.c | 15 ---
1 file changed, 8
From: Lin Huang
Currently the pmd-auto-lb-rebal-interval's value was not been
checked properly.
It maybe a negative, or too big value (>2 weeks between rebalances),
which will be lead to a big unsigned value. So reset it to default
if the value exceeds the max permitted as described in
From: Lin Huang
This series fix ALB parameters type mismatch and set a hard limit
to rebalance_intvl.
It also includes some self-tests.
Changes since v3:
1. Fix CI warnings
Changes since v2:
1. Fix type mismatch int dpif-netdev.c.
Changes since v1:
1. Fix the commit message and
From: linhuang
Currently the pmd-auto-lb-rebal-interval's value was not been
checked properly.
It maybe a negative, or too big value (>2 weeks between rebalances),
which will be lead to a big unsigned value. So reset it to default
if the value exceeds the max permitted as described in
From: linhuang
The ALB parameters should never be negative.
So it's to use unsigned smap_get versions to get it properly, and
update VLOG formatting.
Fixes: 5bf84282482a ("Adding support for PMD auto load balancing")
Signed-off-by: Lin Huang
---
lib/dpif-netdev.c | 22 +++---
From: Lin Huang
This series fix ALB parameters type mismatch and set a hard limit
to rebalance_intvl.
It also includes some self-tests.
Changes since v2:
1. Fix type mismatch int dpif-netdev.c.
Changes since v1:
1. Fix the commit message and formatting.
2. Fix typo in unit tests.
Lin
From: linhuang
Currently the pmd-auto-lb-rebal-interval's value was not been
checked properly.
It maybe a negative, or too big value (>2 weeks between rebalances),
which will be lead to a big unsigned value. So reset it to default
if the value exceeds the max permitted as described in
From: linhuang
The ALB parameters should never be negative.
So it's to use unsigned smap_get versions to get it properly.
Fixes: 5bf84282482a ("Adding support for PMD auto load balancing")
Signed-off-by: Lin Huang
---
lib/dpif-netdev.c | 14 +++---
1 file changed, 7 insertions(+), 7
From: Lin Huang
Changes since v1:
1. Fix the commit message and formatting.
2. Fix typo in unit tests.
Lin Huang (2):
dpif-netdev: Fix ALB parameters type mismatch.
dpif-netdev: Fix ALB 'rebalance_intvl' max hard limit.
lib/dpif-netdev.c | 20
tests/alb.at |
67 matches
Mail list logo
