[ovs-dev] [PATCH net-next v2] net: openvswitch: Be liberal in tcp conntrack.

2020-11-16 Thread nusiddiq
From: Numan Siddique There is no easy way to distinguish if a conntracked tcp packet is marked invalid because of tcp_in_window() check error or because it doesn't belong to an existing connection. With this patch, openvswitch sets liberal tcp flag for the established sessions so that out of

[ovs-dev] [net-next] netfiler: conntrack: Add the option to set ct tcp flag - BE_LIBERAL per-ct basis.

2020-11-08 Thread nusiddiq
From: Numan Siddique Before calling nf_conntrack_in(), caller can set this flag in the connection template for a tcp packet and any errors in the tcp_in_window() will be ignored. A helper function - nf_ct_set_tcp_be_liberal(nf_conn) is added which sets this flag for both the directions of the

[ovs-dev] [PATCH net-next] net: openvswitch: Add support to lookup invalid packet in ct action.

2020-10-06 Thread nusiddiq
From: Numan Siddique For a tcp packet which is part of an existing committed connection, nf_conntrack_in() will return err and set skb->_nfct to NULL if it is out of tcp window. ct action for this packet will set the ct_state to +inv which is as expected. But a controller cannot add an OVS flow

[ovs-dev] [RFC net-next] net: openvswitch: Add support to lookup invalid packet in ct action.

2020-10-02 Thread nusiddiq
From: Numan Siddique For a tcp packet which is part of an existing committed connection, nf_conntrack_in() will return err and set skb->_nfct to NULL if it is out of tcp window. ct action for this packet will set the ct_state to +inv which is as expected. But a controller cannot add an OVS flow

[ovs-dev] [PATCH] ovsdb-server: Allow replication from older schema version servers.

2019-10-15 Thread nusiddiq
From: Numan Siddique Presently, replication is not allowed if there is a schema version mismatch between the schema returned by the active ovsdb-server and the local db schema. This is causing failures in OVN DB HA deployments during uprades. In the case of OpenStack tripleo deployment with

[ovs-dev] [PATCH v3] ovsdb-server: Don't drop all connections on read/write status change.

2019-10-14 Thread nusiddiq
From: Numan Siddique The commit [1] force drops all connections when the db read/write status changes. Prior to the commit [1], when there was read/write status change, the existing jsonrpc sessions with 'db_change_aware' set to true, were not updated with the changed 'read_only' value. If the

[ovs-dev] [PATCH v2] ovsdb-server: Don't drop all connections on read/write status change.

2019-10-14 Thread nusiddiq
From: Numan Siddique The commit [1] force drops all connections when the db read/write status changes. Prior to the commit [1], when there was read/write status change, the existing jsonrpc sessions with 'db_change_aware' set to true, were not updated with the changed 'read_only' value. If the

[ovs-dev] [PATCH] ovsdb-server: Don't drop all connections on read/write status change.

2019-10-14 Thread nusiddiq
From: Numan Siddique The commit [1] force drops all connections when the db read/write status changes. Prior to the commit [1], when there was read/write status change, the existing jsonrpc sessions with 'db_change_aware' set to true, were not updated with the changed 'read_only' value. If the

[ovs-dev] [PATCH ovn] ovn-ctl: Create etcdir when starting ovsdb servers

2019-10-12 Thread nusiddiq
From: Numan Siddique 'ovn-ctl promote_ovnnb/promote_ovnsb' stores the address of the active server in /etc/ovn/ovn(nb/sb)-active.conf and this fails as ovn-ctl doesn't create /etc/ovn dir. This patch fixes it. Signed-off-by: Numan Siddique --- utilities/ovn-ctl | 2 ++ 1 file changed, 2

[ovs-dev] [PATCH ovn] Partially revert "Exclude inport and outport symbol tables from conjunction."

2019-09-30 Thread nusiddiq
From: Numan Siddique This partially revers the commit - 298701dbc99645700be41680a43d049cb061847a as the commit [1] disables the conjunction. We still need the changes to the tests/ovn.at file. CC: Han Zhou Signed-off-by: Numan Siddique --- lib/expr.c | 2 +- 1 file changed, 1 insertion(+),

[ovs-dev] [PATCH ovn] Disable conjunction by force cross product for all the fields.

2019-09-27 Thread nusiddiq
From: Numan Siddique With this ovn-controller will not generate conjunction flows. There are issues with the conjunction flows generated by ovn-controller. Please see the commit 298701dbc996 for more information. Signed-off-by: Numan Siddique --- TODO.rst | 10 + lib/expr.c | 20 +-

[ovs-dev] [RFC PATCH ovn] Disable conjunction

2019-09-25 Thread nusiddiq
From: Numan Siddique The commit 298701dbc996("Exclude inport and outport symbol tables from conjunction") was earlier added to disable conjunction for inport and outport symbols. This patch extends it to all the symbos added in the symbol table by setting the 'must_crossproduct' field to

[ovs-dev] [PATCH ovn v3] Learn the mac binding only if required

2019-09-24 Thread nusiddiq
From: Numan Siddique OVN has the actions - put_arp and put_nd to learn the mac bindings from the ARP/ND packets. These actions update the Southbound MAC_Binding table. These actions translates to controller actions. Whenever pinctrl thread receives such packets, it wakes up the main

[ovs-dev] [PATCH ovn] Fix the compilation failures

2019-09-23 Thread nusiddiq
From: Numan Siddique Below compilation errors are seen: - make[1]: *** No rule to make target 'Documentation/internals/charter.rst', needed by 'all-am'. Stop. - Warning, treated as error: ../MAINTAINERS.rst:63:Insufficient data supplied (1 row(s)); no data remaining for table body, required

[ovs-dev] [PATCH ovn v2] Learn the mac binding only if required

2019-09-16 Thread nusiddiq
From: Numan Siddique OVN has the actions - put_arp and put_nd to learn the mac bindings from the ARP/ND packets. These actions update the Southbound MAC_Binding table. These actions translates to controller actions. Whenever pinctrl thread receives such packets, it wakes up the main

[ovs-dev] [PATCH ovn] ovn-lib: Fix the wrong ovn_etcdir path

2019-09-16 Thread nusiddiq
From: Numan Siddique 'sysconfdir' is used instead of 'ovn_sysconfdir' to determine the ovn_etcdir path. Signed-off-by: Numan Siddique --- utilities/ovn-lib.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utilities/ovn-lib.in b/utilities/ovn-lib.in index

[ovs-dev] [branch 2.12] ovn: Exclude inport and outport symbol tables from conjunction

2019-09-14 Thread nusiddiq
From: Numan Siddique If there are multiple ACLs associated with a port group and they match on a range of some field, then ovn-controller doesn't install the flows properly and this results in broken ACL functionality. For example, if there is a port group - pg1 with logical ports - [p1, p2]

[ovs-dev] [PATCH ovn] Exclude inport and outport symbol tables from conjunction

2019-09-13 Thread nusiddiq
From: Numan Siddique If there are multiple ACLs associated with a port group and they match on a range of some field, then ovn-controller doesn't install the flows properly and this results in broken ACL functionality. For example, if there is a port group - pg1 with logical ports - [p1, p2]

[ovs-dev] [PATCH ovn] Learn the mac binding only if required

2019-09-11 Thread nusiddiq
From: Numan Siddique OVN has the actions - put_arp and put_nd to learn the mac bindings from the ARP/ND packets. These actions update the Southbound MAC_Binding table. These actions translates to controller actions. Whenever pinctrl thread receives such packets, it wakes up the main

[ovs-dev] [PATCH] Exclude ovn-nb/ovn-sb man and OVN schema files during compilation.

2019-09-10 Thread nusiddiq
From: Numan Siddique The commit [1] removed OVN, but had to leave out some OVN bits for the ovsdb-server raft testing. But "make install" is installing ovn-nb/ovn-sb man entries and OVN schema files. This patch excludes these. "make install" is also installing ovn-nbctl/ovn-sbctl and this

[ovs-dev] [PATCH ovn v2 2/2] Generate documentation and manpages for ovn-archicture and ovn-nb/ovn-sb

2019-09-10 Thread nusiddiq
From: Numan Siddique This was missing when OVN was split from OVS. Signed-off-by: Numan Siddique --- Makefile.am | 17 + TODO_SPLIT.rst | 6 --- automake.mk | 84 + ovn-nb.xml | 2 +-

[ovs-dev] [PATCH ovn v2 1/2] Add ovn-appctl utility

2019-09-10 Thread nusiddiq
From: Numan Siddique Now that OVN has it's own rundir, "ovs-appctl -t ovn-controller/ovn-northd" doesn't work. To fix this, ovn-appctl utility is added which looks for the OVN pid/ctl files in the ovn rundir. The code is taken from ovs-appctl.c and modified to use ovn_rundir() instead of

[ovs-dev] [PATCH] Fix the segfault seen in ovn-controller when running tests

2019-09-09 Thread nusiddiq
From: Numan Siddique The test case - "116: ovn -- 2 HVs, 2 lports/HV, localnet ports, DVR N-S Ping" is failing with the segfault in ovn-controller occationally. This patch fixes it. backtrace -- Program terminated with signal SIGSEGV, Segmentation fault. 0x00422414 in

[ovs-dev] [PATCH ovn 2/2] Generate documentation and manpages for ovn-archicture and ovn-nb/ovn-sb

2019-09-02 Thread nusiddiq
From: Numan Siddique This was missing when OVN was split from OVS. Signed-off-by: Numan Siddique --- Makefile.am | 17 + TODO_SPLIT.rst | 6 --- automake.mk | 84 + ovn-nb.xml | 2 +-

[ovs-dev] [PATCH ovn 1/2] Add ovn-appctl utility

2019-09-02 Thread nusiddiq
From: Numan Siddique Now that OVN has it's own rundir, "ovs-appctl -t ovn-controller/ovn-northd" doesn't work. To fix this, ovn-appctl utility is added which looks for the OVN pid/ctl files in the ovn rundir. The code is taken from ovs-appctl.c and modified to use ovn_rundir() instead of

[ovs-dev] [PATCH v4 ovn 4/4] rhel: Run ovn services with the 'openvswitch' user

2019-08-28 Thread nusiddiq
From: Numan Siddique This patch could have created a new user 'ovn' for ovn services instead of using 'openvswitch' user. But this would require some amount of work and proper testing since the new user 'ovn' should be part of 'openvswitch' group (to access /var/run/openvswitch/db.sock.). If ovs

[ovs-dev] [PATCH v4 ovn 3/4] Fix "make rpm-fedora"

2019-08-28 Thread nusiddiq
From: Numan Siddique "make rpm-fedora" is broken and this patch fixes it. Previous patch in this series supported building OVN from external OVS sources. Before running "make rpm-fedora", it is expected that the developer has run "make dist" in the OVS source folder to generate the

[ovs-dev] [PATCH v4 ovn 2/4] Add support for using OVN specific rundirs

2019-08-28 Thread nusiddiq
From: Numan Siddique Until now, OVN uses the openvswitch rundirs (rundir, logdir, etcdir). The commit [1] changed the package name from openvswitch to ovn, but it didn't take into the account the effects of it. When "make install" is run ovn-ctl utility is copied to /usr/local/share/ovn/scripts

[ovs-dev] [PATCH v4 ovn 1/4] Build OVN using external OVS directory

2019-08-28 Thread nusiddiq
From: Numan Siddique With this patch we have to configure OVN to refer to external OVS source/build directory instead of the ovs subtree. The new configuration options added are: * --with-ovs-source=/path/to/ovs/source/dir * --with-ovs-build=/path/to/ovs/build/dir The path to these

[ovs-dev] [PATCH v4 ovn 0/4] External OVS source support and separate run dir for OVN

2019-08-28 Thread nusiddiq
From: Numan Siddique This patch series adds support for building OVN from external OVS sources. The first patch adds the support to compile OVN from external OVS sources. The following configuration options are added when configuring OVN * --with-ovs-source (mandatory) * --with-ovs-build

[ovs-dev] [PATCH v3 ovn 4/4] rhel: Run ovn services with the 'openvswitch' user

2019-08-24 Thread nusiddiq
From: Numan Siddique This patch could have created a new user 'ovn' for ovn services instead of using 'openvswitch' user. But this would require some amount of work and proper testing since the new user 'ovn' should be part of 'openvswitch' group (to access /var/run/openvswitch/db.sock.). If ovs

[ovs-dev] [PATCH v3 ovn 3/4] Fix "make rpm-fedora"

2019-08-24 Thread nusiddiq
From: Numan Siddique "make rpm-fedora" is broken and this patch fixes it. Previous patch in this series supported building OVN from external OVS sources. Before running "make rpm-fedora", it is expected that the developer has run "make dist" in the OVS source folder to generate the

[ovs-dev] [PATCH v3 ovn 2/4] Add support for using OVN specific rundirs

2019-08-24 Thread nusiddiq
From: Numan Siddique Until now, OVN uses the openvswitch rundirs (rundir, logdir, etcdir). The commit [1] changed the package name from openvswitch to ovn, but it didn't take into the account the effects of it. When "make install" is run ovn-ctl utility is copied to /usr/local/share/ovn/scripts

[ovs-dev] [PATCH v3 ovn 1/4] Build OVN using external OVS directory

2019-08-24 Thread nusiddiq
From: Numan Siddique With this patch we have to configure OVN to refer to external OVS source/build directory instead of the ovs subtree. The new configuration options added are: * --with-ovs-source=/path/to/ovs/source/dir * --with-ovs-build=/path/to/ovs/build/dir The path to these

[ovs-dev] [PATCH v3 ovn 0/4] External OVS source support and separate run dir for OVN

2019-08-24 Thread nusiddiq
From: Numan Siddique This patch series adds support for building OVN from external OVS sources. The first patch adds the support to compile OVN from external OVS sources. The following configuration options are added when configuring OVN * --with-ovs-source (mandatory) * --with-ovs-build

[ovs-dev] [PATCH v2 ovn 4/5] rhel: Run ovn services with the 'openvswitch' user

2019-08-19 Thread nusiddiq
From: Numan Siddique This patch could have created a new user 'ovn' for ovn services instead of using 'openvswitch' user. But this would require some amount of work and proper testing since the new user 'ovn' should be part of 'openvswitch' group (to access /var/run/openvswitch/db.sock.). If ovs

[ovs-dev] [PATCH v2 ovn 3/5] Fix "make rpm-fedora"

2019-08-19 Thread nusiddiq
From: Numan Siddique "make rpm-fedora" is broken and this patch fixes it. Previous patch in this series supported building OVN from external OVS sources. Before running "make rpm-fedora", it is expected that the developer has run "make dist" in the OVS source folder to generate the

[ovs-dev] [PATCH v2 ovn 2/5] Add support for using OVN specific rundirs

2019-08-19 Thread nusiddiq
From: Numan Siddique Until now, OVN uses the openvswitch rundirs (rundir, logdir, etcdir). The commit [1] changed the package name from openvswitch to ovn, but it didn't take into the account the effects of it. When "make install" is run ovn-ctl utility is copied to /usr/local/share/ovn/scripts

[ovs-dev] [PATCH v2 ovn 1/5] Build OVN using external OVS directory

2019-08-19 Thread nusiddiq
From: Numan Siddique With this patch we have to configure OVN to refer to external OVS source/build directory instead of the ovs subtree. The new configuration options added are: * --with-ovs-source=/path/to/ovs/source/dir * --with-ovs-build=/path/to/ovs/build/dir Before configuring OVN,

[ovs-dev] [PATCH v2 ovn 0/5] External OVS source support and separate run dir for OVN

2019-08-19 Thread nusiddiq
From: Numan Siddique This patch series adds support for building OVN from external OVS sources. The first patch adds the support to compile OVN from external OVS sources. The following configuration options are added when configuring OVN * --with-ovs-source (mandatory) * --with-ovs-build

[ovs-dev] [PATCH ovn 4/4] rhel: Run ovn services with the 'openvswitch' user

2019-08-13 Thread nusiddiq
From: Numan Siddique This patch could have created a new user 'ovn' for ovn services instead of using 'openvswitch' user. But this would require some amount of work and proper testing since the new user 'ovn' should be part of 'openvswitch' group (to access /var/run/openvswitch/db.sock.). If ovs

[ovs-dev] [PATCH ovn 3/4] Fix "make rpm-fedora"

2019-08-13 Thread nusiddiq
From: Numan Siddique "make rpm-fedora" is broken and this patch fixes it. Previous patch in this series supported building OVN from external OVS sources. Before running "make rpm-fedora", it is expected that the developer has run "make dist" in the OVS source folder to generate the

[ovs-dev] [PATCH ovn 2/4] Build OVN using external OVS directory

2019-08-13 Thread nusiddiq
From: Numan Siddique With this patch we have to configure OVN to refer to external OVS source/build directory instead of the ovs subtree. The new configuration options added are: * --with-ovs-source=/path/to/ovs/source/dir * --with-ovs-build=/path/to/ovs/build/dir Before configuring OVN,

[ovs-dev] [PATCH ovn 1/4] Add support for using OVN specific rundirs

2019-08-13 Thread nusiddiq
From: Numan Siddique Until now, OVN uses the openvswitch rundirs (rundir, logdir, etcdir). The commit [1] changed the package name from openvswitch to ovn, but it didn't take into the account the effects of it. When "make install" is run ovn-ctl utility is copied to /usr/local/share/ovn/scripts

[ovs-dev] [PATCH ovn 0/4] External OVS source support and separate run dir for OVN

2019-08-13 Thread nusiddiq
From: Numan Siddique This patch series adds support for building OVN from external OVS sources. The first patch adds support to run OVN services using separate directores - Default run time dir - /usr/local/var/run/ovm - Default log dir - /usr/loca/var/log/ovn - Default db dir -

[ovs-dev] [PATCH v2 ovn] Add support for using OVN specific rundirs

2019-08-13 Thread nusiddiq
From: Numan Siddique Until now, OVN uses the openvswitch rundirs (rundir, logdir, etcdir). The commit [1] changed the package name from openvswitch to ovn, but it didn't take into the account the effects of it. When "make install" is run ovn-ctl utility is copied to /usr/local/share/ovn/scripts

[ovs-dev] [PATCH ovn] Add support for using OVN specific rundirs

2019-08-09 Thread nusiddiq
From: Numan Siddique Until now, OVN uses the openvswitch rundirs (rundir, logdir, etcdir). The commit [1] changed the package name from openvswitch to ovn, but it didn't take into the account the effects of it. When "make install" is run ovn-ctl utility is copied to /usr/local/share/ovn/scripts

[ovs-dev] [PATCH ovn] Add OVN schema version checks in Makefile.am

2019-08-08 Thread nusiddiq
From: Numan Siddique This was left out during the OVS/OVN split. We still need to handle the below in the automake files - OVN northbound/southbound E-R diagram - OVN northbound/southbound schema documentation - ovn-architecture manpage generation. The above requires some amount of work

[ovs-dev] [PATCH v3 ovn] Build OVN using external OVS directory

2019-08-08 Thread nusiddiq
From: Numan Siddique With this patch we have to configure OVN to refer to external OVS source/build directory instead of the ovs subtree. The new configuration options added are: * --with-ovs-source=/path/to/ovs/source/dir * --with-ovs-build=/path/to/ovs/build/dir Before configuring OVN,

[ovs-dev] [PATCH ovn] Enable OVN in tutorial/ovs-sandbox by default

2019-08-07 Thread nusiddiq
From: Numan Siddique The patch removs the --ovn option and enables OVN by default. Signed-off-by: Numan Siddique --- tutorial/ovs-sandbox | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/tutorial/ovs-sandbox b/tutorial/ovs-sandbox index 9b4c3e4f5..47032b499 100755 ---

[ovs-dev] [PATCH ovn] Correct the include path when including the header files from lib folder

2019-08-06 Thread nusiddiq
From: Numan Siddique Compilation will fail when we try to build ovn from external ovs directory. Earlier commit [1] missed changing the include path for lib/*.c files. [1] - a469954c00c4 ("Include ovn header files from lib/ instead of ovn/lib/") Signed-off-by: Numan Siddique ---

[ovs-dev] [branch 2.12] ovn-northd: fixed memory leak in ovn_port_update_sbrec()

2019-08-06 Thread nusiddiq
From: Damijan Skvarc Memory leak happens because of redundand memory allocation for array of single pointer. Issue was solved by removing this redundand allocation and using address of pointer to created chassis sb_ha_entity instead. Signed-off-by: Damijan Skvarc Acked-by: Numan Siddique

[ovs-dev] [branch 2.12] ovn-controller: Encode the virtual port key in vport_bind action in network byte order

2019-08-06 Thread nusiddiq
From: Numan Siddique The commit [1] encoded the vport key using uint32_t and the test case "action parsing" is failing for s380 arch. This patch fixes this issue by encoding the vport key in the network byte order. [1] - 054f4c85c413("Add a new logical switch port type - 'virtual'") Fixes:

[ovs-dev] [PATCH v2 ovn] Build OVN using external OVS directory

2019-08-05 Thread nusiddiq
From: Numan Siddique With this patch we have to configure OVN to refer to external OVS source/build directory instead of the ovs subtree. The new configuration options added are: * --with-ovs-source=/path/to/ovs/source/dir * --with-ovs-build=/path/to/ovs/build/dir Before configuring OVN,

[ovs-dev] [PATCH v2 ovn] Encode the virtual port key in vport_bind action in network byte order

2019-08-05 Thread nusiddiq
From: Numan Siddique The commit [1] encoded the vport key using uint32_t and the test case "action parsing" is failing for s380 arch. This patch fixes this issue by encoding the vport key in the network byte order. [1] - 054f4c85c413("Add a new logical switch port type - 'virtual'") Fixes:

[ovs-dev] [PATCH ovn] Encode the virtual port key in vport_bind action in network byte order

2019-08-05 Thread nusiddiq
From: Numan Siddique The commit [1] encoded the vport key using uint32_t and the test case "action parsing" is failing for s380 arch. This patch fixes this issue by encoding the vport key in the network byte order. [1] - 054f4c85c413("Add a new logical switch port type - 'virtual'") Fixes:

[ovs-dev] [PATCH] Encode the virtual port key in vport_bind action in network byte order

2019-08-05 Thread nusiddiq
From: Numan Siddique The commit [1] encoded the vport key using uint32_t and the test case "action parsing" is failing for s380 arch. This patch fixes this issue by encoding the vport key in the network byte order. [1] - 054f4c85c413("Add a new logical switch port type - 'virtual'") Fixes:

[ovs-dev] [branch2.12] ovn: Add a new logical switch port type - 'virtual'

2019-08-01 Thread nusiddiq
From: Numan Siddique This new type is added for the following reasons: - When a load balancer is created in an OpenStack deployment with Octavia service, it creates a logical port 'VIP' for the virtual ip. - This logical port is not bound to any VIF. - Octavia service creates a

[ovs-dev] [PATCH ovn] Change the package name from openvswitch to ovn in AC_INIT()

2019-08-01 Thread nusiddiq
From: Numan Siddique Signed-off-by: Numan Siddique --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 180bbcd7c..8a32d3a18 100644 --- a/configure.ac +++ b/configure.ac @@ -13,7 +13,7 @@ # limitations under the License.

[ovs-dev] [branch2.12] ovn-northd: Add the option to pause and resume

2019-08-01 Thread nusiddiq
From: Numan Siddique This patch adds 3 unixctl socket comments - pause, resume and is-paused. Usage: ovs-appctl -t ovn-northd pause/resume/is-paused This feature will be useful if the CMS wants to - deploy OVN DB servers in active/passive mode and - run ovn-northd on all these nodes and

[ovs-dev] [PATCH ovn] Build OVN using external OVS directory

2019-07-31 Thread nusiddiq
From: Numan Siddique With this patch we have to configure OVN to refer to external OVS source/build directory instead of the ovs subtree. The new configuration options added are: * --with-ovs-source=/path/to/ovs/source/dir * --with-ovs-build=/path/to/ovs/build/dir Before configuring OVN,

[ovs-dev] [PATCH v5 ovn] ovn-northd: Add the option to pause and resume

2019-07-31 Thread nusiddiq
From: Numan Siddique This patch adds 3 unixctl socket comments - pause, resume and is-paused. Usage: ovs-appctl -t ovn-northd pause/resume/is-paused This feature will be useful if the CMS wants to - deploy OVN DB servers in active/passive mode and - run ovn-northd on all these nodes and

[ovs-dev] [PATCH v10 ovn] Add a new logical switch port type - 'virtual'

2019-07-29 Thread nusiddiq
From: Numan Siddique This new type is added for the following reasons: - When a load balancer is created in an OpenStack deployment with Octavia service, it creates a logical port 'VIP' for the virtual ip. - This logical port is not bound to any VIF. - Octavia service creates a

[ovs-dev] [branch 2.12] ovn-controller: Fix the chassis row recreation issue

2019-07-29 Thread nusiddiq
From: Numan Siddique Before the commit [1], ovn-controller would always recreate its chassis row if deleted externally. After this commit, it no longer recreates it. This is regression and needs to be fixed. [1] - 242f1799fc22("ovn-controller: Refactor chassis.c to abstract the string

[ovs-dev] [PATCH v4 ovn] ovn-northd: Add the option to pause and resume

2019-07-29 Thread nusiddiq
From: Numan Siddique This patch adds 3 unixctl socket comments - pause, resume and is-paused. Usage: ovs-appctl -t ovn-northd pause/resume/is-paused This feature will be useful if the CMS wants to - deploy OVN DB servers in active/passive mode and - run ovn-northd on all these nodes and

[ovs-dev] [PATCH ovn] Fix the chassis row recreation issue

2019-07-29 Thread nusiddiq
From: Numan Siddique Before the commit [1], ovn-controller would always recreate its chassis row if deleted externally. After this commit, it no longer recreates it. This is regression and needs to be fixed. [1] - 242f1799fc22("ovn-controller: Refactor chassis.c to abstract the string

[ovs-dev] [PATCH v3 ovn] Include common ovn header files from include/ovn instead of ovs/include/ovn

2019-07-29 Thread nusiddiq
From: Numan Siddique For the other header files present in lib/, the previous commit [1] changed the path. But few were left out. This patch fixes them too. Also updated the end comments in the header files with the correct path. [1] - a469954c00c4("Include ovn header files from lib/ instead

[ovs-dev] [PATCHv2 ovn] Include common ovn header files from include/ovn instead of ovs/include/ovn

2019-07-29 Thread nusiddiq
From: Numan Siddique For the other header files present in lib/, the previous commit [1] changed the path. But few were left out. This patch fixes them too. [1] - a469954c00c4("Include ovn header files from lib/ instead of ovn/lib/") Signed-off-by: Numan Siddique --- v1 -> v2 === *

[ovs-dev] [PATCH ovn] Include common ovn header files from include/ovn instead of ovs/include/ovn

2019-07-29 Thread nusiddiq
From: Numan Siddique For the other header files present in lib/, the previous commit [1] changed the path. But few were left out. This patch fixes them too. [1] - a469954c00c4("Include ovn header files from lib/ instead of ovn/lib/") Signed-off-by: Numan Siddique --- Makefile.am | 2

[ovs-dev] [PATCH ovn] Include ovn header files from lib/ instead of ovn/lib/

2019-07-26 Thread nusiddiq
From: Numan Siddique If we don't change this, we will be including the header files from ovs subtree - ovs/ovn/lib/ Signed-off-by: Numan Siddique --- controller-vtep/binding.c | 2 +- controller-vtep/gateway.c | 2 +- controller-vtep/ovn-controller-vtep.c | 4 ++--

[ovs-dev] [PATCH] ovn-controller: Fix the chassis row recreation issue

2019-07-24 Thread nusiddiq
From: Numan Siddique Before the commit [1], ovn-controller would always recreate its chassis row if deleted externally. After this commit, it no longer recreates it. This is regression and needs to be fixed. [1] - 242f1799fc22("ovn-controller: Refactor chassis.c to abstract the string

[ovs-dev] [PATCH v9] ovn: Add a new logical switch port type - 'virtual'

2019-07-18 Thread nusiddiq
From: Numan Siddique This new type is added for the following reasons: - When a load balancer is created in an OpenStack deployment with Octavia service, it creates a logical port 'VIP' for the virtual ip. - This logical port is not bound to any VIF. - Octavia service creates a

[ovs-dev] [PATCH v8] ovn: Add a new logical switch port type - 'virtual'

2019-07-18 Thread nusiddiq
From: Numan Siddique This new type is added for the following reasons: - When a load balancer is created in an OpenStack deployment with Octavia service, it creates a logical port 'VIP' for the virtual ip. - This logical port is not bound to any VIF. - Octavia service creates a

[ovs-dev] [PATCH v3] ovn-northd: Add the option to pause and resume

2019-07-16 Thread nusiddiq
From: Numan Siddique This patch adds 3 unixctl socket comments - pause, resume and is-paused. Usage: ovs-appctl -t ovn-northd pause/resume/is-paused This feature will be useful if the CMS wants to - deploy OVN DB servers in active/passive mode and - run ovn-northd on all these nodes and

[ovs-dev] [PATCH v7] ovn: Add a new logical switch port type - 'virtual'

2019-07-16 Thread nusiddiq
From: Numan Siddique This new type is added for the following reasons: - When a load balancer is created in an OpenStack deployment with Octavia service, it creates a logical port 'VIP' for the virtual ip. - This logical port is not bound to any VIF. - Octavia service creates a

[ovs-dev] [PATCH v2] ovn-northd: Fix the ovn-northd continuous looping

2019-07-16 Thread nusiddiq
From: Numan Siddique ovn-northd wakes up continuously from poll_block(). This issue can be reproduced in the sandbox with the below commands ovn-nbctl lr-add lr0 ovn-nbctl ls-add public ovn-nbctl lrp-add lr0 lr0-public 00:00:20:20:12:13 172.168.0.100/24 ovn-nbctl lsp-add public public-lr0

[ovs-dev] [PATCH v6] ovn: Add a new logical switch port type - 'virtual'

2019-07-12 Thread nusiddiq
From: Numan Siddique This new type is added for the following reasons: - When a load balancer is created in an OpenStack deployment with Octavia service, it creates a logical port 'VIP' for the virtual ip. - This logical port is not bound to any VIF. - Octavia service creates a

[ovs-dev] [PATCH] ovn-northd: Fix the ovn-northd continous looping

2019-07-12 Thread nusiddiq
From: Numan Siddique ovn-northd wakes up continuously from poll_block(). This issue can be reproduced in the sandbox with the below commands ovn-nbctl lr-add lr0 ovn-nbctl ls-add public ovn-nbctl lrp-add lr0 lr0-public 00:00:20:20:12:13 172.168.0.100/24 ovn-nbctl lsp-add public public-lr0

[ovs-dev] [PATCH] ovn: Fix the test failures in travis CI.

2019-07-11 Thread nusiddiq
From: Numan Siddique After the commit [1], below test cases are failing repeatedly in travis CI. 2663: ovn -- 4 HV, 1 LS, 1 LR, packet test with HA distributed router gateway port FAILED (ovn.at:8597) 2664: ovn -- 4 HV, 3 LS, 2 LR, packet test with HA distributed router gateway port FAILED

[ovs-dev] [PATCH v3] ovn-northd: Add the option to pause and resume

2019-07-08 Thread nusiddiq
From: Numan Siddique This patch adds 3 unixctl socket comments - pause, resume and is-paused. Usage: ovs-appctl -t ovn-northd pause/resume/is-paused This feature will be useful if the CMS wants to - deploy OVN DB servers in active/passive mode and - run ovn-northd on all these nodes and

[ovs-dev] [PATCH v2] ovn-northd: Add the option to pause and resume

2019-07-08 Thread nusiddiq
From: Numan Siddique This patch adds 3 unixctl socket comments - pause, resume and is-paused. Usage: ovs-appctl -t ovn-northd pause/resume/is-paused This feature will be useful if the CMS wants to - deploy OVN DB servers in active/passive mode and - run ovn-northd on all these nodes and

[ovs-dev] [PATCH] ovn: Add a new logical switch port type - 'virtual'

2019-07-06 Thread nusiddiq
From: Numan Siddique This new type is added for the following reasons: - When a load balancer is created in an OpenStack deployment with Octavia service, it creates a logical port 'VIP' for the virtual ip. - This logical port is not bound to any VIF. - Octavia service creates a

[ovs-dev] [PATCH v3 3/3] ovn: Send GARP for router port IPs of a router port connected to bridged logical switch

2019-07-01 Thread nusiddiq
From: Numan Siddique This patch handles sending GARPs for - router port IPs of a distributed router port - router port IPs of a router port which belongs to gateway router (with the option - redirect-chassis set in Logical_Router.options) Signed-off-by: Numan Siddique ---

[ovs-dev] [PATCH v3 2/3] ovn: Send GARP for the router ports with reside-on-redirect-chassis options set

2019-07-01 Thread nusiddiq
From: Numan Siddique With the commit [1], the routing for the provider logical switches connected to a router is centralized on the master gateway chassis (if the option - reside-on-redirect-chassis) is set. When the failover happens and a standby gateway chassis becomes master, it should send

[ovs-dev] [PATCH v3 1/3] ovn-northd: Refactor the code which sets nat_addresses

2019-07-01 Thread nusiddiq
From: Numan Siddique The present code which sets the Port_Binding.nat_addresses can be simplied. This patch does this. This would help in upcoming commits to set the nat_addresses column with the mac and IPs of distributed logical router ports and logical router ports with

[ovs-dev] [PATCH v2] ovn-controller: Provide the option to configure inactivity probe interval for OpenFlow conn

2019-07-01 Thread nusiddiq
From: Numan Siddique If the ovn-controller main loop takes more than 5 seconds (if there are lots of logical flows) before it calls poll_block(), it causes the poll_block to wake up immediately, since rconn module has to send echo request. With the incremental processing, this is not an issue

[ovs-dev] [PATCH v3 0/3] Handle GARPs for logical router port IPs

2019-07-01 Thread nusiddiq
From: Numan Siddique The v1 of the patch series had just one patch which handled sending GARPs for the logical router ports with the option - reside-on-redirect-chassis set. The v2+ has totall 3 patches. Patch 1 is a simple refactor in ovn-northd code which sets the Port_Binding.nat_addresses

[ovs-dev] [PATCH v4] ovn-controller: Omit tracking external_ids columns

2019-06-28 Thread nusiddiq
From: Numan Siddique Running the command "ovn-nbctl set logical_switch_port foo external_ids:foo=bar" results in the incremetal processing engine to recompute the flows on the chassis where the logical port 'foo' is claimed. This patch avoids this unnecessary recomputation by omitting the

[ovs-dev] [PATCH] ovn-controller: Provide the option to configure inactivity probe interval for OpenFlow conn

2019-06-27 Thread nusiddiq
From: Numan Siddique If the ovn-controller main loop takes more than 5 seconds (if there are lots of logical flows) before it calls poll_block(), it causes the poll_block to wake up immediately, since rconn module has to send echo request. With the incremental processing, this is not an issue

[ovs-dev] [PATCH v3] ovn-controller: Omit alert for Port_Binding.external_ids changes

2019-06-26 Thread nusiddiq
From: Numan Siddique Running the command "ovn-nbctl set logical_switch_port foo external_ids:foo=bar" results in the incremetal processing engine to recompute the flows on the chassis where the logical port 'foo' is claimed. This patch avoids this unnecessary recomputation by omitting the alert

[ovs-dev] [PATCH v2 3/3] ovn-controller: Consider only port binding changes of normal type for run_time dataengine

2019-06-24 Thread nusiddiq
From: Numan Siddique Any changes for Port_Bindings rows of type - "chassisredirect", "patch", "l3gateway" etc which are not related to the chassis can be ignored in the function 'binding_evaluate_port_binding_changes()'. Presently this returns true and this results in unnecessary flow

[ovs-dev] [PATCH v2 2/3] ovn-controller: Remove the run_id check in engine_run

2019-06-24 Thread nusiddiq
From: Numan Siddique engine_node 'en_sb_port_binding' is added as input to engine nodes - 'en_runtime_data' with the handler runtime_data_sb_port_binding_handler() and - 'en_flow_output' with the handler flow_output_sb_port_binding_handler() nodes. Also 'en_runtime_data' is input to node

[ovs-dev] [PATCH v2 1/3] ovn-controller: Omit alert for Port_Binding.external_ids changes

2019-06-24 Thread nusiddiq
From: Numan Siddique Running the command "ovn-nbctl set logical_switch_port foo external_ids:foo=bar" results in the incremetal processing engine to recompute the flows on the chassis where the logical port 'foo' is claimed. This patch avoids this unnecessary recomputation by omitting the alert

[ovs-dev] [PATCH v2 0/3] ovn-controller: Some IP improvements

2019-06-24 Thread nusiddiq
From: Numan Siddique This patch series does few incremental processing improvements. Right now recomputation is triggered for some scenarios and this patch series tries to avoid that. Please see the ML discussion = https://mail.openvswitch.org/pipermail/ovs-discuss/2019-June/048822.html for

[ovs-dev] [PATCH 3/3] ovn-controller: Consider only port binding changes of normal type for run_time dataengine

2019-06-24 Thread nusiddiq
From: Numan Siddique Any changes for Port_Bindings rows of type - "chassisredirect", "patch", "l3gateway" etc which are not related to the chassis can be ignored in the function 'binding_evaluate_port_binding_changes()'. Presently this returns true and this results in unnecessary flow

[ovs-dev] [PATCH 1/3] ovn-controller: Omit alert for Port_Binding.external_ids changes

2019-06-24 Thread nusiddiq
From: Numan Siddique Running the command "ovn-nbctl set logical_switch_port foo external_ids:foo=bar" results in the incremetal processing engine to recompute the flows on the chassis where the logical port 'foo' is claimed. This patch avoids this unnecessary recomputation by omitting the alert

[ovs-dev] [PATCH 2/3] ovn-controller: Remove the run_id check in engine_run

2019-06-24 Thread nusiddiq
From: Numan Siddique engine_node 'en_sb_port_binding' is added as input to engine nodes - 'en_runtime_data' with the handler runtime_data_sb_port_binding_handler() and - 'en_flow_output' with the handler flow_output_sb_port_binding_handler() nodes. Also 'en_runtime_data' is input to node

[ovs-dev] [PATCH] ovn-northd: Add the option to pause and resume

2019-06-16 Thread nusiddiq
From: Numan Siddique This patch adds 3 unixctl socket comments - pause, resume and is-paused. Usage: ovs-appctl -t ovn-northd pause/resume/is-paused This feature will be useful if the CMS wants to - deploy OVN DB servers in active/passive mode and - run ovn-northd on all these nodes and

[ovs-dev] [PATCH v4] ovn: Add a new logical switch port type - 'virtual'

2019-06-14 Thread nusiddiq
From: Numan Siddique This new type is added for the following reasons: - When a load balancer is created in an OpenStack deployment with Octavia service, it creates a logical port 'VIP' for the virtual ip. - This logical port is not bound to any VIF. - Octavia service creates a

[ovs-dev] [PATCH v2 3/3] ovn: Send GARP for router port IPs of a router port connected to bridged logical switch

2019-06-14 Thread nusiddiq
From: Numan Siddique This patch handles sending GARPs for - router port IPs of a distributed router port - router port IPs of a router port which belongs to gateway router (with the option - redirect-chassis set in Logical_Router.options) Signed-off-by: Numan Siddique ---

  1   2   3   4   5   >