Re: [ovs-dev] [OVN Patch v8 3/3] northd: Restore parallel build with dp_groups

2021-10-01 Thread Han Zhou
On Thu, Sep 30, 2021 at 11:04 PM Anton Ivanov < anton.iva...@cambridgegreys.com> wrote: > On 01/10/2021 01:32, Han Zhou wrote: > > > > On Thu, Sep 30, 2021 at 2:03 PM Anton Ivanov < > anton.iva...@cambridgegreys.com> wrote: > >> On 30/09/2021 20:48, Han Zhou wrote: >> >> >> >> On Thu, Sep 30, 2021

Re: [ovs-dev] [OVN Patch v8 3/3] northd: Restore parallel build with dp_groups

2021-09-30 Thread Anton Ivanov
On 01/10/2021 01:32, Han Zhou wrote: On Thu, Sep 30, 2021 at 2:03 PM Anton Ivanov > wrote: On 30/09/2021 20:48, Han Zhou wrote: On Thu, Sep 30, 2021 at 7:34 AM Anton Ivanov mailto:anton.iva...@cambridgegreys.com>> wrote: Summary

Re: [ovs-dev] [OVN Patch v8 3/3] northd: Restore parallel build with dp_groups

2021-09-30 Thread Han Zhou
On Thu, Sep 30, 2021 at 2:03 PM Anton Ivanov < anton.iva...@cambridgegreys.com> wrote: > On 30/09/2021 20:48, Han Zhou wrote: > > > > On Thu, Sep 30, 2021 at 7:34 AM Anton Ivanov < > anton.iva...@cambridgegreys.com> wrote: > >> Summary of findings. >> >> 1. The numbers on the perf test do not alig

Re: [ovs-dev] [OVN Patch v8 3/3] northd: Restore parallel build with dp_groups

2021-09-30 Thread Anton Ivanov
On 30/09/2021 20:48, Han Zhou wrote: On Thu, Sep 30, 2021 at 7:34 AM Anton Ivanov > wrote: Summary of findings. 1. The numbers on the perf test do not align with heater which is much closer to a realistic load. On some tests where heater g

Re: [ovs-dev] [OVN Patch v8 3/3] northd: Restore parallel build with dp_groups

2021-09-30 Thread Han Zhou
On Thu, Sep 30, 2021 at 7:34 AM Anton Ivanov < anton.iva...@cambridgegreys.com> wrote: > Summary of findings. > > 1. The numbers on the perf test do not align with heater which is much > closer to a realistic load. On some tests where heater gives 5-10% > end-to-end improvement with parallelizatio

Re: [ovs-dev] [OVN Patch v8 3/3] northd: Restore parallel build with dp_groups

2021-09-30 Thread Anton Ivanov
Summary of findings. 1. The numbers on the perf test do not align with heater which is much closer to a realistic load. On some tests where heater gives 5-10% end-to-end improvement with parallelization we get worse results with the perf-test. You spotted this one correctly. Example of the no

Re: [ovs-dev] [OVN Patch v8 3/3] northd: Restore parallel build with dp_groups

2021-09-30 Thread Anton Ivanov
OK, I can dig into this later this afternoon. There is quite a bit of dispersion in tests without parallelization on my system which should not be there. I want to get down to the bottom of where it is coming from and why are we getting different results compared to ovn-heater. I did all the

Re: [ovs-dev] [OVN Patch v8 3/3] northd: Restore parallel build with dp_groups

2021-09-30 Thread Han Zhou
On Thu, Sep 30, 2021 at 12:08 AM Anton Ivanov < anton.iva...@cambridgegreys.com> wrote: > After quickly adding some more prints into the testsuite. > > Test 1: > > Without > > 1: ovn-northd basic scale test -- 200 Hypervisors, 200 Logical > Ports/Hypervisor -- ovn-northd -- dp-groups=yes > ---

Re: [ovs-dev] [OVN Patch v8 3/3] northd: Restore parallel build with dp_groups

2021-09-30 Thread Anton Ivanov
After quickly adding some more prints into the testsuite. Test 1: Without   1: ovn-northd basic scale test -- 200 Hypervisors, 200 Logical Ports/Hypervisor -- ovn-northd -- dp-groups=yes   ---   Maximum (NB in msec): 1130   Average (NB in msec): 620.375000   Maximum (SB in msec): 23   Average

Re: [ovs-dev] [OVN Patch v8 3/3] northd: Restore parallel build with dp_groups

2021-09-29 Thread Han Zhou
Thanks Anton for checking. I am using: Intel(R) Core(TM) i9-7920X CPU @ 2.90GHz, 24 cores. It is weird why my result is so different. I also verified with a scale test script that creates a large scale NB/SB with 800 nodes of simulated k8s setup. And then just run: ovn-nbctl --print-wait-time -

Re: [ovs-dev] [OVN Patch v8 3/3] northd: Restore parallel build with dp_groups

2021-09-29 Thread Anton Ivanov
On 30/09/2021 07:16, Anton Ivanov wrote: Results on a Ryzen 5 3600 - 6 cores 12 threads I will also have a look into the "maximum" measurement for multi-thread. It does not tie up with the drop in average across the board. A. Without   1: ovn-northd basic scale test -- 200 Hypervisors, 2

Re: [ovs-dev] [OVN Patch v8 3/3] northd: Restore parallel build with dp_groups

2021-09-29 Thread Anton Ivanov
Results on a Ryzen 5 3600 - 6 cores 12 threads Without   1: ovn-northd basic scale test -- 200 Hypervisors, 200 Logical Ports/Hypervisor -- ovn-northd -- dp-groups=yes   ---   Maximum (NB in msec): 1256   Average (NB in msec): 679.463785   Maximum (SB in msec): 25   Average (SB in msec): 22.4

Re: [ovs-dev] [OVN Patch v8 3/3] northd: Restore parallel build with dp_groups

2021-09-29 Thread Anton Ivanov
I need to have a look. I use the ovn-heater end-to-end test, that was showing a substantial improvement. What are you running this on? A. On 30/09/2021 00:56, Han Zhou wrote: On Wed, Sep 15, 2021 at 5:45 AM > wrote: > > From: Anton Ivanov

Re: [ovs-dev] [OVN Patch v8 3/3] northd: Restore parallel build with dp_groups

2021-09-29 Thread Han Zhou
On Wed, Sep 15, 2021 at 5:45 AM wrote: > > From: Anton Ivanov > > Restore parallel build with dp groups using rwlock instead > of per row locking as an underlying mechanism. > > This provides improvement ~ 10% end-to-end on ovn-heater > under virutalization despite awakening some qemu gremlin > w

[ovs-dev] [OVN Patch v8 3/3] northd: Restore parallel build with dp_groups

2021-09-15 Thread anton . ivanov
From: Anton Ivanov Restore parallel build with dp groups using rwlock instead of per row locking as an underlying mechanism. This provides improvement ~ 10% end-to-end on ovn-heater under virutalization despite awakening some qemu gremlin which makes qemu climb to silly CPU usage. The gain on ba