Re: [ovs-dev] [PATCH] Conntrack: Fix L4 Checksums in kernel <4.6 when using NAT and helpers

Ok, thanks Ben. This must be a problem when copying to my browser. I've used git send-email to send it again. Hopefully this works. Thanks, John On Fri, Jan 6, 2017 at 5:30 PM, Ben Pfaff wrote: > This patch is still white space damaged. Look at >

Re: [ovs-dev] [PATCH] Conntrack: Fix L4 Checksums in kernel <4.6 when using NAT and helpers

This patch is still white space damaged. Look at https://patchwork.ozlabs.org/patch/712058/: the indentation is all wrong. On Fri, Jan 06, 2017 at 05:23:33PM +, John Hurley wrote: > From 7e20f404bde9fab2604566bc106b3b6ac071bd3f Mon Sep 17 00:00:00 2001 > From: John Hurley

Re: [ovs-dev] [PATCH] Conntrack: Fix L4 Checksums in kernel <4.6 when using NAT and helpers

>From 7e20f404bde9fab2604566bc106b3b6ac071bd3f Mon Sep 17 00:00:00 2001 From: John Hurley Date: Fri, 6 Jan 2017 17:14:53 + Subject: [PATCH 1/1] datapath: Ensure correct L4 checksum with NAT helpers. Fixes:264619055bd52bc2278af848472176642d759874 (datapath: conntrack

Re: [ovs-dev] [PATCH] Conntrack: Fix L4 Checksums in kernel <4.6 when using NAT and helpers

John, This looks functionally OK, but could you repost this with the following changes: - Include a commit message explaining what was broken and how it is fixed. - Refer to the commit that introduced the deleted code with a "Fixes: (“Title”)” line. - Include a "Signed-off-by:” -line. > On

Re: [ovs-dev] [PATCH] Conntrack: Fix L4 Checksums in kernel <4.6 when using NAT and helpers

Ok, this makes sense now. Ive updated and tested the patch: From 93bc4c59b4eb814ed4bc3da3b7459498863add1e Mon Sep 17 00:00:00 2001 From: John Hurley Date: Thu, 5 Jan 2017 17:08:37 + Subject: [PATCH 1/1] ensure correct checksum when a packet is sent to NAT ---

Re: [ovs-dev] [PATCH] Conntrack: Fix L4 Checksums in kernel <4.6 when using NAT and helpers

> On Jan 4, 2017, at 9:50 AM, John Hurley wrote: > > From 64ce83672aab5634990426e0a51af16d882ac2f9 Mon Sep 17 00:00:00 2001 > From: John Hurley > > Date: Wed, 4 Jan 2017 16:52:43 + > Subject: [PATCH]

Re: [ovs-dev] [PATCH] Conntrack: Fix L4 Checksums in kernel <4.6 when using NAT and helpers

> On Jan 4, 2017, at 9:50 AM, John Hurley wrote: > > > > On Wed, Jan 4, 2017 at 12:53 AM, Jarno Rajahalme > wrote: > > > On Dec 28, 2016, at 3:05 PM, John Hurley >

Re: [ovs-dev] [PATCH] Conntrack: Fix L4 Checksums in kernel <4.6 when using NAT and helpers

From 64ce83672aab5634990426e0a51af16d882ac2f9 Mon Sep 17 00:00:00 2001 From: John Hurley Date: Wed, 4 Jan 2017 16:52:43 + Subject: [PATCH] ensure correct checksum when a packet is sent to NAT helper in kernel < 4.6 --- datapath/conntrack.c | 45

Re: [ovs-dev] [PATCH] Conntrack: Fix L4 Checksums in kernel <4.6 when using NAT and helpers

On Wed, Jan 4, 2017 at 12:53 AM, Jarno Rajahalme wrote: > > > On Dec 28, 2016, at 3:05 PM, John Hurley > wrote: > > > > sorry, updated patch…. > > This patch is still whitespace damaged. Maybe use git format-patch and git > send-email to send it? > > >

Re: [ovs-dev] [PATCH] Conntrack: Fix L4 Checksums in kernel <4.6 when using NAT and helpers

> On Dec 28, 2016, at 3:05 PM, John Hurley wrote: > > sorry, updated patch…. This patch is still whitespace damaged. Maybe use git format-patch and git send-email to send it? > > > > Fix for a bug when sending a NATed packet to

Re: [ovs-dev] [PATCH] Conntrack: Fix L4 Checksums in kernel <4.6 when using NAT and helpers

sorry, updated patch. Fix for a bug when sending a NATed packet to helper function in kernels <4.6. Setting CHECKSUM_PARTIAL flag can lead to L4 checksum corruption. Corruption can occur in datapath.c/queue_userspace_packet(). Giving the packet an skb_dst

Re: [ovs-dev] [PATCH] Conntrack: Fix L4 Checksums in kernel <4.6 when using NAT and helpers

On Wed, Dec 28, 2016 at 09:37:30PM +, John Hurley wrote: > Fix for a bug when sending a NATed packet to helper function in kernels > <4.6. > > Setting CHECKSUM_PARTIAL flag means packets could have L4 checksum > corrupted in > > datapath.c/queue_userspace_packet(). > > Giving the packet an