Re: [ovs-dev] [PATCH] bond: Fix using uninitialized 'lacp_fallback_ab_cfg' for 'bond-primary'.

2020-10-19 Thread Ilya Maximets
On 10/13/20 2:58 PM, Jeff Squyres (jsquyres) wrote: > On Oct 13, 2020, at 6:02 AM, Ilya Maximets wrote: >> >> 's->lacp_fallback_ab_cfg' initialized down below in the code, so >> we're using it uninitialized to detect if we need to get 'bond-primary' >> configuration. >> >> Found by valgrind: >> >>

Re: [ovs-dev] [PATCH] bond: Fix using uninitialized 'lacp_fallback_ab_cfg' for 'bond-primary'.

2020-10-13 Thread Jeff Squyres (jsquyres) via dev
On Oct 13, 2020, at 6:02 AM, Ilya Maximets wrote: > > 's->lacp_fallback_ab_cfg' initialized down below in the code, so > we're using it uninitialized to detect if we need to get 'bond-primary' > configuration. > > Found by valgrind: > > Conditional jump or move depends on uninitialised value(s)

Re: [ovs-dev] [PATCH] bond: Fix using uninitialized 'lacp_fallback_ab_cfg' for 'bond-primary'.

2020-10-13 Thread Alin Serdean
squy...@cisco.com> Cc: Flavio Leitner<mailto:f...@sysclose.org>; Ilya Maximets<mailto:i.maxim...@ovn.org> Subject: [ovs-dev] [PATCH] bond: Fix using uninitialized 'lacp_fallback_ab_cfg' for 'bond-primary'. 's->lacp_fallback_ab_cfg' initialized do

[ovs-dev] [PATCH] bond: Fix using uninitialized 'lacp_fallback_ab_cfg' for 'bond-primary'.

2020-10-13 Thread Ilya Maximets
's->lacp_fallback_ab_cfg' initialized down below in the code, so we're using it uninitialized to detect if we need to get 'bond-primary' configuration. Found by valgrind: Conditional jump or move depends on uninitialised value(s) at 0x409114: port_configure_bond (bridge.c:4569) by 0x4091