Re: [ovs-dev] [PATCH] classifier: Fix missing masks on a final stage with ports trie.

2023-02-28 Thread Ilya Maximets
On 2/28/23 16:34, Aaron Conole wrote: > Aaron Conole writes: > >> Ilya Maximets writes: >> >>> Flow lookup doesn't include masks of the final stage in a resulted >>> flow wildcards in case that stage had L4 ports match. Only the result >>> of ports trie lookup is added to the mask. It might be

Re: [ovs-dev] [PATCH] classifier: Fix missing masks on a final stage with ports trie.

2023-02-28 Thread Aaron Conole
Aaron Conole writes: > Ilya Maximets writes: > >> Flow lookup doesn't include masks of the final stage in a resulted >> flow wildcards in case that stage had L4 ports match. Only the result >> of ports trie lookup is added to the mask. It might be sufficient in >> many cases, but it's not corr

Re: [ovs-dev] [PATCH] classifier: Fix missing masks on a final stage with ports trie.

2023-02-21 Thread Aaron Conole
Ilya Maximets writes: > Flow lookup doesn't include masks of the final stage in a resulted > flow wildcards in case that stage had L4 ports match. Only the result > of ports trie lookup is added to the mask. It might be sufficient in > many cases, but it's not correct, because ports trie is not

[ovs-dev] [PATCH] classifier: Fix missing masks on a final stage with ports trie.

2023-02-17 Thread Ilya Maximets
Flow lookup doesn't include masks of the final stage in a resulted flow wildcards in case that stage had L4 ports match. Only the result of ports trie lookup is added to the mask. It might be sufficient in many cases, but it's not correct, because ports trie is not how we decided that the packet