Re: [ovs-dev] [PATCH] compat: Initialize IPv4 reassembly secret timer

2018-07-27 Thread Gregory Rose
On 7/27/2018 11:38 AM, Ben Pfaff wrote: On Wed, Jul 25, 2018 at 08:46:21AM -0700, Gregory Rose wrote: On 7/23/2018 9:22 AM, Yi-Hung Wei wrote: --- a/datapath/linux/compat/ip_fragment.c +++ b/datapath/linux/compat/ip_fragment.c @@ -812,6 +812,9 @@ int __init rpl_ipfrag_init(void) #ifdef

Re: [ovs-dev] [PATCH] compat: Initialize IPv4 reassembly secret timer

2018-07-27 Thread Ben Pfaff
On Wed, Jul 25, 2018 at 08:46:21AM -0700, Gregory Rose wrote: > On 7/23/2018 9:22 AM, Yi-Hung Wei wrote: > --- a/datapath/linux/compat/ip_fragment.c > +++ b/datapath/linux/compat/ip_fragment.c > @@ -812,6 +812,9 @@ int __init rpl_ipfrag_init(void) > #ifdef

Re: [ovs-dev] [PATCH] compat: Initialize IPv4 reassembly secret timer

2018-07-25 Thread Gregory Rose
On 7/23/2018 9:22 AM, Yi-Hung Wei wrote: --- a/datapath/linux/compat/ip_fragment.c +++ b/datapath/linux/compat/ip_fragment.c @@ -812,6 +812,9 @@ int __init rpl_ipfrag_init(void) #ifdef HAVE_INET_FRAGS_WITH_FRAGS_WORK ip4_frags.frags_cache_name = ip_frag_cache_name; #endif +#if

Re: [ovs-dev] [PATCH] compat: Initialize IPv4 reassembly secret timer

2018-07-23 Thread Yi-Hung Wei
>>> --- a/datapath/linux/compat/ip_fragment.c >>> +++ b/datapath/linux/compat/ip_fragment.c >>> @@ -812,6 +812,9 @@ int __init rpl_ipfrag_init(void) >>> #ifdef HAVE_INET_FRAGS_WITH_FRAGS_WORK >>> ip4_frags.frags_cache_name = ip_frag_cache_name; >>> #endif >>> +#if RHEL_RELEASE_CODE <

Re: [ovs-dev] [PATCH] compat: Initialize IPv4 reassembly secret timer

2018-07-20 Thread Gregory Rose
On 7/20/2018 2:00 PM, Yi-Hung Wei wrote: On Thu, Jul 19, 2018 at 6:48 PM, Greg Rose wrote: The RHEL 7 kernels expect the secret timer interval to be initialized before calling the inet_frags_init() function. By not initializing it the inet_frags_secret_rebuild() function was running on every

Re: [ovs-dev] [PATCH] compat: Initialize IPv4 reassembly secret timer

2018-07-20 Thread Yi-Hung Wei
On Thu, Jul 19, 2018 at 6:48 PM, Greg Rose wrote: > The RHEL 7 kernels expect the secret timer interval to be initialized > before calling the inet_frags_init() function. By not initializing it > the inet_frags_secret_rebuild() function was running on every tick > rather than on the expected

Re: [ovs-dev] [PATCH] compat: Initialize IPv4 reassembly secret timer

2018-07-20 Thread Gregory Rose
On 7/19/2018 6:48 PM, Greg Rose wrote: The RHEL 7 kernels expect the secret timer interval to be initialized before calling the inet_frags_init() function. By not initializing it the inet_frags_secret_rebuild() function was running on every tick rather than on the expected interval. This

[ovs-dev] [PATCH] compat: Initialize IPv4 reassembly secret timer

2018-07-19 Thread Greg Rose
The RHEL 7 kernels expect the secret timer interval to be initialized before calling the inet_frags_init() function. By not initializing it the inet_frags_secret_rebuild() function was running on every tick rather than on the expected interval. This caused occasional panics from page faults when