Re: [ovs-dev] [PATCH] connmgr: support changing openflow versions without restarting

Flavio Leitner writes: > On Tue, Aug 11, 2020 at 03:58:44PM -0400, Aaron Conole wrote: >> Flavio Leitner writes: >> >> > Hi Aaron, >> > >> > Thanks for the patch, see my comments below. >> > >> > On Fri, Aug 07, 2020 at 05:32:03PM -0400, Aaron Conole wrote: >> >> When commit a0baa7dfa4fe

Re: [ovs-dev] [PATCH] connmgr: support changing openflow versions without restarting

On Tue, Aug 11, 2020 at 03:58:44PM -0400, Aaron Conole wrote: > Flavio Leitner writes: > > > Hi Aaron, > > > > Thanks for the patch, see my comments below. > > > > On Fri, Aug 07, 2020 at 05:32:03PM -0400, Aaron Conole wrote: > >> When commit a0baa7dfa4fe ("connmgr: Make treatment of active and

Re: [ovs-dev] [PATCH] connmgr: support changing openflow versions without restarting

Flavio Leitner writes: > Hi Aaron, > > Thanks for the patch, see my comments below. > > On Fri, Aug 07, 2020 at 05:32:03PM -0400, Aaron Conole wrote: >> When commit a0baa7dfa4fe ("connmgr: Make treatment of active and passive >> connections more uniform") was applied, it did not take into

Re: [ovs-dev] [PATCH] connmgr: support changing openflow versions without restarting

Hi Aaron, Thanks for the patch, see my comments below. On Fri, Aug 07, 2020 at 05:32:03PM -0400, Aaron Conole wrote: > When commit a0baa7dfa4fe ("connmgr: Make treatment of active and passive > connections more uniform") was applied, it did not take into account > that a reconfiguration of the

Re: [ovs-dev] [PATCH] connmgr: support changing openflow versions without restarting

On Sat, Aug 8, 2020 at 3:02 AM Aaron Conole wrote: > > When commit a0baa7dfa4fe ("connmgr: Make treatment of active and passive > connections more uniform") was applied, it did not take into account > that a reconfiguration of the allowed_versions setting would require a > reload of the ofservice

Re: [ovs-dev] [PATCH] connmgr: support changing openflow versions without restarting

Bleep bloop. Greetings Aaron Conole, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 83 characters long (recommended limit is 79) #47 FILE: ofproto/connmgr.c:608:

[ovs-dev] [PATCH] connmgr: support changing openflow versions without restarting

When commit a0baa7dfa4fe ("connmgr: Make treatment of active and passive connections more uniform") was applied, it did not take into account that a reconfiguration of the allowed_versions setting would require a reload of the ofservice object (only accomplished via a restart of OvS). For now,