Re: [ovs-dev] [PATCH] conntrack: Fix tcp payload length in case multi-segments.

2019-11-11 Thread Darrell Ball
> > > From: Darrell Ball [mailto:dlu...@gmail.com] > Sent: Saturday, November 09, 2019 8:12 AM > To: Zhike Wang > Cc: ovs dev; 王志克 > Subject: Re: [ovs-dev] [PATCH] conntrack: Fix tcp payload length in case > multi-segments. > > Thanks for the patch > > Wo

Re: [ovs-dev] [PATCH] conntrack: Fix tcp payload length in case multi-segments.

2019-11-11 Thread Ilya Maximets
> Hi Darrell, > > In TSO case, the packet may use multi-segments mbuf, and I do not> think we > need to make it linearal. In this case, we can NOT use > pointer to calculate the tcp length. Hi. Just wanted to mention that current main course for TSO enabling in OVS seems to be using of extbuf

Re: [ovs-dev] [PATCH] conntrack: Fix tcp payload length in case multi-segments.

2019-11-10 Thread 王志克 via dev
From: Darrell Ball [mailto:dlu...@gmail.com] Sent: Saturday, November 09, 2019 8:12 AM To: Zhike Wang Cc: ovs dev; 王志克 Subject: Re: [ovs-dev] [PATCH] conntrack: Fix tcp payload length in case multi-segments. Thanks for the patch  Would you mind describing the use case that this patch is aiming

Re: [ovs-dev] [PATCH] conntrack: Fix tcp payload length in case multi-segments.

2019-11-08 Thread Darrell Ball
Thanks for the patch Would you mind describing the use case that this patch is aiming to support ? On Fri, Nov 8, 2019 at 1:23 AM Zhike Wang wrote: > Signed-off-by: Zhike Wang > --- > lib/conntrack-private.h | 16 ++-- > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff

[ovs-dev] [PATCH] conntrack: Fix tcp payload length in case multi-segments.

2019-11-08 Thread Zhike Wang
Signed-off-by: Zhike Wang --- lib/conntrack-private.h | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/lib/conntrack-private.h b/lib/conntrack-private.h index 590f139..1d21f6e 100644 --- a/lib/conntrack-private.h +++ b/lib/conntrack-private.h @@ -233,13