Re: [ovs-dev] [PATCH] conntrack: Refactor nat handling functions

2022-10-27 Thread Ales Musil
On Thu, Oct 27, 2022 at 1:17 PM Paolo Valerio wrote: > Ales Musil writes: > > > On Thu, Oct 27, 2022 at 11:14 AM Ales Musil wrote: > > > > In order to support NAT of inner packet > > for ICMP related traffic refactor the nat > > functions. This fixes the issue that the > > NAT

Re: [ovs-dev] [PATCH] conntrack: Refactor nat handling functions

2022-10-27 Thread Paolo Valerio
Ales Musil writes: > On Thu, Oct 27, 2022 at 11:14 AM Ales Musil wrote: > > In order to support NAT of inner packet > for ICMP related traffic refactor the nat > functions. This fixes the issue that the > NAT was not performed on inner header in orig > direction and avoids

Re: [ovs-dev] [PATCH] conntrack: Refactor nat handling functions

2022-10-27 Thread Ales Musil
On Thu, Oct 27, 2022 at 11:14 AM Ales Musil wrote: > In order to support NAT of inner packet > for ICMP related traffic refactor the nat > functions. This fixes the issue that the > NAT was not performed on inner header in orig > direction and avoids some code duplication. > > Reported-at:

Re: [ovs-dev] [PATCH] conntrack: Refactor nat handling functions

2022-10-27 Thread 0-day Robot
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Inappropriate spacing around cast #190 FILE: lib/conntrack.c:839:

[ovs-dev] [PATCH] conntrack: Refactor nat handling functions

2022-10-27 Thread Ales Musil
In order to support NAT of inner packet for ICMP related traffic refactor the nat functions. This fixes the issue that the NAT was not performed on inner header in orig direction and avoids some code duplication. Reported-at: https://bugzilla.redhat.com/2120546 Signed-off-by: Ales Musil ---