Re: [ovs-dev] [PATCH] daemon-unix: Close log file in monitor process while waiting on child.

2022-01-29 Thread Ben Pfaff
On Wed, Jan 26, 2022 at 06:39:52PM -0800, William Tu wrote: > On Wed, Jan 26, 2022 at 8:56 AM Ben Pfaff wrote: > > > > Until now, the monitor process held its log file open while it waited for > > the child to exit, and then it reopened it after the child exited. Holding > > the log file open thi

Re: [ovs-dev] [PATCH] daemon-unix: Close log file in monitor process while waiting on child.

2022-01-26 Thread William Tu
On Wed, Jan 26, 2022 at 8:56 AM Ben Pfaff wrote: > > Until now, the monitor process held its log file open while it waited for > the child to exit, and then it reopened it after the child exited. Holding > the log file open this way prevented log rotation from freeing disk space. > This commit av

[ovs-dev] [PATCH] daemon-unix: Close log file in monitor process while waiting on child.

2022-01-26 Thread Ben Pfaff
Until now, the monitor process held its log file open while it waited for the child to exit, and then it reopened it after the child exited. Holding the log file open this way prevented log rotation from freeing disk space. This commit avoids the problem by closing the log file before waiting, the