Re: [ovs-dev] [PATCH] datapath: Remove redundant check for IFF_NO_QUEUE

2017-11-02 Thread Ben Pfaff
On Thu, Nov 02, 2017 at 08:51:59AM +0800, Kaige Fu wrote: > On 2017/11/2 4:19, Ben Pfaff wrote: > > On Wed, Nov 01, 2017 at 08:43:20AM -0700, Greg Rose wrote: > >> On 10/30/2017 06:13 PM, fukaige wrote: > >>> From: Kaige Fu > >>> > >>> IFF_NO_QUEUE is checked twice. This cause

Re: [ovs-dev] [PATCH] datapath: Remove redundant check for IFF_NO_QUEUE

2017-11-01 Thread Kaige Fu
On 2017/11/2 4:19, Ben Pfaff wrote: > On Wed, Nov 01, 2017 at 08:43:20AM -0700, Greg Rose wrote: >> On 10/30/2017 06:13 PM, fukaige wrote: >>> From: Kaige Fu >>> >>> IFF_NO_QUEUE is checked twice. This cause a situation >>> that HAVE_IFF_NO_QUEUE is defined no matter whether

Re: [ovs-dev] [PATCH] datapath: Remove redundant check for IFF_NO_QUEUE

2017-11-01 Thread Ben Pfaff
On Wed, Nov 01, 2017 at 08:43:20AM -0700, Greg Rose wrote: > On 10/30/2017 06:13 PM, fukaige wrote: > >From: Kaige Fu > > > >IFF_NO_QUEUE is checked twice. This cause a situation > >that HAVE_IFF_NO_QUEUE is defined no matter whether > >the flag IFF_NO_QUEUE is defined in

[ovs-dev] [PATCH] datapath: Remove redundant check for IFF_NO_QUEUE

2017-10-30 Thread fukaige
From: Kaige Fu IFF_NO_QUEUE is checked twice. This cause a situation that HAVE_IFF_NO_QUEUE is defined no matter whether the flag IFF_NO_QUEUE is defined in kernel or not. Signed-off-by: Kaige Fu --- datapath/linux/compat/include/linux/netdevice.h | 3