Re: [ovs-dev] [PATCH] datapath-windows: Fix payload length calculation in Conntrack.h

2018-09-20 Thread aserdean
iect: Re: [ovs-dev] [PATCH] datapath-windows: Fix payload length > calculation in Conntrack.h > > Hi Alin, > > Thanks for fixing this, > Acked-by: Anand Kumar > > Regards, > Anand Kumar > > On 9/19/18, 3:37 PM, "ovs-dev-boun...@openvswitch.org on be

Re: [ovs-dev] [PATCH] datapath-windows: Fix payload length calculation in Conntrack.h

2018-09-19 Thread Anand Kumar
Hi Alin, Thanks for fixing this, Acked-by: Anand Kumar Regards, Anand Kumar On 9/19/18, 3:37 PM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Gabriel Serdean" wrote: The payload calculation in OvsGetTcpHeader is wrong: `ntohs(ipHdr->tot_len) - expr` instead of `ntohs((ipHdr->to

[ovs-dev] [PATCH] datapath-windows: Fix payload length calculation in Conntrack.h

2018-09-19 Thread Alin Gabriel Serdean
The payload calculation in OvsGetTcpHeader is wrong: `ntohs(ipHdr->tot_len) - expr` instead of `ntohs((ipHdr->tot_len) - expr)`. We already have a macro for that calculation defined in NetProto.h so use it. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Conntrack.h | 3 +-- 1 f