Re: [ovs-dev] [PATCH] datapath-windows: Guard vport usage in user.c

2019-03-13 Thread aserdean
: [ovs-dev] [PATCH] datapath-windows: Guard vport usage in > user.c > > Acked-by: Sairam Venugopal > > On 2/27/19, 6:10 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin > Gabriel Serdean" aserd...@ovn.org> wrote: > > When using a vport we need to guard i

Re: [ovs-dev] [PATCH] datapath-windows: Guard vport usage in user.c

2019-03-12 Thread Sairam Venugopal via dev
Acked-by: Sairam Venugopal On 2/27/19, 6:10 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Gabriel Serdean" wrote: When using a vport we need to guard its usage with the dispatch lock. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/User.c | 16 +

Re: [ovs-dev] [PATCH] datapath-windows: Guard vport usage in user.c

2019-03-12 Thread Anand Kumar via dev
Acked-by: Anand Kumar Thanks, Anand Kumar On 2/27/19, 6:10 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Gabriel Serdean" wrote: When using a vport we need to guard its usage with the dispatch lock. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovs

Re: [ovs-dev] [PATCH] datapath-windows: Guard vport usage in user.c

2019-02-28 Thread aserdean
> Do we need to keep the dispatchLock for reading vport structures? [Alin Serdean] We need to make sure that port is not deleted since we use it for processing. >If that's > the case, then we will need to fix it in other areas of the code too. [Alin Serdean] I sent out https://patchwork.ozlabs.org

Re: [ovs-dev] [PATCH] datapath-windows: Guard vport usage in user.c

2019-02-27 Thread Sairam Venugopal via dev
Do we need to keep the dispatchLock for reading vport structures? If that's the case, then we will need to fix it in other areas of the code too. It would be better to move the locking inside the relevant vport.c functions instead of taking out global ones. Thanks, Sairam On 2/27/19, 6:10 AM,

[ovs-dev] [PATCH] datapath-windows: Guard vport usage in user.c

2019-02-27 Thread Alin Gabriel Serdean
When using a vport we need to guard its usage with the dispatch lock. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/User.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/datapath-windows/ovsext/User.c b/datapath-windows/ovsext/User.c index