Re: [ovs-dev] [PATCH] datapath-windows:adjust Offset when processing packet in POP_VLAN action

2021-09-30 Thread alinserdean
Serdean ; ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH] datapath-windows:adjust Offset when processing packet in POP_VLAN action Alin, Original code diff is to avoid the case below(it will return NDIS_STATUS_SUCCESS before RtlMoveMemory in function OvsPopFieldInPacketBuf

Re: [ovs-dev] [PATCH] datapath-windows:adjust Offset when processing packet in POP_VLAN action

2021-09-29 Thread Wilson Peng
] datapath-windows:adjust Offset when processing packet in POP_VLAN action Alin, Original code diff is to avoid the case below(it will return NDIS_STATUS_SUCCESS before RtlMoveMemory in function OvsPopFieldInPacketBuf). Regards Wilson In function OvsPopFieldInPacketBuf

Re: [ovs-dev] [PATCH] datapath-windows:adjust Offset when processing packet in POP_VLAN action

2021-09-29 Thread Alin-Gabriel Serdean
-dev] [PATCH] datapath-windows:adjust Offset when processing packet in POP_VLAN action Alin, Original code diff is to avoid the case below(it will return NDIS_STATUS_SUCCESS before RtlMoveMemory in function OvsPopFieldInPacketBuf). Regards Wilson In function OvsPopFieldInPacketBuf

Re: [ovs-dev] [PATCH] datapath-windows:adjust Offset when processing packet in POP_VLAN action

2021-09-29 Thread Wilson Peng
Alin, Original code diff is to avoid the case below(it will return NDIS_STATUS_SUCCESS before RtlMoveMemory in function OvsPopFieldInPacketBuf). Regards Wilson In function OvsPopFieldInPacketBuf(..) if (!bufferData) { EthHdr *ethHdr = (EthHdr *)bufferStart; /* If the frame is

Re: [ovs-dev] [PATCH] datapath-windows:adjust Offset when processing packet in POP_VLAN action

2021-09-29 Thread Alin-Gabriel Serdean
From: aserd...@ovn.org Thank you for raising awareness about this issue. You are right the offsets are not being updated when a pop vlan action is hit, they are updated only on pop_mpls. https://github.com/openvswitch/ovs/blob/master/datapath-windows/ovsext/Actions.c#L1173-L1174 Can you please