Re: [ovs-dev] [PATCH] dpif: execute ct together with recirc when slow path

2017-06-15 Thread Joe Stringer
On 14 June 2017 at 19:56, Wei Li wrote: > Great idea, this can process actions like > "ct(...nat),recirc(...),output(...)" correctly, output packet will be a > NATed packet > > Before implementing your idea, how deal with my patch? > > 1: drop it > > 2:accept it for fixing

Re: [ovs-dev] [PATCH] dpif: execute ct together with recirc when slow path

2017-06-14 Thread Wei Li
Great idea, this can process actions like "ct(...nat),recirc(...),output(...)" correctly, output packet will be a NATed packet Before implementing your idea, how deal with my patch? 1: drop it 2:accept it for fixing limited scenario (i will do checkpatch) What's your suggestion? 在

Re: [ovs-dev] [PATCH] dpif: execute ct together with recirc when slow path

2017-06-14 Thread Joe Stringer
On 14 June 2017 at 11:43, Joe Stringer wrote: > On 14 June 2017 at 05:04, wei wrote: >> ct(table=X,zone=X) will xlate 2 actions (ct and recirc), so they should be >> executed together. > > Hi, thanks for the contribution. > > There's a few things in this patch

Re: [ovs-dev] [PATCH] dpif: execute ct together with recirc when slow path

2017-06-14 Thread Joe Stringer
On 14 June 2017 at 05:04, wei wrote: > ct(table=X,zone=X) will xlate 2 actions (ct and recirc), so they should be > executed together. Hi, thanks for the contribution. There's a few things in this patch that do not match standard OVS contribution guidelines. Using

Re: [ovs-dev] [PATCH] dpif: execute ct together with recirc when slow path

2017-06-14 Thread Wei Li
that is for this problem [ovs-dev] [ovs-discuss] ovn: unsnat handling error for Distributed Gateway https://mail.openvswitch.org/pipermail/ovs-dev/2017-April/330536.html Previous patch [PATCH] ovn-northd: Add logical flows to reply ICMP echo requests for all the other router ports connected to

[ovs-dev] [PATCH] dpif: execute ct together with recirc when slow path

2017-06-14 Thread wei
ct(table=X,zone=X) will xlate 2 actions (ct and recirc), so they should be executed together. --- lib/dpif.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/lib/dpif.c b/lib/dpif.c index fe6a986c5..72274731a 100644 --- a/lib/dpif.c +++ b/lib/dpif.c @@