Re: [ovs-dev] [PATCH] dpif-netdev-avx512: Fix overflow of UINT32_C(1).

2022-04-27 Thread Ilya Maximets
On 4/27/22 19:35, Ilya Maximets wrote: > On 4/27/22 18:41, Van Haaren, Harry wrote: >>> -Original Message- >>> From: Ferriter, Cian >>> Sent: Wednesday, April 27, 2022 4:58 PM >>> To: ovs-dev@openvswitch.org >>> Cc: echau...@redhat.com; i.maxim...@ovn.org; Van Haaren, Harry >>> ;

Re: [ovs-dev] [PATCH] dpif-netdev-avx512: Fix overflow of UINT32_C(1).

2022-04-27 Thread Ilya Maximets
On 4/27/22 18:41, Van Haaren, Harry wrote: >> -Original Message- >> From: Ferriter, Cian >> Sent: Wednesday, April 27, 2022 4:58 PM >> To: ovs-dev@openvswitch.org >> Cc: echau...@redhat.com; i.maxim...@ovn.org; Van Haaren, Harry >> ; david.march...@redhat.com; Ferriter, Cian >> >>

Re: [ovs-dev] [PATCH] dpif-netdev-avx512: Fix overflow of UINT32_C(1).

2022-04-27 Thread Van Haaren, Harry
> -Original Message- > From: Ferriter, Cian > Sent: Wednesday, April 27, 2022 4:58 PM > To: ovs-dev@openvswitch.org > Cc: echau...@redhat.com; i.maxim...@ovn.org; Van Haaren, Harry > ; david.march...@redhat.com; Ferriter, Cian > > Subject: [PATCH] dpif-netdev-avx512: Fix overflow of

[ovs-dev] [PATCH] dpif-netdev-avx512: Fix overflow of UINT32_C(1).

2022-04-27 Thread Cian Ferriter
UINT64_C(1) is required in this bitshift since batch_size can be 32 and 1 << 32 overflows UINT32_C(1). Fixes: ba0a2619ca0c ("dpif-netdev-avx512: Fix ubsan shift error in bitmasks.") Signed-off-by: Cian Ferriter --- The other uses of UINT32_C(1) in the dpif-netdev-avx512 files are valid since