On 10.09.2019 14:11, Eelco Chaudron wrote:
>
>
> On 5 Sep 2019, at 14:40, Ilya Maximets wrote:
>
>> Hi Eelco,
>
>
>>> , 2 deletions(-)
>>>
>>> diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
>>> index bc20d6843..a23150387 100644
>>> --- a/lib/netdev-dpdk.c
>>> +++ b/lib/netdev-dpdk.c
>>>
On 5 Sep 2019, at 14:40, Ilya Maximets wrote:
Hi Eelco,
, 2 deletions(-)
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index bc20d6843..a23150387 100644
--- a/lib/netdev-dpdk.c
+++ b/lib/netdev-dpdk.c
@@ -362,6 +362,7 @@ struct netdev_dpdk {
bool attached;
/* If
On 05.09.2019 17:44, Eelco Chaudron wrote:
> See inlines below, and will sent a v2 early next week.
>
> On 5 Sep 2019, at 14:40, Ilya Maximets wrote:
>
>> Hi Eelco,
>> Thanks for the patch! Looks reasonable.
>>
>> One comment is that it's better to explicitly initialize the
>> flag in
See inlines below, and will sent a v2 early next week.
On 5 Sep 2019, at 14:40, Ilya Maximets wrote:
Hi Eelco,
Thanks for the patch! Looks reasonable.
One comment is that it's better to explicitly initialize the
flag in common_construct. I see that we doesn't initialize
'started' flag, but
Hi Eelco,
Thanks for the patch! Looks reasonable.
One comment is that it's better to explicitly initialize the
flag in common_construct. I see that we doesn't initialize
'started' flag, but this might be fixed too.
More comments inline.
Best regards, Ilya Maximets.
On 05.09.2019 14:48, Eelco
Currently, OVS does not register and therefore not handle the
interface reset event from the DPDK framework. This would cause a
problem in cases where a VF is used as an interface, and its
configuration changes.
As an example in the following scenario the MAC change is not
detected/acted upon
