Re: [ovs-dev] [PATCH] netdev-dpdk: use 64-bit arithmetic when converting rates

2017-08-28 Thread Stokes, Ian
> Force 64-bit arithmetic to be used when converting uint32_t rate and burst > parameters from kilobits per second to bytes per second, avoiding > incorrect behavior for rates exceeding UINT_MAX bits per second. > Good catch Lance, thanks for the fix. Acked-by: ian.sto...@intel.com Tested-by: ia

Re: [ovs-dev] [PATCH] netdev-dpdk: use 64-bit arithmetic when converting rates

2017-08-25 Thread Darrell Ball
I applied the patch to dpdk_merge here https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_darball_ovs_commits_dpdk-5Fmerge&d=DwIGaQ&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=A2_FCacqbp2moAo3HGFlTuxsjONUGhlN42OBcAuQQ6w&s=b6btPKhgvOFr2GOUYvktND6kaC6jc3fXI-mXfvNgXOU&e= This lo

Re: [ovs-dev] [PATCH] netdev-dpdk: use 64-bit arithmetic when converting rates

2017-08-24 Thread Kevin Traynor
On 08/24/2017 02:44 PM, Mark Michelson wrote: > LGTM > > Acked-By: Mark Michelson > > On Thu, Aug 24, 2017 at 8:17 AM Lance Richardson > wrote: > >> Force 64-bit arithmetic to be used when converting uint32_t rate >> and burst parameters from kilobits per second to bytes per second, >> avoidin

Re: [ovs-dev] [PATCH] netdev-dpdk: use 64-bit arithmetic when converting rates

2017-08-24 Thread Mark Michelson
LGTM Acked-By: Mark Michelson On Thu, Aug 24, 2017 at 8:17 AM Lance Richardson wrote: > Force 64-bit arithmetic to be used when converting uint32_t rate > and burst parameters from kilobits per second to bytes per second, > avoiding incorrect behavior for rates exceeding UINT_MAX bits > per se

[ovs-dev] [PATCH] netdev-dpdk: use 64-bit arithmetic when converting rates

2017-08-24 Thread Lance Richardson
Force 64-bit arithmetic to be used when converting uint32_t rate and burst parameters from kilobits per second to bytes per second, avoiding incorrect behavior for rates exceeding UINT_MAX bits per second. Reported-by: "王志克" Fixes: 9509913aa722 ("netdev-dpdk.c: Add ingress-policing functionality.