[ovs-dev] [PATCH] netdev-dpdk: vhost get stats fix.

2017-08-25 Thread wangzhike
Signed-off-by: wangzhike --- lib/netdev-dpdk.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 1aaf6f7..bf5c58b 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -2016,10 +2016,10 @@

Re: [ovs-dev] [PATCH] netdev-dpdk: vhost get stats fix

2017-08-25 Thread 王志克
ng Zhike -Original Message- From: Darrell Ball [mailto:db...@vmware.com] Sent: Friday, August 25, 2017 2:04 PM To: 王志克; d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH] netdev-dpdk: vhost get stats fix I am wondering if we should split the +stats->tx_errors = 0; out from this p

Re: [ovs-dev] [PATCH] netdev-dpdk: vhost get stats fix

2017-08-25 Thread Darrell Ball
I am wondering if we should split the +stats->tx_errors = 0; out from this patch and discuss it separately ? In theory, if a stat is really not supported, we should not display a value for it. Displaying 0 could be misleading if there really is a problem and we are not detecting it.

[ovs-dev] [PATCH] netdev-dpdk: vhost get stats fix

2017-08-24 Thread wangzhike
1. "+=" should be "=" 2. tx_errors is a generic param, and should be 0 since vhost does not create such error. Or some app, like libvirt will complain for failure to find this key. Signed-off-by: wangzhike --- lib/netdev-dpdk.c | 7 --- 1 file changed, 4