Re: [ovs-dev] [PATCH] netdev-linux: set correct action for packets that passed policer

2022-07-26 Thread Vlad Buslov via dev
On Mon 25 Jul 2022 at 16:01, Ilya Maximets wrote: > On 7/25/22 14:45, Vlad Buslov via dev wrote: >> Dear maintainers, >> >> Could you please check out this patch? >> >> When kernel 5.19 is released with all the added validation code, it will >> make OvS matchall police offload completely broken

Re: [ovs-dev] [PATCH] netdev-linux: set correct action for packets that passed policer

2022-07-25 Thread Simon Horman
On Mon, Jul 25, 2022 at 04:01:07PM +0200, Ilya Maximets wrote: > On 7/25/22 14:45, Vlad Buslov via dev wrote: > > Dear maintainers, > > > > Could you please check out this patch? > > > > When kernel 5.19 is released with all the added validation code, it will > > make OvS matchall police offload

Re: [ovs-dev] [PATCH] netdev-linux: set correct action for packets that passed policer

2022-07-25 Thread Ilya Maximets
On 7/25/22 14:45, Vlad Buslov via dev wrote: > Dear maintainers, > > Could you please check out this patch? > > When kernel 5.19 is released with all the added validation code, it will > make OvS matchall police offload completely broken on mlx5 without the > fix. Simon, Eelco, could you,

Re: [ovs-dev] [PATCH] netdev-linux: set correct action for packets that passed policer

2022-07-25 Thread Vlad Buslov via dev
Dear maintainers, Could you please check out this patch? When kernel 5.19 is released with all the added validation code, it will make OvS matchall police offload completely broken on mlx5 without the fix. Thanks, Vlad On Wed 06 Jul 2022 at 08:53, Vlad Buslov wrote: > Referenced commit

Re: [ovs-dev] [PATCH] netdev-linux: set correct action for packets that passed policer

2022-07-06 Thread Roi Dayan via dev
On 2022-07-06 9:53 AM, Vlad Buslov wrote: Referenced commit changed policer action type from TC_ACT_UNSPEC (continue) to TC_ACT_PIPE. However, since neither TC hardware offload layer nor mlx5 driver at the time validated action type and always assumed 'continue', the breakage wasn't caught

[ovs-dev] [PATCH] netdev-linux: set correct action for packets that passed policer

2022-07-06 Thread Vlad Buslov via dev
Referenced commit changed policer action type from TC_ACT_UNSPEC (continue) to TC_ACT_PIPE. However, since neither TC hardware offload layer nor mlx5 driver at the time validated action type and always assumed 'continue', the breakage wasn't caught until later validation code was added. The change