Re: [ovs-dev] [PATCH] netdev-offload-tc: Use single thread for probing tc features

2020-11-11 Thread Roi Dayan
On 2020-11-10 2:44 PM, Ilya Maximets wrote: On 11/10/20 1:39 PM, Roi Dayan wrote: On 2020-11-02 2:07 PM, Roi Dayan wrote: There is no need for a thread start per probe. Signed-off-by: Roi Dayan Reviewed-by: Paul Blakey ---   lib/netdev-offload-tc.c | 11 +++   1 file changed, 3

Re: [ovs-dev] [PATCH] netdev-offload-tc: Use single thread for probing tc features

2020-11-10 Thread Ilya Maximets
On 11/10/20 1:39 PM, Roi Dayan wrote: > > > On 2020-11-02 2:07 PM, Roi Dayan wrote: >> There is no need for a thread start per probe. >> >> Signed-off-by: Roi Dayan >> Reviewed-by: Paul Blakey >> --- >>   lib/netdev-offload-tc.c | 11 +++ >>   1 file changed, 3 insertions(+), 8

Re: [ovs-dev] [PATCH] netdev-offload-tc: Use single thread for probing tc features

2020-11-10 Thread Roi Dayan
On 2020-11-02 2:07 PM, Roi Dayan wrote: There is no need for a thread start per probe. Signed-off-by: Roi Dayan Reviewed-by: Paul Blakey --- lib/netdev-offload-tc.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/lib/netdev-offload-tc.c

Re: [ovs-dev] [PATCH] netdev-offload-tc: Use single thread for probing tc features

2020-11-05 Thread Simon Horman
On Tue, Nov 03, 2020 at 12:34:14PM +0100, Ilya Maximets wrote: > On 11/2/20 1:07 PM, Roi Dayan wrote: > > There is no need for a thread start per probe. > > This sounds like we're actually starting some pthreads here. > I think, it should be something like: > "There is no need for a 'once'

Re: [ovs-dev] [PATCH] netdev-offload-tc: Use single thread for probing tc features

2020-11-03 Thread Ilya Maximets
On 11/2/20 1:07 PM, Roi Dayan wrote: > There is no need for a thread start per probe. This sounds like we're actually starting some pthreads here. I think, it should be something like: "There is no need for a 'once' variable per probe." Same for the patch name. E.g. "netdev-offload-tc: Use

[ovs-dev] [PATCH] netdev-offload-tc: Use single thread for probing tc features

2020-11-02 Thread Roi Dayan
There is no need for a thread start per probe. Signed-off-by: Roi Dayan Reviewed-by: Paul Blakey --- lib/netdev-offload-tc.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/lib/netdev-offload-tc.c b/lib/netdev-offload-tc.c index e828a8683910..53662ef3f0e6 100644