Re: [ovs-dev] [PATCH] netlink: removed incorrect optimization

2020-12-15 Thread Yi-Hung Wei
On Mon, Nov 23, 2020 at 6:45 AM Cpp Code wrote: > > I would expect such checks to be commented as indeed it was not clear why > it was there. I looked in similar places where FLOW_TNL_F_UDPIF is used > and there is no such check. The commit which created this condition is > quite large so I am

Re: [ovs-dev] [PATCH] netlink: removed incorrect optimization

2020-11-23 Thread Cpp Code
I would expect such checks to be commented as indeed it was not clear why it was there. I looked in similar places where FLOW_TNL_F_UDPIF is used and there is no such check. The commit which created this condition is quite large so I am not able to conclude from that. I assume this is an

Re: [ovs-dev] [PATCH] netlink: removed incorrect optimization

2020-11-20 Thread Ben Pfaff
On Fri, Nov 20, 2020 at 05:12:46AM -0800, Toms Atteka wrote: > This optimization caused FLOW_TNL_F_UDPIF flag not to be used in > hash calculation for geneve tunnel when revalidating flows which > resulted in different cache hash values and incorrect behaviour. > > Reported-at:

[ovs-dev] [PATCH] netlink: removed incorrect optimization

2020-11-20 Thread Toms Atteka
This optimization caused FLOW_TNL_F_UDPIF flag not to be used in hash calculation for geneve tunnel when revalidating flows which resulted in different cache hash values and incorrect behaviour. Reported-at: https://github.com/vmware-tanzu/antrea/issues/897 Signed-off-by: Toms Atteka ---