Re: [ovs-dev] [PATCH] nsh: rework NSH netlink keys and actions

2017-08-18 Thread Jan Scheurich
> Jan, MD2 is flexible enough, so we mustn't worry there will be one MDx, it > is very weird to use OVS_NSH_PUSH_ATTR_CONTEXT as sub key of > OVS_KEY_ATTR_NSH. There is no point in introducing OVS_NSH_KEY_ATTR_MD2 as we will never transfer MD2 TLV context headers as explicit fields neither as

Re: [ovs-dev] [PATCH] nsh: rework NSH netlink keys and actions

2017-08-17 Thread Jan Scheurich
> > As discussed please adjust the netlink uAPI for NSH as follows: > > > > OVS_KEY_ATTR_NSH > > -- OVS_NSH_KEY_ATTR_BASEmandatory > > -- OVS_NSH_KEY_ATTR_MD1 conditional: if mdtype=MD1 > > > > OVS_ACTION_ATTR_PUSH_NSH > > -- OVS_NSH_KEY_ATTR_BASEmandatory > >

Re: [ovs-dev] [PATCH] nsh: rework NSH netlink keys and actions

2017-08-17 Thread Eric Garver
n...@openvswitch.org] On Behalf Of Yi Yang > > Sent: Wednesday, 16 August, 2017 09:56 > > To: d...@openvswitch.org > > Subject: [ovs-dev] [PATCH] nsh: rework NSH netlink keys and actions > > > > Per kernel data path requirements, this patch ch

Re: [ovs-dev] [PATCH] nsh: rework NSH netlink keys and actions

2017-08-17 Thread Jan Scheurich
ng > Sent: Wednesday, 16 August, 2017 09:56 > To: d...@openvswitch.org > Subject: [ovs-dev] [PATCH] nsh: rework NSH netlink keys and actions > > Per kernel data path requirements, this patch changes > OVS_KEY_ATTR_NSH > to nested attribute and adds three new NSH sub attribute keys:

[ovs-dev] [PATCH] nsh: rework NSH netlink keys and actions

2017-08-16 Thread Yi Yang
Per kernel data path requirements, this patch changes OVS_KEY_ATTR_NSH to nested attribute and adds three new NSH sub attribute keys: OVS_NSH_KEY_ATTR_BASE: for length-fixed NSH base header OVS_NSH_KEY_ATTR_MD1: for length-fixed MD type 1 context OVS_NSH_KEY_ATTR_MD2: for