Re: [ovs-dev] [PATCH] nx-match: Only store significant bytes to stack.

2017-01-06 Thread Ben Pfaff
On Fri, Jan 06, 2017 at 01:10:14PM -0800, Jarno Rajahalme wrote: > > > On Jan 5, 2017, at 9:06 PM, Ben Pfaff wrote: > > > > On Thu, Jan 05, 2017 at 05:45:29PM -0800, Jarno Rajahalme wrote: > >> > >>> On Jan 5, 2017, at 4:48 PM, Ben Pfaff wrote: > >>> > >>> On Thu,

Re: [ovs-dev] [PATCH] nx-match: Only store significant bytes to stack.

2017-01-06 Thread Jarno Rajahalme
> On Jan 5, 2017, at 9:06 PM, Ben Pfaff wrote: > > On Thu, Jan 05, 2017 at 05:45:29PM -0800, Jarno Rajahalme wrote: >> >>> On Jan 5, 2017, at 4:48 PM, Ben Pfaff wrote: >>> >>> On Thu, Jan 05, 2017 at 04:03:17PM -0800, Jarno Rajahalme wrote: > On Jan 4,

Re: [ovs-dev] [PATCH] nx-match: Only store significant bytes to stack.

2017-01-05 Thread Ben Pfaff
On Thu, Jan 05, 2017 at 05:45:29PM -0800, Jarno Rajahalme wrote: > > > On Jan 5, 2017, at 4:48 PM, Ben Pfaff wrote: > > > > On Thu, Jan 05, 2017 at 04:03:17PM -0800, Jarno Rajahalme wrote: > >> > >>> On Jan 4, 2017, at 11:03 PM, Ben Pfaff wrote: > >>> > >>> On

Re: [ovs-dev] [PATCH] nx-match: Only store significant bytes to stack.

2017-01-05 Thread Jarno Rajahalme
> On Jan 5, 2017, at 4:48 PM, Ben Pfaff wrote: > > On Thu, Jan 05, 2017 at 04:03:17PM -0800, Jarno Rajahalme wrote: >> >>> On Jan 4, 2017, at 11:03 PM, Ben Pfaff wrote: >>> >>> On Wed, Jan 04, 2017 at 07:21:44PM -0800, Jarno Rajahalme wrote: > On Dec 21,

Re: [ovs-dev] [PATCH] nx-match: Only store significant bytes to stack.

2017-01-05 Thread Ben Pfaff
On Thu, Jan 05, 2017 at 04:03:17PM -0800, Jarno Rajahalme wrote: > > > On Jan 4, 2017, at 11:03 PM, Ben Pfaff wrote: > > > > On Wed, Jan 04, 2017 at 07:21:44PM -0800, Jarno Rajahalme wrote: > >> > >>> On Dec 21, 2016, at 2:36 PM, Ben Pfaff wrote: > >>> > >>> On

Re: [ovs-dev] [PATCH] nx-match: Only store significant bytes to stack.

2017-01-05 Thread Jarno Rajahalme
> On Jan 4, 2017, at 11:03 PM, Ben Pfaff wrote: > > On Wed, Jan 04, 2017 at 07:21:44PM -0800, Jarno Rajahalme wrote: >> >>> On Dec 21, 2016, at 2:36 PM, Ben Pfaff wrote: >>> >>> On Wed, Dec 07, 2016 at 04:49:00PM -0800, Jarno Rajahalme wrote: Always storing

Re: [ovs-dev] [PATCH] nx-match: Only store significant bytes to stack.

2016-12-21 Thread Ben Pfaff
On Wed, Dec 07, 2016 at 04:49:00PM -0800, Jarno Rajahalme wrote: > Always storing the maximum mf_value size wastes about 120 bytes for > each stack entry. This patch changes the stack from an mf_value array > to a string of value-length pairs. > > The lenght is stored after the value so that the

[ovs-dev] [PATCH] nx-match: Only store significant bytes to stack.

2016-12-07 Thread Jarno Rajahalme
Always storing the maximum mf_value size wastes about 120 bytes for each stack entry. This patch changes the stack from an mf_value array to a string of value-length pairs. The lenght is stored after the value so that the stack pop may first read the length and then the appropriate number of