Re: [ovs-dev] [PATCH] ofproto: fix use-after-free for "ofproto".

2022-02-23 Thread Gaëtan Rivet
t; >> Cc: dingxiaoxiong >> Subject: Re: [ovs-dev] [PATCH] ofproto: fix use-after-free for "ofproto". >> >> >> >> On 2/21/22 11:49, Adrian Moreno wrote: >> > >> > >> > On 2/21/22 11:42, Gaëtan Rivet wrote: >> >>

Re: [ovs-dev] [PATCH] ofproto: fix use-after-free for "ofproto".

2022-02-23 Thread wangyunjian via dev
> -Original Message- > From: Adrian Moreno [mailto:amore...@redhat.com] > Sent: Wednesday, February 23, 2022 8:06 PM > To: Gaëtan Rivet ; wangyunjian ; > d...@openvswitch.org; Ilya Maximets ; 贺鹏 > > Cc: dingxiaoxiong > Subject: Re: [ovs-dev] [PATCH] ofp

Re: [ovs-dev] [PATCH] ofproto: fix use-after-free for "ofproto".

2022-02-23 Thread Adrian Moreno
:08, wangyunjian wrote: -Original Message- From: Gaëtan Rivet [mailto:gr...@u256.net] Sent: Thursday, February 17, 2022 9:31 PM To: wangyunjian ; ; Ilya Maximets ; 贺鹏 ; amore...@redhat.com Cc: dingxiaoxiong Subject: Re: [ovs-dev] [PATCH] ofproto: fix use-after-free for "ofproto"

Re: [ovs-dev] [PATCH] ofproto: fix use-after-free for "ofproto".

2022-02-21 Thread Adrian Moreno
Message- From: Gaëtan Rivet [mailto:gr...@u256.net] Sent: Thursday, February 17, 2022 9:31 PM To: wangyunjian ; ; Ilya Maximets ; 贺鹏 ; amore...@redhat.com Cc: dingxiaoxiong Subject: Re: [ovs-dev] [PATCH] ofproto: fix use-after-free for "ofproto". On Thu, Feb 17, 2022, at 08:29, wangyun

Re: [ovs-dev] [PATCH] ofproto: fix use-after-free for "ofproto".

2022-02-21 Thread Gaëtan Rivet
;>> -Original Message- >>>>>> From: Gaëtan Rivet [mailto:gr...@u256.net] >>>>>> Sent: Thursday, February 17, 2022 9:31 PM >>>>>> To: wangyunjian ; >>>>>> ; Ilya Maximets ; 贺鹏 >>>>>> ; amore...@redhat.c

Re: [ovs-dev] [PATCH] ofproto: fix use-after-free for "ofproto".

2022-02-20 Thread Adrian Moreno
To: wangyunjian ; ; Ilya Maximets ; 贺鹏 ; amore...@redhat.com Cc: dingxiaoxiong Subject: Re: [ovs-dev] [PATCH] ofproto: fix use-after-free for "ofproto". On Thu, Feb 17, 2022, at 08:29, wangyunjian wrote: -Original Message- From: dev [mailto:ovs-dev-boun...@openvswitch.org]

Re: [ovs-dev] [PATCH] ofproto: fix use-after-free for "ofproto".

2022-02-18 Thread Gaëtan Rivet
ebruary 17, 2022 9:31 PM >>>> To: wangyunjian ; >>>> ; Ilya Maximets ; 贺鹏 >>>> ; amore...@redhat.com >>>> Cc: dingxiaoxiong >>>> Subject: Re: [ovs-dev] [PATCH] ofproto: fix use-after-free for "ofproto". >>>>

Re: [ovs-dev] [PATCH] ofproto: fix use-after-free for "ofproto".

2022-02-17 Thread Adrian Moreno
: [ovs-dev] [PATCH] ofproto: fix use-after-free for "ofproto". On Thu, Feb 17, 2022, at 08:29, wangyunjian wrote: -Original Message- From: dev [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of wangyunjian via dev Sent: Thursday, February 17, 2022 11:27 AM To: Gaëtan Rivet

Re: [ovs-dev] [PATCH] ofproto: fix use-after-free for "ofproto".

2022-02-17 Thread Gaëtan Rivet
Of >> >> wangyunjian via dev >> >> Sent: Thursday, February 17, 2022 11:27 AM >> >> To: Gaëtan Rivet ; >> >> ; Ilya Maximets >> >> Cc: dingxiaoxiong >> >> Subject: Re: [ovs-dev] [PATCH] ofproto: fix use-after-free fo

Re: [ovs-dev] [PATCH] ofproto: fix use-after-free for "ofproto".

2022-02-17 Thread wangyunjian via dev
> -Original Message- > From: Gaëtan Rivet [mailto:gr...@u256.net] > Sent: Thursday, February 17, 2022 9:31 PM > To: wangyunjian ; > ; Ilya Maximets ; 贺鹏 > ; amore...@redhat.com > Cc: dingxiaoxiong > Subject: Re: [ovs-dev] [PATCH] ofproto: fix use-after-free fo

Re: [ovs-dev] [PATCH] ofproto: fix use-after-free for "ofproto".

2022-02-17 Thread Gaëtan Rivet
>> Cc: dingxiaoxiong >> Subject: Re: [ovs-dev] [PATCH] ofproto: fix use-after-free for "ofproto". >> >> >> >> > -Original Message- >> > From: Gaëtan Rivet [mailto:gr...@u256.net] >> > Sent: Thursday, February 17, 2022 1:2

Re: [ovs-dev] [PATCH] ofproto: fix use-after-free for "ofproto".

2022-02-16 Thread wangyunjian via dev
> -Original Message- > From: dev [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of > wangyunjian via dev > Sent: Thursday, February 17, 2022 11:27 AM > To: Gaëtan Rivet ; > ; Ilya Maximets > Cc: dingxiaoxiong > Subject: Re: [ovs-dev] [PATCH] ofp

Re: [ovs-dev] [PATCH] ofproto: fix use-after-free for "ofproto".

2022-02-16 Thread wangyunjian via dev
> -Original Message- > From: Gaëtan Rivet [mailto:gr...@u256.net] > Sent: Thursday, February 17, 2022 1:29 AM > To: wangyunjian ; > ; Ilya Maximets > Cc: amore...@redhat.com; dingxiaoxiong ; 贺鹏 > > Subject: Re: [ovs-dev] [PATCH] ofproto: fix use-after-free fo

Re: [ovs-dev] [PATCH] ofproto: fix use-after-free for "ofproto".

2022-02-16 Thread Gaëtan Rivet
On Wed, Feb 16, 2022, at 14:24, wangyunjian wrote: >> -Original Message- >> From: Gaëtan Rivet [mailto:gr...@u256.net] >> Sent: Wednesday, February 16, 2022 7:34 PM >> To: wangyunjian ; >> ; Ilya Maximets >> Cc: dingxiaoxiong >> Subject: Re: [ov

Re: [ovs-dev] [PATCH] ofproto: fix use-after-free for "ofproto".

2022-02-16 Thread wangyunjian via dev
> -Original Message- > From: Gaëtan Rivet [mailto:gr...@u256.net] > Sent: Wednesday, February 16, 2022 7:34 PM > To: wangyunjian ; > ; Ilya Maximets > Cc: dingxiaoxiong > Subject: Re: [ovs-dev] [PATCH] ofproto: fix use-after-free for "ofproto". >

Re: [ovs-dev] [PATCH] ofproto: fix use-after-free for "ofproto".

2022-02-16 Thread Gaëtan Rivet
On Fri, Dec 3, 2021, at 12:25, Yunjian Wang via dev wrote: > When handler threads lookup a "ofproto" and use it, main thread maybe > remove and free the "ofproto" at the same time. The "ofproto" has not > been protected well, which can lead to an OVS crash. > > This patch fixes this by making the

Re: [ovs-dev] [PATCH] ofproto: fix use-after-free for "ofproto".

2022-02-14 Thread Adrian Moreno
. Thanks, Yunjian From: 贺鹏 [mailto:xnhp0...@gmail.com] Sent: Tuesday, January 18, 2022 3:23 PM To: wangyunjian Cc: d...@openvswitch.org; i.maxim...@ovn.org; dingxiaoxiong Subject: Re: [ovs-dev] [PATCH] ofproto: fix use-after-free for "ofproto". Hi, yunjian and Ilya, this patch

Re: [ovs-dev] [PATCH] ofproto: fix use-after-free for "ofproto".

2022-01-18 Thread wangyunjian via dev
...@gmail.com] Sent: Tuesday, January 18, 2022 3:23 PM To: wangyunjian Cc: d...@openvswitch.org; i.maxim...@ovn.org; dingxiaoxiong Subject: Re: [ovs-dev] [PATCH] ofproto: fix use-after-free for "ofproto". Hi, yunjian and Ilya, this patch reminds me of the discussion we have in March last year,

Re: [ovs-dev] [PATCH] ofproto: fix use-after-free for "ofproto".

2022-01-17 Thread 贺鹏
Friendly ping. > > > -Original Message- > > From: wangyunjian > > Sent: Friday, December 3, 2021 7:25 PM > > To: d...@openvswitch.org; i.maxim...@ovn.org > > Cc: dingxiaoxiong ; xudingke > > ; wangyunjian ; Justin > > Pettit > > Subject: [ovs-dev] [PATCH]

Re: [ovs-dev] [PATCH] ofproto: fix use-after-free for "ofproto".

2022-01-08 Thread wangyunjian via dev
Friendly ping. > -Original Message- > From: wangyunjian > Sent: Friday, December 3, 2021 7:25 PM > To: d...@openvswitch.org; i.maxim...@ovn.org > Cc: dingxiaoxiong ; xudingke > ; wangyunjian ; Justin > Pettit > Subject: [ovs-dev] [PATCH] ofproto: fix use

[ovs-dev] [PATCH] ofproto: fix use-after-free for "ofproto".

2021-12-03 Thread Yunjian Wang via dev
When handler threads lookup a "ofproto" and use it, main thread maybe remove and free the "ofproto" at the same time. The "ofproto" has not been protected well, which can lead to an OVS crash. This patch fixes this by making the "ofproto" lookup RCU-safe by using cmap instead of hmap and moving