According with rfc4541 section 2.1.1, a snooping switch
should forward membership reports only to ports with
routers attached.The current code violates the RFC
forwarding membership reports to group ports as well.
The same issue doesn't exist with IPv4.
Fixes: 06994f879c ("mcast-snooping: Add
Hi XiaoXiong,
Thanks again for the patch.
Could you please follow the guidelines to post patches?
https://github.com/openvswitch/ovs/blob/master/Documentation/internals/contributing/submitting-patches.rst
The Subject for instance is a bit confusing as I think
you don't want reports forwarded
According with rfc4541 section 2.1.1, a snooping switch should forward
membership reports only to ports with routers attached.
The current code violates the RFC forwarding membership reports to group ports
as well.
The same issue doesn't exist with IPv4.
Fixes: 06994f879c ("mcast-snooping: Add
Hi,
Thanks for the patch.
On Sat, Sep 19, 2020 at 10:46:01AM +0800, XiaoXiong Ding wrote:
> When mld report come(same as mld done), will do funciton
function
> xlate_normal_mcast_send_rports, and because of no return,
> will do forwarding to group base ports logic, and if
>
When mld report come(same as mld done), will do funciton
xlate_normal_mcast_send_rports, and because of no return,
will do forwarding to group base ports logic, and if
other_config:mcast-snooping-flood is set on a port, will do
xlate_normal_mcast_send_fports. So mld report will be reveived
when
I missed this one, but the comments to the previous patch
remains the same here.
fbl
On Thu, Sep 10, 2020 at 03:49:00PM +0800, XiaoXiong Ding wrote:
> when mld report come(same as mld done), will do funciton
> xlate_normal_mcast_send_rports, and because of no return,
> will doforwarding to
On Thu, Sep 10, 2020 at 03:51:34AM +, dingxiaoxiong wrote:
> when mld report come(same as mld done), will do funciton
Please start with Capital.
> xlate_normal_mcast_send_rports, and because of no return,
> will doforwarding to group base ports logic,and if
two spaces needed
>
when mld report come(same as mld done), will do funciton
xlate_normal_mcast_send_rports, and because of no return,
will doforwarding to group base ports logic,and if
other_config:mcast-snooping-flood is set on a port, will do
xlate_normal_mcast_send_fports. so mld report will be reveived
when
Bleep bloop. Greetings dingxiaoxiong, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author dingxiaoxiong needs to sign off.
WARNING: Unexpected sign-offs from developers
when mld report come(same as mld done), will do funciton
xlate_normal_mcast_send_rports, and because of no return,
will doforwarding to group base ports logic,and if
other_config:mcast-snooping-flood is set on a port, will do
xlate_normal_mcast_send_fports. so mld report will be reveived
when
Bleep bloop. Greetings dingxiaoxiong, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author dingxiaoxiong needs to sign off.
WARNING: Unexpected sign-offs from developers
when mld report come(same as mld done), will do funciton
xlate_normal_mcast_send_rports, and because of no return, will do
forwarding to group base ports logic,and if
other_config:mcast-snooping-flood is set on a port, will do
xlate_normal_mcast_send_fports. so mld report will be reveived when
Bleep bloop. Greetings dingxiaoxiong, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author dingxiaoxiong needs to sign off.
WARNING: Unexpected sign-offs from developers
when mld report come(same as mld done), will do funciton
xlate_normal_mcast_send_rports, and because of no return, will do
forwarding to group base ports logic,and if
other_config:mcast-snooping-flood is set on a port, will do
xlate_normal_mcast_send_fports. so mld report will be reveived when
14 matches
Mail list logo
