Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Don't mirror packets that aren't modified.

2024-03-26 Thread Mike Pattrick
On Mon, Mar 25, 2024 at 10:04 PM Zhangweiwei wrote: > > The ethernet addresses of two ICMP request packets are indeed different . One > is original packet and the other is modified. It is an expected behavior > according to the code. > Actually, when a packet sent by port A is changed by flow

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Don't mirror packets that aren't modified.

2024-03-25 Thread Zhangweiwei
The ethernet addresses of two ICMP request packets are indeed different . One is original packet and the other is modified. It is an expected behavior according to the code. Actually, when a packet sent by port A is changed by flow table and then is sent to itself, we expect to capture this

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Don't mirror packets that aren't modified.

2024-03-25 Thread Mike Pattrick
On Mon, Mar 25, 2024 at 3:48 AM Zhangweiwei wrote: > > Hi, > I have tried this patch, however, there are still some issues when the > packets contents are changed across recirculation. On the follow example, > packets are modified in recirc_id(0) after mirror, the mirror context reset. >

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Don't mirror packets that aren't modified.

2024-03-25 Thread Zhangweiwei
Hi, I have tried this patch, however, there are still some issues when the packets contents are changed across recirculation. On the follow example, packets are modified in recirc_id(0) after mirror, the mirror context reset. Therefore, there are two ICMP request packets are mirrored on port

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Don't mirror packets that aren't modified.

2024-03-15 Thread Ilya Maximets
On 3/12/24 18:37, Mike Pattrick wrote: > Previously OVS reset the mirror contents when a packet is modified in > such a way that the packets contents changes. However, this change > incorrectly reset that mirror context when only metadata changes as > well. > > Now we check for all metadata

[ovs-dev] [PATCH] ofproto-dpif-upcall: Don't mirror packets that aren't modified.

2024-03-12 Thread Mike Pattrick
Previously OVS reset the mirror contents when a packet is modified in such a way that the packets contents changes. However, this change incorrectly reset that mirror context when only metadata changes as well. Now we check for all metadata fields, instead of just tunnel metadata, before